[GitHub] [skywalking] dmsolr commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
dmsolr commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527030801 @stalary I ran the testcase seem like it is okay. All versions passed.

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527031417 > @stalary I ran the testcase seem like it is okay. All versions passed. good -

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527031640 @zhaoyuguang @kezhenxu94 Could you run tests in our INFRA? --

[GitHub] [skywalking] dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319832953 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319833378 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalki

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319837317 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319837755 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3393: Fix Webflux plugin throw ClassCastException when defining a filter

2019-09-02 Thread GitBox
SkyWalkingRobot commented on issue #3393: Fix Webflux plugin throw ClassCastException when defining a filter URL: https://github.com/apache/skywalking/pull/3393#issuecomment-527038280 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319838331 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalki

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319840185 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319843368 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319844259 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319852055 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
dmsolr commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319865339 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3393: Fix Webflux plugin throw ClassCastException when defining a filter

2019-09-02 Thread GitBox
SkyWalkingRobot commented on issue #3393: Fix Webflux plugin throw ClassCastException when defining a filter URL: https://github.com/apache/skywalking/pull/3393#issuecomment-527077832 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/

[GitHub] [skywalking] dmsolr commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
dmsolr commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527085715 All passed in my pc. @stalary @wu-sheng This is a

[GitHub] [skywalking] csullh opened a new issue #3394: springcloug gateway2.1.4 traceid Repeated Generation

2019-09-02 Thread GitBox
csullh opened a new issue #3394: springcloug gateway2.1.4 traceid Repeated Generation URL: https://github.com/apache/skywalking/issues/3394 Please answer these questions before submitting your issue. - Why do you submit this issue? Bug Agent __ ### Bug - Which versio

[GitHub] [skywalking] wu-sheng commented on issue #3394: springcloug gateway2.1.4 traceid Repeated Generation

2019-09-02 Thread GitBox
wu-sheng commented on issue #3394: springcloug gateway2.1.4 traceid Repeated Generation URL: https://github.com/apache/skywalking/issues/3394#issuecomment-527139907 That has been fixed in the master. @zhaoyuguang is working on making this plugin more stable. --

[GitHub] [skywalking] wu-sheng closed issue #3394: springcloug gateway2.1.4 traceid Repeated Generation

2019-09-02 Thread GitBox
wu-sheng closed issue #3394: springcloug gateway2.1.4 traceid Repeated Generation URL: https://github.com/apache/skywalking/issues/3394 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [skywalking] wu-sheng merged pull request #3393: Fix Webflux plugin throw ClassCastException when defining a filter

2019-09-02 Thread GitBox
wu-sheng merged pull request #3393: Fix Webflux plugin throw ClassCastException when defining a filter URL: https://github.com/apache/skywalking/pull/3393 This is an automated message from the Apache Git Service. To respond

[skywalking] branch master updated: fix bug (#3393)

2019-09-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7f5ac23 fix bug (#3393) 7f5ac23 is describ

[GitHub] [skywalking] wu-sheng commented on issue #3385: fix springMVC4 noSuchMethod

2019-09-02 Thread GitBox
wu-sheng commented on issue #3385: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3385#issuecomment-527141398 Any update? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527142941 > @stone-wlg For async, in order to make sure exit span duration accuration. Besides intercepting callback and creating local span there, you should take a lo

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527143878 You can't enhance abstract method or interface method. You could enhance subclass or implementor of interface.

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527144990 > You can't enhance abstract method or interface method. You could enhance subclass or implementor of interface. private or public class ?

[GitHub] [skywalking] stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
stone-wlg edited a comment on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527144990 > You can't enhance abstract method or interface method. You could enhance subclass or implementor of interface. private class is ok ? -

[GitHub] [skywalking] stone-wlg commented on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
stone-wlg commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527145519 > You can't enhance abstract method or interface method. You could enhance subclass or implementor of interface. ok, thanks ---

[GitHub] [skywalking] SummerOfServenteen commented on issue #3385: fix springMVC4 noSuchMethod

2019-09-02 Thread GitBox
SummerOfServenteen commented on issue #3385: fix springMVC4 noSuchMethod URL: https://github.com/apache/skywalking/pull/3385#issuecomment-527145862 sorry,I was a little busy with my work.I'll check this problem carefully tomorrow. ---

[GitHub] [skywalking] wu-sheng commented on issue #3330: Cassandra 3.x Plugin

2019-09-02 Thread GitBox
wu-sheng commented on issue #3330: Cassandra 3.x Plugin URL: https://github.com/apache/skywalking/pull/3330#issuecomment-527148574 No limit about private or public This is an automated message from the Apache Git Service. To r

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
kezhenxu94 commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319975325 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywal

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319978833 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319980116 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalkin

[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
kezhenxu94 commented on a change in pull request #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#discussion_r319986593 ## File path: apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywal

[GitHub] [skywalking] kezhenxu94 commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
kezhenxu94 commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527180153 I've triggered the auto tests, let's wait for the result --

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527185036 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527186501 Tests run on our INFRA, it fails, could you check why? --

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527187171 > Tests run on our INFRA, it fails, could you check why? ok,I'll check it tomorrow

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527188990 Can I see testcase-build.log This is an automated

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527192708 There is jenkins log link above, with test result. --

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527192895 The log says, illegal yanl file. This is an auto

[GitHub] [skywalking] wu-sheng closed issue #3392: Webflux plugin throw ClassCastException when defining a filter

2019-09-02 Thread GitBox
wu-sheng closed issue #3392: Webflux plugin throw ClassCastException when defining a filter URL: https://github.com/apache/skywalking/issues/3392 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527198822 @ascrutae Do you know why? This is an automated

[GitHub] [skywalking] ascrutae commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
ascrutae commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527200149 See more detail about [IllegalDataFileException](https://github.com/SkyAPMTest/agent-integration-testtool/blob/ma

[GitHub] [skywalking] wu-sheng closed issue #3348: Final method [final java.util.List org.springframework.data.jpa.repository.support.SimpleJpaRepository.saveAll$original$sxMMY1Oe$accessor$R7skPnjw(ja

2019-09-02 Thread GitBox
wu-sheng closed issue #3348: Final method [final java.util.List org.springframework.data.jpa.repository.support.SimpleJpaRepository.saveAll$original$sxMMY1Oe$accessor$R7skPnjw(java.lang.Iterable)] cannot get proxied via CGLIB: Calls to this method will NOT be routed to the target instance and mi

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527262509 Ok. I will update the support list after reviewing the test cases today --

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527264749 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/

[GitHub] [skywalking] csullh commented on issue #3394: springcloug gateway2.1.4 traceid Repeated Generation

2019-09-02 Thread GitBox
csullh commented on issue #3394: springcloug gateway2.1.4 traceid Repeated Generation URL: https://github.com/apache/skywalking/issues/3394#issuecomment-527272426 thanks,I've already seen the source code, may I use the plugin(apm-spring-cloud-gateway-2.1.x-plugin) for skywalking6.2.0 now?

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527275666 @stalary We are checking our test env. Look like something wrong there. -

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527275920 @wu-sheng Ok, I'm also running the local tests T

[GitHub] [skywalking] SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
SkyWalkingRobot commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527279064 Here is the [test report](http://github.com/SkywalkingTest/agent-integration-test-report/tree/master/2019/

[GitHub] [skywalking] stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
stalary commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527279456 The local tests were all passed This is an automa

[GitHub] [skywalking] webb2019 opened a new issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

2019-09-02 Thread GitBox
webb2019 opened a new issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index] URL: https://github.com/apache/skywalking/issues/3395 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or dis

[GitHub] [skywalking] wu-sheng commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

2019-09-02 Thread GitBox
wu-sheng commented on issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index] URL: https://github.com/apache/skywalking/issues/3395#issuecomment-527285285 As far as I known, no one is facing this in committer team. I think you have to do some research on

[GitHub] [skywalking] wu-sheng closed issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index]

2019-09-02 Thread GitBox
wu-sheng closed issue #3395: Elasticsearch exception [type=index_not_found_exception, reason=no such index] URL: https://github.com/apache/skywalking/issues/3395 This is an automated message from the Apache Git Service. To r

[GitHub] [skywalking] zhaoxunyong opened a new issue #3396: Can the page of "Span Info" be expanded manually?

2019-09-02 Thread GitBox
zhaoxunyong opened a new issue #3396: Can the page of "Span Info" be expanded manually? URL: https://github.com/apache/skywalking/issues/3396 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug -

[GitHub] [skywalking] wu-sheng commented on issue #3396: Can the page of "Span Info" be expanded manually?

2019-09-02 Thread GitBox
wu-sheng commented on issue #3396: Can the page of "Span Info" be expanded manually? URL: https://github.com/apache/skywalking/issues/3396#issuecomment-527313439 This is good improvement. Contributions are welcome. This is a

[GitHub] [skywalking] wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName

2019-09-02 Thread GitBox
wu-sheng commented on issue #3390: MOD: Modify compatibility of kafka plugin and expand operationName URL: https://github.com/apache/skywalking/pull/3390#issuecomment-527317058 @ascrutae @kezhenxu94 @zhaoyuguang Could anyone of you verify this PR locally? This is the last PR of 6.4.0 miles

[GitHub] [skywalking] jsbxyyx commented on issue #1939: how to install skywalking as windows service?

2019-09-02 Thread GitBox
jsbxyyx commented on issue #1939: how to install skywalking as windows service? URL: https://github.com/apache/skywalking/issues/1939#issuecomment-527323281 @zpc870921 you can use nssm https://www.cnblogs.com/TianFang/p/7912648.html --

[GitHub] [skywalking] honganan closed pull request #3397: Merge pull request #1 from apache/master

2019-09-02 Thread GitBox
honganan closed pull request #3397: Merge pull request #1 from apache/master URL: https://github.com/apache/skywalking/pull/3397 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking] honganan opened a new pull request #3397: Merge pull request #1 from apache/master

2019-09-02 Thread GitBox
honganan opened a new pull request #3397: Merge pull request #1 from apache/master URL: https://github.com/apache/skywalking/pull/3397 merge Please answer these questions before submitting pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provi