[GitHub] [skywalking] dominicqi commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
dominicqi commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-554254426 /run agent-plugin-test-3 This is an automated message from the Apache Git

[GitHub] [skywalking] dominicqi commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
dominicqi commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346698188 ## File path:

[GitHub] [skywalking] dominicqi commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
dominicqi commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346697924 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3693: Test plugin Occasionally ConcurrentModificationException

2019-11-14 Thread GitBox
wu-sheng commented on issue #3693: Test plugin Occasionally ConcurrentModificationException URL: https://github.com/apache/skywalking/issues/3693#issuecomment-554242834 As this has no update in 20+ days. I am closing it. If we have some clues, we could continue on this.

[GitHub] [skywalking] wu-sheng closed issue #3693: Test plugin Occasionally ConcurrentModificationException

2019-11-14 Thread GitBox
wu-sheng closed issue #3693: Test plugin Occasionally ConcurrentModificationException URL: https://github.com/apache/skywalking/issues/3693 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-554243080 /run agent-plugin-test-2 This is an automated message from the Apache Git Service.

[GitHub] [skywalking] wu-sheng commented on issue #3864: How to compile using Eclips/spring boot.we are getting errors in pom.xml

2019-11-14 Thread GitBox
wu-sheng commented on issue #3864: How to compile using Eclips/spring boot.we are getting errors in pom.xml URL: https://github.com/apache/skywalking/issues/3864#issuecomment-554242418 I don't know. AFAIK, all committer team is using IntelliJ if they are developing the Java part. Any

[GitHub] [skywalking] wu-sheng closed issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
wu-sheng closed issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] rakeshs335 opened a new issue #3864: How to

2019-11-14 Thread GitBox
rakeshs335 opened a new issue #3864: How to URL: https://github.com/apache/skywalking/issues/3864 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ ] Question or discussion - [ ] Bug - [ ] Requirement - [ ] Feature or

[GitHub] [skywalking] arugal commented on issue #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
arugal commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-554238609 LGTM This is an automated message from the Apache Git Service. To respond to the

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346678339 ## File path: Jenkinsfile-Agent-Test ## @@ -116,6 +116,12 @@ pipeline { sh 'bash

[GitHub] [skywalking] wu-sheng closed issue #3862: UI not display instance's language?

2019-11-14 Thread GitBox
wu-sheng closed issue #3862: UI not display instance's language? URL: https://github.com/apache/skywalking/issues/3862 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on issue #3862: UI not display instance's language?

2019-11-14 Thread GitBox
wu-sheng commented on issue #3862: UI not display instance's language? URL: https://github.com/apache/skywalking/issues/3862#issuecomment-554229717 It is already back in the latest release.

[GitHub] [skywalking] wu-sheng closed issue #3863: Grpc server thread pool is full, rejecting the task

2019-11-14 Thread GitBox
wu-sheng closed issue #3863: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3863 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] wu-sheng commented on issue #3863: Grpc server thread pool is full, rejecting the task

2019-11-14 Thread GitBox
wu-sheng commented on issue #3863: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3863#issuecomment-554229545 This depends on your backend and storage. If storage is blocking somehow, the queue may be full too. You need to find out

[GitHub] [skywalking] arugal commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
arugal commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346669602 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] arugal commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
arugal commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346669602 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] czd890 opened a new issue #3863: Grpc server thread pool is full, rejecting the task

2019-11-14 Thread GitBox
czd890 opened a new issue #3863: Grpc server thread pool is full, rejecting the task URL: https://github.com/apache/skywalking/issues/3863 Using https://github.com/apache/skywalking-docker/blob/master/6/6.4/compose/docker-compose.yml to run test server. Throw "Grpc server thread pool is

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346667482 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] arugal commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
arugal commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346665856 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] zhaoyuguang commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346665398 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] bnubobby opened a new issue #3862: Why doesn't the UI display instance's language

2019-11-14 Thread GitBox
bnubobby opened a new issue #3862: Why doesn't the UI display instance's language URL: https://github.com/apache/skywalking/issues/3862 Why doesn't the UI display instance language? my app language is php **This is the data in my ES storage :** ` { "_index":

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346653468 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] wu-sheng commented on issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
wu-sheng commented on issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860#issuecomment-554200942 Clickhouse as a warehouse is not very suitable for SkyWalking process mode actually. Clickhouse is good at calculate things inside, but we

[GitHub] [skywalking] nauu commented on issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
nauu commented on issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860#issuecomment-554199091 ClickHouse record its own metrics into ClickHouse each second by default, and also some other query logs ,its performance should be suitable as a storage.

[GitHub] [skywalking] dominicqi commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
dominicqi commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-554193129 i found the problem, RequestTemplate#url miss the url part in the `http://localhost:8080/feign-scenario`,i will try to fix this

[GitHub] [skywalking] dmsolr commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
dmsolr commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346647143 ## File path: test/plugin/scenarios/spring-tx-scenario/config/expectedData.yaml ## @@ -0,0 +1,168 @@ +#

[GitHub] [skywalking] dmsolr commented on issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
dmsolr commented on issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860#issuecomment-554182003 I am thinking to implement the other NoSQL DB as storage. But not ClickHouse, something like InfluxDB or OpenTSDB. @nauu

[GitHub] [skywalking] zhaoyuguang commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346638066 ## File path: Jenkinsfile-Agent-Test-2 ## @@ -82,6 +82,12 @@ pipeline { parallel {

[GitHub] [skywalking] nauu commented on issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
nauu commented on issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860#issuecomment-554179433 I am planning to implement a new storage with ClickHouse , using MergeTree engine. This

[GitHub] [skywalking] HackerRookie commented on issue #3848: Rocketmq async send message occurred exception

2019-11-14 Thread GitBox
HackerRookie commented on issue #3848: Rocketmq async send message occurred exception URL: https://github.com/apache/skywalking/issues/3848#issuecomment-554176668 Present, Can't perfectly solve the problem This is an

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3840: [WIP][test/plugin] immigrate grpc scenario

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3840: [WIP][test/plugin] immigrate grpc scenario URL: https://github.com/apache/skywalking/pull/3840#discussion_r346632638 ## File path: test/plugin/scenarios/grpc-scenario/support-version.list ## @@ -0,0 +1,49 @@ +#

[GitHub] [skywalking] wu-sheng commented on issue #3840: [WIP][test/plugin] immigrate grpc scenario

2019-11-14 Thread GitBox
wu-sheng commented on issue #3840: [WIP][test/plugin] immigrate grpc scenario URL: https://github.com/apache/skywalking/pull/3840#issuecomment-554172605 /run ci This is an automated message from the Apache Git Service. To

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3840: [WIP][test/plugin] immigrate grpc scenario

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3840: [WIP][test/plugin] immigrate grpc scenario URL: https://github.com/apache/skywalking/pull/3840#discussion_r346632160 ## File path: test/plugin/scenarios/grpc-scenario/support-version.list ## @@ -0,0 +1,49 @@ +#

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#discussion_r346629950 ## File path: Jenkinsfile-Agent-Test-2 ## @@ -82,6 +82,12 @@ pipeline { parallel {

[GitHub] [skywalking] wu-sheng commented on issue #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
wu-sheng commented on issue #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#issuecomment-554170072 /run agent-plugin-test-1 This is an automated message from the Apache Git

[skywalking-website] branch asf-site updated (5287799 -> b171685)

2019-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard 5287799 Update asf-site new b171685 Update asf-site This update added new revisions after

[skywalking-website] branch master updated: Release 6.5.0

2019-11-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 8894b1a Release 6.5.0 8894b1a is

[GitHub] [skywalking] wu-sheng commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-554153542 @dominicqi Please make sure the [feign-scenario](https://github.com/apache/skywalking/tree/master/test/plugin/scenarios/feign-scenario)

[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-554136959 @viswaramamoorthy you need to solve the conflict. This is an automated message from

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346601659 ## File path: test/plugin/scenarios/rabbitmq-scenario/config/expectedData.yaml ## @@ -0,0 +1,100 @@ +# Licensed

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346601524 ## File path: test/plugin/scenarios/rabbitmq-scenario/pom.xml ## @@ -0,0 +1,131 @@ + + +

[GitHub] [skywalking] arugal commented on issue #3840: [WIP][test/plugin] immigrate grpc scenario

2019-11-14 Thread GitBox
arugal commented on issue #3840: [WIP][test/plugin] immigrate grpc scenario URL: https://github.com/apache/skywalking/pull/3840#issuecomment-553976337 Since I have never found the reason why ```INTERNAL: HTTP/2 error code: INTERNAL_ERROR Received Goaway``` appears, the current support list

[GitHub] [skywalking] wu-sheng commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-553962225 You could find how to run and test through this doc https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md

[GitHub] [skywalking] wu-sheng commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-553959653 Feign test #3838 has been merged. Please add this into the test. This is an

[GitHub] [skywalking] wu-sheng merged pull request #3838: [test/plugin] immigrate test feign scenario.

2019-11-14 Thread GitBox
wu-sheng merged pull request #3838: [test/plugin] immigrate test feign scenario. URL: https://github.com/apache/skywalking/pull/3838 This is an automated message from the Apache Git Service. To respond to the message, please

[skywalking] branch master updated: [test/plugin] immigrate test feign scenario. (#3838)

2019-11-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 5f8ee25 [test/plugin] immigrate test

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346387865 ## File path:

[GitHub] [skywalking] wu-sheng commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346388253 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
aderm commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346374572 ## File path:

[GitHub] [skywalking] aderm commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
aderm commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346373653 ## File path:

[skywalking-website] branch asf-site updated (a395f6b -> 5287799)

2019-11-14 Thread tanjian
This is an automated email from the ASF dual-hosted git repository. tanjian pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git. discard a395f6b Update asf-site new 5287799 Update asf-site This update added new revisions after

[GitHub] [skywalking] aderm commented on a change in pull request #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
aderm commented on a change in pull request #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#discussion_r346369040 ## File path:

[GitHub] [skywalking-website] wu-sheng merged pull request #67: add new committer

2019-11-14 Thread GitBox
wu-sheng merged pull request #67: add new committer URL: https://github.com/apache/skywalking-website/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[skywalking-website] branch master updated: add new committer (#67)

2019-11-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/master by this push: new 5889f4d add new committer (#67)

[GitHub] [skywalking] arugal commented on issue #3838: [test/plugin] immigrate test feign scenario.

2019-11-14 Thread GitBox
arugal commented on issue #3838: [test/plugin] immigrate test feign scenario. URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553926895 /run agent-plugin-test-4 This is an automated message from the Apache

[GitHub] [skywalking-website] arugal opened a new pull request #67: add new committer

2019-11-14 Thread GitBox
arugal opened a new pull request #67: add new committer URL: https://github.com/apache/skywalking-website/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] wu-sheng commented on issue #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
wu-sheng commented on issue #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#issuecomment-553914227 @viswaramamoorthy Please solve the conflicts and update to the master branch. This

[skywalking] branch master updated: [hotfix] Make socketio-plugin test case stable (#3861)

2019-11-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 41bb3b5 [hotfix] Make socketio-plugin

[GitHub] [skywalking] wu-sheng merged pull request #3861: [hotfix] Make socketio-plugin test case stable

2019-11-14 Thread GitBox
wu-sheng merged pull request #3861: [hotfix] Make socketio-plugin test case stable URL: https://github.com/apache/skywalking/pull/3861 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [skywalking] viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346340698 ## File path:

[GitHub] [skywalking] viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346340226 ## File path: test/plugin/scenarios/rabbitmq-scenario/src/main/resources/log4j2.xml ## @@ -0,0 +1,31 @@

[GitHub] [skywalking] viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346340126 ## File path:

[GitHub] [skywalking] viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration

2019-11-14 Thread GitBox
viswaramamoorthy commented on a change in pull request #3788: Rabbitmq plugin test migration URL: https://github.com/apache/skywalking/pull/3788#discussion_r346339983 ## File path:

[GitHub] [skywalking] wu-sheng commented on issue #3848: Rocketmq async send message occurred exception

2019-11-14 Thread GitBox
wu-sheng commented on issue #3848: Rocketmq async send message occurred exception URL: https://github.com/apache/skywalking/issues/3848#issuecomment-553886922 If you have issues, you should try to fix, amd consider to contribute to the open source. We only fix some issues when we have

[GitHub] [skywalking] arugal commented on issue #3861: [hotfix] Make socketio-plugin test case stable

2019-11-14 Thread GitBox
arugal commented on issue #3861: [hotfix] Make socketio-plugin test case stable URL: https://github.com/apache/skywalking/pull/3861#issuecomment-553883354 /run agent-plugin-test-4 This is an automated message from the Apache

[GitHub] [skywalking] aderm commented on issue #3838: [test/plugin] immigrate test feign scenario.

2019-11-14 Thread GitBox
aderm commented on issue #3838: [test/plugin] immigrate test feign scenario. URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553882654 /run agent-plugin-test-1 This is an automated message from the Apache Git

[GitHub] [skywalking] jackiepon31 commented on issue #3848: Rocketmq async send message occurred exception

2019-11-14 Thread GitBox
jackiepon31 commented on issue #3848: Rocketmq async send message occurred exception URL: https://github.com/apache/skywalking/issues/3848#issuecomment-553875898 so , u haven fixed that problem??? This is an automated

[GitHub] [skywalking] zhaoyuguang removed a comment on issue #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang removed a comment on issue #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#issuecomment-553875439 /run agent-plugin-test-1 This is an automated message from the

[GitHub] [skywalking] zhaoyuguang removed a comment on issue #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang removed a comment on issue #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#issuecomment-553851455 /run agent-plugin-test-1 This is an automated message from the

[GitHub] [skywalking] zhaoyuguang commented on issue #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang commented on issue #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#issuecomment-553875439 /run agent-plugin-test-1 This is an automated message from the Apache Git

[GitHub] [skywalking] dmsolr opened a new pull request #3861: [hotfix] Make socketio-plugin test case stable

2019-11-14 Thread GitBox
dmsolr opened a new pull request #3861: [hotfix] Make socketio-plugin test case stable URL: https://github.com/apache/skywalking/pull/3861 Please answer these questions before submitting pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided -

[GitHub] [skywalking] aderm commented on a change in pull request #3838: [test/plugin] immigrate test feign scenario.

2019-11-14 Thread GitBox
aderm commented on a change in pull request #3838: [test/plugin] immigrate test feign scenario. URL: https://github.com/apache/skywalking/pull/3838#discussion_r346273255 ## File path: test/plugin/scenarios/feign-scenario/support-version.list ## @@ -0,0 +1,20 @@ +#

[GitHub] [skywalking] zhaoyuguang commented on issue #3857: Support spring-tx in optional plugin

2019-11-14 Thread GitBox
zhaoyuguang commented on issue #3857: Support spring-tx in optional plugin URL: https://github.com/apache/skywalking/pull/3857#issuecomment-553851455 /run agent-plugin-test-1 This is an automated message from the Apache Git

[GitHub] [skywalking] arugal commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
arugal commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-553837826 /run agent-plugin-test-3 This is an automated message from the Apache Git

[GitHub] [skywalking] aderm commented on issue #3838: [test/plugin] immigrate test feign scenario.

2019-11-14 Thread GitBox
aderm commented on issue #3838: [test/plugin] immigrate test feign scenario. URL: https://github.com/apache/skywalking/pull/3838#issuecomment-553836055 /run agent-plugin-test-3 This is an automated message from the Apache Git

[GitHub] [skywalking] wu-sheng commented on issue #3854: Intercept feign URL without parameters

2019-11-14 Thread GitBox
wu-sheng commented on issue #3854: Intercept feign URL without parameters URL: https://github.com/apache/skywalking/pull/3854#issuecomment-553821435 You still get the code style issue. You should check locally first. This is

[skywalking] branch master updated: fix component-libraries.yml miss component:rest-high-level-client (#3859)

2019-11-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new db0b748 fix component-libraries.yml miss

[GitHub] [skywalking] wu-sheng merged pull request #3859: fix component-libraries.yml miss component:rest-high-level-client

2019-11-14 Thread GitBox
wu-sheng merged pull request #3859: fix component-libraries.yml miss component:rest-high-level-client URL: https://github.com/apache/skywalking/pull/3859 This is an automated message from the Apache Git Service. To respond

[GitHub] [skywalking] wu-sheng commented on issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
wu-sheng commented on issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860#issuecomment-553798296 There is no such thing called development plan. In SkyWalking, if you want to do something, you could propose a design, discuss it with the committer

[GitHub] [skywalking] wu-sheng commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client

2019-11-14 Thread GitBox
wu-sheng commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client URL: https://github.com/apache/skywalking/pull/3859#issuecomment-553797571 /run ci This is an automated message from the

[GitHub] [skywalking] aderm edited a comment on issue #3859: fix component-libraries.yml miss component:rest-high-level-client

2019-11-14 Thread GitBox
aderm edited a comment on issue #3859: fix component-libraries.yml miss component:rest-high-level-client URL: https://github.com/apache/skywalking/pull/3859#issuecomment-553792612 Test file rest-high-level-client: Elasticsearch did miss out,`Component-library-settings.md` I didn't

[GitHub] [skywalking] aderm commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client

2019-11-14 Thread GitBox
aderm commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client URL: https://github.com/apache/skywalking/pull/3859#issuecomment-553792612 Test file rest-high-level-client: Elasticsearch did miss out,`Component-library-settings.md` did not elaborate on

[GitHub] [skywalking] bolyage opened a new issue #3860: storage support clickhouse

2019-11-14 Thread GitBox
bolyage opened a new issue #3860: storage support clickhouse URL: https://github.com/apache/skywalking/issues/3860 - Why do you submit this issue? - [ ] Question or discussion ___ ### Question - What do you want to know? Is the storage support clickhouse?Or is there a

[GitHub] [skywalking] wu-sheng closed issue #3858: trace cannot be displayed

2019-11-14 Thread GitBox
wu-sheng closed issue #3858: trace cannot be displayed URL: https://github.com/apache/skywalking/issues/3858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [skywalking] wu-sheng commented on issue #3858: trace cannot be displayed

2019-11-14 Thread GitBox
wu-sheng commented on issue #3858: trace cannot be displayed URL: https://github.com/apache/skywalking/issues/3858#issuecomment-553786782 Maybe some parts of trace missing. 6.4.0+ should support missing node visualization already. Please read changelog.

[GitHub] [skywalking] wu-sheng commented on issue #3805: The webflux-plugin is not working properly

2019-11-14 Thread GitBox
wu-sheng commented on issue #3805: The webflux-plugin is not working properly URL: https://github.com/apache/skywalking/issues/3805#issuecomment-553786514 You could add an optional plugin, which could use the jdk8 compile level.

[GitHub] [skywalking] wu-sheng commented on issue #3856: How to add agent in other instance ?

2019-11-14 Thread GitBox
wu-sheng commented on issue #3856: How to add agent in other instance ? URL: https://github.com/apache/skywalking/issues/3856#issuecomment-553786036 Still, don't understand what is your meaning. Are you saying you want response code 200 metrics? If yes, do that in OAL, it is supported. But

[GitHub] [skywalking] wu-sheng commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client

2019-11-14 Thread GitBox
wu-sheng commented on issue #3859: fix component-libraries.yml miss component:rest-high-level-client URL: https://github.com/apache/skywalking/pull/3859#issuecomment-553784027 FYI @aderm Please notice this. @dmsolr @arugal We should add a check about this. Across check

[GitHub] [skywalking] cyejing commented on issue #3805: The webflux-plugin is not working properly

2019-11-14 Thread GitBox
cyejing commented on issue #3805: The webflux-plugin is not working properly URL: https://github.com/apache/skywalking/issues/3805#issuecomment-553780107 I have a problem. method of Mono ``doFinally`` parameter is ``Consumer`` , this is java8 api ``java.util.function.Consumer`` . but