kezhenxu94 opened a new pull request #4307: Clean up legacy v1 header logic,
use built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307
### Motivation:
Codes clean up
### Modifications:
- Remove v1 header, follow up #4244
- Use built-in Ba
kezhenxu94 commented on a change in pull request #4307: Clean up legacy v1
header logic, use built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307#discussion_r373829546
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/c
wu-sheng commented on a change in pull request #4307: Clean up legacy v1 header
logic, use built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307#discussion_r373829678
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/cor
wu-sheng commented on a change in pull request #4307: Clean up legacy v1 header
logic, use built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307#discussion_r373829673
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/cor
wu-sheng commented on issue #30: Support query browser error log
URL:
https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-581113626
Please follow https://github.com/apache/skywalking/pull/4228 comments and
update this PR naming to keep consistent.
wu-sheng commented on issue #4307: Clean up legacy v1 header logic, use
built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307#issuecomment-581113653
Many CI processes fail. Please recheck.
This is an
kezhenxu94 commented on a change in pull request #4307: Clean up legacy v1
header logic, use built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307#discussion_r373830731
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/c
This is an automated email from the ASF dual-hosted git repository.
kezhenxu94 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new bf38e43 Clean up legacy v1 header logic
kezhenxu94 merged pull request #4307: Clean up legacy v1 header logic, use
built-in Base64 since JDK8
URL: https://github.com/apache/skywalking/pull/4307
This is an automated message from the Apache Git Service.
To respond t
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373832544
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373832878
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373831280
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373828732
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373832104
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373833049
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
Fine0830 commented on a change in pull request #4228: Support Browser protocol
at OAP
URL: https://github.com/apache/skywalking/pull/4228#discussion_r373830591
##
File path: oap-server/server-bootstrap/src/main/resources/browser_analysis.oal
##
@@ -0,0 +1,87 @@
+/*
+* Lice
mrproliu opened a new pull request #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve perf
JohnNiang commented on issue #4284: Add lombok dependency into root pom
globally
URL: https://github.com/apache/skywalking/issues/4284#issuecomment-581123382
WIP.
This is an automated message from the Apache Git Service.
To
JohnNiang opened a new pull request #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835767
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzer.j
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835447
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373834686
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835723
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzeCol
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835719
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileAnalyzeCol
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373834506
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStack.java
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835463
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373835316
##
File path: docs/en/setup/backend/backend-profile.md
##
@@ -0,0 +1,22 @@
+# Profile
Review comment:
There
kezhenxu94 commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373834816
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.
JohnNiang commented on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581124962
Maybe I have to downgrade lombok version.
--
kezhenxu94 commented on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581125022
> Maybe I have to downgrade lombok version.
@JohnNiang no, using the latest Lombok versio
codecov-io commented on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request base
(`m
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
codecov-io commented on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581127226
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4309?src=pr&el=h1)
Report
> Merging
mrproliu commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373839459
##
File path: docs/en/setup/backend/backend-profile.md
##
@@ -0,0 +1,22 @@
+# Profile
Review comment:
has lin
mrproliu commented on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581128001
> And we plan to remove all the `@author` tags since it's an ASF project,
better to remove those in newly-added files
Sure, removed.
--
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
arugal commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581134796
The metrics summary by review comments.
```
// browser app
browser_app_pv
browser_app_error_rate
browser_app_error_sum
// browser
arugal edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581134796
The metrics summary by review comments.
```
// browser app
browser_app_pv
browser_app_error_rate
browser_app_error_sum
// b
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
JohnNiang commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851304
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845769
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845609
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845731
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845903
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373850506
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373850898
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845685
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373849860
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845639
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373845784
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851569
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851621
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851621
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373851569
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on issue #4309: Move lombok dependency into root dependency
manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581142985
You should test the compiling locally first.
JohnNiang commented on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581143384
> You should test the compiling locally first.
The checks of test folder failed due to red
codecov-io edited a comment on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581127226
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4309?src=pr&el=h1)
Report
>
kezhenxu94 commented on a change in pull request #4309: Move lombok dependency
into root dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#discussion_r373889516
##
File path: pom.xml
##
@@ -275,6 +276,12 @@
wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as
a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r373895500
##
File path: dist-material/release-docs/NOTICE
##
@@ -905,4 +905,31 @@ be obtained at:
* HOMEP
codecov-io edited a comment on issue #4239: [WIP] Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1)
Report
> Merging
[#4239](https://codecov.io/
Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581205082
> The metrics summary by review comments.
>
> ```
> // browser app
> browser_app_pv
> browser_app_error_rate
> browser_app_error_su
wu-sheng commented on issue #4239: [WIP] Provide influxdb as a new storage
plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581206795
Is this PR ready to review?
This is an automated message from the Ap
codecov-io edited a comment on issue #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309#issuecomment-581127226
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4309?src=pr&el=h1)
Report
>
mrproliu commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373901774
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
mrproliu commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373901868
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
arugal opened a new pull request #17: Add Browser Error Category
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/17
ref: https://github.com/apache/skywalking/pull/4228#issuecomment-581205082 .
This is an a
JaredTan95 merged pull request #4309: Move lombok dependency into root
dependency manager for easier version management
URL: https://github.com/apache/skywalking/pull/4309
This is an automated message from the Apache Git Se
This is an automated email from the ASF dual-hosted git repository.
tanjian pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git.
from bf38e43 Clean up legacy v1 header logic, use built-in Base64 since
JDK8 (#4307)
add 7cf79b1 Move lombok
JohnNiang closed issue #4284: Add lombok dependency into root pom globally
URL: https://github.com/apache/skywalking/issues/4284
This is an automated message from the Apache Git Service.
To respond to the message, please log
mrproliu commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373905496
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded for pull request ba
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373908103
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
codecov-io edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr&el=h1)
Report
> Merging
[#4228](https://codecov.io/gh/apache/skywal
arugal edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581134796
The metrics summary by review comments.
```
// browser app
browser_app_pv
browser_app_error_rate
browser_app_error_sum
// b
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> Merging
[#4308](https://codecov.io/gh/apache/skywalki
arugal edited a comment on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581134796
The metrics summary by review comments.
```
// browser app
browser_app_pv
browser_app_error_rate
browser_app_error_sum
// b
wu-sheng merged pull request #17: Add Browser Error Category
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository
https://gitbox.apache.org/repos/asf/skywalking-data-collect-protocol.git
The following commit(s) were added to refs/heads/master by this push:
new 0cb7d90 Add Browser
wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581224216
Protocol PR merged.
This is an automated message from the Apache Git Service.
To res
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> Merging
[#4308](https://codecov.io/gh/apache/skywalki
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> Merging
[#4308](https://codecov.io/gh/apache/skywalki
codecov-io edited a comment on issue #4308: provide thread stack analyzes
URL: https://github.com/apache/skywalking/pull/4308#issuecomment-581126026
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4308?src=pr&el=h1)
Report
> Merging
[#4308](https://codecov.io/gh/apache/skywalki
Fine0830 commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-581249704
> The metrics summary by review comments.
>
> ```
> // browser app
> browser_app_pv
> browser_app_error_rate
> browser_app_error_su
dmsolr commented on issue #4239: [WIP] Provide influxdb as a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581257953
> Is this PR ready to review?
Yes.
Besides, I will adjust e2e-MySQL compatible with other
storage-plugin(InfluxDB) in a new PR
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373938102
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on a change in pull request #4308: provide thread stack
analyzes
URL: https://github.com/apache/skywalking/pull/4308#discussion_r373939512
##
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profile/analyze/ProfileStackNode.ja
wu-sheng commented on issue #4239: [WIP] Provide influxdb as a new storage
plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581261228
> I will adjust e2e-MySQL compatible
What is the meaning of this?
codecov-io edited a comment on issue #4239: [WIP] Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded f
codecov-io edited a comment on issue #4239: [WIP] Provide influxdb as a new
storage plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-575965825
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4239?src=pr&el=h1)
Report
> :exclamation: No coverage uploaded f
wu-sheng commented on a change in pull request #4239: [WIP] Provide influxdb as
a new storage plugin
URL: https://github.com/apache/skywalking/pull/4239#discussion_r373958815
##
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##
@@ -146,6 +146,11
wu-sheng commented on issue #4239: [WIP] Provide influxdb as a new storage
plugin
URL: https://github.com/apache/skywalking/pull/4239#issuecomment-581281855
Recommend to add e2e for this new storage in this PR. At least it could
recheck this new feature is basically ready.
---
94 matches
Mail list logo