[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1140790571 I am not sure why you pinged me, whether it is same, is not just about source codes, more about target classes, and APIs(such as import classes). This PR came from ServiceComb te

[skywalking-java] branch fix-netty-lib-relocation created (now 7dea4f22b)

2022-05-30 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch fix-netty-lib-relocation in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 7dea4f22b fix native lib relocation for aarch64 This branch includes the following new

[skywalking-java] 01/01: fix native lib relocation for aarch64

2022-05-30 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a commit to branch fix-netty-lib-relocation in repository https://gitbox.apache.org/repos/asf/skywalking-java.git commit 7dea4f22bad1c936b85b9237ddde8b1ddeed014b Author: Megrez Lu AuthorDate: Mon May 30 15:25:38

[skywalking-java] branch fix-netty-lib-relocation updated: add changelog

2022-05-30 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a commit to branch fix-netty-lib-relocation in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/fix-netty-lib-relocation by this push: new

[GitHub] [skywalking-java] lujiajing1126 opened a new pull request, #186: Fix tcnative lib relocation

2022-05-30 Thread GitBox
lujiajing1126 opened a new pull request, #186: URL: https://github.com/apache/skywalking-java/pull/186 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #174: Add `plugin.jdbc.trace_sql_parameters` into Configuration Discovery S…

2022-05-30 Thread GitBox
wu-sheng commented on code in PR #174: URL: https://github.com/apache/skywalking-java/pull/174#discussion_r884511362 ## apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/TraceSqlParametersWatcher.java: ## @@ -0,0 +1,46 @@ +/* + * License

[GitHub] [skywalking-java] wu-sheng merged pull request #186: Fix tcnative lib relocation

2022-05-30 Thread GitBox
wu-sheng merged PR #186: URL: https://github.com/apache/skywalking-java/pull/186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[skywalking-java] branch main updated: Fix tcnative lib relocation (#186)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 1b30a0c08 Fix tcnative lib relocation (#18

[skywalking-java] branch wu-sheng-patch-1 created (now b82056c46)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at b82056c46 Remove JDK 14 from tests This branch includes the following new commits: new b820

[skywalking-java] 01/01: Remove JDK 14 from tests

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git commit b82056c46323cede542fe0622f92eb4077997f03 Author: 吴晟 Wu Sheng AuthorDate: Mon May 30 15:58:18 2022 +0

[GitHub] [skywalking-java] zhyyu commented on a diff in pull request #174: Add `plugin.jdbc.trace_sql_parameters` into Configuration Discovery S…

2022-05-30 Thread GitBox
zhyyu commented on code in PR #174: URL: https://github.com/apache/skywalking-java/pull/174#discussion_r884533484 ## apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/TraceSqlParametersWatcher.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed t

[skywalking-java] branch wu-sheng-patch-1 updated: Remove jdk14-with-gson test.

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/wu-sheng-patch-1 by this push: new 6dd90a087 Remove j

[GitHub] [skywalking-java] wu-sheng opened a new pull request, #187: Remove JDK 14 from tests

2022-05-30 Thread GitBox
wu-sheng opened a new pull request, #187: URL: https://github.com/apache/skywalking-java/pull/187 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://githu

[GitHub] [skywalking-java] wu-sheng merged pull request #187: Remove JDK 14 from tests

2022-05-30 Thread GitBox
wu-sheng merged PR #187: URL: https://github.com/apache/skywalking-java/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[skywalking-java] branch main updated: Remove JDK 14 from tests (#187)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new a8214514a Remove JDK 14 from tests (#187)

[skywalking-java] branch dependabot/maven/apm-sniffer/optional-plugins/shenyu-2.4.x-plugin/org.apache.dubbo-dubbo-2.7.15 created (now e6997db57)

2022-05-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/optional-plugins/shenyu-2.4.x-plugin/org.apache.dubbo-dubbo-2.7.15 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at e6997db57 Bump

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #188: Bump dubbo from 2.7.0 to 2.7.15 in /apm-sniffer/optional-plugins/shenyu-2.4.x-plugin

2022-05-30 Thread GitBox
dependabot[bot] opened a new pull request, #188: URL: https://github.com/apache/skywalking-java/pull/188 Bumps [dubbo](https://github.com/apache/dubbo) from 2.7.0 to 2.7.15. Release notes Sourced from https://github.com/apache/dubbo/releases";>dubbo's releases. dubbo-2.7.15

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #188: Bump dubbo from 2.7.0 to 2.7.15 in /apm-sniffer/optional-plugins/shenyu-2.4.x-plugin

2022-05-30 Thread GitBox
dependabot[bot] commented on PR #188: URL: https://github.com/apache/skywalking-java/pull/188#issuecomment-1140862911 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [skywalking-java] wu-sheng closed pull request #188: Bump dubbo from 2.7.0 to 2.7.15 in /apm-sniffer/optional-plugins/shenyu-2.4.x-plugin

2022-05-30 Thread GitBox
wu-sheng closed pull request #188: Bump dubbo from 2.7.0 to 2.7.15 in /apm-sniffer/optional-plugins/shenyu-2.4.x-plugin URL: https://github.com/apache/skywalking-java/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [skywalking-kubernetes] wu-sheng commented on pull request #86: Fix hasSuffix replace hasPrefix

2022-05-30 Thread GitBox
wu-sheng commented on PR #86: URL: https://github.com/apache/skywalking-kubernetes/pull/86#issuecomment-1140869310 @geffzhang Would you like to follow up this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #101: feat: add `Percentage Of Root` and `Percentage Of Selected` in the eBPF widget

2022-05-30 Thread GitBox
Fine0830 opened a new pull request, #101: URL: https://github.com/apache/skywalking-booster-ui/pull/101 Add `Percentage Of Root` and `Percentage Of Selected` in the eBPF widget. Screenshots https://user-images.githubusercontent.com/20871783/170961227-2d021ce5-1329-425a-bee8-46879975

[skywalking-website] branch asf-site updated: deploy: 2eba8b874ef3d70afc3c4bfa2eedb657cb07d1d4

2022-05-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3323656bda deploy: 2eba8b874

[GitHub] [skywalking-booster-ui] wu-sheng commented on pull request #101: feat: add `Percentage Of Root` and `Percentage Of Selected` in the eBPF widget

2022-05-30 Thread GitBox
wu-sheng commented on PR #101: URL: https://github.com/apache/skywalking-booster-ui/pull/101#issuecomment-1140960228 Please fix CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [skywalking-booster-ui] Fine0830 merged pull request #101: feat: add `Percentage Of Root` and `Percentage Of Selected` in the eBPF widget

2022-05-30 Thread GitBox
Fine0830 merged PR #101: URL: https://github.com/apache/skywalking-booster-ui/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[skywalking-booster-ui] branch main updated: feat: add `Percentage Of Root` and `Percentage Of Selected` in the eBPF widget (#101)

2022-05-30 Thread qiuxiafan
This is an automated email from the ASF dual-hosted git repository. qiuxiafan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 4d26728 feat: add `Percentage Of

[skywalking-banyandb] branch test-stress created (now f17622f)

2022-05-30 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch test-stress in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at f17622f Add the stress test framework This branch includes the following new commits: new

[skywalking-banyandb] 01/01: Add the stress test framework

2022-05-30 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch test-stress in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit f17622f2806c6320ad04a0d546ca09ff19314d56 Author: Gao Hongtao AuthorDate: Mon May 30 10:28:10 2022 +

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #122: Add the stress test framework

2022-05-30 Thread GitBox
hanahmily opened a new pull request, #122: URL: https://github.com/apache/skywalking-banyandb/pull/122 This introduced a stress test framework to generate fixed traffic to verify several behaviors of the banyand server. ## Verify the flushing mechanism of tsdb Most caches of t

[GitHub] [skywalking-banyandb] hanahmily commented on pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
hanahmily commented on PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122#issuecomment-1141012112 Once this PR gets merged, we could move to release the 0.1.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking-banyandb] wu-sheng commented on pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
wu-sheng commented on PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122#issuecomment-1141018524 A question, is the flush required to improve in the future? Do we have disk volume cost? Such as how many GB on disk for 10g traces? -- This is an automated message from t

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
lujiajing1126 commented on code in PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122#discussion_r884721196 ## banyand/measure/measure.go: ## @@ -31,8 +31,10 @@ import ( "github.com/apache/skywalking-banyandb/pkg/timestamp" ) -// a chunk is 1MB -con

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
hanahmily commented on code in PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122#discussion_r884787888 ## banyand/measure/measure.go: ## @@ -31,8 +31,10 @@ import ( "github.com/apache/skywalking-banyandb/pkg/timestamp" ) -// a chunk is 1MB -const c

[GitHub] [skywalking-java] wu-sheng merged pull request #174: Add `plugin.jdbc.trace_sql_parameters` into Configuration Discovery S…

2022-05-30 Thread GitBox
wu-sheng merged PR #174: URL: https://github.com/apache/skywalking-java/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[skywalking-java] branch main updated: Add `plugin.jdbc.trace_sql_parameters` into Configuration Discovery S… (#174)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new e81638ea4 Add `plugin.jdbc.trace_sql_param

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
hanahmily commented on code in PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122#discussion_r884792564 ## pkg/logger/setting.go: ## @@ -23,46 +23,68 @@ import ( "os" "strings" "sync" + "sync/atomic" "time" "gith

[GitHub] [skywalking-banyandb] hanahmily merged pull request #122: Add the stress test framework

2022-05-30 Thread GitBox
hanahmily merged PR #122: URL: https://github.com/apache/skywalking-banyandb/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[skywalking-banyandb] branch main updated: Add the stress test framework (#122)

2022-05-30 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new 7adf824 Add the stress test framewo

[GitHub] [skywalking] wu-sheng closed issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS

2022-05-30 Thread GitBox
wu-sheng closed issue #9028: [Feature] add plugin.jdbc.trace_sql_parameters into agent CDS URL: https://github.com/apache/skywalking/issues/9028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [skywalking] tom-pytel opened a new issue, #9146: Python: Error installing packages with latest version

2022-05-30 Thread GitBox
tom-pytel opened a new issue, #9146: URL: https://github.com/apache/skywalking/issues/9146 ``` $ pip install -r requirements.txt ... Collecting mysqlclient==2.1.0 Using cached mysqlclient-2.1.0.tar.gz (87 kB) Preparing metadata (setup.py) ... error error: subpr

[GitHub] [skywalking] Superskyyy commented on issue #9146: Python: Error installing packages with latest version of Python agent

2022-05-30 Thread GitBox
Superskyyy commented on issue #9146: URL: https://github.com/apache/skywalking/issues/9146#issuecomment-1141199686 I just tried and didn't meet the same problem on a Windows machine. From the PyPI site, I think there are extra system-level dependencies before it can be properly installed.

[GitHub] [skywalking] tom-pytel commented on issue #9146: Python: Error installing packages with latest version of Python agent

2022-05-30 Thread GitBox
tom-pytel commented on issue #9146: URL: https://github.com/apache/skywalking/issues/9146#issuecomment-1141228733 ``` sudo apt-get install python3-dev default-libmysqlclient-dev build-essential ``` Thad did it thx. I had python3-dev installed but not the mysql stuff. -- Th

[GitHub] [skywalking] tom-pytel closed issue #9146: Python: Error installing packages with latest version of Python agent

2022-05-30 Thread GitBox
tom-pytel closed issue #9146: Python: Error installing packages with latest version of Python agent URL: https://github.com/apache/skywalking/issues/9146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking-python] tom-pytel opened a new pull request, #210: improved ignore path regex

2022-05-30 Thread GitBox
tom-pytel opened a new pull request, #210: URL: https://github.com/apache/skywalking-python/pull/210 This is the same as skywalking-nodejs PR #81: Minor enhancement/fix? Previously the config.trace_ignore_path pattern `/a/**/*` would match `/a/b/`, `/a/b/c` and `/a/b/c/`, etc.

[GitHub] [skywalking-python] tom-pytel commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
tom-pytel commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141344754 Update test case, `/**/` should match any number of path segments OR NONE, test case was expecting to match at least one. Correct pattern to match AT LEAST ONE is `/*/**/`. -

[GitHub] [skywalking-python] Superskyyy commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
Superskyyy commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141401409 I think that a `/a/**/*` pattern should not match `/a/` because there must be another `/` after the `**`. Just want to point out the potential mismatch with a common pe

[GitHub] [skywalking-python] tom-pytel commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
tom-pytel commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141421345 > I think that a `/a/**/*` pattern should not match `/a/` because there must be another `/` after the `**`. > > Just want to point out the potential mismatch with a commo

[GitHub] [skywalking-python] Superskyyy commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
Superskyyy commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141428688 I think you are right, this is indeed more robust. Probably adding a small FAQ documentation will be nice, so it eliminates user confusion. -- This is an automated message

[GitHub] [skywalking-python] Superskyyy commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
Superskyyy commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141428774 Other than this concern all LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking-python] tom-pytel commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
tom-pytel commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141462707 > I think you are right, this is indeed more robust. Probably adding a small FAQ documentation will be nice, so it eliminates user confusion. I was looking for a place to

[GitHub] [skywalking-python] Superskyyy commented on pull request #210: improved ignore path regex

2022-05-30 Thread GitBox
Superskyyy commented on PR #210: URL: https://github.com/apache/skywalking-python/pull/210#issuecomment-1141475042 I see, I didn't take a careful look ealier. Then everything LGTM :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [skywalking-python] tom-pytel merged pull request #210: Improved ignore path regex

2022-05-30 Thread GitBox
tom-pytel merged PR #210: URL: https://github.com/apache/skywalking-python/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubs

[skywalking-python] branch master updated: Improved ignore path regex (#210)

2022-05-30 Thread tompytel
This is an automated email from the ASF dual-hosted git repository. tompytel pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/master by this push: new a69041f Improved ignore path regex

[GitHub] [skywalking-java] liubao68 commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
liubao68 commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141575759 @wu-sheng I guess @jaryzou thinks when both 1.x and 2.x plugins are load by skywalking, the plugin used maybe 1.x or 2.x. And It is useless to write a new plugin for 2.x. I

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141579035 We don't have a mechanism to check versions, because they are pointless. The only thing that matters for the plugin is relative codes, class, and methods are used inside the instru

[GitHub] [skywalking-java] liubao68 commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
liubao68 commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141581147 I checked ClassInstanceMethodsEnhancePluginDefine ``` @Override protected ClassMatch enhanceClass() { return NameMatch.byName(ENHANCE_CLASS);

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141581308 @liubao68 @jaryzou If they are the same, you could remove the `servicecomb-java-chassis-1.x-plugin` and to check whether all plugin tests are still passed, if so, I think it is saf

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141581978 > I checked ClassInstanceMethodsEnhancePluginDefine > > ``` > @Override > protected ClassMatch enhanceClass() { > return NameMatch.byName(ENHANCE_CLAS

[GitHub] [skywalking-rust] wu-sheng commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141582809 > Remove Cargo.lock Remove the lock file because? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking-java] liubao68 commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
liubao68 commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141583791 Thanks, we'll further to check how skywalking checks the target plugin to use. BTW, do you think this scenario can be improved ? e.g. when two versions have same signature

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141587425 > Add new plugins for new version is quit normal in continues integration. e.g. We all update the dependencies for new version but change no codes. If you mean there is a log

[skywalking-java] branch remove-duplicate created (now 39a2e78eb)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch remove-duplicate in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at 39a2e78eb Follow https://github.com/apache/skywalking-java/pull/127#issuecomment-1140764345 This

[skywalking-java] 01/01: Follow https://github.com/apache/skywalking-java/pull/127#issuecomment-1140764345

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch remove-duplicate in repository https://gitbox.apache.org/repos/asf/skywalking-java.git commit 39a2e78eb0762965f2faf67929307bbec68e53e9 Author: Wu Sheng AuthorDate: Tue May 31 09:49:41 2022 +0800

[GitHub] [skywalking-java] wu-sheng opened a new pull request, #189: Remove duplicate ServiceCom plugin codes.

2022-05-30 Thread GitBox
wu-sheng opened a new pull request, #189: URL: https://github.com/apache/skywalking-java/pull/189 …t-1140764345 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141588638 I opened https://github.com/apache/skywalking-java/pull/189 to follow what you are asking, let's see. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [skywalking-java] liubao68 commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
liubao68 commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141591692 Thanks, we'll check how to use witness class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-rust] jmjoy commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
jmjoy commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141597041 > > Remove Cargo.lock > > Remove the lock file because? Reference: > If you’re building a non-e

[GitHub] [skywalking-rust] wu-sheng commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141607003 In ASF, all dependencies must be locked. Think in this way, one library will change license from Apache 2.0 to GPL even commercial, then every released version would be compromised.

[GitHub] [skywalking-rust] wu-sheng commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141607387 If you are upgrading versions like this PR, binary license should be updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking-java] wu-sheng commented on pull request #127: servicecomb 2.0 plugin

2022-05-30 Thread GitBox
wu-sheng commented on PR #127: URL: https://github.com/apache/skywalking-java/pull/127#issuecomment-1141608408 I don't think there is meaning to use witness cases for now. It seems 2.0 plugin still passed the v1 cases. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [skywalking-java] wu-sheng merged pull request #189: Remove duplicate ServiceComb plugin codes.

2022-05-30 Thread GitBox
wu-sheng merged PR #189: URL: https://github.com/apache/skywalking-java/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[skywalking-java] branch main updated: Remove duplicate ServiceComb plugin codes. (#189)

2022-05-30 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new d468806f4 Remove duplicate ServiceComb plu

[GitHub] [skywalking-rust] jmjoy commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
jmjoy commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141619266 1. When crate as a dependency, `Cargo.lock` is not valid, even if you add it to version management. 2. In general, changing the license should promote the large version, or minor ver

[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885174868 ## build.rs: ## @@ -15,8 +15,11 @@ // fn main() -> Result<(), Box> { -tonic_build::configure().compile( -&["./skywalking-data-collect-protocol/langu

[GitHub] [skywalking-rust] wu-sheng commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141632114 Please check CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
jmjoy commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885175797 ## build.rs: ## @@ -15,8 +15,11 @@ // fn main() -> Result<(), Box> { -tonic_build::configure().compile( -&["./skywalking-data-collect-protocol/language

[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885176120 ## build.rs: ## @@ -15,8 +15,11 @@ // fn main() -> Result<(), Box> { -tonic_build::configure().compile( -&["./skywalking-data-collect-protocol/langu

[GitHub] [skywalking-rust] codecov-commenter commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
codecov-commenter commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141633569 # [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/19?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [skywalking] donghbcn opened a new issue, #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
donghbcn opened a new issue, #9147: URL: https://github.com/apache/skywalking/issues/9147 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

[GitHub] [skywalking] wu-sheng closed issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
wu-sheng closed issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page URL: https://github.com/apache/skywalking/issues/9147 -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [skywalking] wu-sheng commented on issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
wu-sheng commented on issue #9147: URL: https://github.com/apache/skywalking/issues/9147#issuecomment-1141636544 v8 is not on support mode anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] mrproliu opened a new pull request, #9148: Fix write record data to the wrong index name in ES storage

2022-05-30 Thread GitBox
mrproliu opened a new pull request, #9148: URL: https://github.com/apache/skywalking/pull/9148 Continue https://github.com/apache/skywalking/pull/9145, the previous PR simplified the format relate to TTL and installation, but forget to update the data written index name. - [ ] If th

[GitHub] [skywalking] donghbcn commented on issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
donghbcn commented on issue #9147: URL: https://github.com/apache/skywalking/issues/9147#issuecomment-1141643323 Do you mean it's not a problem in v.9.1.0 any more? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [skywalking] Superskyyy commented on issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
Superskyyy commented on issue #9147: URL: https://github.com/apache/skywalking/issues/9147#issuecomment-1141644545 > Do you mean it's not a problem in v.9.1.0 any more? V9 uses a brand new UI project and it's called boosterUI, RobcketBotUI is no longer maintained. -- This is an au

[GitHub] [skywalking] donghbcn commented on issue #9147: [Bug] The current page number does not change if total page size is less than the current page number after a new query in trace page

2022-05-30 Thread GitBox
donghbcn commented on issue #9147: URL: https://github.com/apache/skywalking/issues/9147#issuecomment-1141644957 Understand now, thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885188067 ## e2e/Cargo.toml: ## @@ -20,6 +20,7 @@ name = "e2e" version = "0.1.0" authors = ["Shikugawa "] edition = "2021" +publish = false Review Comment: What is thi

[GitHub] [skywalking-rust] jmjoy commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
jmjoy commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885190497 ## e2e/Cargo.toml: ## @@ -20,6 +20,7 @@ name = "e2e" version = "0.1.0" authors = ["Shikugawa "] edition = "2021" +publish = false Review Comment: Avoid publish

[GitHub] [skywalking-rust] wu-sheng commented on pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#issuecomment-1141659486 The agent test is still failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[skywalking] branch master updated: Fix write record data to the wrong index name in ES storage (#9148)

2022-05-30 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 0447cb2b71 Fix write record data to the wron

[GitHub] [skywalking] mrproliu merged pull request #9148: Fix write record data to the wrong index name in ES storage

2022-05-30 Thread GitBox
mrproliu merged PR #9148: URL: https://github.com/apache/skywalking/pull/9148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[skywalking-banyandb] branch license created (now a016da3)

2022-05-30 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch license in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at a016da3 Add licenses of dependencies This branch includes the following new commits: new a016

[GitHub] [skywalking-banyandb] hanahmily opened a new pull request, #123: Prepare for releasing 0.1.0

2022-05-30 Thread GitBox
hanahmily opened a new pull request, #123: URL: https://github.com/apache/skywalking-banyandb/pull/123 - Add licenses of dependencies - Update CHANGES.md Signed-off-by: Gao Hongtao -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [skywalking-banyandb] hanahmily merged pull request #123: Prepare for releasing 0.1.0

2022-05-30 Thread GitBox
hanahmily merged PR #123: URL: https://github.com/apache/skywalking-banyandb/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsu

[GitHub] [skywalking-rust] wu-sheng commented on a diff in pull request #19: Remove Cargo.lock, update dependencies, update submodule, disable build grpc server api.

2022-05-30 Thread GitBox
wu-sheng commented on code in PR #19: URL: https://github.com/apache/skywalking-rust/pull/19#discussion_r885249821 ## build.rs: ## @@ -15,8 +15,11 @@ // fn main() -> Result<(), Box> { -tonic_build::configure().compile( -&["./skywalking-data-collect-protocol/langu