[GitHub] [skywalking] innerpeacez opened a new issue, #10457: [Bug] Click the topology node to appear in the wrong position of the menu

2023-02-27 Thread via GitHub
innerpeacez opened a new issue, #10457: URL: https://github.com/apache/skywalking/issues/10457 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Compone

[GitHub] [skywalking] Fine0830 commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
Fine0830 commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447637839 > @Fine0830 I think we need `cpm5d + AvgPreview` for table list calculation. https://github.com/apache/skywalking/pull/10456 has merged. Please feel free to use `cpm5d + AvgPr

[GitHub] [skywalking] wu-sheng merged pull request #10456: Sync UI: add calculation related to `cpm5d`

2023-02-27 Thread via GitHub
wu-sheng merged PR #10456: URL: https://github.com/apache/skywalking/pull/10456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[skywalking] branch master updated: sync ui (#10456)

2023-02-27 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 90d6fccf69 sync ui (#10456) 90d6fccf69 is d

[GitHub] [skywalking] jameslee007 commented on issue #10439: [Bug] make command stopped at Unable to find libclang in alpine

2023-02-27 Thread via GitHub
jameslee007 commented on issue #10439: URL: https://github.com/apache/skywalking/issues/10439#issuecomment-1447633651 Can anyone please help me on how to install skywalking_agent in alpine image? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] Fine0830 opened a new pull request, #10456: Sync UI: add calculation related to `cpm5d`

2023-02-27 Thread via GitHub
Fine0830 opened a new pull request, #10456: URL: https://github.com/apache/skywalking/pull/10456 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/d

[skywalking-booster-ui] branch main updated: feat: add cpm4d + avg calculations (#241)

2023-02-27 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 1be572a feat: add cpm4d + avg calcu

[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #241: feat: add calculations for the `cpm5dAvg`

2023-02-27 Thread via GitHub
wu-sheng merged PR #241: URL: https://github.com/apache/skywalking-booster-ui/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #241: feat: add calculations for the `cpm5dAvg`

2023-02-27 Thread via GitHub
Fine0830 opened a new pull request, #241: URL: https://github.com/apache/skywalking-booster-ui/pull/241 Add calculations for the `cpm5dAvg`. Video https://user-images.githubusercontent.com/20871783/221756396-4bf3acd4-4ab1-496d-9b03-0cae4651e2ee.mov Signed-off-by: Qi

[skywalking] branch master updated: Adapt otel exponential histogram data (#10449)

2023-02-27 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new f93a98d4c7 Adapt otel exponential histogram

[GitHub] [skywalking] wu-sheng merged pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng merged PR #10449: URL: https://github.com/apache/skywalking/pull/10449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1119472695 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1119459445 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1119438687 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] hanahmily commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
hanahmily commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1119436555 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
kezhenxu94 commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1119433268 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/test/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessorTest.java

[GitHub] [skywalking] wu-sheng commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447296388 @Fine0830 I think we need `cpm5d + AvgPreview` for table list calculation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447284938 Do you mean we need a new UI function? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking] wu-sheng commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447284023 I am not following, the read through GraphQL is reading values, and calculated by UI function. So, the OAL should not be irrelevant. -- This is an automated message from the Ap

[GitHub] [skywalking] kezhenxu94 commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
kezhenxu94 commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447278964 > > But here comes the problem, if I change it to cpm5d, the list will be broken. > > Could you check the GraphQL to see what happens? Basically, changing the metric name(k

[GitHub] [skywalking] wu-sheng commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1447273072 > But here comes the problem, if I change it to cpm5d, the list will be broken. Could you check the GraphQL to see what happens? Basically, changing the metric name(keep calc

[GitHub] [skywalking] Superskyyy commented on issue #10447: [Feature] Python agent performance enhancement with Confluent-Kafka

2023-02-27 Thread via GitHub
Superskyyy commented on issue #10447: URL: https://github.com/apache/skywalking/issues/10447#issuecomment-1447007787 > I have now basically finished migrating the code from **kafka-python** to **confluent-kafka-python** and successfully running the prefork use case in the demos folder. But

[GitHub] [skywalking] toffentoffen commented on pull request #10420: Add cpm5d aggregation function

2023-02-27 Thread via GitHub
toffentoffen commented on PR #10420: URL: https://github.com/apache/skywalking/pull/10420#issuecomment-1446889913 > [apache/skywalking-booster-ui#239](https://github.com/apache/skywalking-booster-ui/pull/239) has merged. Please update the relative dashboards and OAL to adopt this cpm5d fun

[GitHub] [skywalking] FAWC438 commented on issue #10447: [Feature] Python agent performance enhancement with Confluent-Kafka

2023-02-27 Thread via GitHub
FAWC438 commented on issue #10447: URL: https://github.com/apache/skywalking/issues/10447#issuecomment-1446800146 I have now basically finished migrating the code from **kafka-python** to **confluent-kafka-python** and successfully running the prefork use case in the demos folder. But no fu

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118967182 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118955396 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118955396 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953641 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118953797 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118944320 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118933586 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118928239 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118923225 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118923225 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java:

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118919216 ## oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java: ## @@ -315,6 +326,30 @@ private Class generateMetricsClass(AnalysisResult metric

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118915600 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118913759 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118907876 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118906645 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBAggregationQueryDAO.java: #

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118900586 ## oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java: ## @@ -315,6 +326,30 @@ private Class generateMetricsClass(AnalysisResult m

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118899100 ## oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java: ## @@ -315,6 +326,30 @@ private Class generateMetricsClass(AnalysisResult metric

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118897935 ## oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java: ## @@ -315,6 +326,30 @@ private Class generateMetricsClass(AnalysisResult metric

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118880408 ## oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBModelExtension.java: ## @@ -45,4 +46,23 @@ public class B

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118877729 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[skywalking] branch banyandb-topn updated (a9cf1d6989 -> 15006b3071)

2023-02-27 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch banyandb-topn in repository https://gitbox.apache.org/repos/asf/skywalking.git from a9cf1d6989 support filter add 15006b3071 add @BanyanDB.TopNAggregation to OAL and MAL No new revis

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118842586 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java:

[GitHub] [skywalking] kezhenxu94 commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
kezhenxu94 commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118837536 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java: ##

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118833407 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java:

[GitHub] [skywalking] wu-sheng commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446440510 > the function can not be put into the OpenTelemetryMetricRequestProcessor#adaptMetrics part and should be put in the analyzer part. And should we also consider small double data c

[GitHub] [skywalking] mufiye commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446398092 > If you want to learn this for now, then MAL is groovy based script. `SampleFamily` is the root class running in MAL engine, and this is the type referred by the metric name of the e

[GitHub] [skywalking] wu-sheng commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446371235 > > > I review the data collected from airflow and find there are some small timer data, such as 1.182709 and 1.348083 in one exponentialHistogram data. Where should I add the closu

[GitHub] [skywalking] mufiye commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446353848 > > I review the data collected from airflow and find there are some small timer data, such as 1.182709 and 1.348083 in one exponentialHistogram data. Where should I add the closure?

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118757785 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ## @@ -1

[GitHub] [skywalking] wu-sheng closed issue #10454: [Feature] Implement the manual trace API for Java

2023-02-27 Thread via GitHub
wu-sheng closed issue #10454: [Feature] Implement the manual trace API for Java URL: https://github.com/apache/skywalking/issues/10454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [skywalking] CoderYellow opened a new issue, #10454: [Feature] Implement the manual trace API for Java

2023-02-27 Thread via GitHub
CoderYellow opened a new issue, #10454: URL: https://github.com/apache/skywalking/issues/10454 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

2023-02-27 Thread via GitHub
lujiajing1126 commented on code in PR #10448: URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118731890 ## oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java: ##

[GitHub] [skywalking] wu-sheng commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446261363 > I review the data collected from airflow and find there are some small timer data, such as 1.182709 and 1.348083 in one exponentialHistogram data. Where should I add the closure?

[GitHub] [skywalking] mufiye commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446259412 > > > @mufiye One question, does this histogram always build bucket boundaries as integers? Could it be a very small double? Because when we calculate percentile from

[GitHub] [skywalking] wu-sheng commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446246228 > > @mufiye One question, does this histogram always build bucket boundaries as integers? Could it be a very small double? Because when we calculate percentile from the histogram (u

[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
wu-sheng commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118668885 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java:

[GitHub] [skywalking] mufiye commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118651899 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java: ##

[GitHub] [skywalking] mufiye commented on pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on PR #10449: URL: https://github.com/apache/skywalking/pull/10449#issuecomment-1446202639 > @mufiye One question, does this histogram always build bucket boundaries as integers? Could it be a very small double? Because when we calculate percentile from the histogram (usual

[GitHub] [skywalking] mufiye commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118496823 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java: ##

[GitHub] [skywalking] mufiye commented on a diff in pull request #10449: Adapt otel exponential histogram data

2023-02-27 Thread via GitHub
mufiye commented on code in PR #10449: URL: https://github.com/apache/skywalking/pull/10449#discussion_r1118496823 ## oap-server/server-receiver-plugin/otel-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/otel/otlp/OpenTelemetryMetricRequestProcessor.java: ##