[GitHub] [skywalking-python] Superskyyy opened a new pull request, #294: Remove dead MIT gpg site and fix release command

2023-03-14 Thread via GitHub
Superskyyy opened a new pull request, #294: URL: https://github.com/apache/skywalking-python/pull/294 1. MIT gpg site is gone, replaced with ubuntu keyserver. 2. Release command was previously wrong, now fixed. - [ ] If this pull request

[skywalking-python] branch remove-gpg-dl updated: Fix release doc and command

2023-03-14 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a commit to branch remove-gpg-dl in repository https://gitbox.apache.org/repos/asf/skywalking-python.git The following commit(s) were added to refs/heads/remove-gpg-dl by this push: new 527a832 Fix

[skywalking-cli] branch master updated: Support sub-commands for the cross-thread trace profiling (#178)

2023-03-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new f3eed66 Support sub-commands for the

[GitHub] [skywalking-cli] wu-sheng merged pull request #178: Update sub-commands for the cross-thread trace profiling

2023-03-14 Thread via GitHub
wu-sheng merged PR #178: URL: https://github.com/apache/skywalking-cli/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-python] branch remove-gpg-dl created (now 1803a71)

2023-03-14 Thread yihaochen
This is an automated email from the ASF dual-hosted git repository. yihaochen pushed a change to branch remove-gpg-dl in repository https://gitbox.apache.org/repos/asf/skywalking-python.git at 1803a71 Fix wrong environment names in doc (#292) No new revisions were added by this update.

[GitHub] [skywalking-python] Superskyyy commented on pull request #293: Don't init profile / meter damon threads when not active.

2023-03-14 Thread via GitHub
Superskyyy commented on PR #293: URL: https://github.com/apache/skywalking-python/pull/293#issuecomment-1469334879 > @Superskyyy Why the deadlink happens? I assume this is a main branch issue. It's the mit gpg site, I will remove it from doc. -- This is an automated message from

[GitHub] [skywalking] jmjoy closed issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

2023-03-14 Thread via GitHub
jmjoy closed issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`. URL: https://github.com/apache/skywalking/issues/10539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [skywalking-python] Superskyyy commented on pull request #293: Update __init__.py

2023-03-14 Thread via GitHub
Superskyyy commented on PR #293: URL: https://github.com/apache/skywalking-python/pull/293#issuecomment-1469333844 Let's wait CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking-python] wu-sheng commented on pull request #293: Update __init__.py

2023-03-14 Thread via GitHub
wu-sheng commented on PR #293: URL: https://github.com/apache/skywalking-python/pull/293#issuecomment-1469333913 @Superskyyy Why the deadlink happens? I assume this is a main branch issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-python] Superskyyy commented on pull request #293: Update __init__.py

2023-03-14 Thread via GitHub
Superskyyy commented on PR #293: URL: https://github.com/apache/skywalking-python/pull/293#issuecomment-1469330181 Good catch thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] kezhenxu94 commented on issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

2023-03-14 Thread via GitHub
kezhenxu94 commented on issue #10539: URL: https://github.com/apache/skywalking/issues/10539#issuecomment-1469322537 `check` is to check incompatible licenses, adding `--summary` to `check` command sounds like "the summary of incompatible licenses", if you wan to check the summary file,

[GitHub] [skywalking-cli] mrproliu opened a new pull request, #178: Support sub-commands for the cross-thread trace profiling

2023-03-14 Thread via GitHub
mrproliu opened a new pull request, #178: URL: https://github.com/apache/skywalking-cli/pull/178 1. `profiling trace segment-list`: update the response data content. 2. `profiling trace profiled-segment`: remove this command. 3. `profiling trace analysis`: replace flag `segment-id`

[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

2023-03-14 Thread via GitHub
lujiajing1126 commented on code in PR #257: URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1136506714 ## banyand/measure/measure_write.go: ## @@ -131,9 +131,12 @@ func (s *measure) write(shardID common.ShardID, entity []byte, entityValues tsdb

[skywalking-banyandb] branch topn-oap-integration updated (b09f6a22 -> 44ad6a7d)

2023-03-14 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch topn-oap-integration in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from b09f6a22 Merge branch 'main' into topn-oap-integration add 44ad6a7d set TopN to 2

[GitHub] [skywalking-python] ZEALi opened a new pull request, #293: Update __init__.py

2023-03-14 Thread via GitHub
ZEALi opened a new pull request, #293: URL: https://github.com/apache/skywalking-python/pull/293 should not init profile / meter damon threads if those configuration are not active. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [skywalking] wu-sheng commented on issue #9560: [Bug] [Eyes] Ignore pattern doesn't work for `cmake-build-* ` when it is intended to be a folder

2023-03-14 Thread via GitHub
wu-sheng commented on issue #9560: URL: https://github.com/apache/skywalking/issues/9560#issuecomment-1469250255 I am going to close until someone is willing pick it back to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [skywalking] wu-sheng closed issue #9560: [Bug] [Eyes] Ignore pattern doesn't work for `cmake-build-* ` when it is intended to be a folder

2023-03-14 Thread via GitHub
wu-sheng closed issue #9560: [Bug] [Eyes] Ignore pattern doesn't work for `cmake-build-* ` when it is intended to be a folder URL: https://github.com/apache/skywalking/issues/9560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [skywalking] tisonkun commented on issue #9560: [Bug] [Eyes] Ignore pattern doesn't work for `cmake-build-* ` when it is intended to be a folder

2023-03-14 Thread via GitHub
tisonkun commented on issue #9560: URL: https://github.com/apache/skywalking/issues/9560#issuecomment-1469249446 @wu-sheng This is more like a new feature suggestion that I don't have time to implement :) I'm OK if it's closed as workaround provided: ``` cmake-build-*/**

[GitHub] [skywalking] wu-sheng commented on issue #8686: [Bug] Owner field doesn't work correctly

2023-03-14 Thread via GitHub
wu-sheng commented on issue #8686: URL: https://github.com/apache/skywalking/issues/8686#issuecomment-1469249152 No update for a year. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking] wu-sheng closed issue #8686: [Bug] Owner field doesn't work correctly

2023-03-14 Thread via GitHub
wu-sheng closed issue #8686: [Bug] Owner field doesn't work correctly URL: https://github.com/apache/skywalking/issues/8686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [skywalking] jmjoy commented on issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

2023-03-14 Thread via GitHub
jmjoy commented on issue #10539: URL: https://github.com/apache/skywalking/issues/10539#issuecomment-1469248012 @kezhenxu94 How about the idea? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng commented on issue #9560: [Bug] [Eyes] Ignore pattern doesn't work for `cmake-build-* ` when it is intended to be a folder

2023-03-14 Thread via GitHub
wu-sheng commented on issue #9560: URL: https://github.com/apache/skywalking/issues/9560#issuecomment-1469247487 Is there any update for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[skywalking-banyandb] branch topn-oap-integration updated (4e428bd5 -> b09f6a22)

2023-03-14 Thread lujiajing
This is an automated email from the ASF dual-hosted git repository. lujiajing pushed a change to branch topn-oap-integration in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 4e428bd5 fix top_n ut add e68249a3 [UI] Add YAML language filter (#260) add

[GitHub] [skywalking-satellite] mrproliu commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
mrproliu commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1469215856 There are still a lot of unprocessed previews here. Please handle them all. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] jmjoy opened a new issue, #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

2023-03-14 Thread via GitHub
jmjoy opened a new issue, #10539: URL: https://github.com/apache/skywalking/issues/10539 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking] wu-sheng closed issue #10538: [Feature] Support `Deprecated` mechanism in OAL and annotation

2023-03-14 Thread via GitHub
wu-sheng closed issue #10538: [Feature] Support `Deprecated` mechanism in OAL and annotation URL: https://github.com/apache/skywalking/issues/10538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [skywalking] wu-sheng opened a new issue, #10538: [Feature] Support `Deprecated` mechanism in OAL and annotation

2023-03-14 Thread via GitHub
wu-sheng opened a new issue, #10538: URL: https://github.com/apache/skywalking/issues/10538 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[GitHub] [skywalking] Superskyyy commented on issue #10408: [Feature] Python agent performance enhancement with asyncio

2023-03-14 Thread via GitHub
Superskyyy commented on issue #10408: URL: https://github.com/apache/skywalking/issues/10408#issuecomment-1469057983 > hey @Superskyyy, i would like to work on the Python agent. Could you please suggest to me some issues on which I can work to gain some experience for this particular

[GitHub] [skywalking] wu-sheng commented on pull request #10476: Feature DCS supports global configuration

2023-03-14 Thread via GitHub
wu-sheng commented on PR #10476: URL: https://github.com/apache/skywalking/pull/10476#issuecomment-1469045412 I think you still make the code boundaries not clear, which makes me hard to approve this change to upstream. Let me try to re-word how I think the codes should be. 1. The

[GitHub] [skywalking] mrproliu commented on pull request #10473: Support continuous profiling feature

2023-03-14 Thread via GitHub
mrproliu commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1469038004 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [skywalking] wu-sheng commented on pull request #10473: Support continuous profiling feature

2023-03-14 Thread via GitHub
wu-sheng commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1469013416 Sure, ping me, I am flexible these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-goapi] dependabot[bot] commented on pull request #56: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
dependabot[bot] commented on PR #56: URL: https://github.com/apache/skywalking-goapi/pull/56#issuecomment-1468988983 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-goapi] kezhenxu94 closed pull request #56: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
kezhenxu94 closed pull request #56: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 URL: https://github.com/apache/skywalking-goapi/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [skywalking-cli] dependabot[bot] commented on pull request #177: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
dependabot[bot] commented on PR #177: URL: https://github.com/apache/skywalking-cli/pull/177#issuecomment-1468988799 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-cli] kezhenxu94 closed pull request #177: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
kezhenxu94 closed pull request #177: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1 URL: https://github.com/apache/skywalking-cli/pull/177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[skywalking-cli] branch dependabot/go_modules/google.golang.org/protobuf-1.29.1 created (now 386abbf)

2023-03-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/google.golang.org/protobuf-1.29.1 in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git at 386abbf Bump google.golang.org/protobuf from 1.29.0 to

[GitHub] [skywalking-cli] dependabot[bot] opened a new pull request, #177: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #177: URL: https://github.com/apache/skywalking-cli/pull/177 Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.29.0 to 1.29.1. Release notes Sourced from

[skywalking-goapi] branch dependabot/go_modules/google.golang.org/protobuf-1.29.1 created (now 79ca7f8)

2023-03-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/google.golang.org/protobuf-1.29.1 in repository https://gitbox.apache.org/repos/asf/skywalking-goapi.git at 79ca7f8 Bump google.golang.org/protobuf from 1.29.0

[GitHub] [skywalking-goapi] dependabot[bot] opened a new pull request, #56: Bump google.golang.org/protobuf from 1.29.0 to 1.29.1

2023-03-14 Thread via GitHub
dependabot[bot] opened a new pull request, #56: URL: https://github.com/apache/skywalking-goapi/pull/56 Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.29.0 to 1.29.1. Release notes Sourced from

[skywalking] branch kezhenxu94-patch-1 created (now c90409157e)

2023-03-14 Thread kezhenxu94
This is an automated email from the ASF dual-hosted git repository. kezhenxu94 pushed a change to branch kezhenxu94-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at c90409157e Add ElasticSearch 8.6.2 to test matrix No new revisions were added by this update.

[GitHub] [skywalking] kezhenxu94 opened a new pull request, #10537: Add ElasticSearch 8.6.2 to test matrix

2023-03-14 Thread via GitHub
kezhenxu94 opened a new pull request, #10537: URL: https://github.com/apache/skywalking/pull/10537 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[GitHub] [skywalking] hanahmily commented on pull request #10473: Support continuous profiling feature

2023-03-14 Thread via GitHub
hanahmily commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1468981241 @mrproliu @wu-sheng Could we set up a meeting to discuss how to store profiling data to BanyanDB in an appropriate way? The BanyanDB project will kick off the design process of

[GitHub] [skywalking] hanahmily commented on pull request #10473: Support continuous profiling feature

2023-03-14 Thread via GitHub
hanahmily commented on PR #10473: URL: https://github.com/apache/skywalking/pull/10473#issuecomment-1468978642 > Also, for now, the BanyanDB cannot query property with multiple IDs The API provides listing multi-ids in a single request. @lujiajing1126 Java client should support it

[skywalking-php] branch master updated: Upgrade dependencies and adapt the codes. (#57)

2023-03-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-php.git The following commit(s) were added to refs/heads/master by this push: new 4d2648f Upgrade dependencies and

[GitHub] [skywalking-php] wu-sheng merged pull request #57: Upgrade dependencies and adapt the codes.

2023-03-14 Thread via GitHub
wu-sheng merged PR #57: URL: https://github.com/apache/skywalking-php/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-cli] branch master updated: Add the sub-command `metrics nullable` for query the nullable metrics value (#176)

2023-03-14 Thread liuhan
This is an automated email from the ASF dual-hosted git repository. liuhan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-cli.git The following commit(s) were added to refs/heads/master by this push: new f3d3445 Add the sub-command `metrics

[GitHub] [skywalking-cli] mrproliu merged pull request #176: Add the sub-command `metrics nullable` for query the nullable metrics value

2023-03-14 Thread via GitHub
mrproliu merged PR #176: URL: https://github.com/apache/skywalking-cli/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-cli] wu-sheng commented on pull request #176: Add the sub-command `metrics nullable` for query the nullable metrics value

2023-03-14 Thread via GitHub
wu-sheng commented on PR #176: URL: https://github.com/apache/skywalking-cli/pull/176#issuecomment-1468027887 Please list the new query command in the PR content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [skywalking-cli] mrproliu commented on pull request #176: Add the sub-command `metrics nullable` for query the nullable metrics value

2023-03-14 Thread via GitHub
mrproliu commented on PR #176: URL: https://github.com/apache/skywalking-cli/pull/176#issuecomment-1468025595 @wankai123 This works for query the `readNullableMetricsValue`. But if you want to use this on the E2E in the main repo, please wait for the

[GitHub] [skywalking] jmjoy commented on issue #10517: [Bug] ERROR skywalking_agent::execute: before execute ex err=PHPer(ExpectType(ExpectTypeError { expect_type: TypeInfo { t: 4 }, actual_type: Type

2023-03-14 Thread via GitHub
jmjoy commented on issue #10517: URL: https://github.com/apache/skywalking/issues/10517#issuecomment-1467859128 > [curl_php.txt](https://github.com/apache/skywalking/files/10940327/curl_php.txt) > > It's curl code @wu-sheng @jmjoy This code failed to reproduce the issue. --

[GitHub] [skywalking-satellite] mrproliu commented on a diff in pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#discussion_r1135259663 ## .github/workflows/e2e-native-kafka.yaml: ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [skywalking-php] jmjoy opened a new pull request, #57: Upgrade dependencies and adapt the codes.

2023-03-14 Thread via GitHub
jmjoy opened a new pull request, #57: URL: https://github.com/apache/skywalking-php/pull/57 1. Upgrade dependencies. 2. Adapt to `skywalking-rust`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [skywalking-java] wu-sheng merged pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng merged PR #479: URL: https://github.com/apache/skywalking-java/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking-java] branch main updated: Support keep trace profiling when cross-thread (#479)

2023-03-14 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new d357bdef7a Support keep trace profiling

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467744777 Please fix the CI and more important, we require a Kafka involved e2e to verify this feature. @zbw911 -- This is an automated message from the Apache Git Service. To

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135252459 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -48,7 +48,7 @@ public class

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135218173 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -48,7 +48,7 @@ public class

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135217595 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135215333 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135215041 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java: ## @@ -241,10 +241,15 @@ public static class Profile {

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467678925 > At present, I think we can accept him. I checked the current official agents, they are basically only supported by the gRPC protocol. The satellite itself can be used as a

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467676455 Notice, I am not arguing for Kafka VS gRPC. The key point is why don't implement Kafka sender on .net agent side like Java and Python, it has better performance than using

[GitHub] [skywalking-satellite] mrproliu commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
mrproliu commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467675262 At present, I think we can accept him. I checked the current official agents, they are basically only supported by the gRPC protocol. The satellite itself can be used as a

[GitHub] [skywalking-satellite] zbw911 commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
zbw911 commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467673221 > Currently, I have performed gray testing on .NET, Java, and Python in the production environment. I am using Kafka directly for Java and Python, but the .NET agent does

[GitHub] [skywalking-satellite] zbw911 commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
zbw911 commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467671352 > Currently, I have performed gray testing on .NET, Java, and Python in the production environment. I am using Kafka directly for Java and Python, but the .NET agent does

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135175098 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135175098 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135172865 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467626812 About the existing Kafka forward of logs, we explained why it is there at https://github.com/apache/skywalking-satellite/pull/123#issuecomment-1328990817 Anyway,

[GitHub] [skywalking-satellite] wu-sheng closed pull request #123: Adding kafka forwarder plugins

2023-03-14 Thread via GitHub
wu-sheng closed pull request #123: Adding kafka forwarder plugins URL: https://github.com/apache/skywalking-satellite/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [skywalking-satellite] dependabot[bot] commented on pull request #126: bump golang.org/x/net from 0.5.0 to 0.7.0

2023-03-14 Thread via GitHub
dependabot[bot] commented on PR #126: URL: https://github.com/apache/skywalking-satellite/pull/126#issuecomment-1467621919 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-satellite] wu-sheng closed pull request #126: bump golang.org/x/net from 0.5.0 to 0.7.0

2023-03-14 Thread via GitHub
wu-sheng closed pull request #126: bump golang.org/x/net from 0.5.0 to 0.7.0 URL: https://github.com/apache/skywalking-satellite/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467611653 Directly setting up a Kafka sender at the agent side would be much better to maintain this kind of forwarder by satellite. -- This is an automated message from the Apache

[GitHub] [skywalking-satellite] wu-sheng commented on pull request #128: Kafka forwards

2023-03-14 Thread via GitHub
wu-sheng commented on PR #128: URL: https://github.com/apache/skywalking-satellite/pull/128#issuecomment-1467597846 I want to argue the necessarily of this. If you need a Kafka as buffer and transparent layer between agents and OAP, why do you cost resources on satellite? -- This is an

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135114184 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135110743 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135108875 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking] wu-sheng closed issue #10535: [Bug] When i uses filter to build condition in oal, the filter expressions do not support linking by and, or

2023-03-14 Thread via GitHub
wu-sheng closed issue #10535: [Bug] When i uses filter to build condition in oal, the filter expressions do not support linking by and, or URL: https://github.com/apache/skywalking/issues/10535 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135104670 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking] tjzheng1002 opened a new issue, #10535: [Bug] When i uses filter to build condition in oal, the filter expressions do not support linking by and, or

2023-03-14 Thread via GitHub
tjzheng1002 opened a new issue, #10535: URL: https://github.com/apache/skywalking/issues/10535 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135099079 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on pull request #469: Override tag(AbstractTag, String) method in Entry Span

2023-03-14 Thread via GitHub
wu-sheng commented on PR #469: URL: https://github.com/apache/skywalking-java/pull/469#issuecomment-1467534380 Make sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-java] lujiajing1126 commented on pull request #469: Override tag(AbstractTag, String) method in Entry Span

2023-03-14 Thread via GitHub
lujiajing1126 commented on PR #469: URL: https://github.com/apache/skywalking-java/pull/469#issuecomment-1467533622 > Any update about this? Too many test failures. I suppose we may address https://github.com/apache/skywalking/issues/10479 first. WDYT -- This is an automated

[GitHub] [skywalking-java] wu-sheng commented on pull request #469: Override tag(AbstractTag, String) method in Entry Span

2023-03-14 Thread via GitHub
wu-sheng commented on PR #469: URL: https://github.com/apache/skywalking-java/pull/469#issuecomment-1467521629 Any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135091819 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] mrproliu commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
mrproliu commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135090183 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135089406 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #479: Support keep trace profiling when cross-thread

2023-03-14 Thread via GitHub
wu-sheng commented on code in PR #479: URL: https://github.com/apache/skywalking-java/pull/479#discussion_r1135076370 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/profile/ProfileTaskExecutionContext.java: ## @@ -72,39 +72,57 @@ public void