[GitHub] [skywalking] wu-sheng commented on issue #10752: [Feature] Support OTLP Native Logging

2023-05-02 Thread via GitHub
wu-sheng commented on issue #10752: URL: https://github.com/apache/skywalking/issues/10752#issuecomment-1532397967 `receiver-otel` module may face some name confusing, as `enabledHandlers` and `enabledOtelRules` are actually only metrics oriented. Ref from a question,

[GitHub] [skywalking] wu-sheng opened a new issue, #10752: [Feature] Support OTLP Native Logging

2023-05-02 Thread via GitHub
wu-sheng opened a new issue, #10752: URL: https://github.com/apache/skywalking/issues/10752 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement. ### Description

[skywalking-showcase] branch main updated: Bump up OAP/UI versions to 8453e00

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-showcase.git The following commit(s) were added to refs/heads/main by this push: new dcc6383 Bump up OAP/UI versions to

[skywalking] branch master updated: Sync UI. (#10751)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 8453e00f14 Sync UI. (#10751) 8453e00f14 is

[GitHub] [skywalking] wu-sheng merged pull request #10751: Sync UI.

2023-05-02 Thread via GitHub
wu-sheng merged PR #10751: URL: https://github.com/apache/skywalking/pull/10751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[skywalking] branch ui-update updated (c59166a4f0 -> daf66cf4d9)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git from c59166a4f0 Fix license order. add daf66cf4d9 Fix license order No new revisions were added by this

[skywalking] branch ui-update updated (1fa81c76b5 -> c59166a4f0)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git from 1fa81c76b5 Update changelog. add c59166a4f0 Fix license order. No new revisions were added by this

[skywalking] branch ui-update updated (e7f9a07a4c -> 1fa81c76b5)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git from e7f9a07a4c Sync UI. add 6d84e44426 Fix license. add 1fa81c76b5 Update changelog. No new revisions

[GitHub] [skywalking] wu-sheng opened a new pull request, #10751: Sync UI.

2023-05-02 Thread via GitHub
wu-sheng opened a new pull request, #10751: URL: https://github.com/apache/skywalking/pull/10751 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking] 01/01: Sync UI.

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git commit e7f9a07a4c9a54e6e1d85fe25c92d533b69f0cd5 Author: Wu Sheng AuthorDate: Wed May 3 00:21:56 2023 +0800 Sync

[skywalking] branch ui-update created (now e7f9a07a4c)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch ui-update in repository https://gitbox.apache.org/repos/asf/skywalking.git at e7f9a07a4c Sync UI. This branch includes the following new commits: new e7f9a07a4c Sync UI. The 1

[skywalking-booster-ui] branch main updated: fix: set endpoint and instance selectors with url parameters (#264)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-booster-ui.git The following commit(s) were added to refs/heads/main by this push: new 903cf8e fix: set endpoint and

[GitHub] [skywalking-booster-ui] wu-sheng merged pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng merged PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
Fine0830 commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182766541 ## src/views/dashboard/panel/Tool.vue: ## @@ -585,6 +604,19 @@ limitations under the License. --> } return resp; } + async function

[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
Fine0830 commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182765395 ## src/views/dashboard/panel/Tool.vue: ## @@ -585,6 +604,19 @@ limitations under the License. --> } return resp; } + async function

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531747296 > If both agents lock names and the special identifier in the name is the same, there will be a conflict. We can solve this problem by randomly generating an identity when the

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182762565 ## src/views/dashboard/panel/Tool.vue: ## @@ -585,6 +604,19 @@ limitations under the License. --> } return resp; } + async function

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182762305 ## src/views/dashboard/panel/Tool.vue: ## @@ -585,6 +604,19 @@ limitations under the License. --> } return resp; } + async function

[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
Fine0830 commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182757816 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-java] kylixs commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531739061 > How about two skywalking agents for one target? I don't expect we would do two interceptors for one target inside skywalking. The other one is fork distribution. Will that work?

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531712209 > Multiple ByteBuddy/AgentBuilder instances that install an interceptor on the same method of the same class form an interceptor call chain How about two skywalking agents

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182725761 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182713809 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-booster-ui] Fine0830 commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
Fine0830 commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182696703 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182683223 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264#discussion_r1182680998 ## src/views/dashboard/panel/Tool.vue: ## @@ -602,13 +619,29 @@ limitations under the License. --> selectorStore.setCurrentDestPod(currentDestPod);

[GitHub] [skywalking-booster-ui] Fine0830 opened a new pull request, #264: fix: set endpoint and instance selectors with url parameters

2023-05-02 Thread via GitHub
Fine0830 opened a new pull request, #264: URL: https://github.com/apache/skywalking-booster-ui/pull/264 Fixes endpoint and instance selectors with url parameters. video https://user-images.githubusercontent.com/20871783/235704561-4a413be8-07cb-4e16-b4c6-03ed0a2b3d32.mov

[skywalking] branch master updated: Less hierarchies of log docs. (#10750)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 4b9ae1e7ec Less hierarchies of log docs.

[GitHub] [skywalking] wu-sheng merged pull request #10750: Less hierarchies of log docs.

2023-05-02 Thread via GitHub
wu-sheng merged PR #10750: URL: https://github.com/apache/skywalking/pull/10750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking] wu-sheng opened a new pull request, #10750: Less hierarchies of log docs.

2023-05-02 Thread via GitHub
wu-sheng opened a new pull request, #10750: URL: https://github.com/apache/skywalking/pull/10750 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES`

[skywalking] branch doc-path created (now 3682ed7e96)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch doc-path in repository https://gitbox.apache.org/repos/asf/skywalking.git at 3682ed7e96 Less hierarchies of log docs. This branch includes the following new commits: new 3682ed7e96

[skywalking] 01/01: Less hierarchies of log docs.

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch doc-path in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 3682ed7e962b42b1664d4270b795f6b1f4fcccda Author: Wu Sheng AuthorDate: Tue May 2 21:09:47 2023 +0800 Less

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531319287 I can't provide this information as I don't have their owner permission, sorry. I just want to mention this as a case. Such as if they have a modified plugin/interceptor but

[GitHub] [skywalking-java] kylixs commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531301699 If they haven't modified the Skywalking agent's plugin interceptor flow, they should be compatible. If they change the interceptor mechanism or the ByteBuddy option, they need to be

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531289029 I know they can, I mean many of them are not doing this. I think you still are not following what is redistribution of open source. Thinking about Ubuntu relationship with

[GitHub] [skywalking-java] kylixs commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531276945 ByteBuddy uses random names, which is essential in dynamic proxy/class creation, but in APM scenarios, dynamic names are bad. We use `sw_xxx$` as a specific flag for auxiliary

[skywalking] branch master updated: * Make the log relative docs more clear, and easier for further more formats support. (#10749)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new df7486c700 * Make the log relative docs

[GitHub] [skywalking] wu-sheng merged pull request #10749: * Make the log relative docs easier for further more formats support.

2023-05-02 Thread via GitHub
wu-sheng merged PR #10749: URL: https://github.com/apache/skywalking/pull/10749 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531231277 > > The question I left is only about whether we are going to conflict with our own fork, due to names are always same in two agents. > > > > I don't quite

[skywalking-website] branch asf-site updated: deploy: 3b16d06c75320f694bf7e18d34520858e581615c

2023-05-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/skywalking-website.git The following commit(s) were added to refs/heads/asf-site by this push: new f3167cdee6b deploy:

[GitHub] [skywalking] wu-sheng opened a new pull request, #10749: * Make the log relative docs easier for further more formats support.

2023-05-02 Thread via GitHub
wu-sheng opened a new pull request, #10749: URL: https://github.com/apache/skywalking/pull/10749 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [x] Update the [`CHANGES`

[skywalking] 01/01: * Make the log relative docs more clear, and easier for further more formats support.

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch polish-doc-log in repository https://gitbox.apache.org/repos/asf/skywalking.git commit aac245456c24e52c28243592de674f531359162d Author: Wu Sheng AuthorDate: Tue May 2 18:01:10 2023 +0800 *

[skywalking] branch polish-doc-log created (now aac245456c)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch polish-doc-log in repository https://gitbox.apache.org/repos/asf/skywalking.git at aac245456c * Make the log relative docs more clear, and easier for further more formats support. This

[GitHub] [skywalking-java] kylixs commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531190316 > The question I left is only about whether we are going to conflict with our own fork, due to names are always same in two agents. I don't quite understand this. Could you

[GitHub] [skywalking] arturo-seijas opened a new issue, #10748: [Bug] [INFRA/EYE] Failing to configure paths and paths-ignore when providing multiple licenses

2023-05-02 Thread via GitHub
arturo-seijas opened a new issue, #10748: URL: https://github.com/apache/skywalking/issues/10748 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking

[GitHub] [skywalking] wu-sheng closed issue #10739: [Feature] Support Jersey REST framework Trace

2023-05-02 Thread via GitHub
wu-sheng closed issue #10739: [Feature] Support Jersey REST framework Trace URL: https://github.com/apache/skywalking/issues/10739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [skywalking] arturo-seijas commented on issue #10746: [Bug] [INFRA/EYE] Failing to validate custom content when providing multiple licenses

2023-05-02 Thread via GitHub
arturo-seijas commented on issue #10746: URL: https://github.com/apache/skywalking/issues/10746#issuecomment-1531152044 HI again! I've been testing this and, although I'm not getting the warning anymore, The `paths` and paths-ignore` sections are being ignored: ``` header: -

[skywalking-java] branch main updated: support jersey rest framework (#520)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new dc9f7d130d support jersey rest framework

[GitHub] [skywalking-java] wu-sheng merged pull request #520: support jersey rest framework

2023-05-02 Thread via GitHub
wu-sheng merged PR #520: URL: https://github.com/apache/skywalking-java/pull/520 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531144883 > Provide a fallback transform mode. If there is a compatibility problem, users can fall back to the previous mode. We can keep improving it. Falling back usually is too

[GitHub] [skywalking-java] kylixs commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531137660 > It's a bit complicated, and we haven't tested enough scenarios to know if there are other compatibility issues. I came up with a few ideas: * Provide a fallback

[GitHub] [skywalking-java] dependabot[bot] commented on pull request #523: Bump jetty-server from 9.1.0.v20131115 to 10.0.14 in /apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin

2023-05-02 Thread via GitHub
dependabot[bot] commented on PR #523: URL: https://github.com/apache/skywalking-java/pull/523#issuecomment-1531097273 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

[GitHub] [skywalking-java] wu-sheng closed pull request #523: Bump jetty-server from 9.1.0.v20131115 to 10.0.14 in /apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin

2023-05-02 Thread via GitHub
wu-sheng closed pull request #523: Bump jetty-server from 9.1.0.v20131115 to 10.0.14 in /apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin URL: https://github.com/apache/skywalking-java/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [skywalking] wu-sheng closed issue #10736: [Feature] support monitor jetty server container work thread pool

2023-05-02 Thread via GitHub
wu-sheng closed issue #10736: [Feature] support monitor jetty server container work thread pool URL: https://github.com/apache/skywalking/issues/10736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [skywalking-java] kylixs commented on a diff in pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on code in PR #521: URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182250166 ## apm-sniffer/bytebuddy-patch/src/main/java/net/bytebuddy/agent/builder/SWAsmVisitorWrapper.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

[GitHub] [skywalking-java] dependabot[bot] opened a new pull request, #523: Bump jetty-server from 9.1.0.v20131115 to 10.0.14 in /apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin

2023-05-02 Thread via GitHub
dependabot[bot] opened a new pull request, #523: URL: https://github.com/apache/skywalking-java/pull/523 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.1.0.v20131115 to 10.0.14. Release notes Sourced from

[skywalking-java] branch dependabot/maven/apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin/org.eclipse.jetty-jetty-server-10.0.14 created (now 3c4f6fd2e5)

2023-05-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/apm-sniffer/apm-sdk-plugin/jetty-thread-pool-plugin/org.eclipse.jetty-jetty-server-10.0.14 in repository https://gitbox.apache.org/repos/asf/skywalking-java.git at

[skywalking-java] branch main updated: support jetty server work thread pool metric monitor (#517)

2023-05-02 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-java.git The following commit(s) were added to refs/heads/main by this push: new 3ad9f249d9 support jetty server work

[GitHub] [skywalking-java] wu-sheng merged pull request #517: support jetty server work thread pool metric monitor

2023-05-02 Thread via GitHub
wu-sheng merged PR #517: URL: https://github.com/apache/skywalking-java/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [skywalking-java] kylixs commented on a diff in pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on code in PR #521: URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182242937 ## apm-sniffer/bytebuddy-patch/src/main/java/net/bytebuddy/agent/builder/NativeMethodStrategySupport.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #521: URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182241765 ## apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java: ## @@ -161,9 +175,10 @@ public DynamicType.Builder transform(final

[GitHub] [skywalking-java] kylixs commented on a diff in pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
kylixs commented on code in PR #521: URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182239454 ## apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java: ## @@ -161,9 +175,10 @@ public DynamicType.Builder transform(final

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #517: support jetty server work thread pool metric monitor

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #517: URL: https://github.com/apache/skywalking-java/pull/517#discussion_r1182210051 ## .github/workflows/plugins-jdk17-test.0.yaml: ## @@ -57,6 +57,7 @@ jobs: case: - jdk17-with-gson-scenario -

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #517: support jetty server work thread pool metric monitor

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #517: URL: https://github.com/apache/skywalking-java/pull/517#discussion_r1182208942 ## .github/workflows/plugins-jdk17-test.0.yaml: ## @@ -57,6 +57,7 @@ jobs: case: - jdk17-with-gson-scenario -

[GitHub] [skywalking-java] wu-sheng commented on pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on PR #521: URL: https://github.com/apache/skywalking-java/pull/521#issuecomment-1531034463 Hi @kylixs Thanks for providing your way of debugging and resolving the issue. I believe locking the field and method name for auxiliary class and method is a way to resolve the

[GitHub] [skywalking-java] wu-sheng commented on a diff in pull request #521: Improve bytebuddy class enhance

2023-05-02 Thread via GitHub
wu-sheng commented on code in PR #521: URL: https://github.com/apache/skywalking-java/pull/521#discussion_r1182177929 ## apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/interceptor/enhance/ClassEnhancePluginDefine.java: ## @@ -65,8 +65,8 @@