simonluo345 commented on PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#issuecomment-1722133963
> This PR only includes 100-200 LOCs, it is hard to say it is involved in
too many codes. The 3 months ospp is helping you in trying and learning the
project, it should not be a
wu-sheng commented on PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#issuecomment-1722132248
This PR only includes 100-200 LOCs, it is hard to say it is involved in too
many codes.
The 3 months ospp is helping you in trying and learning the project, it
should not be a wo
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new e448febb4f Add a release mechanism for alar
wu-sheng merged PR #11336:
URL: https://github.com/apache/skywalking/pull/11336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327435442
##
docs/en/changes/changes.md:
##
@@ -10,6 +10,7 @@
* Support Kafka Monitoring.
* [Breaking Change] Elasticsearch storage merge all management data indices
int
dylanforest commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327428493
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -198,8 +198,14 @@ public void move
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327422956
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -198,8 +198,14 @@ public void moveTo(
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327396083
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -383,6 +396,17 @@ private boolean isM
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327394183
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -217,10 +218,22 @@ public List check(
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327394183
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -217,10 +218,22 @@ public List check(
codecov-commenter commented on PR #330:
URL:
https://github.com/apache/skywalking-banyandb/pull/330#issuecomment-1721399732
##
[Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327392067
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -199,6 +199,7 @@ public void moveTo(
dylanforest commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327383995
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -383,6 +392,14 @@ private boolean
hailin0 opened a new pull request, #330:
URL: https://github.com/apache/skywalking-banyandb/pull/330
### Fix
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
- [ ] If this pull request closes/reso
This is an automated email from the ASF dual-hosted git repository.
wanghailin pushed a change to branch add_mod_revision
in repository
https://gitbox.apache.org/repos/asf/skywalking-banyandb-java-client.git
from 3c5d874 fix
add ccd1239 update oap image
add 0f7109b fix
No new
hailin0 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327355132
##
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBu
hailin0 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327355132
##
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamBu
hailin0 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327351312
##
src/main/proto/banyandb/v1/banyandb-stream.proto:
##
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata
hailin0 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327338277
##
src/main/proto/banyandb/v1/banyandb-stream.proto:
##
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata
wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327342622
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -198,8 +198,13 @@ public void moveTo
wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327342622
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -198,8 +198,13 @@ public void moveTo
wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327342622
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -198,8 +198,13 @@ public void moveTo
hailin0 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327338277
##
src/main/proto/banyandb/v1/banyandb-stream.proto:
##
@@ -84,13 +84,22 @@ message ElementValue {
}
message WriteRequest {
- // the metadata
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/test/plugin/scenarios/undertow-scenario/io.undertow-undertow-core-2.3.5.Final
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
was b5418de729 Bump
dependabot[bot] commented on PR #611:
URL: https://github.com/apache/skywalking-java/pull/611#issuecomment-1721301362
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor versio
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/io.undertow-undertow-core-2.3.5.Final
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
wu-sheng closed pull request #611: Bump io.undertow:undertow-core from
1.3.0.Final to 2.3.5.Final in /test/plugin/scenarios/undertow-scenario
URL: https://github.com/apache/skywalking-java/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] commented on PR #612:
URL: https://github.com/apache/skywalking-java/pull/612#issuecomment-1721301192
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor versio
wu-sheng closed pull request #612: Bump io.undertow:undertow-core from
2.0.9.Final to 2.3.5.Final in
/apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin
URL: https://github.com/apache/skywalking-java/pull/612
--
This is an automated message from the Apache Git Service.
To respon
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/apm-sniffer/apm-sdk-plugin/undertow-plugins/undertow-2.x-plugin/io.undertow-undertow-core-2.3.5.Final
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
dependabot[bot] opened a new pull request, #612:
URL: https://github.com/apache/skywalking-java/pull/612
Bumps [io.undertow:undertow-core](https://github.com/undertow-io/undertow)
from 2.0.9.Final to 2.3.5.Final.
Commits
https://github.com/undertow-io/undertow/commit/a55aeac10e
dependabot[bot] opened a new pull request, #611:
URL: https://github.com/apache/skywalking-java/pull/611
Bumps [io.undertow:undertow-core](https://github.com/undertow-io/undertow)
from 1.3.0.Final to 2.3.5.Final.
Commits
https://github.com/undertow-io/undertow/commit/a55aeac10e
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/test/plugin/scenarios/undertow-scenario/io.undertow-undertow-core-2.3.5.Final
in repository https://gitbox.apache.org/repos/asf/skywalking-java.git
at b5418de729 Bump
wu-sheng commented on PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#issuecomment-1721255477
Also, the code style file is in the root, please make sure you could pass
code style check.
--
This is an automated message from the Apache Git Service.
To respond to the message,
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327259451
##
oap-server/server-alarm-plugin/src/test/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRuleTest.java:
##
@@ -38,6 +39,8 @@
import org.apache
wu-sheng commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327257871
##
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##
@@ -383,6 +392,14 @@ private boolean isM
dylanforest opened a new pull request, #11336:
URL: https://github.com/apache/skywalking/pull/11336
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
- [x] Update the [`CHANGES`
log](https://github.com/apache/skywalking/blob
wu-sheng commented on issue #11279:
URL: https://github.com/apache/skywalking/issues/11279#issuecomment-1721168258
@yswdqz According to this afternoon discussion, let's submit PRs through this
1. Refactor the codes to move the expected replaced classes/methods out of
the original codes. N
wu-sheng commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327124354
##
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##
@@ -34,29 +40,50 @@
@ThreadSafe
public class StreamB
lujiajing1126 commented on code in PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327122199
##
src/main/java/org/apache/skywalking/banyandb/v1/client/StreamBulkWriteProcessor.java:
##
@@ -34,29 +40,50 @@
@ThreadSafe
public class St
wu-sheng commented on PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#issuecomment-1721010289
From upstream/community perspective, I don't care. So, I would not block
this PR once it is ready. But I didn't see this kind of commits before.
https://github.com/apache/skyw
wu-sheng commented on PR #11330:
URL: https://github.com/apache/skywalking/pull/11330#issuecomment-1721008366
@heyanlong From the OSPP perspective, I have concerns about why most commits
are made by you rather than a student.
This should not be a recommended and qualified work for a stude
This is an automated email from the ASF dual-hosted git repository.
wankai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/master by this push:
new 1943ce0c25 Fix elasticsearch merge managemen
hanahmily commented on PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1720839524
> @hanahmily @lujiajing1126 Please check this.
>
>
>
> As properties TTL feature in 0.5 is still not added, should we wait for
that to do a release? O
wu-sheng commented on PR #47:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/47#issuecomment-1720785238
@hanahmily @lujiajing1126 Please check this.
As properties TTL feature in 0.5 is still not added, should we wait for that
to do a release? Or should we run a R
hailin0 commented on PR #46:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/46#issuecomment-1720778548
> I can see relative server commit is merged, do we need some update on
this? As we have the server now.
oap image has been updated
--
This is an automated m
46 matches
Mail list logo
