IceSoda177 opened a new pull request, #178:
URL: https://github.com/apache/skywalking-go/pull/178
Supporting http headers collection for Gin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
wu-sheng commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531658612
##
plugins/gin/intercepter.go:
##
@@ -70,3 +77,26 @@ func isFirstHandle(c interface{}) bool {
}
return true
}
+
+func collectHttpHeaders(span trac
wu-sheng commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531659046
##
plugins/gin/intercepter.go:
##
@@ -70,3 +77,26 @@ func isFirstHandle(c interface{}) bool {
}
return true
}
+
+func collectHttpHeaders(span trac
wu-sheng commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009007431
@CodePrometheus Would you like to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
IceSoda177 commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531672316
##
plugins/gin/intercepter.go:
##
@@ -70,3 +77,26 @@ func isFirstHandle(c interface{}) bool {
}
return true
}
+
+func collectHttpHeaders(span tr
IceSoda177 commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531673522
##
plugins/gin/intercepter.go:
##
@@ -70,3 +77,26 @@ func isFirstHandle(c interface{}) bool {
}
return true
}
+
+func collectHttpHeaders(span tr
mrproliu commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531675819
##
tools/go-agent/config/agent.default.yaml:
##
@@ -97,3 +97,5 @@ plugin:
redis:
# Limit the bytes size of redis args request
max_args_bytes: ${
mrproliu commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531677744
##
tools/go-agent/config/agent.default.yaml:
##
@@ -97,3 +97,5 @@ plugin:
redis:
# Limit the bytes size of redis args request
max_args_bytes: ${
IceSoda177 commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531677876
##
tools/go-agent/config/agent.default.yaml:
##
@@ -97,3 +97,5 @@ plugin:
redis:
# Limit the bytes size of redis args request
max_args_bytes:
mrproliu commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531677744
##
tools/go-agent/config/agent.default.yaml:
##
@@ -97,3 +97,5 @@ plugin:
redis:
# Limit the bytes size of redis args request
max_args_bytes: ${
OrezzerO opened a new pull request, #675:
URL: https://github.com/apache/skywalking-java/pull/675
###
- [x] Tests(including UT, IT, E2E) are added to verify the new feature.
- [x] If this pull request closes/resolves/fixes an existing issue, replace
CodePrometheus commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009293900
@IceSoda177 hello bro, could you help to update the
docs/en/agent/plugin-configurations.md? And plz fix the CI.
--
This is an automated message from the Apache Git Service.
T
wu-sheng commented on PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#issuecomment-2009181137
Please explain your scenario. When this happens, and what was not working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
CodePrometheus commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009268928
> @CodePrometheus Would you like to review this?
I am more than willing to participate in code review, and I will pay
attention during my free time at work~ (Beijing time
wu-sheng commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009147085
UT is just a small thing, it is not very useful in agent mode. We have
specific plugin test,
https://skywalking.apache.org/docs/skywalking-go/next/en/development-and-contribution/wri
mrproliu commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531891550
##
plugins/gin/config.go:
##
@@ -0,0 +1,23 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE
wu-sheng commented on PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#issuecomment-2009471939
I think you should add `callback` in
https://github.com/apache/skywalking-java/tree/main/test/plugin/scenarios/sofarpc-scenario
and verify the callback spans through the expected f
IceSoda177 commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009645456
> UT is just a small thing, it is not very useful in agent mode. We have
specific plugin test,
https://skywalking.apache.org/docs/skywalking-go/next/en/development-and-contribution
IceSoda177 commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009647371
> @IceSoda177 hello bro, could you help to update the
docs/en/agent/plugin-configurations.md? And plz fix the CI.
Will do
--
This is an automated message from the Apache G
wu-sheng commented on PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#issuecomment-2009657536
> > UT is just a small thing, it is not very useful in agent mode. We have
specific plugin test,
https://skywalking.apache.org/docs/skywalking-go/next/en/development-and-contribution
IceSoda177 commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1532142589
##
plugins/gin/config.go:
##
@@ -0,0 +1,23 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTI
mrproliu commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1532188256
##
plugins/gin/config.go:
##
@@ -0,0 +1,23 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE
OrezzerO opened a new pull request, #57:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/57
## Problem
When I run 'bash ./test/plugin/run.sh -f sofarpc-scenario' at
SKYWALKING_JAVA_HOME compile error occur.
```
Class com.sun.tools.javac.tree.JCTree$JCImport does not h
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532270254
##
docs/en/agent/tracing-metrics-logging.md:
##
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent
enhancements related to th
The
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532270757
##
plugins/core/tracer_ignore.go:
##
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements.
wu-sheng commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532279572
##
docs/en/agent/tracing-metrics-logging.md:
##
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent
enhancements related to th
The basic
This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking-agent-test-tool.git
The following commit(s) were added to refs/heads/master by this push:
new b6efe6a Bump up lombok ver
wu-sheng merged PR #57:
URL: https://github.com/apache/skywalking-agent-test-tool/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-
mrproliu commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532282160
##
plugins/core/tracer_ignore.go:
##
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See t
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532299323
##
plugins/core/tracer_ignore.go:
##
@@ -0,0 +1,144 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements.
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/skywalking-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 2d4e43d58a5 deploy: 1f113613
CodePrometheus commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1532370144
##
docs/en/agent/tracing-metrics-logging.md:
##
@@ -22,10 +22,11 @@ If you wish to disable a particular plugin to prevent
enhancements related to th
The
OrezzerO opened a new pull request, #676:
URL: https://github.com/apache/skywalking-java/pull/676
- [x] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [x] Update the [`CHANGES`
log](https://githu
Superskyyy commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2010524334
Eh, but how did the agent pass GitHub action testing though..?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch data-generator
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/data-generator by this push:
new ab05bdfa89 Fix service or
lujiajing1126 commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2010996984
> Eh, but how did the agent pass GitHub action testing though..? or java
agent hasn't been tested on jdk21 yet
JDK21 is only tested for Spring 6.x scenario...
--
lujiajing1126 commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011000801
> Fix compile problem when run scenario test.
I suppose you have to use JDK8 or 17 for those scenarios based on the
workflows defined in the repo.
For other cases
wu-sheng commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011006633
Agree, I have the same question, is this bump up necessary for all tests.
Because basically, different tests are not expected to run on locked JDK
versions. Some of the lib, especi
wu-sheng commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011007700
> Eh, but how did the agent pass GitHub action testing though..? or java
agent hasn't been tested on jdk21 yet
The agent is ready, but the target libs may or may not, dependi
wu-sheng commented on PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#issuecomment-2011020678
@OrezzerO Is https://github.com/apache/skywalking-java/pull/676 somehow
affected this plugin? Is SOFA requiring JDK21? It seems not. Could you change
your local JDK to JDK8 or 11 t
OrezzerO commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011040754
I follow the advice of [Java Agent Compiling
porject](https://skywalking.apache.org/docs/skywalking-java/next/en/contribution/compiling/)
and use JDK 21. I checked Github Action co
OrezzerO commented on PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#issuecomment-2011042896
> @OrezzerO Is #676 somehow affected this plugin? Is SOFA requiring JDK21?
It seems not. Could you change your local JDK to JDK8 or 11 to finish this?
I can change my jdk. I
wu-sheng commented on PR #675:
URL: https://github.com/apache/skywalking-java/pull/675#issuecomment-2011046875
I think it is not hard to run. The basic workflow is, the test is using a
demo app with a compiled latest Java agent up and running. Then there is a mock
traffic generator to trigg
lujiajing1126 commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011051263
> I follow the advice of [Java Agent Compiling
porject](https://skywalking.apache.org/docs/skywalking-java/next/en/contribution/compiling/)
and use JDK 21. There is a little p
wu-sheng closed pull request #676: Bump up lombok version to 1.18.30 to support
JDK21
URL: https://github.com/apache/skywalking-java/pull/676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
wu-sheng commented on PR #676:
URL: https://github.com/apache/skywalking-java/pull/676#issuecomment-2011078975
Close for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mrproliu commented on code in PR #177:
URL: https://github.com/apache/skywalking-go/pull/177#discussion_r1533170163
##
plugins/core/tracer_ignore.go:
##
@@ -0,0 +1,133 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See t
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch data-generator
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/data-generator by this push:
new b35e8b8729 Add default va
48 matches
Mail list logo
