Re: [I] How to connect elasticsearch with https? [skywalking]

2024-05-13 Thread via GitHub
kyleli666 commented on issue #4512: URL: https://github.com/apache/skywalking/issues/4512#issuecomment-2109410067 From https://github.com/apache/skywalking/blob/v6.6.0/docs/en/setup/backend/backend-storage.md#elasticsearch-6-with-https-ssl-encrypting-communications, I found another ENV sh

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109373978 Or simply, try dev image from here, https://github.com/apache/skywalking-banyandb/pkgs/container/skywalking-banyandb/215721861?tag=c8270670d47a9c6caa2661af434157656c4b7eaf --

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109371084 This is build doc, https://skywalking.apache.org/docs/skywalking-banyandb/latest/installation/binaries/#build-binaries -- This is an automated message from the Apache Git Ser

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
Almot77 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109366071 How to install go libaries ? Ubuntu 22.04 I do: sudo apt install time nodejs npm sudo npm cache clean -f sudo npm install -g n sudo n stable wget

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
Almot77 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109322821 Okay, i'l test it now. We use php application in docker + sw php libay for trace collecting + grafana dashboards (made from sw examples for grafana) -- This is an autom

Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
Almot77 commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109320331 Okay, i'l test it now. We use php application in docker + sw php libay for trace collecting + grafana dashboards (made from sw examples for grafana) -- This is an auto

Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]

2024-05-13 Thread via GitHub
CzyerChen commented on PR #691: URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2109206083 > I can see RocketMQ case fails again. OK,I will check RocketMQ case first. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109188070 I reopened this as we don't know gow this happens. @Almot77 We will need more, could you package the whole data folder to us, then we could address what is the illegal da

Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
hanahmily commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109168664 > Will we cherry-pick this commit to v0.6.x? I prefer waiting for 24 hours for future feedback on the error, and regardless of the result, a new patch is necessary. -

(skywalking-banyandb) branch topn-entity deleted (was c023b1ab)

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git was c023b1ab Update change log The revisions that were on this branch are still contained in other ref

(skywalking-banyandb) branch main updated: Fix topn query nil and add more context to err (#445)

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git The following commit(s) were added to refs/heads/main by this push: new c8270670 Fix topn query nil and add mo

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng closed issue #12219: [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() URL: https://github.com/apache/skywalking/issues/12219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
wu-sheng merged PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109152626 > Will we cherry-pick this commit to v0.6.x? It depends on why this happens. If this is blocking the general use, we should have 0.6.1. Otherwise, it is not in urgent.

Re: [PR] Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
lujiajing1126 commented on PR #445: URL: https://github.com/apache/skywalking-banyandb/pull/445#issuecomment-2109147544 Will we cherry-pick this commit to v0.6.x? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(skywalking-banyandb) branch topn-entity updated (01a270cd -> c023b1ab)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 01a270cd Fix license add c023b1ab Update change log No new revisions were added by this upd

(skywalking-banyandb) branch topn-entity updated (58d9aaf3 -> 01a270cd)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git from 58d9aaf3 Fix topn query nil and add more context to err add 01a270cd Fix license No new rev

(skywalking-banyandb-helm) annotated tag v0.2.0 updated (5c073c1 -> a402dd8)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to annotated tag v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git *** WARNING: tag v0.2.0 was modified! *** from 5c073c1 (commit) to a402dd8 (tag) tagg

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
hanahmily commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109036234 The nil error is fixed by https://github.com/apache/skywalking-banyandb/pull/445/files#diff-695073ea8dec3fcdaae77a3fcfb4eabc7290daade34399aee1de42d7b476R124 But the

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109032259 This error is easy to fix, @Almot77 but we want to know how you could trigger it, as we have run many tests to verify features. -- This is an automated message from the Apach

[PR] [WIP]Fix topn query nil and add more context to err [skywalking-banyandb]

2024-05-13 Thread via GitHub
hanahmily opened a new pull request, #445: URL: https://github.com/apache/skywalking-banyandb/pull/445 - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes apache/skywalking#12219. - [ ] Update the [`CHANGES` log](https://github.com/apac

(skywalking-banyandb) 01/01: Fix topn query nil and add more context to err

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit 58d9aaf3ebdf9a9fad381009683c1d5c9250d27e Author: Gao Hongtao AuthorDate: Tue May 14 07:55:44 2024 +

(skywalking-banyandb) branch topn-entity updated (a3464aff -> 58d9aaf3)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git discard a3464aff Fix topn query nil and add more context to err new 58d9aaf3 Fix topn query nil and

(skywalking-banyandb) 01/01: Fix topn query nil and add more context to err

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git commit a3464aff95e673a89bf0af4a48843b76094ec15c Author: Gao Hongtao AuthorDate: Tue May 14 07:55:44 2024 +

(skywalking-banyandb) branch topn-entity created (now a3464aff)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch topn-entity in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb.git at a3464aff Fix topn query nil and add more context to err This branch includes the following new c

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2109013133 Are you using docker quick start? We haven't upgraded it to latest. It needs v10 oap and latest banyandb 0.6. -- This is an automated message from the Apache Git Service. To

(skywalking-banyandb-helm) annotated tag v0.2.0 deleted (was 2ebb393)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to annotated tag v0.2.0 in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git *** WARNING: tag v0.2.0 was deleted! *** tag was 2ebb393 The revisions that were on this anno

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
Almot77 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108659386 > Your configuration is not well formatted. Please correct them. And what does `SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when you use BanyanDB. >

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
prostocvet commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108655703 > s/bus.go:270 + It`s docker-compose file to run SW with selected db profile: elastic or banyandb. right way to run it: docker compose --profile banyandb up -d

Re: [PR] update dependencies [skywalking-java]

2024-05-13 Thread via GitHub
JoeCqupt commented on PR #690: URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2108081345 after i clear my .m2/repository dir. then everything is all right. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108057982 @lujiajing1126 What is the case of occurring this error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
lujiajing1126 commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108047447 After checking the code, it seems error is not handled properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12219: URL: https://github.com/apache/skywalking/issues/12219#issuecomment-2108046013 Your configuration is not well formatted. Please correct them. And what does `SW_STORAGE: elasticsearch` mean? I think we don't need Elasticsearch when you use BanyanDB.

Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #691: URL: https://github.com/apache/skywalking-java/pull/691#issuecomment-2108028821 I can see RocketMQ case fails again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Bug] SIGSEGV: segmentation violation in banyand/query.(*topNQueryProcessor).Rev.func1() [skywalking]

2024-05-13 Thread via GitHub
Almot77 opened a new issue, #12219: URL: https://github.com/apache/skywalking/issues/12219 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

Re: [PR] Fix method name missing in spring-plugins:scheduled-annotation-plugin with spring 6.1.x [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on code in PR #691: URL: https://github.com/apache/skywalking-java/pull/691#discussion_r1598620639 ## CHANGES.md: ## @@ -11,6 +11,7 @@ Release Notes. * Use a daemon thread to flush logs. * Fix typos in `URLParser`. * Add support for `Derby`/`Sybase`/`SQLite

Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]

2024-05-13 Thread via GitHub
dashanji closed issue #12040: [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. URL: https://github.com/apache/skywalking/issues/12040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]

2024-05-13 Thread via GitHub
dashanji commented on issue #12040: URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107693144 Fix in https://github.com/apache/skywalking-helm/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

(skywalking-banyandb-helm) branch master updated: Move image parameters to the root (#17)

2024-05-13 Thread hanahmily
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking-banyandb-helm.git The following commit(s) were added to refs/heads/master by this push: new 5c073c1 Move image paramet

Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]

2024-05-13 Thread via GitHub
hanahmily merged PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-u

Re: [I] [Bug] SkyWalking Operator helm does not yet include the CRD for BanyanDB. [skywalking]

2024-05-13 Thread via GitHub
wu-sheng commented on issue #12040: URL: https://github.com/apache/skywalking/issues/12040#issuecomment-2107585227 @ButterBright How about this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107534947 > > I think you got it wrong. It should be in ContextManager#continued method, which controls the context. > > Understood. How can the [span](https://github.com/apache/skywa

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107529372 > > This is a force sampling(unsampling), we don't need to worry about sampling counter. > > ForceSampling might not necessarily be true. I feel that it could still impact t

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107509503 > This is a force sampling(unsampling), we don't need to worry about sampling counter. > This is a force sampling(unsampling), we don't need to worry about sampling

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107480474 > I think you got it wrong. It should be in ContextManager#continued method, which controls the context. Understood. How can the [span](https://github.com/apache/skywalking

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107451077 This is a force sampling(unsampling), we don't need to worry about sampling counter. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107449336 I think you got it wrong. It should be in ContextManager#continued method, which controls the context. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Bug] skywalking-java maven build problem [skywalking]

2024-05-13 Thread via GitHub
JoeCqupt closed issue #12218: [Bug] skywalking-java maven build problem URL: https://github.com/apache/skywalking/issues/12218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] update dependencies [skywalking-java]

2024-05-13 Thread via GitHub
JoeCqupt closed pull request #690: update dependencies URL: https://github.com/apache/skywalking-java/pull/690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107376314 > When this is about ContextManager, it should not affect TracingContext#CreateLocal span. Only snapshot should be changed, and ContextManager asked TracingContext switching to Ig

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107355009 When this is about ContextManager, it should not affect TracingContext#CreateLocal span. Only snapshot should be changed, and ContextManager asked TracingContext switching to Ignor

Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]

2024-05-13 Thread via GitHub
ButterBright commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107324862 Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107275825 You are adding a mechanism for local span creation. This should not happen, if there is a context switching out, it must be controlled by ContextManager. -- This is an automated

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107265410 I don't have direct answer, if I had, I already told you in the last discussion. The reason it doesn't exist is, the tracing context is created before the snapshot is contin

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107252722 > I think we need to separate the context. Cross thread is different from cross process. Cross process is defined here, https://skywalking.apache.org/docs/main/latest/en/api/x-pro

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107220318 I am feeling you are doing a hijack only, which should not be the official way. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107218830 I think we need to separate the context. Cross thread is different from cross process. Cross process is defined here, https://skywalking.apache.org/docs/main/latest/en/api/x-pr

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107191416 > Add what? here: https://github.com/apache/skywalking-java/pull/689#issue-2292115894 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107183993 Add what? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Move image parameters to the root [skywalking-banyandb-helm]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2107183002 Do we need to update docs accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2107173269 > Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. Added. -- This is an automated message from the Apac

Re: [PR] update dependencies [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #690: URL: https://github.com/apache/skywalking-java/pull/690#issuecomment-2107025344 CI has covered all compiling process, nothing wrong happens. Please be clear why you failed. -- This is an automated message from the Apache Git Service. To respond to the

[PR] update dependencies [skywalking-java]

2024-05-13 Thread via GitHub
JoeCqupt opened a new pull request, #690: URL: https://github.com/apache/skywalking-java/pull/690 ### Fix - [ ] Add a unit test to verify that the fix works. - [] Explain briefly why the bug exists and how to fix it. - [ ] If this pull request clo

[I] [Bug] skywalking-java maven build problem [skywalking]

2024-05-13 Thread via GitHub
JoeCqupt opened a new issue, #12218: URL: https://github.com/apache/skywalking/issues/12218 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues. ### Apache SkyWalking Component

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106941367 For an official proposal, you could refer to SWIP(https://skywalking.apache.org/docs/main/next/en/swip/readme/), which is mandatory for OAP, but not for the agent. A key part of

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106934764 > Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. Do you have a proposal template? -- This is an a

Re: [PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #689: URL: https://github.com/apache/skywalking-java/pull/689#issuecomment-2106928547 Please write a proposal about what is a force-ignoring mechanism. The discussion we did was only about the context. -- This is an automated message from the Apache Git Service.

(skywalking) branch wu-sheng-patch-1 deleted (was 84a30e5a76)

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git was 84a30e5a76 Fix next SWIP ID The revisions that were on this branch are still contained in other refere

(skywalking) branch master updated: Fix next SWIP ID (#12217)

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/skywalking.git The following commit(s) were added to refs/heads/master by this push: new 7f20b99b4f Fix next SWIP ID (#12217) 7f20b9

[PR] Add a forceIgnoring mechanism and apply it to the plugins (Spring Clo… [skywalking-java]

2024-05-13 Thread via GitHub
gzlicanyi opened a new pull request, #689: URL: https://github.com/apache/skywalking-java/pull/689 Add a [forceIgnoring mechanism](https://github.com/apache/skywalking/discussions/12161) and apply it to the plugins (Spring Cloud Gateway, HttpClient, JDK-ForkJoinPool, JDK-Threading, JDK-Thr

Re: [PR] Fix next SWIP ID [skywalking]

2024-05-13 Thread via GitHub
wu-sheng merged PR #12217: URL: https://github.com/apache/skywalking/pull/12217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[PR] Fix next SWIP ID [skywalking]

2024-05-13 Thread via GitHub
wu-sheng opened a new pull request, #12217: URL: https://github.com/apache/skywalking/pull/12217 - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #. - [ ] Update the [`CHANGES` log](https://github.com/apa

(skywalking) branch wu-sheng-patch-1 created (now 84a30e5a76)

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a change to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git at 84a30e5a76 Fix next SWIP ID This branch includes the following new commits: new 84a30e5a76 Fix n

(skywalking) 01/01: Fix next SWIP ID

2024-05-13 Thread wusheng
This is an automated email from the ASF dual-hosted git repository. wusheng pushed a commit to branch wu-sheng-patch-1 in repository https://gitbox.apache.org/repos/asf/skywalking.git commit 84a30e5a76b22814ce016069b62d7a84b97c4907 Author: 吴晟 Wu Sheng AuthorDate: Mon May 13 16:00:44 2024 +0800

Re: [PR] Update image repository and tag of BanyanDB cluster [skywalking-banyandb-helm]

2024-05-13 Thread via GitHub
wu-sheng commented on PR #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17#issuecomment-2106807251 Do we want to control this in the same place? Like we may need to override repo and commit ID within dev stage? -- This is an automated message from the Apache Git Servic

[PR] Update image repository and tag of BanyanDB cluster [skywalking-banyandb-helm]

2024-05-13 Thread via GitHub
ButterBright opened a new pull request, #17: URL: https://github.com/apache/skywalking-banyandb-helm/pull/17 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To