[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-483726579 We can close this now with https://github.com/apache/incubator-skywalking/pull/2386 being accepted. This gives Skywalking basic support

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-481694527 @wu-sheng, could you explain that please? OpenTracing support is mentioned on this project several times. It's my understanding that if you

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-481691244 @vietj, the new tracing features in Vert.x 4.0 look easy and simple to use. As far as I understand though, there isn't a simple way to do

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473488678 @wu-sheng, everything makes sense when you say it :P. I've added the local span back. I think the last question I have before I repeat this

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-473479322 @wu-sheng, using the new asynchronous functionality I'm able to get the following results: ![Screenshot from 2019-03-15

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472682444 @wu-sheng, I think I understand. I assumed that the Vert.x `EntrySpan` would be the root one. I wasn't thinking bigger picture. I agree

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472665623 @wu-sheng, I guess I'm just not entirely sure where you see the difficulty in holding the `EntrySpan` open until the response. Even in a

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472658289 @wu-sheng, okay the `ContextManager` implementation might be too far. How is this not an issue for other async plugins you have though (eg:

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472654046 @wu-sheng, I think I have a firm grasp of the problem now lol. Instead of modifying the `endTime` why not just wait to close the span? I

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472523795 @wu-sheng, I think I'm almost on the same page with you. You're saying the JSON trace stack I included above is correct in all aspects

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472473079 @wu-sheng, I would definitely like to implement support for Vert.x so if it's necessary to create a new TracingContext implementation to do

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-472435960 @wu-sheng, yeah those operation names are for testing right now. I've deleted code to try to keep what I'm showing you as straight forward

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-471853260 @wu-sheng, your advice appears to have gotten me closer but I think there is something I'm fundamentally not understanding. I able to

[GitHub] [incubator-skywalking] BFergerson commented on issue #2341: Support plugin for Vert.x

BFergerson commented on issue #2341: Support plugin for Vert.x URL: https://github.com/apache/incubator-skywalking/issues/2341#issuecomment-471383541 I had a lightbulb moment when you said the key was I was creating spans on a shared thread. I'm pretty sure you're absolutely right.