BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-474650413
@wu-sheng, luck you :P. That's okay though. I'm sure this isn't ready yet. I
wanted to ask you if I was doing the `EntrySpan`/`ExitSpan` pattern
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-475834936
@wu-sheng, why do you think it will be hard to tell whether or not to make
an exit span vs a local span? I'm able to detect whether the message i
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-476930095
@wu-sheng, pushed the remaining work.
Would you like me to begin working on the integration test or do you want to
review/discuss the code
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-477379781
@wu-sheng, is it necessary to open a local span when you're just closing an
async local span?
Without opening another local I have this:
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480083566
@wu-sheng, I'm surprised those tests ended up working. That's awesome though.
And I just started with 3.6.3 since it was the latest. Would you
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480120556
@wu-sheng, I added all versions from 3.x to the integration test. I can't
get any of them to work locally so I'm just going to wait for the SkyWa
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-480860663
@wu-sheng, that might actually be pretty interesting. I've never presented
at something like ApacheCon before but it's something I'll definitely
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-482831750
@wu-sheng, I should be able to get it to support 3.2+. This is when Vert.x
introduced the `ClusteredMessage` which is what I use to tell if a mes
BFergerson commented on issue #2386: Vert.x Core 3.x Plugin
URL:
https://github.com/apache/incubator-skywalking/pull/2386#issuecomment-483091447
@wu-sheng, I think from adding the witness class there should not be any
problems with Vert.x 3.0.0 and 3.1.0. I've also updated the documentatio
