[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522815442 > At today, provide a static writer pointer may be safe for now. I am not sure about the future yet. Do you face any real issue about this? Actually not. It

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522816754 > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the modification of

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522818797 > > > `org.apache.skywalking.apm.agent.core.conf.Config.Logging#OUTPUT` is modifiable at runtime and the real writer may change, after your patch the modification

[GitHub] [skywalking] wayilau commented on issue #3287: Add cached writer.

2019-08-19 Thread GitBox
wayilau commented on issue #3287: Add cached writer. URL: https://github.com/apache/skywalking/pull/3287#issuecomment-522862073 /run-ci This is an automated message from the Apache Git Service. To respond to the message, pleas