[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

2023-02-21 Thread via GitHub
wu-sheng commented on code in PR #239: URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113763846 ## src/views/dashboard/data.ts: ## @@ -309,7 +309,7 @@ export const CalculationOpts = [ value: "convertMilliseconds", }, { label: "Seconds to Y

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

2023-02-21 Thread via GitHub
wu-sheng commented on code in PR #239: URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113763213 ## src/views/dashboard/data.ts: ## @@ -309,7 +309,7 @@ export const CalculationOpts = [ value: "convertMilliseconds", }, { label: "Seconds to Y

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

2023-02-21 Thread via GitHub
wu-sheng commented on code in PR #239: URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113762854 ## src/views/dashboard/data.ts: ## @@ -309,7 +309,7 @@ export const CalculationOpts = [ value: "convertMilliseconds", }, { label: "Seconds to Y

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

2023-02-21 Thread via GitHub
wu-sheng commented on code in PR #239: URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113693642 ## src/hooks/useMetricsProcessor.ts: ## @@ -398,15 +398,15 @@ export function aggregation(val: number, config: { calculation?: string }): numb case

[GitHub] [skywalking-booster-ui] wu-sheng commented on a diff in pull request #239: feat: add a calculation for `cpm5d`

2023-02-21 Thread via GitHub
wu-sheng commented on code in PR #239: URL: https://github.com/apache/skywalking-booster-ui/pull/239#discussion_r1113174991 ## src/hooks/useMetricsProcessor.ts: ## @@ -398,15 +398,15 @@ export function aggregation(val: number, config: { calculation?: string }): numb case