wu-sheng merged PR #707:
URL: https://github.com/apache/skywalking-java/pull/707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690955075
##
docs/en/setup/service-agent/java-agent/Supported-list.md:
##
@@ -76,7 +76,7 @@ metrics based on the tracing data.
* MQ
* [RocketMQ](https://github.com/apa
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2249629671
> One more. changes.md should be updated as well.
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2249623005
One more. changes.md should be updated as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690881990
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -63,103 +63,1
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690867660
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -63,103 +63,1
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690854260
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -63,103 +63,1
lujiajing1126 commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690850098
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/Kafka37AsyncConsumerInstrumentation.java:
##
@@ -0,0
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690851500
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/Kafka37AsyncConsumerInstrumentation.java:
##
@@ -0,0 +
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690848907
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/Kafka37AsyncConsumerInstrumentation.java:
##
@@ -0,0 +
lujiajing1126 commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690845088
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/Kafka37AsyncConsumerInstrumentation.java:
##
@@ -0,0
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2249496898
@kezhenxu94 As 403 respond code, should we add this into ignore list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2249496863
> > ---
/home/runner/work/skywalking-java/skywalking-java/tools/plugin/md-javaagent-plugin-list.txt
2024-07-25 03:04:25.186078041 +
> > +++
/home/runner/work/skywalkin
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690768521
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -63,103 +63,1
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690760806
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/Kafka37ConsumerInterceptor.java:
##
@@ -0,0 +1,57 @@
+/*
+ *
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690750382
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/Kafka37ConsumerInterceptor.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Lice
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690745753
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -63,103 +63,103 @
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690734241
##
docs/en/setup/service-agent/java-agent/Bootstrap-plugins.md:
##
@@ -19,4 +19,3 @@ The plugin of JDK HttpURLConnection depended on `sun.net.*`.
When using
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690733039
##
docs/en/setup/service-agent/java-agent/Bootstrap-plugins.md:
##
@@ -19,4 +19,3 @@ The plugin of JDK HttpURLConnection depended on `sun.net.*`.
When using Jav
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690732900
##
docs/en/setup/service-agent/java-agent/Bootstrap-plugins.md:
##
@@ -19,4 +19,3 @@ The plugin of JDK HttpURLConnection depended on `sun.net.*`.
When using Jav
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690732121
##
docs/en/setup/service-agent/java-agent/Bootstrap-plugins.md:
##
@@ -19,4 +19,3 @@ The plugin of JDK HttpURLConnection depended on `sun.net.*`.
When using
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2249286147
> ---
/home/runner/work/skywalking-java/skywalking-java/tools/plugin/md-javaagent-plugin-list.txt
2024-07-25 03:04:25.186078041 +
+++
/home/runner/work/skywalking-java/s
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690731077
##
docs/en/setup/service-agent/java-agent/Bootstrap-plugins.md:
##
@@ -19,4 +19,3 @@ The plugin of JDK HttpURLConnection depended on `sun.net.*`.
When using Jav
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2246138300
> You should verify all locally rather than costing too much on CI.
Sry, it's my first time to create PR in github, I'm doing test CI in my
private branch now
--
This
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2244249281
You should verify all locally rather than costing too much on CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242405594
And please fix CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242405190
> > Logically same. But we should test.
>
>
>
> OK, Should I create modules kafka-3.6.x-scenario and kafka-3.7.x-scenario
like kafka-2.3.x-scenario in dir /test?
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242402344
> Logically same. But we should test.
OK, Should I create modules kafka-3.6.x-scenario and kafka-3.7.x-scenario
like kafka-2.3.x-scenario in dir /test?
--
This is an a
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242330562
Logically same. But we should test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242326514
> Please pick one for 3.4, 3.5, 3.6 as well.
3.4, 3.5, 3.6 are same to 3.2.3
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242323585
Please pick one for 3.4, 3.5, 3.6 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1686127385
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -62,104 +64,1
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2242110660
About
https://github.com/apache/skywalking-java/pull/708#issuecomment-2242063529 I
mean the test versions
demo codes
https://github.com/apache/skywalking-java/tree/main/tes
darkness-2nd commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2241880439
> ase explain what is changing here, and if th
> If the new use cases are same here, you should add more versions to
support your new implementations for newer ve
wu-sheng commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1685833702
##
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##
@@ -62,104 +64,121 @
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2241813975
If the new use cases are same here, you should add more versions to support
your new implementations for newer versions, and keep compatibility with
previous.
--
This is an auto
wu-sheng commented on PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#issuecomment-2241725810
Please explain what is changing here, and if this is a plugin update, you
need to update test scenarios too.
--
This is an automated message from the Apache Git Service.
To respo
darkness-2nd opened a new pull request, #707:
URL: https://github.com/apache/skywalking-java/pull/707
- [ ] If this pull request closes/resolves/fixes an existing issue, replace
the issue number. Closes #.
- [ ] Update the [`CHANGES`
log](https://g
38 matches
Mail list logo
