lujiajing1126 opened a new pull request, #150:
URL: https://github.com/apache/skywalking-go/pull/150
In https://github.com/apache/skywalking-go/pull/104, trace related APIs are
introduced for developers.
But the plugin strucuture is not correct, this leads to empty version in the
`Ve
mrproliu commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393722290
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
// ch
lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393778468
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393778468
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393844015
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
mrproliu commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393858336
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
// ch
lujiajing1126 commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393862011
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
mrproliu commented on code in PR #150:
URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1394137419
##
tools/go-agent/instrument/plugins/instrument.go:
##
@@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions)
bool {
// ch
mrproliu merged PR #150:
URL: https://github.com/apache/skywalking-go/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
