wu-sheng merged PR #107:
URL: https://github.com/apache/skywalking-php/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr..
wu-sheng commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955728454
> > > $spanId should not be for the entire request, right?
> >
> >
> > It is not. It is variable according to span creation and stop status.
>
> I would like to impl
jmjoy commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955725165
> > $spanId should not be for the entire request, right?
>
> It is not. It is variable according to span creation and stop status.
I would like to implement $spanId in the
wu-sheng commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955716258
> > How about $spanId?
>
> $spanId should not be for the entire request, right?
It is not. It is variable according to span creation and stop status.
--
This is an au
jmjoy commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955693441
> How about $spanId?
$spanId should not be for the entire request, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
wu-sheng commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1954108830
And please update the docs according, after you added the span ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
wu-sheng commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-195384
> > Should we consider the whole trace context?
>
> $serviceName, $instanceName, $traceId, $traceSegmentId are injected.
How about $spanId?
--
This is an automated me
jmjoy commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953830055
> Should we consider the whole trace context?
$serviceName, $instanceName, $traceId, $traceSegmentId are injected.
--
This is an automated message from the Apache Git Service.
wu-sheng commented on PR #107:
URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1953487834
Should we consider the whole trace context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
