Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng merged PR #11892: URL: https://github.com/apache/skywalking/pull/11892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on code in PR #11892: URL: https://github.com/apache/skywalking/pull/11892#discussion_r1499414175 ## oap-server/server-starter/src/main/resources/application.yml: ## @@ -485,6 +485,7 @@ configuration: port: ${SW_DCS_SERVER_PORT:80} clusterName:

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on code in PR #11892: URL: https://github.com/apache/skywalking/pull/11892#discussion_r1499413638 ## docs/en/setup/backend/configuration-vocabulary.md: ## @@ -281,6 +281,7 @@ The Configuration Vocabulary lists all available configurations provided by `app |

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

ooi22 commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1959560376 > `configuration-vocabulary.md` and `changes.md` should be updated accordingly. Done -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1959080291 Then, please follow the change request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

ooi22 commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1959077892 > You removed YAML resolver relative changes? Are those irrelevant? Yes, and it is another optimization point, but I have no time to change it to a setting instead of hardcoded,

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1956905983 `configuration-vocabulary.md` and `changes.md` should be updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1956483902 You removed YAML resolver relative changes? Are those irrelevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

ooi22 commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1956464574 done > > Your current change is too reckless, and could cause OOM easily for loading a wrong file or malicious file > > This is a very valid point, please adjust to a

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1953402024 > > Which configuration file is over 4M? Alerting rule? > > yes Please follow the comment above. -- This is an automated message from the Apache Git Service. To

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

ooi22 commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1953384740 > Which configuration file is over 4M? Alerting rule? yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

Superskyyy commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1952860980 > Your current change is too reckless, and could cause OOM easily for loading a wrong file or malicious file This is a very valid point, please adjust to a setting instead

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1952628529 This change should be applied for certain use case, rather than making all YAML files adopting this change. And the max length should not be hard coded, it should be

Re: [PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1952616654 Which configuration file is over 4M? Alerting rule? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] Modifying the limit size of yaml and GRPC inbound message [skywalking]

ooi22 opened a new pull request, #11892: URL: https://github.com/apache/skywalking/pull/11892 ### Fix - [ ] Add a unit test to verify that the fix works. - [x] The default size is 4M,modifying the limit size to maximum. - [ ] If this pull request