[GitHub] [incubator-superset] mistercrunch commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart

2019-09-04 Thread GitBox
mistercrunch commented on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart URL: https://github.com/apache/incubator-superset/pull/8082#issuecomment-527778665 I was internally debating the pros/cons of adding a new `GeoJSON` `line_type`, vs this approach or making a smart

[GitHub] [incubator-superset] lshunran closed issue #8161: navbar_menu.html is not found

2019-09-04 Thread GitBox
lshunran closed issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-superset] lshunran commented on issue #8161: navbar_menu.html is not found

2019-09-04 Thread GitBox
lshunran commented on issue #8161: navbar_menu.html is not found URL: https://github.com/apache/incubator-superset/issues/8161#issuecomment-527781672 run superset db upgrade & superset init again This is an automated message

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #8082: add GeoJSON encoding support to deck.gl Polygon chart URL: https://github.com/apache/incubator-superset/pull/8082#issuecomment-527445947 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8082?src=pr&el=h1) Report > Merging [#

[GitHub] [incubator-superset] alexnikitchuk opened a new issue #8168: Impala REQUEST_POOL query option

2019-09-04 Thread GitBox
alexnikitchuk opened a new issue #8168: Impala REQUEST_POOL query option URL: https://github.com/apache/incubator-superset/issues/8168 **Is your feature request related to a problem? Please describe.** I'm not able to specify query option REQUEST_POOL **Describe the solution you'd

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8168: Impala REQUEST_POOL query option

2019-09-04 Thread GitBox
issue-label-bot[bot] commented on issue #8168: Impala REQUEST_POOL query option URL: https://github.com/apache/incubator-superset/issues/8168#issuecomment-527784617 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.97. Please mark this

[GitHub] [incubator-superset] zachary124 commented on issue #8151: Can't load plugin: sqlalchemy.dialects:drill.jdbc

2019-09-04 Thread GitBox
zachary124 commented on issue #8151: Can't load plugin: sqlalchemy.dialects:drill.jdbc URL: https://github.com/apache/incubator-superset/issues/8151#issuecomment-527796385 @cgivre The dependencies were reinstalled and the test_jdbc.py can work 。but in superset has another issue,I will cr

[GitHub] [incubator-superset] zachary124 closed issue #8151: Can't load plugin: sqlalchemy.dialects:drill.jdbc

2019-09-04 Thread GitBox
zachary124 closed issue #8151: Can't load plugin: sqlalchemy.dialects:drill.jdbc URL: https://github.com/apache/incubator-superset/issues/8151 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-superset] syazwan0913 opened a new issue #8169: Where to find superset.log file?

2019-09-04 Thread GitBox
syazwan0913 opened a new issue #8169: Where to find superset.log file? URL: https://github.com/apache/incubator-superset/issues/8169 A clear and concise description of what the bug is. ### Expected results can find superset.log file ### Actual results cannot find

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8169: Where to find superset.log file?

2019-09-04 Thread GitBox
issue-label-bot[bot] commented on issue #8169: Where to find superset.log file? URL: https://github.com/apache/incubator-superset/issues/8169#issuecomment-527800496 Issue-Label Bot is automatically applying the label `#question` to this issue, with a confidence of 0.72. Please mark this co

[GitHub] [incubator-superset] zachary124 opened a new issue #8170: drill not work in superset when create table

2019-09-04 Thread GitBox
zachary124 opened a new issue #8170: drill not work in superset when create table URL: https://github.com/apache/incubator-superset/issues/8170 hello, I want to use drill in superset and create table then create charts。 first I use drill+sadrill and I can create databases and can use in

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8170: drill not work in superset when create table

2019-09-04 Thread GitBox
issue-label-bot[bot] commented on issue #8170: drill not work in superset when create table URL: https://github.com/apache/incubator-superset/issues/8170#issuecomment-527802491 Issue Label Bot is not confident enough to auto-label this issue. See [dashboard](https://mlbot.net/data/apache/

[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8171: Celery worker support for Druid Queries

2019-09-04 Thread GitBox
issue-label-bot[bot] commented on issue #8171: Celery worker support for Druid Queries URL: https://github.com/apache/incubator-superset/issues/8171#issuecomment-527852516 Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.82. Please m

[GitHub] [incubator-superset] Stephan3555 opened a new issue #8171: Celery worker support for Druid Queries

2019-09-04 Thread GitBox
Stephan3555 opened a new issue #8171: Celery worker support for Druid Queries URL: https://github.com/apache/incubator-superset/issues/8171 I set up a superset cluster consisting of superset web server, redis (as broker, result backend and cache) and celery workers. Everything works fine w

[GitHub] [incubator-superset] theikkila commented on issue #6202: Add cache support for 'CSV Export' function. This change will get CSV…

2019-09-04 Thread GitBox
theikkila commented on issue #6202: Add cache support for 'CSV Export' function. This change will get CSV… URL: https://github.com/apache/incubator-superset/pull/6202#issuecomment-527871205 @mistercrunch @smokemonster99 @kristw Could you please review this PR -

[GitHub] [incubator-superset] villebro commented on issue #6202: Add cache support for 'CSV Export' function. This change will get CSV…

2019-09-04 Thread GitBox
villebro commented on issue #6202: Add cache support for 'CSV Export' function. This change will get CSV… URL: https://github.com/apache/incubator-superset/pull/6202#issuecomment-527897606 This change is largely a copy of the `get_df_payload` method. I believe the following change should

[GitHub] [incubator-superset] betodealmeida opened a new pull request #8172: Allow users to estimate query cost before executing them

2019-09-04 Thread GitBox
betodealmeida opened a new pull request #8172: Allow users to estimate query cost before executing them URL: https://github.com/apache/incubator-superset/pull/8172 ### CATEGORY Choose one - [ ] Bug Fix - [X] Enhancement (new features, refinement) - [ ] Refactor - [ ]

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117#issuecomment-527578626 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8117?src=pr&el=h1) Report > Mer

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320858065 ## File path: superset/assets/src/SqlLab/components/SqlEditor.jsx ## @@ -59,6 +59,7 @@ const

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320860910 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320851277 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -132,7 +139,23 @@ export fu

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320842106 ## File path: superset/assets/spec/javascripts/sqllab/actions/sqlLab_spec.js ## @@ -206,4 +2

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320859566 ## File path: superset/config.py ## @@ -457,7 +457,7 @@ class CeleryConfig(object): # rathe

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320851512 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -165,7 +188,18 @@ export fu

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320853804 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -271,40 +303,230 @@ export

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r319692793 ## File path: superset/assets/package.json ## @@ -93,6 +93,7 @@ "chrono-node": "^1.3.11

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320861399 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320860702 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320870285 ## File path: superset/views/sql_lab.py ## @@ -169,6 +175,157 @@ def show(self, pk): appbui

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320850861 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -132,7 +139,23 @@ export fu

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320860784 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320858219 ## File path: superset/assets/src/SqlLab/components/SqlEditor.jsx ## @@ -153,6 +158,7 @@ cla

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320858898 ## File path: superset/assets/src/SqlLab/reducers/getInitialState.js ## @@ -37,16 +39,113 @@

[GitHub] [incubator-superset] mistercrunch closed issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1

2019-09-04 Thread GitBox
mistercrunch closed issue #8062: CUSTOM_SECURITY_MANAGER not working in 0.34.0rc1 URL: https://github.com/apache/incubator-superset/issues/8062 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-superset] mistercrunch merged pull request #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items

2019-09-04 Thread GitBox
mistercrunch merged pull request #8117: Fix to Werkzeug ProxyFix; expose ProxyFix configuration items URL: https://github.com/apache/incubator-superset/pull/8117 This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-superset] mistercrunch closed issue #8110: Investigate broken Custom Security Manager

2019-09-04 Thread GitBox
mistercrunch closed issue #8110: Investigate broken Custom Security Manager URL: https://github.com/apache/incubator-superset/issues/8110 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-superset] villebro commented on issue #8165: [bugfix] fix timegrain addon regression

2019-09-04 Thread GitBox
villebro commented on issue #8165: [bugfix] fix timegrain addon regression URL: https://github.com/apache/incubator-superset/pull/8165#issuecomment-528003914 This should be ready for review. This is an automated message from

[GitHub] [incubator-superset] kristw opened a new pull request #8173: feat: read control panel configs from registry

2019-09-04 Thread GitBox
kristw opened a new pull request #8173: feat: read control panel configs from registry URL: https://github.com/apache/incubator-superset/pull/8173 ### CATEGORY Choose one - [X] Refactor ### SUMMARY Read control panel configs from registry. This is part of the work to

[GitHub] [incubator-superset] paulvic opened a new pull request #8174: Bump flask-appbuilder to 2.1.12

2019-09-04 Thread GitBox
paulvic opened a new pull request #8174: Bump flask-appbuilder to 2.1.12 URL: https://github.com/apache/incubator-superset/pull/8174 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Devel

[GitHub] [incubator-superset] dpgaspar commented on issue #8127: Frontend not built after installing Superset with Docker

2019-09-04 Thread GitBox
dpgaspar commented on issue #8127: Frontend not built after installing Superset with Docker URL: https://github.com/apache/incubator-superset/issues/8127#issuecomment-528062071 On the logs I'm seeing: ``` + exec ./docker-init.sh + fabmanager create-admin --app superset Username

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320987456 ## File path: superset/assets/package.json ## @@ -93,6 +93,7 @@ "chrono-node": "^

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320987516 ## File path: superset/assets/spec/javascripts/sqllab/actions/sqlLab_spec.js ## @@ -20

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320987634 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -132,7 +139,23 @@ exp

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320988472 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -132,7 +139,23 @@ exp

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320988508 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -165,7 +188,18 @@ exp

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320988853 ## File path: superset/assets/src/SqlLab/actions/sqlLab.js ## @@ -271,40 +303,230 @@ e

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320988932 ## File path: superset/assets/src/SqlLab/components/SqlEditor.jsx ## @@ -59,6 +59,7 @@

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320989776 ## File path: superset/assets/src/SqlLab/components/SqlEditor.jsx ## @@ -153,6 +158,7

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320990140 ## File path: superset/config.py ## @@ -457,7 +457,7 @@ class CeleryConfig(object): #

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320989969 ## File path: superset/assets/src/SqlLab/reducers/getInitialState.js ## @@ -37,16 +39,

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320990270 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320990306 ## File path: superset/migrations/versions/02f260780a2b_add_tables_for_sql_lab_state.py ##

[GitHub] [incubator-superset] betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r320990411 ## File path: superset/views/sql_lab.py ## @@ -169,6 +175,157 @@ def show(self, pk):

[GitHub] [incubator-superset] dpgaspar commented on issue #8174: Bump flask-appbuilder to 2.1.12

2019-09-04 Thread GitBox
dpgaspar commented on issue #8174: Bump flask-appbuilder to 2.1.12 URL: https://github.com/apache/incubator-superset/pull/8174#issuecomment-528127805 Can you bump it to 2.1.13? This is an automated message from the Apache Git

[GitHub] [incubator-superset] john-bodley opened a new pull request #8175: [metric] Adding security for restricted metrics

2019-09-04 Thread GitBox
john-bodley opened a new pull request #8175: [metric] Adding security for restricted metrics URL: https://github.com/apache/incubator-superset/pull/8175 ### CATEGORY Choose one - [ ] Bug Fix - [x] Enhancement (new features, refinement) - [ ] Refactor - [x] Add tests

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8060: SIP-23: Persist SQL Lab state in the backend URL: https://github.com/apache/incubator-superset/pull/8060#discussion_r321036576 ## File path: superset/views/sql_lab.py ## @@ -169,6 +175,157 @@ def show(self, pk): appbui

[GitHub] [incubator-superset] villebro commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab

2019-09-04 Thread GitBox
villebro commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164#discussion_r321075341 ## File path: superset/db_engine_specs/hive.py ## @@ -200,7 +200,7 @@ def extract

[GitHub] [incubator-superset] dpgaspar opened a new pull request #8176: Bump FAB to 2.1.13

2019-09-04 Thread GitBox
dpgaspar opened a new pull request #8176: Bump FAB to 2.1.13 URL: https://github.com/apache/incubator-superset/pull/8176 ### CATEGORY - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Do

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab

2019-09-04 Thread GitBox
etr2460 commented on a change in pull request #8164: [sqllab] More detailed async error messages for sqllab URL: https://github.com/apache/incubator-superset/pull/8164#discussion_r321076431 ## File path: superset/db_engine_specs/hive.py ## @@ -200,7 +200,7 @@ def extract_

[GitHub] [incubator-superset] lilila commented on issue #8165: [bugfix] fix timegrain addon regression

2019-09-04 Thread GitBox
lilila commented on issue #8165: [bugfix] fix timegrain addon regression URL: https://github.com/apache/incubator-superset/pull/8165#issuecomment-528201624 Thank you @villebro , it works well (at least for mysql db) This

[GitHub] [incubator-superset] villebro commented on a change in pull request #8038: Prevent 'main' database connection creation

2019-09-04 Thread GitBox
villebro commented on a change in pull request #8038: Prevent 'main' database connection creation URL: https://github.com/apache/incubator-superset/pull/8038#discussion_r321078356 ## File path: tests/sqllab_tests.py ## @@ -160,11 +148,15 @@ def test_queries_endpoint(self)

[GitHub] [incubator-superset] codecov-io commented on issue #8176: Bump FAB to 2.1.13

2019-09-04 Thread GitBox
codecov-io commented on issue #8176: Bump FAB to 2.1.13 URL: https://github.com/apache/incubator-superset/pull/8176#issuecomment-528226456 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8176?src=pr&el=h1) Report > Merging [#8176](https://codecov.io/gh/apache/incubato

[GitHub] [incubator-superset] codecov-io edited a comment on issue #8176: Bump FAB to 2.1.13

2019-09-04 Thread GitBox
codecov-io edited a comment on issue #8176: Bump FAB to 2.1.13 URL: https://github.com/apache/incubator-superset/pull/8176#issuecomment-528226456 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8176?src=pr&el=h1) Report > Merging [#8176](https://codecov.io/gh/apache/i