visharavana commented on PR #27291:
URL: https://github.com/apache/superset/pull/27291#issuecomment-2046614658
@michael-s-molina when you use this code to align the Data Zoom slide
perfectly.
yAxisIndex: isHorizontal ? 60 : undefined,
: bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-preset-chart-nvd3
URL: https://github.com/apache/superset/pull/27820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
dependabot[bot] commented on PR #27837:
URL: https://github.com/apache/superset/pull/27837#issuecomment-2046587929
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
dependabot[bot] commented on PR #27828:
URL: https://github.com/apache/superset/pull/27828#issuecomment-2046588024
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
rusackas closed pull request #27828: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-sankey
URL: https://github.com/apache/superset/pull/27828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
dependabot[bot] commented on PR #27799:
URL: https://github.com/apache/superset/pull/27799#issuecomment-2046587561
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
dependabot[bot] commented on PR #27803:
URL: https://github.com/apache/superset/pull/27803#issuecomment-2046587458
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
dependabot[bot] commented on PR #27807:
URL: https://github.com/apache/superset/pull/27807#issuecomment-2046587401
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
dependabot[bot] commented on PR #27801:
URL: https://github.com/apache/superset/pull/27801#issuecomment-2046587517
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
rusackas closed pull request #27803: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-country-map
URL: https://github.com/apache/superset/pull/27803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
dependabot[bot] commented on PR #27820:
URL: https://github.com/apache/superset/pull/27820#issuecomment-2046588099
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
rusackas closed pull request #27826: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-world-map
URL: https://github.com/apache/superset/pull/27826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
dependabot[bot] commented on PR #27829:
URL: https://github.com/apache/superset/pull/27829#issuecomment-2046587960
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
rusackas closed pull request #27829: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-partition
URL: https://github.com/apache/superset/pull/27829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
rusackas closed pull request #27837: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-heatmap
URL: https://github.com/apache/superset/pull/27837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rusackas closed pull request #27799: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-parallel-coordinates
URL: https://github.com/apache/superset/pull/27799
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rusackas closed pull request #27801: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-chord
URL: https://github.com/apache/superset/pull/27801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
rusackas closed pull request #27807: build(deps): bump d3 from 3.5.17 to 7.9.0
in /superset-frontend/plugins/legacy-plugin-chart-rose
URL: https://github.com/apache/superset/pull/27807
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Abhishek-kumar-samsung commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2046586892
I accidently closed the PR and I reopened it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
codecov-commenter commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2046586087
##
[Codecov](https://app.codecov.io/gh/apache/superset/pull/24449?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm
Abhishek-kumar-samsung opened a new pull request, #24449:
URL: https://github.com/apache/superset/pull/24449
Earlier at dashboard level we had very limited options in 'Set auto-refresh
interval' as shown in image below
![107 99 45
216_9000_superset_dashboard_5__native_filters_key=6Z
dependabot[bot] closed pull request #27862: build(deps): bump deck.gl from
8.8.27 to 9.0.4 in /superset-frontend/plugins/legacy-preset-chart-deckgl
URL: https://github.com/apache/superset/pull/27862
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dependabot[bot] opened a new pull request, #27965:
URL: https://github.com/apache/superset/pull/27965
Bumps [deck.gl](https://github.com/visgl/deck.gl) from 8.8.27 to 9.0.6.
Release notes
Sourced from https://github.com/visgl/deck.gl/releases";>deck.gl's
releases.
v9.0.6
rusackas merged PR #27810:
URL: https://github.com/apache/superset/pull/27810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
dependabot[bot] commented on PR #27862:
URL: https://github.com/apache/superset/pull/27862#issuecomment-2046584635
Superseded by #27965.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2046584091
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Abhishek-kumar-samsung commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2046583583
> > Hi all - please direct me to an issue link if there's a separate place
for questions. We recently adopted Superset and I'm looking into setting up
refresh schedules
rusackas commented on PR #27862:
URL: https://github.com/apache/superset/pull/27862#issuecomment-2046583561
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Abhishek-kumar-samsung closed pull request #24449: feat: custom refresh
frequency
URL: https://github.com/apache/superset/pull/24449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
baiyuxiong opened a new issue, #27964:
URL: https://github.com/apache/superset/issues/27964
### Bug description
```
curl --location --request POST 'http://127.0.0.1:8088/api/v1/security/login'
\
--header 'accept: application/json' \
--header 'Content-Type: application/json' \
rusackas opened a new pull request, #27963:
URL: https://github.com/apache/superset/pull/27963
### SUMMARY
Per ASF Infra, GA is not allowed. This account is vestigial anyway, but
let's just chop it out.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TE
fisjac opened a new pull request, #27962:
URL: https://github.com/apache/superset/pull/27962
### SUMMARY
This is a proof of concept for accessing the tabs associated with a
dashboard.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
EuphoriaCelestial opened a new issue, #27961:
URL: https://github.com/apache/superset/issues/27961
### Bug description
Hi, as the title said, I am using Superset API to do things like create DB
connection, create users, ...
The login, get csrf token endpoints is fine, and I am als
zhangymPerson commented on code in PR #27930:
URL: https://github.com/apache/superset/pull/27930#discussion_r1558782527
##
RESOURCES/FEATURE_FLAGS.md:
##
@@ -52,7 +52,7 @@ These features are **finished** but currently being tested.
They are usable, but
- PLAYWRIGHT_REPORTS_AND
eulloa10 commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1558772499
##
superset-frontend/src/explore/components/controls/FixedOrMetricControl/index.jsx:
##
@@ -127,7 +127,7 @@ export default class FixedOrMetricControl extends
React
mdeshmu commented on issue #26183:
URL: https://github.com/apache/superset/issues/26183#issuecomment-2046307654
Was the initial version of this feature released with 4.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mistercrunch commented on PR #27956:
URL: https://github.com/apache/superset/pull/27956#issuecomment-2046284774
@rusackas I'll let you merge this one since you wanted to use it for
troubleshooting the `.htaccess` stuffs
--
This is an automated message from the Apache Git Service.
To respo
qleroy opened a new issue, #27959:
URL: https://github.com/apache/superset/issues/27959
### Bug description
PR #26074 updated the json and .po files and introduced regressions in
French translations.
Solution is to revert to the previous .json and .po files, while keeping the
mistercrunch closed pull request #27958: chore(🦾): bump python flask-caching
subpackage(s)
URL: https://github.com/apache/superset/pull/27958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
mistercrunch closed pull request #27958: chore(🦾): bump python flask-caching
subpackage(s)
URL: https://github.com/apache/superset/pull/27958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
github-actions[bot] opened a new pull request, #27958:
URL: https://github.com/apache/superset/pull/27958
Updates the python "flask-caching" library version from null to null.
Generated by @supersetbot 🦾
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] closed pull request #27958: chore(🦾): bump python
flask-caching subpackage(s)
URL: https://github.com/apache/superset/pull/27958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
guenp commented on code in PR #27908:
URL: https://github.com/apache/superset/pull/27908#discussion_r1558552091
##
superset/db_engine_specs/duckdb.py:
##
@@ -38,9 +45,208 @@
COLUMN_DOES_NOT_EXIST_REGEX = re.compile("no such column: (?P.+)")
-class DuckDBEngineSpec(BaseEngin
lilykuang merged PR #27911:
URL: https://github.com/apache/superset/pull/27911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
kenniy opened a new issue, #27957:
URL: https://github.com/apache/superset/issues/27957
### Bug description
When creating a chart with a custom SQL column made up of a string
containing more than one dot, such as `"google.co.uk"`, the chart fails to
render with an "Unexpected error"
rusackas commented on PR #27942:
URL: https://github.com/apache/superset/pull/27942#issuecomment-2046104330
I take it back. CI was fine. Published an INFRA ticket here:
https://issues.apache.org/jira/browse/INFRA-25701
--
This is an automated message from the Apache Git Service.
To respon
rusackas merged PR #27955:
URL: https://github.com/apache/superset/pull/27955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
mistercrunch opened a new pull request, #27956:
URL: https://github.com/apache/superset/pull/27956
### SUMMARY
I believe the intention is to have the docs
aligned with what is on `master`, currently pushing on a release
branch will trigger a potential regression.
It could
rusackas commented on code in PR #27954:
URL: https://github.com/apache/superset/pull/27954#discussion_r1558314552
##
docs/docs/installation/running-on-kubernetes.mdx:
##
@@ -93,7 +93,7 @@ Depending how you configured external access, the URL will
vary. Once you've ide
villebro commented on code in PR #27954:
URL: https://github.com/apache/superset/pull/27954#discussion_r1558311597
##
docs/docs/installation/running-on-kubernetes.mdx:
##
@@ -93,7 +93,7 @@ Depending how you configured external access, the URL will
vary. Once you've ide
rusackas opened a new pull request, #27955:
URL: https://github.com/apache/superset/pull/27955
### SUMMARY
I tried to bump everything to node 18 in [this
PR](https://github.com/apache/superset/pull/27198), but I seem to have missed
one. Thanks for catching it, @mistercrunch :
mistercrunch commented on PR #27951:
URL: https://github.com/apache/superset/pull/27951#issuecomment-2046046744
What about changing it here? ->
https://github.com/apache/superset/blob/master/docker/pythonpath_dev/superset_config.py#L97-L99
--
This is an automated message from the Apache G
rusackas commented on PR #24449:
URL: https://github.com/apache/superset/pull/24449#issuecomment-2046038294
After some quick sanity tests on the ephemeral, this is looking pretty good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rusackas commented on PR #27933:
URL: https://github.com/apache/superset/pull/27933#issuecomment-2046029531
I'll take a look... as long as the data being pulled in is
license-compatible with the Apache 2 license, I think we should be OK.
--
This is an automated message from the Apache Git
rusackas commented on issue #27535:
URL: https://github.com/apache/superset/issues/27535#issuecomment-2046025311
Hmmm... that's the old `explore_json` endpoint, used by legacy charts, as
opposed to the `v1/chart/data` endpoint, which is newer. I wonder the Excel
export is broken for all the
rusackas commented on issue #27949:
URL: https://github.com/apache/superset/issues/27949#issuecomment-2046021096
I think @michael-s-molina and @geido know this component best and might have
pointers on how to clear/reset the search result when clearing the (last?)
selected item. I assume th
rusackas commented on PR #27954:
URL: https://github.com/apache/superset/pull/27954#issuecomment-2046017001
@margorczynski let me know if this addresses your concern, or make
suggestions accordingly if not :) Thanks.
--
This is an automated message from the Apache Git Service.
To respond
rusackas opened a new pull request, #27954:
URL: https://github.com/apache/superset/pull/27954
### SUMMARY
Addressing some confusion from this issue:
https://github.com/apache/superset/issues/27931
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INST
rusackas commented on issue #27931:
URL: https://github.com/apache/superset/issues/27931#issuecomment-2046015015
> it seems SHOULD should be replace by MUST for it to work
I'll open a PR for this... but please feel free to make additional docs PRs
or let me know what changes you thin
rusackas commented on issue #19222:
URL: https://github.com/apache/superset/issues/19222#issuecomment-2046005895
Is anyone experiencing this able to make an example export to share here
that we can troubleshoot with? I haven't been able to reproduce the issue. It
seems like if you make a vi
mistercrunch opened a new pull request, #27953:
URL: https://github.com/apache/superset/pull/27953
### SUMMARY
When firing the `docker-compose up` command, which is pretty much the first
step
of most developer workflows, we kick off up 2 chromium downloads: one
for PLAYWRIGHT an
rusackas commented on issue #18938:
URL: https://github.com/apache/superset/issues/18938#issuecomment-2045998559
Closing this out since it's gone silent for a good long while. Also since
we're moving feature requests over to GitHub discussions, and leaving Issues
for bugs (which this isn't)
rusackas closed issue #18938: Can superset fromat currency dynamically
according to the user's setting
URL: https://github.com/apache/superset/issues/18938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rusackas commented on PR #26094:
URL: https://github.com/apache/superset/pull/26094#issuecomment-2045993955
Running CI. Fingers crossed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
rusackas commented on PR #27942:
URL: https://github.com/apache/superset/pull/27942#issuecomment-2045991166
Actually, I think it's our CI that didn't trigger/run correctly... it looks
like the change was not pushed over to the other docs repo that's actually
hosted.
--
This is an automat
guenp commented on code in PR #27908:
URL: https://github.com/apache/superset/pull/27908#discussion_r1558239950
##
superset/db_engine_specs/duckdb.py:
##
@@ -38,9 +45,208 @@
COLUMN_DOES_NOT_EXIST_REGEX = re.compile("no such column: (?P.+)")
-class DuckDBEngineSpec(BaseEngin
guenp commented on code in PR #27908:
URL: https://github.com/apache/superset/pull/27908#discussion_r1558238829
##
superset/databases/utils.py:
##
@@ -104,7 +104,7 @@ def get_table_metadata(
}
-def make_url_safe(raw_url: Union[str, URL]) -> URL:
+def make_url_safe(raw_u
craig-rueda merged PR #27946:
URL: https://github.com/apache/superset/pull/27946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
sfirke commented on PR #27942:
URL: https://github.com/apache/superset/pull/27942#issuecomment-2045940388
Bah. Thank you and good luck! 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
rusackas commented on PR #27942:
URL: https://github.com/apache/superset/pull/27942#issuecomment-2045929772
It looks like the site didn't update at all... I'm going to have to take
this up with ASF infra (again).
--
This is an automated message from the Apache Git Service.
To respond to t
mistercrunch commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1558160238
##
superset/utils/log.py:
##
@@ -359,3 +365,29 @@ def log( # pylint:
disable=too-many-arguments,too-many-locals
except SQLAlchemyError as ex:
villebro commented on code in PR #27950:
URL: https://github.com/apache/superset/pull/27950#discussion_r1558158991
##
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberWithTrendline/transformProps.ts:
##
@@ -249,7 +229,27 @@ export default function transformP
ramki88 commented on PR #26094:
URL: https://github.com/apache/superset/pull/26094#issuecomment-2045854329
> @ramki88 would you mind running the [pre-commit
hooks](https://superset.apache.org/docs/contributing/hooks-and-linting/) on
this so it can pass CI/linting?
Sure, I've ran it a
mistercrunch commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1558123366
##
superset/utils/log.py:
##
@@ -47,10 +47,12 @@ def collect_request_payload() -> dict[str, Any]:
payload: dict[str, Any] = {
"path": request.pa
mistercrunch commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1558119957
##
superset/sql_lab.py:
##
@@ -281,21 +276,26 @@ def execute_sql_statement( # pylint:
disable=too-many-statements
log_params,
)
mistercrunch commented on code in PR #27943:
URL: https://github.com/apache/superset/pull/27943#discussion_r1558117497
##
superset/models/core.py:
##
@@ -598,42 +627,30 @@ def _log_query(sql: str) -> None:
with self.get_raw_connection(schema=schema) as conn:
martin-raymond commented on issue #25749:
URL: https://github.com/apache/superset/issues/25749#issuecomment-2045831803
we changed all of our temporal field in our pinot table, so we skipped the
problem completely. the thread can stay closed, thx
--
This is an automated message from the Ap
justinpark commented on issue #27645:
URL: https://github.com/apache/superset/issues/27645#issuecomment-2045816998
> I think it's important to add this to the SIP so folks that are not
participating in the discussion can understand what's the plan. This depends on
the reply of the Ag Grid f
betodealmeida commented on issue #26128:
URL: https://github.com/apache/superset/issues/26128#issuecomment-2045798717
I'm happy to take a look if this is still happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rusackas commented on issue #26128:
URL: https://github.com/apache/superset/issues/26128#issuecomment-2045793604
Thanks! Officially, we support 3.1.x and 4.0.0 now, but I'm guessing the
same issue exists there too.
--
This is an automated message from the Apache Git Service.
To respond to
nathan-gilbert commented on issue #26962:
URL: https://github.com/apache/superset/issues/26962#issuecomment-2045769044
This seems similar to what I am experiencing as well:
https://github.com/apache/superset/issues/27952
--
This is an automated message from the Apache Git Service.
To resp
rusackas commented on PR #27950:
URL: https://github.com/apache/superset/pull/27950#issuecomment-2045765929
One question I have isn't about the PR itself (which is lookin' good!) but
about the new component's potential future, and thus its location in the
codebase.
Since the TooltipR
michael-s-molina commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045764543
Hi @fisjac. Both options are valid but if you opt for the feature flag
(useful if multiple developers), you need to update the `FEATURE_FLAGS.md` file.
--
This is an automat
rusackas commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045755351
Hey @fisjac - I think @michael-s-molina means that you just need to add an
entry to [this
file](https://github.com/apache/superset/blob/master/RESOURCES/FEATURE_FLAGS.md).
Presumably
fisjac commented on PR #27773:
URL: https://github.com/apache/superset/pull/27773#issuecomment-2045739890
@michael-s-molina could you clarify what you mean. It seems we have a couple
options here:
1. build the feature flag and merge in. This would enable building smaller
PRs to build out
john-bodley commented on code in PR #27951:
URL: https://github.com/apache/superset/pull/27951#discussion_r1558049160
##
docs/docs/installation/alerts-reports.mdx:
##
@@ -160,7 +160,7 @@ WEBDRIVER_OPTION_ARGS = [
]
# This is for internal use, you can keep http
-WEBDRIVER_BAS
nathan-gilbert opened a new issue, #27952:
URL: https://github.com/apache/superset/issues/27952
### Bug description
Problem is the title. No matter what timezone I select, the report job gets
scheduled 12 hours ahead.
In the Superset UI, the timezone display on the created rep
geido commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1557961896
##
superset-frontend/src/components/Icons/AntdEnhanced.tsx:
##
@@ -25,9 +25,10 @@ import IconType from './IconType';
const AntdEnhancedIcons = Object.keys(AntdIcons)
lilykuang merged PR #27909:
URL: https://github.com/apache/superset/pull/27909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...
john-bodley merged PR #27149:
URL: https://github.com/apache/superset/pull/27149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr.
dpgaspar commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045651454
> @kasiazjc @dpgaspar One thing I forgot to mention was about the loaded
columns. Apart from their names, their types are equality important because
they will inform users if they nee
justinpark commented on PR #27392:
URL: https://github.com/apache/superset/pull/27392#issuecomment-2045650322
@michael-s-molina @john-bodley PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
john-bodley commented on code in PR #27149:
URL: https://github.com/apache/superset/pull/27149#discussion_r1557972831
##
tests/integration_tests/sql_lab/api_tests.py:
##
@@ -51,7 +56,11 @@ class TestSqlLabApi(SupersetTestCase):
clear=True,
)
def test_get_from_
geido commented on code in PR #26602:
URL: https://github.com/apache/superset/pull/26602#discussion_r1557956067
##
superset-frontend/plugins/legacy-preset-chart-deckgl/src/components/Legend.tsx:
##
@@ -106,6 +106,7 @@ const Legend = ({
michael-s-molina commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045601881
@kasiazjc @dpgaspar One thing I forgot to mention was about the loaded
columns. Apart from their names, their types are equality important because
they will inform users if th
justinpark commented on code in PR #27950:
URL: https://github.com/apache/superset/pull/27950#discussion_r1557947595
##
superset-frontend/plugins/plugin-chart-echarts/src/utils/TooltipRenderer.ts:
##
@@ -0,0 +1,151 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) und
mistercrunch commented on PR #27904:
URL: https://github.com/apache/superset/pull/27904#issuecomment-2045535414
Please open a new issue. You start by searching the codebase for
currency-related terms or symbol.
--
This is an automated message from the Apache Git Service.
To respond to the
kasiazjc commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2045477799
Thanks @michael-s-molina for the review and @dpgaspar for working on this!
>
> 1 - I know it's not part of this PR, but could you use this opportunity to
improve how the menu i
1 - 100 of 135 matches
Mail list logo
