villebro commented on issue #28047:
URL: https://github.com/apache/superset/issues/28047#issuecomment-2058220187
> Another needed example would be enabling accessibility features (e.g.
ECharts decals/patterns) since few would want to turn this on deployment-wide,
but any org would want thei
rusackas commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566700921
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-video
villebro commented on issue #28021:
URL: https://github.com/apache/superset/issues/28021#issuecomment-2058202680
Thanks for the summary @mistercrunch 👍 I hadn't thought of looking into
existing libraries/frameworks for the ABAC system. I'll look into these. I also
agree on getting started o
rusackas commented on PR #28045:
URL: https://github.com/apache/superset/pull/28045#issuecomment-2058176497
@sfirke happy to catch you and the gang up on this when you have time. It's
a drag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rusackas opened a new pull request, #28048:
URL: https://github.com/apache/superset/pull/28048
### SUMMARY
ASF doesn't want people to get tracked by Google, so they suggest
approximating [this
approach](https://privacy.apache.org/examples/youtube-html/with-youtube-embeds.html
rusackas merged PR #28045:
URL: https://github.com/apache/superset/pull/28045
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
villebro commented on issue #27245:
URL: https://github.com/apache/superset/issues/27245#issuecomment-2058166386
> @villebro That would probably work but I dispute the notion that #21093 is
problematic. The issue in #21093 can be solved in the query with a IFNULL and
the solution is disinge
mistercrunch commented on PR #27849:
URL: https://github.com/apache/superset/pull/27849#issuecomment-2058064791
@dpgaspar I addressed pretty much all feedback. Personally prefer avoiding
the CELERY_BEAT configuration, but open to consider that approach too if we
decide it's preferable.
--
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566593892
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user = bootstrap_user
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566593892
##
superset/views/users/api.py:
##
@@ -93,3 +97,85 @@ def get_my_roles(self) -> Response:
return self.response_401()
user = bootstrap_user
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566589124
##
tests/integration_tests/users/api_tests.py:
##
@@ -62,3 +63,23 @@ def test_get_me_anonymous(self, mock_g):
mock_g.user = security_manager.get_anonym
mistercrunch commented on code in PR #27849:
URL: https://github.com/apache/superset/pull/27849#discussion_r1566588802
##
superset/config.py:
##
@@ -1453,6 +1455,7 @@ def EMAIL_HEADER_MUTATOR( # pylint:
disable=invalid-name,unused-argument
"data:",
"h
EnxDev opened a new pull request, #28046:
URL: https://github.com/apache/superset/pull/28046
### SUMMARY
Migrate saveModalActions to TypeScript
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N.A
### TESTING INSTRUCTIONS
- All tests should pass
### ADDITION
rusackas opened a new pull request, #28045:
URL: https://github.com/apache/superset/pull/28045
### SUMMARY
Disabling Bugherd until ASF decides if/how we can proceed with a DPA.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
##
mistercrunch commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566517342
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-v
mistercrunch merged PR #28028:
URL: https://github.com/apache/superset/pull/28028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
bmschow opened a new issue, #28044:
URL: https://github.com/apache/superset/issues/28044
### Bug description
We are running Superset via helm chart (version 0.12.9) and running aurora
postgres on AWS as the database backend. In the UI we are able to successfully
test a connection.
boomrollkick opened a new issue, #28043:
URL: https://github.com/apache/superset/issues/28043
### Bug description
It looks like the code to upload the csv
mistercrunch commented on PR #28028:
URL: https://github.com/apache/superset/pull/28028#issuecomment-2057884597
I think the `time.sleep` did the trick, at least I was able to run manually
4 times without seeing an error. Might have been luck, but willing to try our
luck with merging this, a
mistercrunch commented on issue #28021:
URL: https://github.com/apache/superset/issues/28021#issuecomment-2057882229
As discussed this morning:
- overall we'd like to consider a federated model for all RBAC/ABAC,
including data access (database, catalog, schema, tables, RLS) and objects
mistercrunch commented on issue #28002:
URL: https://github.com/apache/superset/issues/28002#issuecomment-2057868627
Closing in favor of
[SIP-126](https://github.com/apache/superset/issues/28021) - a more federated
approach to RBAC/ABAC
--
This is an automated message from the Apache Git
dependabot[bot] opened a new pull request, #28042:
URL: https://github.com/apache/superset/pull/28042
Bumps [sqlparse](https://github.com/andialbrecht/sqlparse) from 0.4.4 to
0.5.0.
Changelog
Sourced from https://github.com/andialbrecht/sqlparse/blob/master/CHANGELOG";>sqlparse's
mistercrunch merged PR #27884:
URL: https://github.com/apache/superset/pull/27884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
eschutho merged PR #28018:
URL: https://github.com/apache/superset/pull/28018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
rusackas commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566346444
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-video
mistercrunch commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566327391
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-v
mistercrunch commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566327391
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-v
martinspudich commented on PR #28035:
URL: https://github.com/apache/superset/pull/28035#issuecomment-2057644089
@rusackas Hi, I add 'czech republic' to Jupyter notebook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rusackas commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566263491
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-video
rusackas commented on code in PR #27998:
URL: https://github.com/apache/superset/pull/27998#discussion_r1566262497
##
README.md:
##
@@ -70,8 +70,8 @@ Superset provides:
## Screenshots & Gifs
**Video Overview**
-
-https://github.com/apache/superset-site/raw/lfs/superset-video
rusackas commented on PR #28035:
URL: https://github.com/apache/superset/pull/28035#issuecomment-2057502207
Hi! These need to be added to the Jupyter notebook (which might be a
one-line edit, adding the country name), as the geojson files and TS files are
generated from there. If we don't d
rusackas commented on code in PR #28031:
URL: https://github.com/apache/superset/pull/28031#discussion_r1566230444
##
superset/sql_parse.py:
##
@@ -765,8 +765,8 @@ def _extract_tables_from_sql(self) -> set[Table]:
SupersetError(
error_type=S
rusackas commented on issue #28007:
URL: https://github.com/apache/superset/issues/28007#issuecomment-2057483124
If we have a workaround and can't fix this in Superset, we should probably
close it. Before I/we do, would anyone want to open a Documentation PR (or at
least suggestion) on [thi
rusackas commented on PR #28028:
URL: https://github.com/apache/superset/pull/28028#issuecomment-2057480658
Thanks for looking, this has been driving me nuts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rusackas commented on issue #28029:
URL: https://github.com/apache/superset/issues/28029#issuecomment-2057479148
Are you actually seeing a 500 in your logs? This seems truthful. According
to your error, it sounds like on line 420, you should throw a 403 and/or
redirect to the login page.
mistercrunch commented on code in PR #28028:
URL: https://github.com/apache/superset/pull/28028#discussion_r1566209128
##
.github/workflows/bashlib.sh:
##
@@ -89,6 +89,8 @@ EOF
setup-mysql() {
say "::group::Initialize database"
mysql -h 127.0.0.1 -P 13306 -u root --passwo
rusackas commented on PR #28038:
URL: https://github.com/apache/superset/pull/28038#issuecomment-2057457924
Thanks for opening this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
mistercrunch commented on code in PR #28028:
URL: https://github.com/apache/superset/pull/28028#discussion_r1566209128
##
.github/workflows/bashlib.sh:
##
@@ -89,6 +89,8 @@ EOF
setup-mysql() {
say "::group::Initialize database"
mysql -h 127.0.0.1 -P 13306 -u root --passwo
mistercrunch commented on PR #28028:
URL: https://github.com/apache/superset/pull/28028#issuecomment-2057448070
Didn't work! :( Still feel like there's something here, the intuition around
"why is mysql the only one that flakes on these specific tests!?" and something
around read uncommitte
mistercrunch merged PR #28039:
URL: https://github.com/apache/superset/pull/28039
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr
mistercrunch closed issue #28026: docker\.env-local not found
URL: https://github.com/apache/superset/issues/28026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mistercrunch commented on PR #28039:
URL: https://github.com/apache/superset/pull/28039#issuecomment-2057444308
docker-compose is getting very usable for dev workflows - having it boot
fast from my previous PR makes it much more viable too
--
This is an automated message from the Apache G
rusackas merged PR #28040:
URL: https://github.com/apache/superset/pull/28040
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
rusackas commented on code in PR #28041:
URL: https://github.com/apache/superset/pull/28041#discussion_r1566193585
##
.github/ISSUE_TEMPLATE/bug-report.yml:
##
@@ -46,7 +47,6 @@ body:
options:
- master / latest-dev
- "4.0.0"
-- "3.1.2"
Review Co
rusackas commented on code in PR #28041:
URL: https://github.com/apache/superset/pull/28041#discussion_r1566189262
##
RELEASING/email_templates/vote_pmc.j2:
##
@@ -39,7 +39,7 @@ https://github.com/apache/{{ project_module }}/blob/{{
version_rc }}/UPDATING.md
Public keys are av
rusackas commented on code in PR #28041:
URL: https://github.com/apache/superset/pull/28041#discussion_r1566184834
##
.github/ISSUE_TEMPLATE/bug-report.yml:
##
@@ -7,6 +7,7 @@ body:
value: |
Hello Superset Community member! Please keep things tidy by putting
you
rusackas commented on PR #28039:
URL: https://github.com/apache/superset/pull/28039#issuecomment-2057426071
@artofcomputing please feel free to leave a review if you're so inclined :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
mistercrunch commented on code in PR #28039:
URL: https://github.com/apache/superset/pull/28039#discussion_r1566168336
##
.gitignore:
##
@@ -110,7 +110,6 @@ release.json
messages.mo
docker/requirements-local.txt
-docker/.env-local
Review Comment:
turns out that's covered
michael-s-molina opened a new pull request, #28041:
URL: https://github.com/apache/superset/pull/28041
### SUMMARY
Following the [Release Process changes
discussion](https://github.com/apache/superset/discussions/27769), this PR:
- Adds instructions to report security issues
- Remov
artofcomputing commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2057308690
Hm I think it would be really good to keep it as optional. It's a neat idea
to have a .env-local for overrides, IMO makes customizing the environment much
easier.
--
Thi
Always-prog commented on PR #27779:
URL: https://github.com/apache/superset/pull/27779#issuecomment-2057285996
@rusackas I see, ok. I have pushed commit with the fix :+1:, please take a
look!
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mistercrunch commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2057283533
Oh nice, I saw you message after I published my fix, I may keep it then,
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
mistercrunch commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2057276333
Ok https://github.com/apache/superset/pull/28039 should address this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
esivakumar26 opened a new pull request, #28040:
URL: https://github.com/apache/superset/pull/28040
### SUMMARY
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
-
mistercrunch opened a new pull request, #28039:
URL: https://github.com/apache/superset/pull/28039
As reported here https://github.com/apache/superset/issues/28026, in
https://github.com/apache/superset/pull/27953 I added support for a
supplemental `docker/.env-local` override file, not
artofcomputing commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2057238606
Ah that makes sense, it's due to Docker Compose making any environment file
a hard requirement.
You can make the file optional by specifying it on the `required` attr
geido merged PR #28015:
URL: https://github.com/apache/superset/pull/28015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@sup
github-actions[bot] commented on PR #28015:
URL: https://github.com/apache/superset/pull/28015#issuecomment-2057194380
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
giftig commented on PR #28034:
URL: https://github.com/apache/superset/pull/28034#issuecomment-2057192659
Since this clearly wasn't intended as a real PR I'll close it but feel free
to open a new PR if you'd like to contribute.
--
This is an automated message from the Apache Git Service.
giftig closed pull request #28034: Test branch
URL: https://github.com/apache/superset/pull/28034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifi
github-actions[bot] commented on PR #28015:
URL: https://github.com/apache/superset/pull/28015#issuecomment-2057160906
@geido Ephemeral environment spinning up at http://54.188.208.226:8080.
Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping
and startup.
--
T
mistercrunch commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2057159641
It wasn't my intention to make it required. Until An empty file should do
the trick until I find a better solution, so just `touch docker/.env-local` for
now and you're back
geido commented on PR #28015:
URL: https://github.com/apache/superset/pull/28015#issuecomment-2057142553
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mtrentz commented on PR #23064:
URL: https://github.com/apache/superset/pull/23064#issuecomment-2057114328
@rusackas opened this one #28038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mtrentz opened a new pull request, #28038:
URL: https://github.com/apache/superset/pull/28038
### SUMMARY
Previously when the value of a BigNumber was zero (falsey) the expression to
evaluate colors always got evaluated to false. Meaning that if my condition was
`number <= 50` and my num
Rydberg95 commented on issue #23384:
URL: https://github.com/apache/superset/issues/23384#issuecomment-2056961849
> Can be fixed on ClickHouse side, with override default value for property
**prefer_column_name_to_alias**
>
> via user setting for default profile
>
> ```
>
xavier-GitHub76 opened a new issue, #28037:
URL: https://github.com/apache/superset/issues/28037
### Bug description
Hello,
with superset v3.0.0, I create an user with essential permission (cf.
https://github.com/apache/superset/issues/27765), an access on a dataset is
created
betodealmeida merged PR #27908:
URL: https://github.com/apache/superset/pull/27908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubsc
michael-s-molina opened a new pull request, #28036:
URL: https://github.com/apache/superset/pull/28036
### SUMMARY
Fixes a bug where a filter was not showing all values on blur/clear events
when the `Dynamically search all filter values` option is checked.
Fix https://github.com/ap
michael-s-molina merged PR #28017:
URL: https://github.com/apache/superset/pull/28017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsu
artofcomputing commented on issue #28026:
URL: https://github.com/apache/superset/issues/28026#issuecomment-2056678200
Related to changes done in #27953.
@mistercrunch should the docker/.env-local file be a hard requirement since
it acts as a overwrite file? We might need to update th
martinspudich opened a new pull request, #28035:
URL: https://github.com/apache/superset/pull/28035
### SUMMARY
Add Czech Republic country map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
coderwolf786 opened a new pull request, #28034:
URL: https://github.com/apache/superset/pull/28034
Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Hardik94 opened a new issue, #28033:
URL: https://github.com/apache/superset/issues/28033
### Bug description
We have existing Superset 2.0.1 Installed on cluster and docker was working
fine. Due to new release and some more features. we have tried to move to
Superset 3.0.3
w
NikoJ commented on issue #23384:
URL: https://github.com/apache/superset/issues/23384#issuecomment-2056479582
@rusackas Thanks! When I have free time, I will check it and then close this
issue as solved if everything is ok.
--
This is an automated message from the Apache Git Service.
To r
github-actions[bot] commented on PR #27840:
URL: https://github.com/apache/superset/pull/27840#issuecomment-2056210344
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
dpgaspar merged PR #27840:
URL: https://github.com/apache/superset/pull/27840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
lscheibel opened a new pull request, #28031:
URL: https://github.com/apache/superset/pull/28031
### SUMMARY
This PR does two things:
1. fixes a use of f-strings in sql_parse.py which causes pybabel to error.
(See https://github.com/python-babel/babel/issues/715 for why.)
2. reorders
kanishk-aidash opened a new issue, #28030:
URL: https://github.com/apache/superset/issues/28030
### Bug description
While trying to setup Superset with Amazon Redshift Cluster, I am running
into the following error:
>
2024-04-15 13:31:10,401:ERROR:flask_appbuilder.security
berlicon commented on issue #28007:
URL: https://github.com/apache/superset/issues/28007#issuecomment-2056026397
OK, I fixed it with workaround:
1. in `superset/sql_lab.py` add this:
import re-- row №25
`sql = add_sleep_to_selects_in_sql(sql)`-- row №264 in
`execute_
80 matches
Mail list logo
