Re: [PR] feat(actions): auto-label PRs that close issues. [superset]

2024-08-02 Thread via GitHub
rusackas closed pull request #27047: feat(actions): auto-label PRs that close issues. URL: https://github.com/apache/superset/pull/27047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] failed to solve: process "/bin/sh -c npm run ${BUILD_CMD}" did not complete successfully: exit code: 1 [superset]

2024-08-02 Thread via GitHub
enricozab commented on issue #29825: URL: https://github.com/apache/superset/issues/29825#issuecomment-2266357294 I'm using Windows 11 and Docker Desktop with WSL2. I have already set the memory to 12GB (even tried up to 16GB) but I still get stuck at that part. It doesn't crash, it's just

Re: [PR] refactor(ChartCreation): Migrate tests to RTL [superset]

2024-08-02 Thread via GitHub
rtexelm merged PR #29674: URL: https://github.com/apache/superset/pull/29674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@s

Re: [PR] fix: load slack channels earlier [superset]

2024-08-02 Thread via GitHub
sadpandajoe commented on PR #29846: URL: https://github.com/apache/superset/pull/29846#issuecomment-2266301927 @supersetbot label 4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] fix: load slack channels earlier [superset]

2024-08-02 Thread via GitHub
eschutho opened a new pull request, #29846: URL: https://github.com/apache/superset/pull/29846 ### SUMMARY Loading slack channels earlier to ensure that the method dropdowns have the correct value when they are loaded. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Re: [PR] refactor(controls): Migrate AdhocMetricOption.test to RTL [superset]

2024-08-02 Thread via GitHub
rtexelm merged PR #29843: URL: https://github.com/apache/superset/pull/29843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@s

Re: [PR] refactor(controls): Migrate MetricDefinitionValue.test to RTL [superset]

2024-08-02 Thread via GitHub
rtexelm merged PR #29845: URL: https://github.com/apache/superset/pull/29845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@s

Re: [PR] fix: Download to CSV shows a special Chinese characters [superset]

2024-08-02 Thread via GitHub
mistercrunch closed pull request #29506: fix: Download to CSV shows a special Chinese characters URL: https://github.com/apache/superset/pull/29506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] fix: Download to CSV shows a special Chinese characters [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on PR #29506: URL: https://github.com/apache/superset/pull/29506#issuecomment-2266265591 Closing for now, happy to push Werkzeug dependency forward when the fix is in -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] chore(translations): Arabic translations [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on PR #29586: URL: https://github.com/apache/superset/pull/29586#issuecomment-2266264490 Somehow conflicting with something, happy to semi-blindly merge if/when conflicts are resolved -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] build(deps-dev): update @babel/types requirement from ^7.24.5 to ^7.25.2 in /superset-frontend/plugins/plugin-chart-pivot-table [superset]

2024-08-02 Thread via GitHub
mistercrunch merged PR #29808: URL: https://github.com/apache/superset/pull/29808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] chore(cleanup): Removing bootstrap (experimental) [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on PR #29844: URL: https://github.com/apache/superset/pull/29844#issuecomment-2266260543 ![clean](https://github.com/user-attachments/assets/e32cd059-9fb7-4c5d-bc67-fbb26bafb995) -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] fix: Removed fixed width constraint from Save button [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on PR #29686: URL: https://github.com/apache/superset/pull/29686#issuecomment-2266258007 Yup here's a link to it for reference. https://github.com/apache/superset/blob/master/superset-frontend/src/components/DropdownButton/index.tsx#L38 Curious why it's there

Re: [I] Drill to detail gives error on some charts when using Druid. [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #27416: URL: https://github.com/apache/superset/issues/27416#issuecomment-2266254267 I think drill to details adds in "Calculated Columns" defined in at the dataset level and will fail if there's an error in any of them. I just hit a similar issue and deletin

[PR] refactor(controls): Migrate MetricDefinitionValue.test to RTL [superset]

2024-08-02 Thread via GitHub
rtexelm opened a new pull request, #29845: URL: https://github.com/apache/superset/pull/29845 ### SUMMARY Convert tests to RTL ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS Run tests ### ADDITIONAL INFORMATION -

[PR] chore(cleanup): Removing bootstrap (experimental) [superset]

2024-08-02 Thread via GitHub
rusackas opened a new pull request, #29844: URL: https://github.com/apache/superset/pull/29844 ### SUMMARY I'm running this locally, and I don't see any trouble yet. Let's see if it passes CI! ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTI

Re: [PR] fix: machine auth for GAQ enabled deployments [superset]

2024-08-02 Thread via GitHub
villebro merged PR #29591: URL: https://github.com/apache/superset/pull/29591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[PR] refactor(controls): Migrate AdhocMetricOption.test to RTL [superset]

2024-08-02 Thread via GitHub
rtexelm opened a new pull request, #29843: URL: https://github.com/apache/superset/pull/29843 ### SUMMARY Converts the current tests to use RTL ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS Run tests ### ADDITIONAL INFORMA

[PR] chore(deps): bump bootstrap (experimental) [superset]

2024-08-02 Thread via GitHub
rusackas opened a new pull request, #29842: URL: https://github.com/apache/superset/pull/29842 ### SUMMARY Just experimentally bumping bootstrap, to reduce CVEs. No idea if this will work, but will check on an ephemeral. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Re: [PR] fix: Chart cache-warmup task fails on Superset 4.0 [superset]

2024-08-02 Thread via GitHub
villebro commented on PR #28706: URL: https://github.com/apache/superset/pull/28706#issuecomment-2266208909 @rmasters this needs a rebase, and I don't have permissions to push changes to your branch to do it. Can you rebase, and optionally make that `utils` refactor? -- This is an automa

Re: [PR] fix: Chart cache-warmup task fails on Superset 4.0 [superset]

2024-08-02 Thread via GitHub
villebro commented on code in PR #28706: URL: https://github.com/apache/superset/pull/28706#discussion_r1702365181 ## superset/tasks/cache.py: ## @@ -212,14 +212,38 @@ def get_payloads(self) -> list[dict[str, int]]: strategies = [DummyStrategy, TopNDashboardsStrategy, Dashboard

[PR] chore(deps): bumping jquery [superset]

2024-08-02 Thread via GitHub
rusackas opened a new pull request, #29841: URL: https://github.com/apache/superset/pull/29841 ### SUMMARY Picking this up from the stale PR here https://github.com/apache/superset/pull/18057 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIO

[PR] WIP [superset]

2024-08-02 Thread via GitHub
betodealmeida opened a new pull request, #29840: URL: https://github.com/apache/superset/pull/29840 ### SUMMARY ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TESTING INSTRUCTIONS ### ADDITIONAL INFORMATION - [ ] Has associated issue: -

[I] [SIP] Global Async Task Framework [superset]

2024-08-02 Thread via GitHub
villebro opened a new issue, #29839: URL: https://github.com/apache/superset/issues/29839 ## [SIP] Proposal for Global Async Task Framework ### Motivation *Note*: This replaces [[SIP-141] Global Async Queries 2.0](#29515) which aimed at completing [[SIP-39] Global Async Query S

Re: [PR] chore(deps): npm audit fix results [superset]

2024-08-02 Thread via GitHub
rusackas merged PR #29838: URL: https://github.com/apache/superset/pull/29838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] fix: pass slack recipients correctly [superset]

2024-08-02 Thread via GitHub
eschutho merged PR #29721: URL: https://github.com/apache/superset/pull/29721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [I] [SIP-142] Improving Database Migration Management [superset]

2024-08-02 Thread via GitHub
michael-s-molina commented on issue #29546: URL: https://github.com/apache/superset/issues/29546#issuecomment-2265853714 > PRs introducing database migrations must include runtime estimates and downtime expectations. @mistercrunch that's what I'm currently doing while testing 4.1. If

Re: [I] failed to solve: process "/bin/sh -c npm run ${BUILD_CMD}" did not complete successfully: exit code: 1 [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #29825: URL: https://github.com/apache/superset/issues/29825#issuecomment-2265848286 Does it crash/gets killed? Seems memory-related too or more inderectly swapping if it's just coming to a crawl. We'll need a way to control/diminish memory usage when b

Re: [I] [SIP-142] Improving Database Migration Management [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #29546: URL: https://github.com/apache/superset/issues/29546#issuecomment-2265816516 Oh I just found prior art here https://github.com/apache/superset/issues/13351 > PRs introducing database migrations must include runtime estimates and downtime expect

Re: [I] [SIP-142] Improving Database Migration Management [superset]

2024-08-02 Thread via GitHub
rusackas commented on issue #29546: URL: https://github.com/apache/superset/issues/29546#issuecomment-2265812261 > @michael-s-molina I added the section "Considerations for large environments:". I'm removing the DRAFT tag and will open a PR setting us up as CODEOWNERS There's also a

Re: [I] [DRAFT][SIP-142] Improving Database Migration Management [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #29546: URL: https://github.com/apache/superset/issues/29546#issuecomment-2265807184 @michael-s-molina I added the section "Considerations for large environments:". I'm removing the DRAFT tag and will open a PR setting us up as CODEOWNERS -- This is an aut

Re: [I] No module named 's3cache' [superset]

2024-08-02 Thread via GitHub
rusackas commented on issue #29835: URL: https://github.com/apache/superset/issues/29835#issuecomment-2265796605 This is a completely wild and uneducated guess, but does `from s3cache.s3cache import S3Cache` happen to work? That's what it looks like in [these docs](https://pypi.org/project/

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
betodealmeida commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1702099935 ## superset/db_engine_specs/databricks.py: ## @@ -434,7 +434,25 @@ def get_default_catalog( cls, database: Database, ) -> str | None: +

Re: [I] [DRAFT][SIP-142] Improving Database Migration Management [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #29546: URL: https://github.com/apache/superset/issues/29546#issuecomment-2265793204 Relevant: https://github.com/apache/superset/issues/29801#issuecomment-2263052989 - posting this here and editing the SIP to tackle this type of issue -- This is an automa

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
betodealmeida commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1702090563 ## pyproject.toml: ## @@ -236,7 +236,7 @@ legacy_tox_ini = """ # Remember to start celery workers to run celery tests, e.g. # celery --app=superset.tasks.cel

Re: [I] [SIP-141] Simplified Global Async Queries [superset]

2024-08-02 Thread via GitHub
villebro commented on issue #29515: URL: https://github.com/apache/superset/issues/29515#issuecomment-2265732362 We are closing this SIP and will be opening a new one to reflect a new direction that was established during discussions. But in summary: - WebSockets will remain as is, pollin

Re: [I] [SIP-141] Simplified Global Async Queries [superset]

2024-08-02 Thread via GitHub
villebro closed issue #29515: [SIP-141] Simplified Global Async Queries URL: https://github.com/apache/superset/issues/29515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] chore(build): uplift several outdated frontend packages [superset]

2024-08-02 Thread via GitHub
hainenber commented on PR #29652: URL: https://github.com/apache/superset/pull/29652#issuecomment-2265713197 `npm install`-ed but sadly the CI had a Chrome crash during 1st E2E :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Superset app loads infinitely or throws unexpected error occasionally. Ver. 3.1.2 [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on issue #28259: URL: https://github.com/apache/superset/issues/28259#issuecomment-2265711907 > the JS Chunk load errors have become so severe I thought the JS Chunk load errors would be corollated to [how many users have an active browser open updates] * [how

Re: [PR] fix: set default timezone to UTC for cron timezone conversions [superset]

2024-08-02 Thread via GitHub
mistercrunch commented on PR #29798: URL: https://github.com/apache/superset/pull/29798#issuecomment-2265704387 I just created a new `hold:updating.md` label we can use that should prevent merging without having to do a "requires changes" review -- This is an automated message from the Ap

[PR] chore(deps): npm audit fix results [superset]

2024-08-02 Thread via GitHub
rusackas opened a new pull request, #29838: URL: https://github.com/apache/superset/pull/29838 ### SUMMARY Just a good ol' `npm audit fix` as we should do periodically. Removes two `high` level dependencies. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF ### TE

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
Vitor-Avila commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1701959131 ## superset/db_engine_specs/databricks.py: ## @@ -434,7 +434,25 @@ def get_default_catalog( cls, database: Database, ) -> str | None: +

Re: [PR] fix: create permissions on DB import [superset]

2024-08-02 Thread via GitHub
Vitor-Avila commented on code in PR #29802: URL: https://github.com/apache/superset/pull/29802#discussion_r1701945638 ## pyproject.toml: ## @@ -236,7 +236,7 @@ legacy_tox_ini = """ # Remember to start celery workers to run celery tests, e.g. # celery --app=superset.tasks.celer

Re: [I] Database Issue when using mariadb 10.4, illegal mixx [superset]

2024-08-02 Thread via GitHub
sfirke commented on issue #29483: URL: https://github.com/apache/superset/issues/29483#issuecomment-2265284640 Thank you for sharing what worked for you! Until Superset is tested continuously to work with MariaDB, I would be worried about people setting up new instances using it as a backe

Re: [I] No module named 's3cache' [superset]

2024-08-02 Thread via GitHub
rajivpatki commented on issue #29835: URL: https://github.com/apache/superset/issues/29835#issuecomment-2265239548 Try ```bash pip install --no-cache-dir s3werkzeugcache ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] fix: set default timezone to UTC for cron timezone conversions [superset]

2024-08-02 Thread via GitHub
michael-s-molina commented on PR #29798: URL: https://github.com/apache/superset/pull/29798#issuecomment-2265231752 I'm sorry @mistercrunch, I think I missed your comment. I agree that a comment in `UPDATING.md` is necessary. @danielli-ziprecruiter could you open a follow-up please? -- T

Re: [I] Superset app loads infinitely or throws unexpected error occasionally. Ver. 3.1.2 [superset]

2024-08-02 Thread via GitHub
philicious commented on issue #28259: URL: https://github.com/apache/superset/issues/28259#issuecomment-2265205195 Since upgrading to 4.x, the JS Chunk load errors have become so severe that we had to downgrade again. (We have several dozen users and use auto-refreshing dashboards alot)

Re: [I] failed to solve: process "/bin/sh -c npm run ${BUILD_CMD}" did not complete successfully: exit code: 1 [superset]

2024-08-02 Thread via GitHub
enricozab commented on issue #29825: URL: https://github.com/apache/superset/issues/29825#issuecomment-2265089931 I have also fixed this issue by increasing my WSL memory. However, I encounter this issue where I get stuck at "**[webpack.Progress] 94% sealing after seal**". ![image](

Re: [I] Installing latest superset via helm, cant connect to azure redis service via ssl [superset]

2024-08-02 Thread via GitHub
pgagarinov commented on issue #25375: URL: https://github.com/apache/superset/issues/25375#issuecomment-2265072321 Same problem here with connecting to AWS Redis with Auth and in-transit encryption enabled. Setting ssl_cert_reqs to none works. -- This is an automated message from the Apa

Re: [I] user_favorite_tag table not created after "superset db upgrade" when upgrade superset 3.0.1 to 4.0.2 on docker [superset]

2024-08-02 Thread via GitHub
dosubot[bot] commented on issue #29836: URL: https://github.com/apache/superset/issues/29836#issuecomment-2265028803 Hey @jinmengcheng! I'm here to help you with any bugs, questions, or contributions you may have regarding the Superset upgrade. Let's work together to solve this issue!

[I] user_favorite_tag table not created after "superset db upgrade" when upgrade superset 3.0.1 to 4.0.2 on docker [superset]

2024-08-02 Thread via GitHub
jinmengcheng opened a new issue, #29836: URL: https://github.com/apache/superset/issues/29836 ### Bug description Hi Superset developers: I am trying to upgrade superset 3.0.1 to 4.0.2, main features looks good so far, but there is a small problem when I am trying to use Tag system

Re: [I] No module named 's3cache' [superset]

2024-08-02 Thread via GitHub
hieuthanhpro commented on issue #29835: URL: https://github.com/apache/superset/issues/29835#issuecomment-2265000244 but it have bugs: ![image](https://github.com/user-attachments/assets/2bb1f5c9-54c7-4ad2-8446-3d28eee192f6) Found but failed to import local superset_config Traceback

Re: [I] No module named 's3cache' [superset]

2024-08-02 Thread via GitHub
dosubot[bot] commented on issue #29835: URL: https://github.com/apache/superset/issues/29835#issuecomment-2264991382 The error `ModuleNotFoundError: No module named 's3cache'` indicates that the `s3cache` module is not installed in your environment. The `s3cache` module is an external d

[I] No module named 's3cache' [superset]

2024-08-02 Thread via GitHub
hieuthanhpro opened a new issue, #29835: URL: https://github.com/apache/superset/issues/29835 ### Bug description when I use: from s3cache.s3cache import S3Cache logs is: ModuleNotFoundError: No module named 's3cache' thank you! ### How to reproduce the bug 1. code:

Re: [PR] fix: Add user filtering to changed_by. Fixes #27986 [superset]

2024-08-02 Thread via GitHub
marre commented on PR #29287: URL: https://github.com/apache/superset/pull/29287#issuecomment-2264889422 Noticed that I had a typo in the first sentence of the description. I wrote "modified-by" where I intended "owner" and vice-versa. Corrected in description. -- This is an automated mes

Re: [PR] fix: Add user filtering to changed_by. Fixes #27986 [superset]

2024-08-02 Thread via GitHub
marre commented on PR #29287: URL: https://github.com/apache/superset/pull/29287#issuecomment-2264821230 @sadpandajoe Would really love to have this in 4.1... @bruno-santos-6 What version of superset are you testing with? Just pulled latest from superset/superset (master branch)

Re: [I] Login page loops indefinitely [superset]

2024-08-02 Thread via GitHub
k-e-das commented on issue #24579: URL: https://github.com/apache/superset/issues/24579#issuecomment-2264775075 We haven't found any Content Security Policy (CSP) defined in the configurations. Please make sure to configure CSP using the TALISMAN_ENABLED and TALISMAN_CONFIG keys or any