[GitHub] [zookeeper] w6et commented on pull request #1774: ZOOKEEPER-4409 NullPointerException in SendAckRequestProcessor

2023-06-29 Thread via GitHub
w6et commented on PR #1774: URL: https://github.com/apache/zookeeper/pull/1774#issuecomment-1613614104 Maybe it's not a threads concurrently issue,just network broken from follower to leader (As @maoling guessed,I think so too),learner.sock has been closed or assigned to null in Follower#f

[GitHub] [zookeeper] horizonzy opened a new pull request, #2025: ZOOKEEPER-4715: Verify file size and position in testGetCurrentLogSize.

2023-06-29 Thread via GitHub
horizonzy opened a new pull request, #2025: URL: https://github.com/apache/zookeeper/pull/2025 This is pre-PR for #2024. In #2024, we maintain fileSize and filePosition ourselves, and we want our values to match the original values. Therefore, we added checks for fileSize and filePos

[GitHub] [zookeeper] horizonzy closed pull request #2021: Reduce outstanding changes race condition

2023-06-29 Thread via GitHub
horizonzy closed pull request #2021: Reduce outstanding changes race condition URL: https://github.com/apache/zookeeper/pull/2021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [zookeeper] horizonzy commented on pull request #2024: ZOOKEEPER-4714 Improve syncRequestProcessor performance

2023-06-29 Thread via GitHub
horizonzy commented on PR #2024: URL: https://github.com/apache/zookeeper/pull/2024#issuecomment-1613450794 I used the following code as a performance benchmark, and started a standalone zookeeper on my laptop. https://github.com/horizonzy/zookeeper/commit/affbb05a1b7f7f3f97fa79f41229169

[GitHub] [zookeeper] horizonzy opened a new pull request, #2024: ZOOKEEPER-4714 Improve syncRequestProcessor performance

2023-06-29 Thread via GitHub
horizonzy opened a new pull request, #2024: URL: https://github.com/apache/zookeeper/pull/2024 Motivation: 1. Maintain file size by self. 2. Maintain file position by self. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t