Filter one-post thread only ?

2011-12-23 Thread Jani Nikula
On Thu, 22 Dec 2011 21:45:14 +0100, Xavier Maillard wrote: > Hi, > > In order to clean up and to trash out as many posts as possible in > several mailing lists I did not check lately, I am trying to find a way > to limit the current display to messages matching this requirements: > > 1. post old

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson
sc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/76cbdf95/attachment.pgp>

[PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread David Edmondson
vailable URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/6df08b62/attachment.pgp>

Filter one-post thread only ?

2011-12-23 Thread David Edmondson
simple (especially in elisp), but you'd still have to write it. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/0cb4b0a6/attachment.pgp>

ANNOUNCE: nottoomuch-addresses.sh version 1.5

2011-12-23 Thread Tomi Ollila
nottoomuch-addresses.sh -- email address substring matcher -- completion helper version 1.5 is available. This version exits with return value 0 in case matches were not found (previous returned with 1). Location: http://www.iki.fi/too/nottoomuch/nottoomuch-addresses.sh Sha1sum: 49ac32568142bf5

[PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard
Hi Jameson, On Thu, 22 Dec 2011 20:55:48 -0800, Jameson Graef Rollins wrote: > Since message-ids necessarily match just a single message, there's no > reason to do a search for the id before viewing the actual message; > the search just becomes an extra screen to click through. Clicking on > an

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard
Hi David, On Fri, 23 Dec 2011 07:48:49 +, David Edmondson wrote: > On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins finestructure.net> wrote: > > Since message-ids necessarily match just a single message, there's no > > reason to do a search for the id before viewing the actual mess

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson
; WDYT ? I was talking nonsense. `notmuch-show' will show the full thread but only the matching message open. Jesse: Sorry for the noise - the patch looks good to me. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/aa656d62/attachment-0001.pgp>

[PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread Tomi Ollila
On Fri, 23 Dec 2011 08:10:33 +, David Edmondson wrote: > Sorry for being slow. > > Can you describe the situation in which you expect a write to stderr to > be a short write? (Without error.) In the following hypothetical case (correct me if I'm wrong :): * There is 4096 byte buffer in tty

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread David Bremner
On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay wrote: > Text properties change between characters; prev-s-c-property-change > returns the position after the change. Thus, it is still inside the > invisible region. Pushed, d

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread Dmitry Kurochkin
Hi Aaron. Thanks for the fix. Would be nice to have a test for it :) Regards, Dmitry

[PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread Dmitry Kurochkin
Hi Aaron. Thanks for the fix. Would be nice to have a test for it :) Regards, Dmitry

S/MIME support in notmuch

2011-12-23 Thread Dan Bryant
On Wed, 21 Dec 2011 06:51:01 -0500, Darren McGuicken wrote: > On Wed, 07 Dec 2011 21:58:03 -0500, Dan Bryant > wrote: > > I'd like to report some success on getting S/MIME signature > > verification working using notmuch and the recently-released GMime > > 2.6. I specifically tested with notmuch

Question : Tag mail according to it directory path ?

2011-12-23 Thread Emmanuel Leblond
Thanks for the answer, it's exactly what I was looking for ! Regards -- G.bleu

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-23 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine how they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- Switched back to using `previous-single-char-property-change' now that Aaron explained it. Fix a bug rewi

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-23 Thread Dmitry Kurochkin
Hi David. On Fri, 23 Dec 2011 18:41:52 +, David Edmondson wrote: > The advance/rewind functions had become complex, which made it hard to > determine how they are expected to behave. Re-implement them simply in > order to poll user-experience and expectation. > --- > > Switched back to using

[PATCH 1/5] Fix comments about what is stored in the database

2011-12-23 Thread David Bremner
On Tue, 13 Dec 2011 18:11:41 +0100, Thomas Jost wrote: > Commit 567bcbc2 introduced two new values for each message (content of the > "From" and "Subject" headers), but the comments about the database schema had > not been updated accordingly. Pushed this one. d

[PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread Dmitry Kurochkin
Hi Austin. On Thu, 22 Dec 2011 15:15:48 -0500, Austin Clements wrote: > Even if we don't care about errors from write(2), it's still necessary > to handle short writes in order to use write correctly. Some versions > of glibc even mark write as warn_unused_result because of this, so our > previo

[PATCH] emacs: fix docstring for `notmuch-search-line-faces'.

2011-12-23 Thread David Edmondson
Looks obviously correct. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/a173dda6/attachment.pgp>

nmbug changes

2011-12-23 Thread David Bremner
part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 315 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/5248d8b6/attachment.pgp>

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
Thanks for the thorough review! Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: > Hi Austin. > > +/* The number of children of this part. */ > +int children; > > Consider renaming to children_count or similar to make it clear that it > is a counter and not the actual children. Good point.

[PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
Quoth Jameson Graef Rollins on Dec 10 at 1:17 pm: > On Sat, 10 Dec 2011 03:25:48 +0400, Dmitry Kurochkin gmail.com> wrote: > > + out->is_encrypted = TRUE; > > + out->is_signed = TRUE; > > > > These are set only if we do decryption/verification. But their > > names and commen

[PATCH 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-23 Thread Austin Clements
Quoth Dmitry Kurochkin on Dec 10 at 3:43 pm: > On Fri, 9 Dec 2011 14:54:27 -0500, Austin Clements > wrote: > > This function matches how we number parts for the --part argument to > > show. It will allow us to jump directly to the desired part, rather > > than traversing the entire tree and ca

[PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface.

2011-12-23 Thread Austin Clements
Quoth Dmitry Kurochkin on Dec 11 at 2:34 pm: > Hi Austin. > > I enjoyed reviewing this patch. It is a pleasure to see how complex and > confusing code becomes much smaller and cleaner. > > I still have some questions with the new code. It seems confusing to me > that part_content is called fir

[PATCH v4 0/4] First step of 'show' rewrite

2011-12-23 Thread Austin Clements
This addresses Dmitry's and Jameson's review comments from id:"87k46572f7.fsf at gmail.com" id:"87liqk5dly.fsf at servo.finestructure.net" id:"87hb187iu6.fsf at gmail.com" and rebases to current master. I'd like a quick eye over this to make sure I didn't screw anything up in the latest vers

[PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body.

2011-12-23 Thread Austin Clements
In addition to simplifying the code, we'll need the notmuch_message_t* in show_message_body shortly. --- notmuch-client.h |2 +- notmuch-reply.c |3 +-- notmuch-show.c |3 +-- show-message.c |3 ++- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/notmuch-client.

[PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
This wraps all of the complex MIME part handling in a single, simple function that gets part N from *any* MIME object, so traversing a MIME part tree becomes a two-line for loop. Furthermore, the MIME node structure provides easy access to envelopes for message parts as well as cryptographic infor

[PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-23 Thread Austin Clements
This function matches how we number parts for the --part argument to show. It will allow us to jump directly to the desired part, rather than traversing the entire tree and carefully tracking whether or not we're "in the zone". --- mime-node.c | 27 +++ notmuch-clie

[PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface.

2011-12-23 Thread Austin Clements
This removes all of the MIME traversal logic from show_message_body and leaves only its interaction with the format callbacks. Besides isolating concerns, since traversal happens behind a trivial interface, there is now much less code duplication in show_message_part. Also, this uses mime_node_se

[PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Jameson Graef Rollins
nature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/e7a285a1/attachment.pgp>

[PATCH v4 0/4] First step of 'show' rewrite

2011-12-23 Thread Jameson Graef Rollins
pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20111223/e5973c3e/attachment.pgp>

Re: [PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread David Edmondson
Sorry for being slow. Can you describe the situation in which you expect a write to stderr to be a short write? (Without error.) In that situation, what guarantee is there that the loop you've written will terminate? We're not talking about safeguarding a users' data here - this is a short messa

Re: Filter one-post thread only ?

2011-12-23 Thread David Edmondson
On Thu, 22 Dec 2011 21:45:14 +0100, Xavier Maillard wrote: > In order to clean up and to trash out as many posts as possible in > several mailing lists I did not check lately, I am trying to find a way > to limit the current display to messages matching this requirements: > > 1. post older than 1

ANNOUNCE: nottoomuch-addresses.sh version 1.5

2011-12-23 Thread Tomi Ollila
nottoomuch-addresses.sh -- email address substring matcher -- completion helper version 1.5 is available. This version exits with return value 0 in case matches were not found (previous returned with 1). Location: http://www.iki.fi/too/nottoomuch/nottoomuch-addresses.sh Sha1sum: 49ac32568142bf5

Re: [PATCH] emacs: call notmuch-show instead notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard
Hi Jameson, On Thu, 22 Dec 2011 20:55:48 -0800, Jameson Graef Rollins wrote: > Since message-ids necessarily match just a single message, there's no > reason to do a search for the id before viewing the actual message; > the search just becomes an extra screen to click through. Clicking on > an

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard
Hi David, On Fri, 23 Dec 2011 07:48:49 +, David Edmondson wrote: > On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins > wrote: > > Since message-ids necessarily match just a single message, there's no > > reason to do a search for the id before viewing the actual message; > > the sea

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson
On Fri, 23 Dec 2011 11:10:53 +0100, Xavier Maillard wrote: > Hi David, > > On Fri, 23 Dec 2011 07:48:49 +, David Edmondson wrote: > > On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins > > wrote: > > > Since message-ids necessarily match just a single message, there's no > > > reaso

Re: [PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread Tomi Ollila
On Fri, 23 Dec 2011 08:10:33 +, David Edmondson wrote: > Sorry for being slow. > > Can you describe the situation in which you expect a write to stderr to > be a short write? (Without error.) In the following hypothetical case (correct me if I'm wrong :): * There is 4096 byte buffer in tty

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread David Bremner
On Thu, 22 Dec 2011 09:24:20 -0500, Aaron Ecay wrote: > Text properties change between characters; prev-s-c-property-change > returns the position after the change. Thus, it is still inside the > invisible region. Pushed, d ___ notmuch mailing list n

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread Dmitry Kurochkin
Hi Aaron. Thanks for the fix. Would be nice to have a test for it :) Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: fix off-by-one bug in notmuch-show-archive

2011-12-23 Thread Dmitry Kurochkin
Hi Aaron. Thanks for the fix. Would be nice to have a test for it :) Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: S/MIME support in notmuch

2011-12-23 Thread Dan Bryant
On Wed, 21 Dec 2011 06:51:01 -0500, Darren McGuicken wrote: > On Wed, 07 Dec 2011 21:58:03 -0500, Dan Bryant wrote: > > I'd like to report some success on getting S/MIME signature > > verification working using notmuch and the recently-released GMime > > 2.6. I specifically tested with notmuch-0

Re: Question : Tag mail according to it directory path ?

2011-12-23 Thread Emmanuel Leblond
Thanks for the answer, it's exactly what I was looking for ! Regards -- G.bleu ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-23 Thread David Edmondson
The advance/rewind functions had become complex, which made it hard to determine how they are expected to behave. Re-implement them simply in order to poll user-experience and expectation. --- Switched back to using `previous-single-char-property-change' now that Aaron explained it. Fix a bug rewi

Re: [RFC][PATCH v4] emacs: Re-implement advance/rewind functions of notmuch-show-mode.

2011-12-23 Thread Dmitry Kurochkin
Hi David. On Fri, 23 Dec 2011 18:41:52 +, David Edmondson wrote: > The advance/rewind functions had become complex, which made it hard to > determine how they are expected to behave. Re-implement them simply in > order to poll user-experience and expectation. > --- > > Switched back to using

Re: [PATCH 1/5] Fix comments about what is stored in the database

2011-12-23 Thread David Bremner
On Tue, 13 Dec 2011 18:11:41 +0100, Thomas Jost wrote: > Commit 567bcbc2 introduced two new values for each message (content of the > "From" and "Subject" headers), but the comments about the database schema had > not been updated accordingly. Pushed this one. d _

Re: [PATCH] Properly handle short writes in sigint handlers

2011-12-23 Thread Dmitry Kurochkin
Hi Austin. On Thu, 22 Dec 2011 15:15:48 -0500, Austin Clements wrote: > Even if we don't care about errors from write(2), it's still necessary > to handle short writes in order to use write correctly. Some versions > of glibc even mark write as warn_unused_result because of this, so our > previo

[PATCH] emacs: fix docstring for `notmuch-search-line-faces'.

2011-12-23 Thread Dmitry Kurochkin
Examples in documentation for `notmuch-search-line-faces' had an extra quote, e.g.: '(\"unread\" . '(:foreground \"green\")) Which resulted in values like: (\"unread\" quote (:foreground \"green\")) And tons of "Invalid face reference: quote" errors in the messages buffer. --- emacs/notmuc

Re: [PATCH] emacs: fix docstring for `notmuch-search-line-faces'.

2011-12-23 Thread David Edmondson
Looks obviously correct. pgpOYISK60muJ.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

nmbug changes

2011-12-23 Thread David Bremner
For those of you following/using the nmbug experiment, I made some slightly disruptive changes, in order to support auto-updating the web view on push. The clone url is now http://nmbug.tethera.net/git/nmbug-tags The push url is nm...@nmbug.tethera.net:nmbug-tags the status page is a

Re: [Patch 2/3] Respect window margins in notmuch-hello.el

2011-12-23 Thread Dmitry Kurochkin
Hi Ivy. The patch looks good to me. But I think it would be very nice to have a test for it, which would be broken at first and fixed by this patch. Can you add it please? Regards, Dmitry ___ notmuch mailing list notmuch@notmuchmail.org http://notmuc

Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
Thanks for the thorough review! Quoth Dmitry Kurochkin on Dec 10 at 3:25 am: > Hi Austin. > > +/* The number of children of this part. */ > +int children; > > Consider renaming to children_count or similar to make it clear that it > is a counter and not the actual children. Good point.

Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
Quoth Jameson Graef Rollins on Dec 10 at 1:17 pm: > On Sat, 10 Dec 2011 03:25:48 +0400, Dmitry Kurochkin > wrote: > > + out->is_encrypted = TRUE; > > + out->is_signed = TRUE; > > > > These are set only if we do decryption/verification. But their > > names and comments imply

Re: [PATCH 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-23 Thread Austin Clements
Quoth Dmitry Kurochkin on Dec 10 at 3:43 pm: > On Fri, 9 Dec 2011 14:54:27 -0500, Austin Clements wrote: > > This function matches how we number parts for the --part argument to > > show. It will allow us to jump directly to the desired part, rather > > than traversing the entire tree and caref

Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree interface.

2011-12-23 Thread Austin Clements
Quoth Dmitry Kurochkin on Dec 11 at 2:34 pm: > Hi Austin. > > I enjoyed reviewing this patch. It is a pleasure to see how complex and > confusing code becomes much smaller and cleaner. > > I still have some questions with the new code. It seems confusing to me > that part_content is called fir

[PATCH v4 0/4] First step of 'show' rewrite

2011-12-23 Thread Austin Clements
This addresses Dmitry's and Jameson's review comments from id:"87k46572f7@gmail.com" id:"87liqk5dly@servo.finestructure.net" id:"87hb187iu6@gmail.com" and rebases to current master. I'd like a quick eye over this to make sure I didn't screw anything up in the latest version, but

[PATCH v4 1/4] show: Pass notmuch_message_t instead of path to show_message_body.

2011-12-23 Thread Austin Clements
In addition to simplifying the code, we'll need the notmuch_message_t* in show_message_body shortly. --- notmuch-client.h |2 +- notmuch-reply.c |3 +-- notmuch-show.c |3 +-- show-message.c |3 ++- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/notmuch-client.

[PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Austin Clements
This wraps all of the complex MIME part handling in a single, simple function that gets part N from *any* MIME object, so traversing a MIME part tree becomes a two-line for loop. Furthermore, the MIME node structure provides easy access to envelopes for message parts as well as cryptographic infor

[PATCH v4 3/4] Utility function to seek in MIME trees in depth-first order.

2011-12-23 Thread Austin Clements
This function matches how we number parts for the --part argument to show. It will allow us to jump directly to the desired part, rather than traversing the entire tree and carefully tracking whether or not we're "in the zone". --- mime-node.c | 27 +++ notmuch-clie

[PATCH v4 4/4] show: Rewrite show_message_body to use the MIME tree interface.

2011-12-23 Thread Austin Clements
This removes all of the MIME traversal logic from show_message_body and leaves only its interaction with the format callbacks. Besides isolating concerns, since traversal happens behind a trivial interface, there is now much less code duplication in show_message_part. Also, this uses mime_node_se

[PATCH 1/3] emacs: use a single history for all searches

2011-12-23 Thread Dmitry Kurochkin
There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to "s". Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH 2/3] emacs: reindent `notmuch-hello' function

2011-12-23 Thread Dmitry Kurochkin
Reindent `notmuch-hello' function after the search history changes. --- emacs/notmuch-hello.el | 56 1 files changed, 28 insertions(+), 28 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index ba34ac5..0922821 100644 ---

[PATCH 3/3] emacs: hide recent searches if `notmuch-hello-recent-searches-max' is zero

2011-12-23 Thread Dmitry Kurochkin
--- emacs/notmuch-hello.el | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 0922821..821ef22 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -36,7 +36,10 @@ "Variable to store history

Re: [PATCH v4 0/4] First step of 'show' rewrite

2011-12-23 Thread Dmitry Kurochkin
On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements wrote: > This addresses Dmitry's and Jameson's review comments from > id:"87k46572f7@gmail.com" > id:"87liqk5dly@servo.finestructure.net" > id:"87hb187iu6@gmail.com" > and rebases to current master. > > I'd like a quick eye ove

Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal.

2011-12-23 Thread Jameson Graef Rollins
On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements wrote: > +/* True if decryption of this part was attempted. */ > +notmuch_bool_t decrypt_attempted; > +/* True if decryption of this part's child succeeded. In this > + * case, the decrypted part is substituted for the second chi

Re: [PATCH v4 0/4] First step of 'show' rewrite

2011-12-23 Thread Jameson Graef Rollins
On Fri, 23 Dec 2011 22:45:44 -0500, Austin Clements wrote: > This addresses Dmitry's and Jameson's review comments from > id:"87k46572f7@gmail.com" > id:"87liqk5dly@servo.finestructure.net" > id:"87hb187iu6@gmail.com" > and rebases to current master. > > I'd like a quick eye ove