[PATCH v3 2/2] search: Support automatic tag exclusions

On Thu, 19 Jan 2012 22:01:27 +, Mark Walters wrote: > > > > I am happy with them appearing as a non matching message, but currently > > > they appear as a full open message. (The patch to achieve this is > > > trivial: essentially transpose part of Austin's patch of > > > notmuch-search.c

[PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving

One indentation nit and then this LGTM. Quoth Mark Walters on Jan 19 at 9:23 pm: > Define a keymap for attachment buttons to allow multiple actions. > Define 3 possible actions: > save attachment: exactly as currently, > view attachment: uses mailcap entry, > view attachment with

[PATCH] emacs: Quote MML tags in replies

On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote: > Emacs message-mode uses certain text strings to indicate how to attach > files to outgoing mail. If these are present in the text of an email, > and a user is tricked into replying to the message, the user?s files > could be exposed. > ---

[PATCH 4/4] setup: prompt user for search.exclude_tags value

Quoth Pieter Praet on Jan 19 at 10:16 pm: > On Thu, 19 Jan 2012 14:44:37 -0500, Austin Clements > wrote: > > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > > Allow users to customize the search.exclude_tags option during setup. > > > > > > --- > > > notmuch-setup.c | 36

[PATCH v3 2/2] Add compatibility with gmime 2.6

Nearly there. A few more small comments. Quoth Thomas Jost on Jan 20 at 1:06 am: > There are lots of API changes in gmime 2.6 crypto handling. By adding > preprocessor directives, it is however possible to add gmime 2.6 compatibility > while preserving compatibility with gmime 2.4 too. > >

[PATCH] emacs: fix tests wrt notmuch-hello invisible dot

Not meant to be applied! Should be merged into id:"1326815734-20421-1-git-send-email-dmitry.kurochkin at gmail.com" --- test/emacs.expected-output/notmuch-hello |2 +- .../notmuch-hello-no-saved-searches|2 +-

[PATCH] emacs: Quote MML tags in replies

On Fri, 20 Jan 2012 00:21:08 +0100, Pieter Praet wrote: > So, would I be right to assume MML tags in signatures are never > evaluated to begin with? Otherwise, there would still be a security > hole, no? I am thinking of MML tags that a user puts in their own signature. If that case is a

[PATCH v3 2/2] search: Support automatic tag exclusions

On Thu, 19 Jan 2012 14:36:47 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > > Same here. I probably will use the spam

[PATCH 4/4] setup: prompt user for search.exclude_tags value

On Thu, 19 Jan 2012 14:44:37 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > Allow users to customize the search.exclude_tags option during setup. > > > > --- > > notmuch-setup.c | 36 > > 1 files changed, 36 insertions(+), 0

[PATCH] config: Better formatting for search section comment

On Wed, 18 Jan 2012 15:56:45 -0500, Austin Clements wrote: > Since "auto_exclude_tags" is long and its description is multi-line, > start the description on the next line and indent it consistently. > --- > notmuch-config.c |7 --- > 1 files changed, 4 insertions(+), 3 deletions(-) > >

[PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags

On Thu, 19 Jan 2012 14:41:15 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > All other config-related functions and args include the section > > title in their name, so for the sake of consistency, mirror that. > > > > Also, the "auto"matic part is a given, so that

[PATCH] Automatically exclude tags in notmuch-show

Add the use of auto_exclude_tags in notmuch-show.c. As with Austin's patch (commit 42a907992823030f070fc395a174f779998ca6f5) it just adds the excluded tags to the query so the excluded messages will still appear in the emacs interface, but as a single header line rather than as a matching

[PATCH v3 2/2] search: Support automatic tag exclusions

> > I am happy with them appearing as a non matching message, but currently > > they appear as a full open message. (The patch to achieve this is > > trivial: essentially transpose part of Austin's patch of > > notmuch-search.c into notmuch-show.c) > > This definitely sounds like the right thing

[PATCH v4 0/1]

Sorry this should have been in-reply-to id:"20120118192147.GF16740 at mit.edu" Mark

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

On Thu, Jan 19, 2012 at 11:45, Aaron Ecay wrote: > Shouldn?t this just use message-insert-formatted-citation-line? Yes, good idea. I just tried this and it almost works. The only issue is that the default message-mode-citation-line-format has a newline at the end, and this function inserts an

[PATCH v4 1/1] Make buttons for attachments allow viewing as well as saving

Define a keymap for attachment buttons to allow multiple actions. Define 3 possible actions: save attachment: exactly as currently, view attachment: uses mailcap entry, view attachment with user chosen program Keymap on a button is: s for save, v for view and o for view with other

[PATCH v4 0/1]

Here is a new version of the patch incorporating all the review comments. I have rebased it on master so, in particular, it fits into the recently committed customization framework. To deal with one corner case I decided to go with Austin's suggestion of using lexical-let as it is probably more

[PATCH v3 2/2] search: Support automatic tag exclusions

> On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > > I would actually like make a different suggestion: extend > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > my deleted (ie hidden rather than actually deleted) messages return when > >

[PATCH v4] emacs: logically group def{custom,face}s

On Thu, 19 Jan 2012 13:14:25 -0400, David Bremner wrote: > On Mon, 16 Jan 2012 11:38:33 +0100, Pieter Praet wrote: > > To allow for expansion whilst keeping everything tidy and organized, > > move all defcustom/defface variables to the following subgroups, > > defined in notmuch-lib.el: > >

[PATCH 4/4] setup: prompt user for search.exclude_tags value

Allow users to customize the search.exclude_tags option during setup. --- notmuch-setup.c | 36 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/notmuch-setup.c b/notmuch-setup.c index c3ea937..44d4aaa 100644 --- a/notmuch-setup.c +++

[PATCH 2/4] test: only exclude "deleted" messages from search if explicitly configured

If the 'search.exclude_tags' option is missing from the config file, its value is automatically set to "deleted;spam;". Taking PoLS/DWIM into account, this should probably only happen during setup. --- test/search |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git

[PATCH 1/4] search: rename auto_exclude_tags to {search, }exclude_tags

All other config-related functions and args include the section title in their name, so for the sake of consistency, mirror that. Also, the "auto"matic part is a given, so that was dropped. --- notmuch-client.h |4 ++-- notmuch-config.c | 32

[PATCH v3 2/2] search: Support automatic tag exclusions

Nice feature! I won't be using it myself, but I can imagine it being *very* useful for those who still feel the need to "delete" email :). Nitpicking: - All other config-related functions and args include the section title in their name [1], so for the sake of consistency, we might want to

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

On Wed, 18 Jan 2012 17:18:48 -0500, Aaron Ecay wrote: > On Wed, 18 Jan 2012 14:48:02 +0100, Pieter Praet wrote: > > My original intent of conserving a key(chord) [1] (which in > > retrospect was a fairly pointless exercise in and of itself > > [2,3]) seems to have inconspicuously morphed into an

[PATCH] emacs: invert relation between 'notmuch-send and 'message customization groups

'message contains options relevant to 'notmuch-send, not the other way around. Thanks to Austin for suggesting `custom-add-to-group'. id:"20120118184408.GD16740 at mit.edu" --- emacs/notmuch-lib.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v3 2/2] search: Support automatic tag exclusions

> > So I'd like to suggest replacing all occurences of "auto_exclude_tags" > > with "search_exclude_tags" (and simply "exclude_tags" in the args to > > `_config_get_list' and `_config_set_list', of course). > > You are technically correct, the best kind of correct. I'd completely > missed

Updated remote script

On Thu, 19 Jan 2012 11:24:32 -0500, Jesse Rosenthal wrote: > Dear all, > > The big change in this script is that it uses dtach to set up a ssh > socket, rather than suggesting that users do so themselves with the > ControlMaster configuration option. This has the benefit of not making > anyone

[PATCH] Automatically exclude tags in notmuch-show

LGTM, but should definitely come with a test. Also, this won't commute with Pieter's patch (id:"1327000744-25463-2-git-send-email-pieter at praet.org"), so one or the other will have to get updated. Quoth Mark Walters on Jan 19 at 10:03 pm: > Add the use of auto_exclude_tags in notmuch-show.c.

[PATCH] emacs: Quote MML tags in replies

On Thu, 19 Jan 2012 17:48:42 -0500, Austin Clements wrote: > Did you consider using point-max instead of mark? IIRC, that mark was > very recently introduced which, perhaps irrationally, makes it seem > less future-proof to me. Well, if the patch goes in and someone changes the code so that it

[PATCH] emacs: Quote MML tags in replies

On Thu, 19 Jan 2012 17:46:31 -0500, Austin Clements wrote: > > ### OT: > > For some reason, `mml-quote-region' explicitly re-quotes > > already quoted MML tags: > > > > "<#!*/?\\(multipart\\|part\\|external\\|mml\\)" > > > > Why is that ? > > Probably so the transformation is invertible,

[PATCH] emacs: Quote MML tags in replies

LGTM and I think it could go in despite my two comments below. Quoth Aaron Ecay on Jan 19 at 1:43 pm: > Emacs message-mode uses certain text strings to indicate how to attach > files to outgoing mail. If these are present in the text of an email, > and a user is tricked into replying to the

[PATCH] emacs: Quote MML tags in replies

Quoth Pieter Praet on Jan 19 at 11:23 pm: > On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote: > > Emacs message-mode uses certain text strings to indicate how to attach > > files to outgoing mail. If these are present in the text of an email, > > and a user is tricked into replying to the

[PATCH v3 2/2] Silence buildbot warnings about unused results

This ignores the results of the two writes in sigint handlers even harder than before. While my libc lacks the declarations that trigger these warnings, this can be tested by adding the following to notmuch.h: __attribute__((warn_unused_result)) ssize_t write(int fd, const void *buf, size_t

[PATCH v3 1/2] show: Handle read and write errors

For showing a message in raw format, rather than silently succeeding when a read or a write fails (or, probably, looping if a read fails), try to print an error message and exit with a non-zero status. This silences one of the buildbot warnings about unused resuls. While my libc lacks the

[PATCH v3 0/2]

I fail at git. Here's an actually updated version of this series that changes the comment in tag's sigint handler.

Updated remote script

Hi Tomi, On Thu, 19 Jan 2012 19:50:38 +0200, Tomi Ollila wrote: > Quick comments: "/tmp/notmuch_dtach.socket" is dangerous (and the _ssh). > > either > make directory /tmp/notmuch_`id -u` > and chmod it to 0700 > and make sure you own it and it has right permissions. >

[PATCH v3 2/2] search: Support automatic tag exclusions

Quoth Mark Walters on Jan 19 at 8:23 pm: > > > On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > > > I would actually like make a different suggestion: extend > > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > > my deleted (ie hidden rather

[PATCH v3 2/2] search: Support automatic tag exclusions

On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > I would actually like make a different suggestion: extend > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > my deleted (ie hidden rather than actually deleted) messages return when > viewing a

[PATCH 4/4] setup: prompt user for search.exclude_tags value

Quoth Pieter Praet on Jan 19 at 8:19 pm: > Allow users to customize the search.exclude_tags option during setup. > > --- > notmuch-setup.c | 36 > 1 files changed, 36 insertions(+), 0 deletions(-) > > diff --git a/notmuch-setup.c b/notmuch-setup.c > index

[PATCH 1/4] search: rename auto_exclude_tags to {search,}exclude_tags

Quoth Pieter Praet on Jan 19 at 8:19 pm: > All other config-related functions and args include the section > title in their name, so for the sake of consistency, mirror that. > > Also, the "auto"matic part is a given, so that was dropped. LGTM other than one nit, below. > ---

[PATCH v3 2/2] search: Support automatic tag exclusions

Quoth Pieter Praet on Jan 19 at 8:19 pm: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Same here. I probably will use the spam tag, though. > Nitpicking: > > - All other config-related functions

[PATCH] emacs: invert relation between 'notmuch-send and 'message customization groups

Quoth Pieter Praet on Jan 19 at 8:13 pm: > 'message contains options relevant to 'notmuch-send, not the other way around. > > Thanks to Austin for suggesting `custom-add-to-group'. > id:"20120118184408.GD16740 at mit.edu" LGTM.

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

On Thu, 19 Jan 2012 10:46:57 -0700, Adam Wolfe Gordon wrote: > Instead of using a static citation line for the first line of the > reply message, use the customizable one defined by message-mode. > This makes it easy for users to customize the reply style, and > retains

[PATCH] emacs: Make the part content available to `mm-inlinable-p'.

[and again with reply to all] On Thu, 19 Jan 2012 09:34:07 +, David Edmondson wrote: > The `mm-inlinable-p' function works better if it has access to the > data of the relevant part, so load that content before calling it. > > Don't load the content for parts that the user has indicated no

[PATCH v2] emacs: Make the part content available to the mm-inline* checks.

On Thu, 19 Jan 2012 07:39:32 +, David Edmondson wrote: > On Wed, 18 Jan 2012 23:00:15 +0400, Dmitry Kurochkin gmail.com> wrote: > > > That would allow a sane default (("image/*" "text/*") perhaps), but also > > > allow more to be added to that list (or some to be removed), either by > > >

[PATCH] Fix dependency generation for CLI sources

On Sun, 15 Jan 2012 15:20:23 -0500, Austin Clements wrote: > Previously, the dependency file list was generated before the CLI > sources were added to SRCS, so dependency files weren't generated for > CLI sources. This moves that code to after the CLI sources are added. pushed, d

[PATCH] Fix dependency generation for compat, test, and util

On Sun, 15 Jan 2012 15:20:42 -0500, Austin Clements wrote: > This adds source files in compat, test, and util to SRCS so that the > top-level Makefile.local will generate dependency files for them. > --- pushed, d

[PATCH v4] emacs: logically group def{custom,face}s

On Mon, 16 Jan 2012 11:38:33 +0100, Pieter Praet wrote: > To allow for expansion whilst keeping everything tidy and organized, > move all defcustom/defface variables to the following subgroups, > defined in notmuch-lib.el: pushed d

[PATCH 2/3] test: Add `test_emacs_expect_t'.

On Thu, 19 Jan 2012 10:42:31 +, David Edmondson wrote: > On Thu, 19 Jan 2012 12:32:21 +0200, Tomi Ollila wrote: > > Consider the following: > > > > $ emacsclient --eval '(print "$(echo rm -rf /); echo `date +%Y`")' > > "$(echo rm -rf /); echo `date +%Y`" > > Or: > > $ emacsclient --eval

[PATCH v2 2/2] Silence buildbot warnings about unused results

This ignores the results of the two writes in sigint handlers even harder than before. While my libc lacks the declarations that trigger these warnings, this can be tested by adding the following to notmuch.h: __attribute__((warn_unused_result)) ssize_t write(int fd, const void *buf, size_t

[PATCH v2 1/2] show: Handle read and write errors

For showing a message in raw format, rather than silently succeeding when a read or a write fails (or, probably, looping if a read fails), try to print an error message and exit with a non-zero status. This silences one of the buildbot warnings about unused resuls. While my libc lacks the

[PATCH 2/2] Silence buildbot warnings about unused results

Quoth David Edmondson on Jan 19 at 7:23 am: > On Wed, 18 Jan 2012 19:40:11 -0500, Austin Clements > wrote: > > +/* See handle_sigint in notmuch-new.c for the justification for > > + * ignoring write's result. */ > > +IGNORE_RESULT (write (2, msg, sizeof(msg)-1)); > > Just include

[PATCH 3/3] test: Add address cleaning tests.

Including some more test framework in test-lib.el. --- test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 12 test/notmuch-test |1 + test/test-lib.el | 30 ++ 4 files

[PATCH 2/3] test: Add `test_emacs_expect_t'.

Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- In the interest of moving forward,

[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

--- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index d1fbc05..7c9ce24 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval

[PATCH 0/2] Fix or silence "unused result" warnings

On Wed, 18 Jan 2012 19:40:09 -0500, Austin Clements wrote: > I'm afraid I bikeshedded dme's original patch for this into oblivion > (id:"1324503532-5799-1-git-send-email-dme at dme.org") and we still have > these warnings on the buildbot. Tomi convinced me that dme was right > and I was wrong,

[PATCH 2/3] test: Add `test_emacs_expect_t'.

On Thu, 19 Jan 2012 09:59:16 +, David Edmondson wrote: > On Wed, 18 Jan 2012 16:55:59 +0200, Tomi Ollila wrote: > > > + # Report success/failure. > > > + if ! test_skip "$test_subtest_name" > > > + then > > > + if [ "$result" == t ] > > > > if [ "$result" = t ] > > > >

[PATCH] emacs: Make the part content available to `mm-inlinable-p'.

On Thu, 19 Jan 2012 09:34:07 +, David Edmondson wrote: > The `mm-inlinable-p' function works better if it has access to the > data of the relevant part, so load that content before calling it. > > Don't load the content for parts that the user has indicated no desire > to inline. > > This

Updated remote script

Dear all, Just wanted to note that I finally got around to updating the way-deprecated "remoteusage" wiki page[0], with a simplified script, that takes into account comments that some have made in the past. Caching for attachments is gone, since the complications of part handling vs. raw

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

Instead of using a static citation line for the first line of the reply message, use the customizable one defined by message-mode. This makes it easy for users to customize the reply style, and retains consistency for users with existing message-mode customizations. --- emacs/notmuch-mua.el |

[PATCH v3 4/5] emacs: Use the new JSON reply format.

Using the new JSON reply format allows emacs to quote HTML parts nicely by using mm-display-part to turn them into displayable text, then quoting them. This is very useful for users who regularly receive HTML-only email. The behavior for messages that contain plain text parts should be unchanged.

[PATCH v3 3/5] man: Update notmuch-reply man page for JSON format.

--- man/man1/notmuch-reply.1 |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 5160ece..ea7f87b 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -43,6 +43,11 @@ include .BR default

[PATCH v3 2/5] reply: Add a JSON reply format.

This new JSON format for replies includes headers generated for a reply message as well as the headers and all text parts of the original message. Using this data, a client can intelligently create a reply. For example, the emacs client will be able to create replies with quoted HTML parts by

[PATCH v3 1/5] test: Add broken test for the new JSON reply format.

--- test/multipart |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/test/multipart b/test/multipart index f83526b..f5ebf04 100755 --- a/test/multipart +++ b/test/multipart @@ -589,6 +589,13 @@ Non-text part: text/html EOF test_expect_equal_file OUTPUT EXPECTED

[PATCH v3 0/5] Quoting HTML emails in reply

Hi everyone, Thanks to all who reviewed bits of my previous series [1]. This version contains: * The latest version of the emacs patch [2], rebased against the current master. * An updated version of the patch to notmuch-reply.c to address Jani's review comments from yesterday. * The

[PATCH 2/3] test: Add `test_emacs_expect_t'.

hat's your point? -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120119/dcadd45f/attachment.pgp>

[PATCH 2/3] test: Add `test_emacs_expect_t'.

cs tests run via test_emacs_expect_t wrote their output > to ${output} directly above code could be much cleaner in many > places. Environment variable could be used for the file name. I'm reluctant to change this just to avoid calling eval. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120119/f18423f7/attachment.pgp>

[PATCH] emacs: Make the part content available to `mm-inlinable-p'.

The `mm-inlinable-p' function works better if it has access to the data of the relevant part, so load that content before calling it. Don't load the content for parts that the user has indicated no desire to inline. This fixes the display of attached image/jpeg parts, for example. --- Updated

RFC: tag macros

On Wed, 18 Jan 2012 10:50:50 -0800, Jameson Graef Rollins wrote: > Is all of this really easier than just adding the following to your > .emacs?: > > (define-key notmuch-search-mode-map "o" > (lambda () > (interactive) > (notmuch-show-add-tag "notmuch::patch") >

[PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

e same. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120119/92b00133/attachment.pgp>

[PATCH v2 0/3] emacs: notmuch-hello search cleanup

d... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120119/631d9ef7/attachment.pgp>

[PATCH v2] emacs: Make the part content available to the mm-inline* checks.

ation/pkcs7-mime" These are the only types for which we'd acquire the part content for examination by `mm-inlinable-p' (by default). -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120119/c5220a9f/attachment.pgp>

[PATCH 2/2] Silence buildbot warnings about unused results

the code in notmuch-new.c and we'll lose it. Then, +1. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20120

[PATCH v2 2/4] reply: Add a JSON reply format.

On Mon, 16 Jan 2012 11:13:21 -0700, Adam Wolfe Gordon wrote: > This new JSON format for replies includes headers generated for a reply > message as well as the headers and all text parts of the original message. > Using this data, a client can intelligently create a reply.

[PATCH 0/3] Second step of 'show' rewrite

Hi Austin. On Wed, 18 Jan 2012 15:28:24 -0500, Austin Clements wrote: > This adds support for self-recursive message formatters, while > maintaining backwards compatibility with old style formatters. After > this, each format can be converted to the new style individually and, > once they're

[PATCH 3/3] show: Introduce mime_node formatter callback

On Wed, 18 Jan 2012 15:28:27 -0500, Austin Clements wrote: > This callback is the gateway to the new mime_node_t-based formatters. > This maintains backwards compatibility so the formatters can be > transitioned one at a time. Once all formatters are converted, the > formatter structure can be

[PATCH 1/3] mime node: Record depth-first part numbers

On Wed, 18 Jan 2012 15:28:25 -0500, Austin Clements wrote: > This makes the part numbers readily accessible to formatters. > Hierarchical part numbering would be a more natural and efficient fit > for MIME and may be the way to go in the future, but depth-first > numbering maintains compatibility

[PATCH v2 3/3] emacs: bind "s" to `notmuch-hello-search' in notmuch-hello buffer

`notmuch-hello-search' uses `notmuch-search' function but refreshes notmuch-hello buffer when the search buffer is closed. --- emacs/notmuch-hello.el |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index cb36977..e908659

[PATCH v2 2/3] emacs: use a single history for all searches

There are two ways to do search in Emacs UI: search widget in notmuch-hello buffer and `notmuch-search' function bound to "s". Before the change, these search mechanisms used different history lists. The patch makes notmuch-hello search use the same history list as `notmuch-search' function. ---

[PATCH v2 1/3] emacs: bind "s" to `notmuch-search' in notmuch-hello buffer

Before the change, "s" in notmuch-hello buffer would jump to the search box. The patch changes the binding to `notmuch-search' which is consistent with all other notmuch buffers. --- emacs/notmuch-hello.el | 19 ++-

[PATCH v2 0/3] emacs: notmuch-hello search cleanup

Changes in v2 since v1: * expected results changes for tests moved from patch 2 to 1 where it belong Regards, Dmitry

Sort by newest first from notmuch-hello ?

Hi, I am running latest release (0.11). I have set notmuch-search-oldest-first to t. When doing M-x notmuch-search, messages order does not respect this setting -i.e newest com firts -. On the other hand, from notmuch-hello I get expected behaviour. How can this be more "consistent" ? By the

Re: [PATCH v2 0/3] emacs: notmuch-hello search cleanup

On Thu, 19 Jan 2012 00:22:53 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: Changes in v2 since v1: * expected results changes for tests moved from patch 2 to 1 where it belong The patch set looks good to me. pgpNMumAPxq0s.pgp Description: PGP signature

Re: [PATCH] v2 [RFC] emacs: merge overhauled `notmuch-cycle-notmuch-buffers' into `notmuch'

On Wed, 18 Jan 2012 17:18:48 -0500, Aaron Ecay aarone...@gmail.com wrote: Runtime dependencies are not allowed in code distributed with emacs because of RMS’s conservativism[1]. Yow! Conservatism is such a pejorative term. But, I generally agree. We should allow cl at runtime and document the

Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

On Thu, 19 Jan 2012 07:39:32 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 23:00:15 +0400, Dmitry Kurochkin dmitry.kuroch...@gmail.com wrote: That would allow a sane default ((image/* text/*) perhaps), but also allow more to be added to that list (or some to be removed),

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

On Wed, 18 Jan 2012 16:55:59 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: + # Report success/failure. + if ! test_skip $test_subtest_name + then + if [ $result == t ] if [ $result = t ] to be compatible with POSIX and consistent with rest code. I'm

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

On Thu, 19 Jan 2012 09:59:16 +, David Edmondson d...@dme.org wrote: On Wed, 18 Jan 2012 16:55:59 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: + # Report success/failure. + if ! test_skip $test_subtest_name + then + if [ $result == t ] if [ $result = t ]

Re: [PATCH 0/2] Fix or silence unused result warnings

On Wed, 18 Jan 2012 19:40:09 -0500, Austin Clements amdra...@mit.edu wrote: I'm afraid I bikeshedded dme's original patch for this into oblivion (id:1324503532-5799-1-git-send-email-...@dme.org) and we still have these warnings on the buildbot. Tomi convinced me that dme was right and I was

Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.

On Thu, 19 Jan 2012 10:42:31 +, David Edmondson d...@dme.org wrote: On Thu, 19 Jan 2012 12:32:21 +0200, Tomi Ollila tomi.oll...@iki.fi wrote: Consider the following: $ emacsclient --eval '(print $(echo rm -rf /); echo `date +%Y`)' $(echo rm -rf /); echo `date +%Y` Or: $

[PATCH 1/3] test: Don't return the result of checking for running emacs to the tester.

--- test/test-lib.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/test-lib.sh b/test/test-lib.sh index d1fbc05..7c9ce24 100644 --- a/test/test-lib.sh +++ b/test/test-lib.sh @@ -926,7 +926,7 @@ test_emacs () { --eval

[PATCH 3/3] test: Add address cleaning tests.

Including some more test framework in test-lib.el. --- test/emacs-address-cleaning.el | 29 + test/emacs-address-cleaning.sh | 12 test/notmuch-test |1 + test/test-lib.el | 30 ++ 4 files

[PATCH 2/3] test: Add `test_emacs_expect_t'.

Add a new test function to allow simpler testing of emacs functionality. `test_emacs_expect_t' takes one argument - a list expression to evaluate. The test passes if the expression returns `t', otherwise it fails and the output is reported to the tester. --- In the interest of moving forward,

Re: RFC: tag macros

On Wed, 18 Jan 2012 10:50:50 -0800, Jameson Graef Rollins jroll...@finestructure.net wrote: Is all of this really easier than just adding the following to your .emacs?: (define-key notmuch-search-mode-map o (lambda () (interactive) (notmuch-show-add-tag notmuch::patch)

Updated remote script

Dear all, Just wanted to note that I finally got around to updating the way-deprecated remoteusage wiki page[0], with a simplified script, that takes into account comments that some have made in the past. Caching for attachments is gone, since the complications of part handling vs. raw handling

Re: [PATCH v4] emacs: logically group def{custom,face}s

On Mon, 16 Jan 2012 11:38:33 +0100, Pieter Praet pie...@praet.org wrote: To allow for expansion whilst keeping everything tidy and organized, move all defcustom/defface variables to the following subgroups, defined in notmuch-lib.el: pushed d ___

Re: [PATCH] Fix dependency generation for compat, test, and util

On Sun, 15 Jan 2012 15:20:42 -0500, Austin Clements amdra...@mit.edu wrote: This adds source files in compat, test, and util to SRCS so that the top-level Makefile.local will generate dependency files for them. --- pushed, d ___ notmuch mailing

Re: [PATCH] Fix dependency generation for CLI sources

On Sun, 15 Jan 2012 15:20:23 -0500, Austin Clements amdra...@mit.edu wrote: Previously, the dependency file list was generated before the CLI sources were added to SRCS, so dependency files weren't generated for CLI sources. This moves that code to after the CLI sources are added. pushed, d

[PATCH v3 0/5] Quoting HTML emails in reply

Hi everyone, Thanks to all who reviewed bits of my previous series [1]. This version contains: * The latest version of the emacs patch [2], rebased against the current master. * An updated version of the patch to notmuch-reply.c to address Jani's review comments from yesterday. * The

[PATCH v3 3/5] man: Update notmuch-reply man page for JSON format.

--- man/man1/notmuch-reply.1 |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/man/man1/notmuch-reply.1 b/man/man1/notmuch-reply.1 index 5160ece..ea7f87b 100644 --- a/man/man1/notmuch-reply.1 +++ b/man/man1/notmuch-reply.1 @@ -43,6 +43,11 @@ include .BR default

[PATCH v3 5/5] emacs: Use message-citation-line-format in reply

Instead of using a static citation line for the first line of the reply message, use the customizable one defined by message-mode. This makes it easy for users to customize the reply style, and retains consistency for users with existing message-mode customizations. --- emacs/notmuch-mua.el |

  1   2   >