Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page

2015-12-31 Thread W. Trevor King
On Thu, Dec 31, 2015 at 06:11:34PM -0400, David Bremner wrote: > W. Trevor King writes: > > On Thu, Dec 31, 2015 at 01:39:21PM -0400, David Bremner wrote: > >> For me it's a bit odd to have a man page for a tool we don't > >> install by default. Is it maybe time to "promote" nmbug-status to > >> th

Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page

2015-12-31 Thread David Bremner
"W. Trevor King" writes: > On Thu, Dec 31, 2015 at 01:39:21PM -0400, David Bremner wrote: > >> For me it's a bit odd to have a man page for a tool we don't install >> by default. Is it maybe time to "promote" nmbug-status to the >> notmuch- namespace and install it by default? > > Sounds good to

Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page

2015-12-31 Thread W. Trevor King
On Thu, Dec 31, 2015 at 01:39:21PM -0400, David Bremner wrote: > Jani Nikula writes: > > I am wondering about the man page though. I find it slightly > > confusing there would be a man page named after the tool > > describing just the config, but not the tool itself. Yeah, a man page about the too

Re: [PATCH 3/5] nmbug-status: Add an nmbug-status(5) man page

2015-12-31 Thread David Bremner
Jani Nikula writes: > On Wed, 30 Dec 2015, "W. Trevor King" wrote: >> To describe the config file format, so folks don't have to dig through >> NEWS or the nmbug-status source to get that information. > > Overall I approve of the series (though I did not do a thorough > review). > > I am wonderi

Re: [PATCH 4/5] nmbug-status: Wrap query phrases in parentheses when and-ing together

2015-12-31 Thread W. Trevor King
On Wed, Dec 30, 2015 at 11:16:59AM -0800, W. Trevor King wrote: > @@ -167,7 +167,8 @@ class Page (object): > view['title'], sort_key)) > if 'query-string' not in view: > query = view['query'] > -view['query-string'] = ' and '.join(query) > +

Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced fixups to default templates

2015-12-31 Thread W. Trevor King
On Thu, Dec 31, 2015 at 03:46:50PM +0200, Tomi Ollila wrote: > This series LGTM. (html) tidy complains about imo irrelevant things > -- or I just did not know how to use it correctly -- as `| tidy > -eq`. That doesn't complain about anything with the current tidy 5.1.25 [1] with output built by th

Re: [PATCH 0/2] nmbug-status: h1 title and unbalanced fixups to default templates

2015-12-31 Thread Tomi Ollila
On Wed, Dec 30 2015, "W. Trevor King" wrote: > Polishing the templates a bit. Details in the individual patches. This series LGTM. (html) tidy complains about imo irrelevant things -- or I just did not know how to use it correctly -- as `| tidy -eq`. > > Cheers, > Trevor Tomi PS: it was a b