Re: [PATCH v2 06/21] crypto: Test restore of cleartext index from stashed session keys

2017-12-04 Thread David Bremner
Pushed patches 1 to 6. I seem to recall 7 and 8 basically adressed concerns/suggestions Jamie had, so I'm hoping he can have a quick look at those. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2 04/21] crypto: use stashed session-key properties for decryption, if available

2017-12-04 Thread David Bremner
Daniel Kahn Gillmor writes: > On Thu 2017-11-30 03:59:29 -0500, Daniel Kahn Gillmor wrote: >> +hexidecimal representation of the algorithm-specific key. For > > ugh, this should be hexadecimal, not hexidecimal. > > This is fixed in my gitlab session-keys branch [0], but doesn't seem > worth

Re: [PATCH 4/5] debian: bump Standards-Version to 4.1.1

2017-12-04 Thread David Bremner
Daniel Kahn Gillmor writes: > No minor changes were necessary to become compliant with Debian policy > version 4.1.1, so this is basically a freebie. pushed 2,3,4. Waiting for you and Tomi to reach a fixed point on 1. Skeptical of 5; I tend to think lintian is wrong here. Not sure if I care enou

Re: [PATCH] test: unbreak performance tests

2017-12-04 Thread David Bremner
David Bremner writes: > In 8e7fb88237aedea22 Jani replaced the use of $(pwd -P) to find the > TEST_DIRECTORY in order to better support out of tree > builds. Unfortunately the performance-tests need a different value for > the variable and were thus broken. > > This commit splits out the setting

Re: [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx

2017-12-04 Thread Tomi Ollila
On Mon, Dec 04 2017, Tomi Ollila wrote: > On Mon, Dec 04 2017, Daniel Kahn Gillmor wrote: > >> On Sun 2017-12-03 15:35:04 +0200, Tomi Ollila wrote: >>> On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote: >>> hm, on further reflection, this one is specifically problematic because of the

Re: [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx

2017-12-04 Thread Tomi Ollila
On Mon, Dec 04 2017, Daniel Kahn Gillmor wrote: > On Sun 2017-12-03 15:35:04 +0200, Tomi Ollila wrote: >> On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote: >> >>> On Thu 2017-11-30 04:40:39 -0500, Daniel Kahn Gillmor wrote: python2 is going to be deprecated, and python3-sphinx is available all

Re: [PATCH v2] cli/help: give a hint about notmuch-emacs-mua

2017-12-04 Thread Tomi Ollila
On Mon, Dec 04 2017, Daniel Kahn Gillmor wrote: > "notmuch help" doesn't mention "notmuch-emacs-mua" even though we > support it through the try_external_command() mechanism. > > In addition, "notmuch help emacs-mua" doesn't work, even though we > ship the appropriate manpage. > > This changeset f

Re: [PATCH] cli/help: give a hint about notmuch-emacs-mua

2017-12-04 Thread Daniel Kahn Gillmor
On Mon 2017-12-04 10:44:40 -0500, Daniel Kahn Gillmor wrote: > But maybe you'll find my revised version > (id:20171204154333.27505-1-...@fifthhorseman.net) mitigates the error > you're pointing out? sorry, that should be id:20171204184310.17125-1-...@fifthhorseman.net -- the previous message-id wa

[PATCH v2] cli/help: give a hint about notmuch-emacs-mua

2017-12-04 Thread Daniel Kahn Gillmor
"notmuch help" doesn't mention "notmuch-emacs-mua" even though we support it through the try_external_command() mechanism. In addition, "notmuch help emacs-mua" doesn't work, even though we ship the appropriate manpage. This changeset fixes both of these problems. --- configure | 1 + notmuch.c

Re: [PATCH] cli/help: give a hint about notmuch-emacs-mua

2017-12-04 Thread Daniel Kahn Gillmor
On Sun 2017-12-03 15:26:32 +0200, Tomi Ollila wrote: > My thought was that even though user may compile notmuch without emacs > support (and notmuch-emacs-mua not installed) we would be hinting > `notmuch emacs-mua` command to exist. Currently, if the user *does* compile with emacs support, and i

Re: [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx

2017-12-04 Thread Daniel Kahn Gillmor
On Sun 2017-12-03 15:35:04 +0200, Tomi Ollila wrote: > On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote: > >> On Thu 2017-11-30 04:40:39 -0500, Daniel Kahn Gillmor wrote: >>> python2 is going to be deprecated, and python3-sphinx is available all >>> the way back to oldoldstable. let's use the more m