Re: [PATCH 3/5] build: optionally build python-cffi bindings

2019-11-04 Thread David Bremner
Tomi Ollila writes: > how bad does out-of-tree build break with this -- do we need to do > the same as with ruby bindings (copy sources -- do we still do so)? or does > python provide better alternative..? Good question. What is here will break with out of tree builds, just from trivial things

Re: [PATCH 4/5] tests: run python-cffi tests

2019-11-04 Thread Tomi Ollila
On Mon, Nov 04 2019, Tomi Ollila wrote: > > as for checking pytest existence, the following works somewhat: > >~/test-venv/bin/python3 -m pytest --version > > It prints the version, then exists. Could not figure out how to request > specific version in quick look (10 min search/trial/error

Re: [PATCH 4/5] tests: run python-cffi tests

2019-11-04 Thread Tomi Ollila
On Sun, Nov 03 2019, David Bremner wrote: > The entire python-cffi test suite is considered as a single test at > the level of the notmuch test suite. This might or might not be ideal, > but it gets them run. > --- > test/T391-python-cffi.sh | 12 > 1 file changed, 12 insertions(+)

Re: [PATCH 3/5] build: optionally build python-cffi bindings

2019-11-04 Thread Tomi Ollila
On Sun, Nov 03 2019, David Bremner wrote: > Put the build product (and tests) in a well known location so that we > can find them e.g. from the tests. > --- > Makefile.local | 2 +- > bindings/Makefile.local | 9 + > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff

Re: [PATCH 2/5] configure: check for python cffi module

2019-11-04 Thread Tomi Ollila
On Sun, Nov 03 2019, David Bremner wrote: > This is needed to build the new python bindings > --- > configure | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/configure b/configure > index 3c148e12..300591fe 100755 > --- a/configure > +++ b/configure > @@ -671,6 +671,15

Re: [PATCH 4/5] tests: run python-cffi tests

2019-11-04 Thread David Bremner
Tomi Ollila writes: > On Sun, Nov 03 2019, David Bremner wrote: > >> The entire python-cffi test suite is considered as a single test at >> the level of the notmuch test suite. This might or might not be ideal, >> but it gets them run. > > IMO this is good enough approach -- provided that pytest

Re: [PATCH 4/5] tests: run python-cffi tests

2019-11-04 Thread Tomi Ollila
On Sun, Nov 03 2019, David Bremner wrote: > The entire python-cffi test suite is considered as a single test at > the level of the notmuch test suite. This might or might not be ideal, > but it gets them run. IMO this is good enough approach -- provided that pytest is prereq for this test to be

Re: python CFFI bindings integration into notmuch build/test

2019-11-04 Thread David Bremner
David Bremner writes: > This series is on top of a slightly modified version [1] of > > id:20191008210312.20685-2-f...@devork.be > > If you want to try out the new bindings, you can try the branch wip/cffi in > the repo > https://git.notmuchmail.org/git/notmuch > > One current annoyance is

Re: notmuch-mode and org-capture

2019-11-04 Thread Leo Gaspard
Tristan Cacqueray writes: >> Hmm I'm on 9.2.3 for the time being, and there appears to be no change >> to anything named `notmuch` between 9.2.3 and 9.2.6. >> >> Is the change you're talking of unreleased yet? > > Indeed the change isn't actually released, the rename happened in: > >

Re: Python3 cffi bindings

2019-11-04 Thread Gaute Hope
Hi, I just checked out the wip/cffi branch on git.notmuch.org with the purpose of porting Lieer (https://github.com/gauteh/lieer). There seems to be some missing functionality: `Database.get_directory()` specifically. I also ran into a couple of warning when building (included below). Thanks for