Re: [PATCH] ruby: improve compilation with CFLAGS

On Mon, May 17, 2021 at 12:48 AM Felipe Contreras wrote: > > The ruby MakeMakefile generates a makefile that is suboptimal, which has > CFLAGS like this: > > CFLAGS = $(CCDLFLAGS) -march=x86-64 -mtune=generic \ > -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG) > > This works as long as the user

[PATCH] ruby: improve compilation with CFLAGS

The ruby MakeMakefile generates a makefile that is suboptimal, which has CFLAGS like this: CFLAGS = $(CCDLFLAGS) -march=x86-64 -mtune=generic \ -O2 -pipe -fno-plt -fPIC $(ARCH_FLAG) This works as long as the user doesn't modify the Makefile. Certain flags (namely -fPIC) need to be

Re: Breakage after updating to 0.32 (database and path issues)

Hi David, David Bremner writes: > Jack Kamm writes: > >> Update: I was able to fix my problems by explicitly setting "database.path" >> to "$HOME/mail" in my .notmuch-config. Then, notmuch was able to find my >> emails in my "$HOME/mail" as well as my database at "$HOME/mail/.notmuch". >> >>

Re: announce: my fork of alot

2021-05-16 12:19:45, Anton Khirnov wrote: > Thought I'd share with the people here the fork of alot I've been > hacking on for the past ~1.5 years, see if there is any interest in it. > The code can be found at git://git.khirnov.net/alot. This looks very promising, and at least for me personally

Re: ruby: building with CFLAGS="something"

On Sun, May 16 2021, Felipe Contreras wrote: > On Sun, May 16, 2021 at 7:28 AM David Bremner wrote: >> >> >> The rest of the (C and C++) codebase supports >> >> make CFLAGS="-g -O0" >> >> or >> >> CFLAGS="-g -O0" ./configure >> >> but the ruby bindings don't build: > > That's because

Re: [PATCH 1/4] bindings/ruby: unexport CFLAGS when building

On Sun, May 16 2021, David Bremner wrote: > This prevents breaking the ruby build when passing CFLAGS to other > parts of the build. > --- > bindings/Makefile.local | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/bindings/Makefile.local b/bindings/Makefile.local > index

Re: announce: my fork of alot

Quoting Patrick Totzke (2021-05-16 17:41:49) > Hi everyone, > > All this sounds very exciting and I'd be very happy to see these features in > (mainline) alot! > > I agree that some of alot's underlying code is ready for refactoring > and urwid in particular has been a big drag on quickly

Re: announce: my fork of alot

Hi everyone, Of course I feel obliged to chime in and clarify, so here it goes. Quoting Michael J Gruber (2021-05-16 12:15:28) > Anton Khirnov venit, vidit, dixit 2021-05-16 12:19:45: > > Hi, > > > > Thought I'd share with the people here the fork of alot I've been > > hacking on for the past

Re: Fixes for building with -DDEBUG

David Bremner writes: > The first patch is an attempt at fixing the build failure in the ruby > bindings. I'm not sure if this is an acceptable use of "env" or not. I > noticed that all of our shebangs use env, but I guess that is optional > in some sense. I belatedly checked, and POSIX env

[PATCH 3/4] test: ignore debugging messages

Previously building with "-DDEBUG" broke the test suite in several places. --- test/T300-encoding.sh | 12 ++-- test/T310-emacs.sh | 1 - test/T450-emacs-show.sh | 1 - test/test-lib.sh| 23 +++ 4 files changed, 21 insertions(+), 16 deletions(-) diff

[PATCH 4/4] test: quiet some extra debugging output

This output does not cause test failures, but may make it harder to interpret the output. --- test/T140-excludes.sh| 2 +- test/T380-atomicity.sh | 2 +- test/T700-reindex.sh | 4 ++-- test/T750-user-header.sh | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 1/4] bindings/ruby: unexport CFLAGS when building

This prevents breaking the ruby build when passing CFLAGS to other parts of the build. --- bindings/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bindings/Makefile.local b/bindings/Makefile.local index bc960bbc..8e3cd051 100644 --- a/bindings/Makefile.local

[PATCH 2/4] lib/thread: add common prefix to debug messages, join lines

This will simplify filtering these message, e.g. in the test suite. --- lib/thread.cc | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/lib/thread.cc b/lib/thread.cc index 46a50e80..5ac0db6f 100644 --- a/lib/thread.cc +++ b/lib/thread.cc @@ -25,7 +25,7 @@

Fixes for building with -DDEBUG

The first patch is an attempt at fixing the build failure in the ruby bindings. I'm not sure if this is an acceptable use of "env" or not. I noticed that all of our shebangs use env, but I guess that is optional in some sense. The remaining patches keep debugging output from disrupting the test

Re: [PATCH v2 2/6] test: more style fixes

Felipe Contreras writes: > In order to fit the git coding style. > > Signed-off-by: Felipe Contreras I personally prefer this style, but I have to point out that the C and C++ code in the code base (including the Ruby bindings) use the "brace-on-the-next-line" style. Should we strive for

announce: my fork of alot

Hi, Thought I'd share with the people here the fork of alot I've been hacking on for the past ~1.5 years, see if there is any interest in it. The code can be found at git://git.khirnov.net/alot. There are many changes in various places, the most user-visible ones in the thread view mode.