There is existing support for general prerequisites in the test suite.
But it is not very convenient to use: every test case has to keep
track for it's dependencies and they have to be explicitly listed.
The patch aims to add better support for a particular type of external
dependencies: external
---
test/test-lib.sh |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 625d19b..ce7576a 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -635,41 +635,42 @@ test_skip () {
test_report_skip_ "$@"
---
test/test-lib.sh |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index ff85848..f21e45e 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -622,82 +622,85 @@ test_skip () {
test_reset_state_
say
Otherwise, we can set the EMACS_SERVER and return with an error. And
subsequent calls to test_emacs would assume that emacs server is running.
---
test/test-lib.sh |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 222b5e4..ff858
Currently, there is only one such variable test_subtest_known_broken_.
But more will be added in the future.
---
test/test-lib.sh | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 1ea7fa9..222b5e4 100755
--- a/test/test-li
New version of [1] patch series. Changes:
v2 since v1:
* Add test_require_external_prereq function to explicitly check for
external dependencies, use it in test_emacs.
* Indenting fixes.
* Use $binary instead of $1 in test_declare_external_prereq.
Regards,
Dmitry
On Thu, 17 Nov 2011 10:46:58 +0100, Thomas Jost wrote:
> On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin
> wrote:
> > Hi all.
> >
> > The following patch series is an attempt to introduce proper
> > dependencies for external binaries in a less intrusive way
Hi Jameson.
On Thu, 17 Nov 2011 01:14:07 -0800, Jameson Graef Rollins
wrote:
> On Thu, 17 Nov 2011 05:56:17 +0400, Dmitry Kurochkin
> wrote:
> > The following patch series is an attempt to introduce proper
> > dependencies for external binaries in a less intrusive way
On Thu, 17 Nov 2011 11:43:36 +0200, Tomi Ollila wrote:
> On Thu, 17 Nov 2011 05:56:25 +0400, Dmitry Kurochkin
> wrote:
> > Unfortunately, this is needed to avoid the emacs waiting loop.
> > ---
>
> > test/test-lib.sh |4
> > 1 files chan
On Thu, 17 Nov 2011 01:14:13 -0800, Jameson Graef Rollins
wrote:
> On Thu, 17 Nov 2011 05:56:19 +0400, Dmitry Kurochkin
> wrote:
> > Otherwise, we can set the EMACS_SERVER and return with an error. And
> > subsequent calls to test_emacs would assume that emacs server is
On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe
wrote:
> This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38
> ---
> NEWS |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index ff12ca6..a2fa69f 100644
> --- a/NEWS
> +++ b
If emacs is not available, test_expect_equal would be called with only
one argument. The patch fixes this by quoting the (possibly empty)
$(cat OUTPUT) argument.
---
test/emacs |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/test/emacs b/test/emacs
index 75a0a74..9883f40
Unfortunately, this is needed to avoid the emacs waiting loop.
---
test/test-lib.sh |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 840c86c..5bd5bd6 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -858,40 +858,44 @@ expo
That are: dtach(1), emacs(1), emacsclient(1), gdb(1) and gpg(1).
---
test/test-lib.sh |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index c11493d..840c86c 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -1101,20 +1101,27
Some tests (e.g. crypto) do a common initialization required for all
subtests. The patch adds a check for missing external dependencies
during this initialization. If any prerequisites are missing, all
subtests are skipped.
The check is run on the first call of test_reset_state_ function, so
no
There is existing support for general prerequisites in the test suite.
But it is not very convenient to use: every test case has to keep
track for it's dependencies and they have to be explicitly listed.
The patch aims to add better support for a particular type of external
dependencies: external
---
test/test-lib.sh |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index ab8c6fd..acac8ca 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -635,41 +635,42 @@ test_skip () {
test_report_skip_ "$@"
---
test/test-lib.sh |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index ff85848..f21e45e 100755
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -622,82 +622,85 @@ test_skip () {
test_reset_state_
say
Otherwise, we can set the EMACS_SERVER and return with an error. And
subsequent calls to test_emacs would assume that emacs server is running.
---
test/test-lib.sh |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 222b5e4..ff858
Currently, there is only one such variable test_subtest_known_broken_.
But more will be added in the future.
---
test/test-lib.sh | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/test/test-lib.sh b/test/test-lib.sh
index 1ea7fa9..222b5e4 100755
--- a/test/test-li
Hi all.
The following patch series is an attempt to introduce proper
dependencies for external binaries in a less intrusive way than
[1]. The primary aim was to avoid changing every subtest that
uses external binaries.
There are still failing tests if a dependency is
missing (e.g. "Verify that s
On Wed, 16 Nov 2011 18:53:13 +0100, Daniel Schoepe wrote:
> This adds a NEWS entry for commit 4a4ada73b751b1916c5dc4d408a8056411566e38
> ---
> NEWS |6 +-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index ff12ca6..a2fa69f 100644
> --- a/NEWS
> +++ b/
On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner
> wrote:
> > What do people think about this change? Personally I will have change
> > some scripts to not add "tag:", but it isn't that big of a deal.
>
> I would actually prefe
On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins
wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner wrote:
> > What do people think about this change? Personally I will have change
> > some scripts to not add "tag:", but it isn't that big of a deal.
>
> I would actually prefer
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote:
> On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses
> > emacsclient(1) now and it does not print unwanted messages (like
> >
On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila wrote:
> On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements
> wrote:
> >
> > Actually, since sending mail is synchronous, there shouldn't be any
> > issues with buffering or timing. If Emacs successfully sends the
> > message, it will wait for t
On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote:
> On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin
> wrote:
> > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses
> > emacsclient(1) now and it does not print unwanted messages (like
> > those f
On Sat, 12 Nov 2011 23:07:38 +0200, Tomi Ollila wrote:
> On Sat, 12 Nov 2011 10:41:28 -0500, Austin Clements wrote:
> >
> > Actually, since sending mail is synchronous, there shouldn't be any
> > issues with buffering or timing. If Emacs successfully sends the
> > message, it will wait for the
Hi all.
Any objections to this trivial patch? Can we get it pushed?
Regards,
Dmitry
On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila wrote:
> dtach is simpler than screen and is not setuid/setgid program so
> TMPDIR does not get cleared by dynamic loader when executed.
> ---
>
> Updated version after discussion with DmitryKurochkin and amdragon
> on IRC. Thank you.
>
Looks good
On Fri, 11 Nov 2011 13:29:48 +0200, Tomi Ollila wrote:
> On Fri, 11 Nov 2011 12:41:11 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Hi Tomi.
> >
> > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins > finestructure.net> wrote:
> > > From: Tomi Oll
Hi all.
Any objections to this trivial patch? Can we get it pushed?
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
On Fri, 11 Nov 2011 22:48:13 +0200, Tomi Ollila wrote:
> dtach is simpler than screen and is not setuid/setgid program so
> TMPDIR does not get cleared by dynamic loader when executed.
> ---
>
> Updated version after discussion with DmitryKurochkin and amdragon
> on IRC. Thank you.
>
Looks good
Hi Tomi.
On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins wrote:
> From: Tomi Ollila
>
> dtach is lighter than screen and is not setuid/setgid program so
> TMPDIR does not get reset by dynamic loader when executed.
>
> Signed-off-by: Jameson Graef Rollins
> ---
> This tweaks the orig
On Fri, 11 Nov 2011 13:29:48 +0200, Tomi Ollila wrote:
> On Fri, 11 Nov 2011 12:41:11 +0400, Dmitry Kurochkin
> wrote:
> > Hi Tomi.
> >
> > On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins
> > wrote:
> > > From: Tomi Ollila
> > >
Hi Tomi.
On Thu, 10 Nov 2011 14:22:17 -0800, Jameson Graef Rollins
wrote:
> From: Tomi Ollila
>
> dtach is lighter than screen and is not setuid/setgid program so
> TMPDIR does not get reset by dynamic loader when executed.
>
> Signed-off-by: Jameson Graef Rollins
> ---
> This tweaks the ori
Hi Austin.
The patch looks good to me. Thanks for it! A very nice optimization!
Regards,
Dmitry
Hi Austin.
The patch looks good to me. Thanks for it! A very nice optimization!
Regards,
Dmitry
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Hi Austin.
On Mon, 7 Nov 2011 22:55:23 -0500, Austin Clements wrote:
> This optimizes the user's tagging query to exclude messages that won't
> be affected by the tagging operation, saving computation and IO for
> redundant tagging operations.
>
> For example,
> notmuch tag +notmuch to:notmuc
Hi Austin.
On Mon, 7 Nov 2011 22:55:23 -0500, Austin Clements wrote:
> This optimizes the user's tagging query to exclude messages that won't
> be affected by the tagging operation, saving computation and IO for
> redundant tagging operations.
>
> For example,
> notmuch tag +notmuch to:notmuc
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index b70dbfb..aaf69
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 0303d7d..1aa5299 100755
--- a/test/emac
Hi David.
On Sat, 05 Nov 2011 22:06:47 -0300, David Bremner wrote:
> On Fri, 1 Jul 2011 08:55:19 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Add Emacs test to check that `notmuch-show-advance-and-archive'
> > works for the last message in thread with invisible signa
`point-invisible-p' does not work correctly when `invisible'
property is a list. There are standard `invisible-p' and related
functions that should be used instead.
---
emacs/notmuch-lib.el | 15 ---
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/emacs/notmuch-lib.e
Remove `notmuch-show-move-past-invisible-backward' and
`notmuch-show-move-past-invisible-forward' functions which are
unused.
---
emacs/notmuch-show.el |8
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index b70dbfb..aaf69
Use `previous-single-char-property-change' instead of going
through each character by hand and testing it's visibility. This
fixes `notmuch-show-advance-and-archive' to work for the last
message in thread with hidden signature.
---
emacs/notmuch-show.el | 17 +
1 files changed,
Add Emacs test to check that `notmuch-show-advance-and-archive'
works for the last message in thread with invisible signature.
---
test/emacs | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/test/emacs b/test/emacs
index 0303d7d..1aa5299 100755
--- a/test/emac
Hi David.
On Sat, 05 Nov 2011 22:06:47 -0300, David Bremner wrote:
> On Fri, 1 Jul 2011 08:55:19 +0400, Dmitry Kurochkin
> wrote:
> > Add Emacs test to check that `notmuch-show-advance-and-archive'
> > works for the last message in thread with invisible signature.
&g
On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner wrote:
>
> I'd like to add a search term argument to notmuch dump (see
> id:"87wrcijn1w.fsf at zancas.localnet" and followup for context). The
> "notmuch" way would be to have
>
> notmuch dump
>
> do the right thing, and that is easy enough
On Thu, 06 Oct 2011 21:20:40 -0300, David Bremner wrote:
>
> I'd like to add a search term argument to notmuch dump (see
> id:"87wrcijn1w.fsf@zancas.localnet" and followup for context). The
> "notmuch" way would be to have
>
> notmuch dump
>
> do the right thing, and that is easy enough _e
Hi Thomas.
On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost wrote:
> On Sun, 02 Oct 2011 05:45:53 +0400, Dmitry Kurochkin
> wrote:
> > BTW there were patches to support tmux (or maybe it was dtach). IIRC
> > the consensus was that supporting it does not worth complicatin
Hi Thomas.
On Mon, 03 Oct 2011 14:39:36 +0200, Thomas Jost
wrote:
> On Sun, 02 Oct 2011 05:45:53 +0400, Dmitry Kurochkin gmail.com> wrote:
> > BTW there were patches to support tmux (or maybe it was dtach). IIRC
> > the consensus was that supporting it does not worth complic
Hi David.
On Sat, 01 Oct 2011 08:51:20 -0300, David Bremner wrote:
> On Mon, 26 Sep 2011 21:25:08 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Most likely the test passes because emacs is run in server mode and
> > visibility stuff works differently. I sent a patch series [1
Hi David.
On Sat, 01 Oct 2011 08:51:20 -0300, David Bremner wrote:
> On Mon, 26 Sep 2011 21:25:08 +0400, Dmitry Kurochkin
> wrote:
> > Most likely the test passes because emacs is run in server mode and
> > visibility stuff works differently. I sent a patch series [1] t
Hi David.
On Mon, 26 Sep 2011 08:01:16 -0300, David Bremner wrote:
> On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Result: nothing happens except for "No URL at point" message
> >
> > Expected result: the second message is shown/
Hi David.
On Mon, 26 Sep 2011 08:01:16 -0300, David Bremner wrote:
> On Mon, 4 Jul 2011 05:59:03 +0400, Dmitry Kurochkin
> wrote:
> > Result: nothing happens except for "No URL at point" message
> >
> > Expected result: the second message is shown/hidden
On Mon, 12 Sep 2011 23:41:54 -0300, david at tethera.net wrote:
> From: David Bremner
>
> This means that test_subtest_known_broken needs to be called before
> every known broken subtest, which is no different than what is
> documented for the test_begin_subtest case.
>
> The assumption is that
On Mon, 12 Sep 2011 23:41:54 -0300, da...@tethera.net wrote:
> From: David Bremner
>
> This means that test_subtest_known_broken needs to be called before
> every known broken subtest, which is no different than what is
> documented for the test_begin_subtest case.
>
> The assumption is that eve
On Sun, 11 Sep 2011 20:51:47 -0300, David Bremner wrote:
> On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Hi David.
> > IMHO this is not a good idea, because:
> >
> > 1. It introduces multiple places where the flag is reset. If new
>
Hi David.
On Sun, 11 Sep 2011 20:11:54 -0300, david at tethera.net wrote:
> From: David Bremner
>
> Commit 4cc6727 introduced the library function
> test_subtest_known_broken which sets a variable
> test_subtest_known_broken_ . Unfortunately this variable is not reset
> if test_begin_subtest is
On Sun, 11 Sep 2011 20:51:47 -0300, David Bremner wrote:
> On Mon, 12 Sep 2011 03:30:54 +0400, Dmitry Kurochkin
> wrote:
> > Hi David.
> > IMHO this is not a good idea, because:
> >
> > 1. It introduces multiple places where the flag is reset. If new
> >
Hi David.
On Sun, 11 Sep 2011 20:11:54 -0300, da...@tethera.net wrote:
> From: David Bremner
>
> Commit 4cc6727 introduced the library function
> test_subtest_known_broken which sets a variable
> test_subtest_known_broken_ . Unfortunately this variable is not reset
> if test_begin_subtest is not
On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote:
> On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Use `previous-single-char-property-change' instead of going
> > through each character by hand and testing it's visibility. This
>
On Wed, 07 Sep 2011 09:13:22 +, Jani Nikula wrote:
> On Fri, 1 Jul 2011 08:55:20 +0400, Dmitry Kurochkin
> wrote:
> > Use `previous-single-char-property-change' instead of going
> > through each character by hand and testing it's visibility. This
> &g
Hi Jamie.
On Tue, 06 Sep 2011 09:43:00 -0700, Jameson Graef Rollins wrote:
> On Fri, 3 Jun 2011 10:01:06 -0700, Jameson Graef Rollins finestructure.net> wrote:
> > This was a minor oversite in checking of part type when outputing
> > content raw. This was causing gmime was to throw an exceptio
Hi Jamie.
On Tue, 06 Sep 2011 09:43:00 -0700, Jameson Graef Rollins
wrote:
> On Fri, 3 Jun 2011 10:01:06 -0700, Jameson Graef Rollins
> wrote:
> > This was a minor oversite in checking of part type when outputing
> > content raw. This was causing gmime was to throw an exception to
> > stderr
On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost
wrote:
> On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins finestructure.net> wrote:
> Non-text part: multipart/signed
> > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin > gmail.com> wrote:
> > > On W
Hi Thomas.
On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost
wrote:
> Before this change, the test suite reported many failed tests on machines
> where
> screen is not installed (which is the case of many *BSD systems). This patch
> makes the test suite try to use tmux, another terminal multiplex
On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost wrote:
> On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins
> wrote:
> Non-text part: multipart/signed
> > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin
> > wrote:
> > > On Wed, 20 Jul 2011 14:36:36 +0
Hi Thomas.
On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost wrote:
> Before this change, the test suite reported many failed tests on machines
> where
> screen is not installed (which is the case of many *BSD systems). This patch
> makes the test suite try to use tmux, another terminal multiplexe
gards,
Dmitry
> I didn't change the "when" though--not because of personal reasons
> ;)--but because it is used for determining indentation of multi-parts.
>
>
> Cheers,
> Felix
>
>
>
> On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin gmail.com&
Hi Felix.
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote:
> Hi,
>
> I added a variable to toggle message indentation in Emacs.
>
> Please let me know what you think.
>
I like the change. Though I do not think I would use it without
chronological sorting.
Comments on the code below.
gards,
Dmitry
> I didn't change the "when" though--not because of personal reasons
> ;)--but because it is used for determining indentation of multi-parts.
>
>
> Cheers,
> Felix
>
>
>
> On Mon, 11 Jul 2011 12:53:04 +0400, Dmitry Kurochkin
> wro
Hi Felix.
On Mon, 11 Jul 2011 10:42:04 +0200, Felix Geller wrote:
> Hi,
>
> I added a variable to toggle message indentation in Emacs.
>
> Please let me know what you think.
>
I like the change. Though I do not think I would use it without
chronological sorting.
Comments on the code below.
On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe wrote:
> Hi Dmitry,
>
> On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin gmail.com> wrote:
> > Why do we need to remove `goto-address-mode' overlays if it is not
> > enabled ((goto-address-mode t) is below is
Hi Daniel.
On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe wrote:
> This fixes the minor annoyance that message ids were parsed as mail
> addresses by goto-address-mode in notmuch-show buffers.
I did not try it yet but it looks like a nice feature. Though I have
some questions on the code be
On Thu, 07 Jul 2011 10:15:47 +0200, Daniel Schoepe
wrote:
> Hi Dmitry,
>
> On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin
> wrote:
> > Why do we need to remove `goto-address-mode' overlays if it is not
> > enabled ((goto-address-mode t) is below is removed
Hi Daniel.
On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe
wrote:
> This fixes the minor annoyance that message ids were parsed as mail
> addresses by goto-address-mode in notmuch-show buffers.
I did not try it yet but it looks like a nice feature. Though I have
some questions on the code b
On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin wrote:
> The patch rewrites `notmuch-show-message-extent' to be more
> robust. The main goal is to make it work as expected if point is
> invisible. Besides, there are no more point movements and
> property search functions
On Sun, 3 Jul 2011 08:28:06 +0400, Dmitry Kurochkin
wrote:
> The patch rewrites `notmuch-show-message-extent' to be more
> robust. The main goal is to make it work as expected if point is
> invisible. Besides, there are no more point movements and
> property search functions
On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote:
> On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin gmail.com> wrote:
> > It is very convenient when C-e (bound to `widget-end-of-line') ignores
> > trailing spaces inside the search widget. But it only does so
It is very convenient when C-e (bound to `widget-end-of-line') ignores
trailing spaces inside the search widget. But it only does so if a
widget is not followed by a newline (that is why it works in the saved
search widgets). The patch just adds an insisible space after the
search widget to get t
On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote:
> On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin gmail.com> wrote:
> > It is very convenient when C-e (bound to `widget-end-of-line') ignores
> > trailing spaces inside the search widget. But it only does so
It is very convenient when C-e (bound to `widget-end-of-line') ignores
trailing spaces inside the search widget. But it only does so if a
widget is not followed by a newline (that is why it works in the saved
search widgets). The patch just adds an insisible space after the
search widget to get t
Human-friendly scenario:
* open a thread where a message which ends with an HTML part is
followed by another message
* make the first message visible
* goto the beginning of the second message (first line, first colon)
* hit "RET"
Result: nothing happens except for "No URL at point" message
There is existing support for broken tests. But it is not convenient
to use. The primary issue is that we have to maintain a set of
test_expect_*_failure functions which are equivalent to the normal
test_expect_* counterparts except for what functions are called for
result reporting. The patch a
Update test_emacs documentation in test/README according to the latest
changes in emacs tests. Move the note regarding setting variables
from test/emacs to test/README.
---
test/README | 10 +++---
test/emacs |5 -
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/test
This version implements suggestions by Austin.
Regards,
Dmitry
>
Oh. I hope atomicity will be there soon.
> Three minor comments below.
>
> On Sun, Jul 3, 2011 at 9:59 PM, Dmitry Kurochkin
> wrote:
> > There is existing support for broken tests. ?But it is not convenient
> > to use. ?The primary issue is that we have to m
Human-friendly scenario:
* open a thread where a message which ends with an HTML part is
followed by another message
* make the first message visible
* goto the beginning of the second message (first line, first colon)
* hit "RET"
Result: nothing happens except for "No URL at point" message
There is existing support for broken tests. But it is not convenient
to use. The primary issue is that we have to maintain a set of
test_expect_*_failure functions which are equivalent to the normal
test_expect_* counterparts except for what functions are called for
result reporting. The patch a
Update test_emacs documentation in test/README according to the latest
changes in emacs tests. Move the note regarding setting variables
from test/emacs to test/README.
---
test/README | 10 +++---
test/emacs |5 -
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/test
On Mon, 04 Jul 2011 10:55:21 +0200, Pieter Praet wrote:
> On Mon, 4 Jul 2011 12:27:04 +0400, Dmitry Kurochkin
> wrote:
> > It is very convenient when C-e (bound to `widget-end-of-line') ignores
> > trailing spaces inside the search widget. But it only does so if a
>
It is very convenient when C-e (bound to `widget-end-of-line') ignores
trailing spaces inside the search widget. But it only does so if a
widget is not followed by a newline (that is why it works in the saved
search widgets). The patch just adds an insisible space after the
search widget to get t
On Mon, 04 Jul 2011 09:24:17 +0200, Pieter Praet wrote:
> On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin
> wrote:
> > It is very convenient when C-e (bound to `widget-end-of-line') ignores
> > trailing spaces inside the search widget. But it only does so if a
>
It is very convenient when C-e (bound to `widget-end-of-line') ignores
trailing spaces inside the search widget. But it only does so if a
widget is not followed by a newline (that is why it works in the saved
search widgets). The patch just adds an insisible space after the
search widget to get t
Human-friendly scenario:
* open a thread where a message which ends with an HTML part is
followed by another message
* make the first message visible
* goto the beginning of the second message (first line, first colon)
* hit "RET"
Result: nothing happens except for "No URL at point" message
There is existing support for broken tests. But it is not convenient
to use. The primary issue is that we have to maintain a set of
test_expect_*_failure functions which are equivalent to the normal
test_expect_* counterparts except for what functions are called for
result reporting. The patch a
901 - 1000 of 1248 matches
Mail list logo