On Wed, Oct 29 2014, Jesse Rosenthal wrote:
> By the way, this discussion brings up another problem. I wasn't able to
> write a test for this (to address the below concerns) because the test
> suite for thread-naming supplies some sort of auto-generated subject
> for threads with empty subjects.
Hi
On Wed, 29 Oct 2014, Jesse Rosenthal wrote:
> [I'm not sure why the below reply did not go to the list. Later replies
> did, so I assume there must have been so problem in the sending. Mark,
> apologies if you get this twice.]
>
> Hi,
>
> Thanks for taking a look at this.
>
> Mark Walters wr
[I'm not sure why the below reply did not go to the list. Later replies
did, so I assume there must have been so problem in the sending. Mark,
apologies if you get this twice.]
Hi,
Thanks for taking a look at this.
Mark Walters writes:
> I approve of the change in the output but I am unsure abo
Hmm, that's strange -- my inital detailed response to Mark's message
didn't go through to the list. I wonder if it's being filtered or
something.
Thanks for taking a look.
Tomi Ollila writes:
> IMO it is a bit silly to scan through the whole string and use the return
> value of 0 (vs != 0) to have effect. we should probably have something like
> #define EMPTY_STRING(s) ((s)[0] == '\0')
> and use that instead.
Good point. Will put in the
By the way, this discussion brings up another problem. I wasn't able to
write a test for this (to address the below concerns) because the test
suite for thread-naming supplies some sort of auto-generated subject
for threads with empty subjects. So we can't test behavior for dealing
with empty subje
Hi,
Thanks for taking a look at this.
Mark Walters writes:
> I approve of the change in the output but I am unsure about the
> implementation. It would be nice to have a clear rule about which
> subject is taken. Eg:
>
> if sort is oldest first then it is the subject of the oldest
>
Hi
On Tue, 07 Oct 2014, Jesse Rosenthal wrote:
> Currently the thread is named based on either the oldest or newest
> matching message (depending on the search order). If this message has
> an empty subject, though, the thread will show up with an empty
> subject in the search results. (See the
Hi
On Wed, 29 Oct 2014, Jesse Rosenthal wrote:
> [I'm not sure why the below reply did not go to the list. Later replies
> did, so I assume there must have been so problem in the sending. Mark,
> apologies if you get this twice.]
>
> Hi,
>
> Thanks for taking a look at this.
>
> Mark Walters wr
Hi,
Thanks for taking a look at this.
Mark Walters writes:
> I approve of the change in the output but I am unsure about the
> implementation. It would be nice to have a clear rule about which
> subject is taken. Eg:
>
> if sort is oldest first then it is the subject of the oldest
>
[I'm not sure why the below reply did not go to the list. Later replies
did, so I assume there must have been so problem in the sending. Mark,
apologies if you get this twice.]
Hi,
Thanks for taking a look at this.
Mark Walters writes:
> I approve of the change in the output but I am unsure abo
On Wed, Oct 29 2014, Jesse Rosenthal wrote:
> By the way, this discussion brings up another problem. I wasn't able to
> write a test for this (to address the below concerns) because the test
> suite for thread-naming supplies some sort of auto-generated subject
> for threads with empty subjects.
Hmm, that's strange -- my inital detailed response to Mark's message
didn't go through to the list. I wonder if it's being filtered or
something.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Thanks for taking a look.
Tomi Ollila writes:
> IMO it is a bit silly to scan through the whole string and use the return
> value of 0 (vs != 0) to have effect. we should probably have something like
> #define EMPTY_STRING(s) ((s)[0] == '\0')
> and use that instead.
Good point. Will put in the
By the way, this discussion brings up another problem. I wasn't able to
write a test for this (to address the below concerns) because the test
suite for thread-naming supplies some sort of auto-generated subject
for threads with empty subjects. So we can't test behavior for dealing
with empty subje
Hi
On Tue, 07 Oct 2014, Jesse Rosenthal wrote:
> Currently the thread is named based on either the oldest or newest
> matching message (depending on the search order). If this message has
> an empty subject, though, the thread will show up with an empty
> subject in the search results. (See the
On Tue, Oct 07 2014, Jesse Rosenthal wrote:
> Currently the thread is named based on either the oldest or newest
> matching message (depending on the search order). If this message has
> an empty subject, though, the thread will show up with an empty
> subject in the search results. (See the threa
On Wed, 08 Oct 2014, Sergei Shilovsky wrote:
> I would also suggest to drop subjects consisting of only "Re:" and
> "Fwd" sequences
I think it's okay to avoid empty thread names at the lib level; however
I think any further processing should be done near the user interface.
BR,
Jani.
On Tue, Oct 07 2014, Jesse Rosenthal wrote:
> Currently the thread is named based on either the oldest or newest
> matching message (depending on the search order). If this message has
> an empty subject, though, the thread will show up with an empty
> subject in the search results. (See the threa
On Wed, 08 Oct 2014, Sergei Shilovsky wrote:
> I would also suggest to drop subjects consisting of only "Re:" and
> "Fwd" sequences
I think it's okay to avoid empty thread names at the lib level; however
I think any further processing should be done near the user interface.
BR,
Jani.
__
I would also suggest to drop subjects consisting of only "Re:" and
"Fwd" sequences
I would also suggest to drop subjects consisting of only "Re:" and
"Fwd" sequences
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Currently the thread is named based on either the oldest or newest
matching message (depending on the search order). If this message has
an empty subject, though, the thread will show up with an empty
subject in the search results. (See the thread starting with
`id:1412371140-21051-1-git-send-email
Currently the thread is named based on either the oldest or newest
matching message (depending on the search order). If this message has
an empty subject, though, the thread will show up with an empty
subject in the search results. (See the thread starting with
`id:1412371140-21051-1-git-send-email
24 matches
Mail list logo
