[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-12 Thread David Bremner
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson wrote: > Inserting spaces to pad out columns is good, except when the padding > makes the line wider than the window. This looks particularly bad on a > tty where there is no fringe. Pushed, d

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-12 Thread David Bremner
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson d...@dme.org wrote: Inserting spaces to pad out columns is good, except when the padding makes the line wider than the window. This looks particularly bad on a tty where there is no fringe. Pushed, d

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-11 Thread Xavier Maillard
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson wrote: > Inserting spaces to pad out columns is good, except when the padding > makes the line wider than the window. This looks particularly bad on a > tty where there is no fringe. > > Hence, avoid padding the last column on each row. Works

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-11 Thread Ivy Foster
On 11 Jan 2012, at 8:27 am +, David Edmondson wrote: > On Tue, 10 Jan 2012 22:45:47 +0200, Jani Nikula wrote: > > On Tue, 10 Jan 2012 22:41:49 +0200, Jani Nikula wrote: > > > On Tue, 10 Jan 2012 16:18:21 +, David Edmondson > > > wrote: > > > > I have a vague recollection that someone

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-11 Thread David Edmondson
On Tue, 10 Jan 2012 22:45:47 +0200, Jani Nikula wrote: > On Tue, 10 Jan 2012 22:41:49 +0200, Jani Nikula wrote: > > On Tue, 10 Jan 2012 16:18:21 +, David Edmondson wrote: > > > I have a vague recollection that someone reported a bug where > > > `(window-width)' was not the right value to

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-11 Thread David Edmondson
On Tue, 10 Jan 2012 22:45:47 +0200, Jani Nikula j...@nikula.org wrote: On Tue, 10 Jan 2012 22:41:49 +0200, Jani Nikula j...@nikula.org wrote: On Tue, 10 Jan 2012 16:18:21 +, David Edmondson d...@dme.org wrote: I have a vague recollection that someone reported a bug where

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-11 Thread Xavier Maillard
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson d...@dme.org wrote: Inserting spaces to pad out columns is good, except when the padding makes the line wider than the window. This looks particularly bad on a tty where there is no fringe. Hence, avoid padding the last column on each row.

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Jani Nikula
On Tue, 10 Jan 2012 22:41:49 +0200, Jani Nikula wrote: > On Tue, 10 Jan 2012 16:18:21 +, David Edmondson wrote: > > I have a vague recollection that someone reported a bug where > > `(window-width)' was not the right value to use if `line-number-mode' is > > enabled, but I can't find it

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Jani Nikula
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson wrote: > Inserting spaces to pad out columns is good, except when the padding > makes the line wider than the window. This looks particularly bad on a > tty where there is no fringe. > > Hence, avoid padding the last column on each row. > --- >

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
On Tue, 10 Jan 2012 11:05:02 -0500, Austin Clements wrote: > > > Is it possible for a tag in the last column to be just long enough to > > > make the line still wrap? Somehow my current tag set doesn't trigger > > > this bug, so I can't test this case (and I admit I can't follow > > >

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
On Tue, 10 Jan 2012 10:36:50 -0500, Austin Clements wrote: > LGTM, though would it be easier to put this in the else clause of the > if after the setq count? Agreed. I got confused thinking about it due to the empty elements in the matrix, but perhaps that doesn't matter. I'll continue to think,

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Austin Clements
Quoth David Edmondson on Jan 10 at 3:47 pm: > On Tue, 10 Jan 2012 10:36:50 -0500, Austin Clements > wrote: > > LGTM, though would it be easier to put this in the else clause of the > > if after the setq count? > > Agreed. I got confused thinking about it due to the empty elements in > the

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Austin Clements
LGTM, though would it be easier to put this in the else clause of the if after the setq count? Is it possible for a tag in the last column to be just long enough to make the line still wrap? Somehow my current tag set doesn't trigger this bug, so I can't test this case (and I admit I can't

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
Inserting spaces to pad out columns is good, except when the padding makes the line wider than the window. This looks particularly bad on a tty where there is no fringe. Hence, avoid padding the last column on each row. --- Thanks to j4ni in #notmuch for spotting this. emacs/notmuch-hello.el |

[PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
Inserting spaces to pad out columns is good, except when the padding makes the line wider than the window. This looks particularly bad on a tty where there is no fringe. Hence, avoid padding the last column on each row. --- Thanks to j4ni in #notmuch for spotting this. emacs/notmuch-hello.el |

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Austin Clements
LGTM, though would it be easier to put this in the else clause of the if after the setq count? Is it possible for a tag in the last column to be just long enough to make the line still wrap? Somehow my current tag set doesn't trigger this bug, so I can't test this case (and I admit I can't

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
On Tue, 10 Jan 2012 10:36:50 -0500, Austin Clements amdra...@mit.edu wrote: LGTM, though would it be easier to put this in the else clause of the if after the setq count? Agreed. I got confused thinking about it due to the empty elements in the matrix, but perhaps that doesn't matter. I'll

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread David Edmondson
On Tue, 10 Jan 2012 11:05:02 -0500, Austin Clements amdra...@mit.edu wrote: Is it possible for a tag in the last column to be just long enough to make the line still wrap? Somehow my current tag set doesn't trigger this bug, so I can't test this case (and I admit I can't follow

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Jani Nikula
On Tue, 10 Jan 2012 10:15:28 +, David Edmondson d...@dme.org wrote: Inserting spaces to pad out columns is good, except when the padding makes the line wider than the window. This looks particularly bad on a tty where there is no fringe. Hence, avoid padding the last column on each row.

Re: [PATCH] emacs: Improve `notmuch-hello' display on ttys.

2012-01-10 Thread Jani Nikula
On Tue, 10 Jan 2012 22:41:49 +0200, Jani Nikula j...@nikula.org wrote: On Tue, 10 Jan 2012 16:18:21 +, David Edmondson d...@dme.org wrote: I have a vague recollection that someone reported a bug where `(window-width)' was not the right value to use if `line-number-mode' is enabled, but