[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-23 Thread Pieter Praet
On Sun, 22 Jan 2012 23:09:30 +0100, Xavier Maillard wrote: > Hey Pieter, > Hi! > On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > > Add

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-22 Thread Xavier Maillard
Hey Pieter, On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Adding a 'deleted' tag does not mean there will be a delete/purge process ;) (curren

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-22 Thread Pieter Praet
On Sun, 22 Jan 2012 23:09:30 +0100, Xavier Maillard wrote: > Hey Pieter, > Hi! > On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > > Addi

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-22 Thread Xavier Maillard
Hey Pieter, On Thu, 19 Jan 2012 20:19:00 +0100, Pieter Praet wrote: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Adding a 'deleted' tag does not mean there will be a delete/purge process ;) (curren

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 22:01:27 +, Mark Walters wrote: > > > > I am happy with them appearing as a non matching message, but currently > > > they appear as a full open message. (The patch to achieve this is > > > trivial: essentially transpose part of Austin's patch of > > > notmuch-search.c in

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 14:36:47 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > > Same here. I probably will use the spam t

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Mark Walters
> > I am happy with them appearing as a non matching message, but currently > > they appear as a full open message. (The patch to achieve this is > > trivial: essentially transpose part of Austin's patch of > > notmuch-search.c into notmuch-show.c) > > This definitely sounds like the right thing

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Mark Walters
> On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > > I would actually like make a different suggestion: extend > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > my deleted (ie hidden rather than actually deleted) messages return when > > viewi

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
Nice feature! I won't be using it myself, but I can imagine it being *very* useful for those who still feel the need to "delete" email :). Nitpicking: - All other config-related functions and args include the section title in their name [1], so for the sake of consistency, we might want to

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread markwalters1...@gmail.com
> > So I'd like to suggest replacing all occurences of "auto_exclude_tags" > > with "search_exclude_tags" (and simply "exclude_tags" in the args to > > `_config_get_list' and `_config_set_list', of course). > > You are technically correct, the best kind of correct. I'd completely > missed

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Austin Clements
Quoth Mark Walters on Jan 19 at 8:23 pm: > > > On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > > > I would actually like make a different suggestion: extend > > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > > my deleted (ie hidden rather t

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Aaron Ecay
On Thu, 19 Jan 2012 20:06:27 +, markwalters1009 at gmail.com wrote: > I would actually like make a different suggestion: extend > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > my deleted (ie hidden rather than actually deleted) messages return when > viewing a thread

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 22:01:27 +, Mark Walters wrote: > > > > I am happy with them appearing as a non matching message, but currently > > > they appear as a full open message. (The patch to achieve this is > > > trivial: essentially transpose part of Austin's patch of > > > notmuch-search.c in

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Austin Clements
Quoth Pieter Praet on Jan 19 at 8:19 pm: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Same here. I probably will use the spam tag, though. > Nitpicking: > > - All other config-related functions a

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Mark Walters
> > I am happy with them appearing as a non matching message, but currently > > they appear as a full open message. (The patch to achieve this is > > trivial: essentially transpose part of Austin's patch of > > notmuch-search.c into notmuch-show.c) > > This definitely sounds like the right thing

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
On Thu, 19 Jan 2012 14:36:47 -0500, Austin Clements wrote: > Quoth Pieter Praet on Jan 19 at 8:19 pm: > > Nice feature! I won't be using it myself, but I can imagine it being > > *very* useful for those who still feel the need to "delete" email :). > > Same here. I probably will use the spam t

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Austin Clements
Quoth Mark Walters on Jan 19 at 8:23 pm: > > > On Thu, 19 Jan 2012 20:06:27 +, markwalters1...@gmail.com wrote: > > > I would actually like make a different suggestion: extend > > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > > my deleted (ie hidden rather than

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Mark Walters
> On Thu, 19 Jan 2012 20:06:27 +, markwalters1...@gmail.com wrote: > > I would actually like make a different suggestion: extend > > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > > my deleted (ie hidden rather than actually deleted) messages return when > > viewing

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Aaron Ecay
On Thu, 19 Jan 2012 20:06:27 +, markwalters1...@gmail.com wrote: > I would actually like make a different suggestion: extend > auto_exclude_tags to notmuch-show as well. I was quite surprised to see > my deleted (ie hidden rather than actually deleted) messages return when > viewing a thread.

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread markwalters1009
> > So I'd like to suggest replacing all occurences of "auto_exclude_tags" > > with "search_exclude_tags" (and simply "exclude_tags" in the args to > > `_config_get_list' and `_config_set_list', of course). > > You are technically correct, the best kind of correct. I'd completely > missed

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Austin Clements
Quoth Pieter Praet on Jan 19 at 8:19 pm: > Nice feature! I won't be using it myself, but I can imagine it being > *very* useful for those who still feel the need to "delete" email :). Same here. I probably will use the spam tag, though. > Nitpicking: > > - All other config-related functions a

Re: [PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-19 Thread Pieter Praet
Nice feature! I won't be using it myself, but I can imagine it being *very* useful for those who still feel the need to "delete" email :). Nitpicking: - All other config-related functions and args include the section title in their name [1], so for the sake of consistency, we might want to

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-14 Thread Austin Clements
This adds a "search" section to the config file and an "auto_tag_exclusions" setting in that section. The search and count commands pass tag tags from the configuration to the library. --- notmuch-client.h |8 notmuch-config.c | 42 ++ notmuc

[PATCH v3 2/2] search: Support automatic tag exclusions

2012-01-14 Thread Austin Clements
This adds a "search" section to the config file and an "auto_tag_exclusions" setting in that section. The search and count commands pass tag tags from the configuration to the library. --- notmuch-client.h |8 notmuch-config.c | 42 ++ notmuc