Re: Consider following XDG base directory specification

2022-10-24 Thread Dario
Thanks for replying thank you very much for pointing me in the right direction. I guess I didn't RTFM properly. Environment variables are good enough for me. Keep up the good work. On 2022-10-24 08:21:42-0300, David Bremner wrote: > Dario writes: > > > I apologize in advance if the issue has

Re: Consider following XDG base directory specification

2022-10-24 Thread David Bremner
Dario writes: > I apologize in advance if the issue has already been raised by somebody else > but I couldn't find anything on the bug tracker and furthermore I'm one of > those freaks who prefer a de-cluttered home directory. ;-) > > Instead of saving config file in $HOME/.notmuch-config, >

Re: Selection bug

2022-10-18 Thread Justus Winter
David Bremner writes: > Justus Winter writes: > >> I think I found a reproducer: >> >> mkdir -p /tmp/selection-bug/{tmp,new,cur} >> echo "[database] >> path=/tmp/selection-bug" > /tmp/selection-bug/notmuch-config >> NOTMUCH_CONFIG=/tmp/selection-bug/notmuch-config notmuch new >>

Re: [PATCH] emacs: fix dangling overlays in notmuch-search

2022-10-16 Thread Matt Armstrong
Matt Armstrong writes: > See Emacs bug#58479. An upcoming change in Emacs will make these > dangling overlays visible to the user. It seems that the ellipsis overlays were shown due to a bug in Emacs, but this patch is still a reasonable idea. Otherwise, every time a notmuch search buffer is

Re: Possible bug: incorrect processing of multipart, base64-encoded subject lines.

2022-10-14 Thread Jakub Wilk
* Thibault Polge , 2022-09-21 16:15: Subject: =?UTF-8?B?TGl2cmFpc29uIHByw6l2dWUgcG91ciBhdWpvdXJk4oCZaHU=?= =?UTF-8?B?aTogUkVTVFJBUCBTYWRkbGUgQmFnIFNhY2NvY2hlLi4u?= Notmuch displays the subject as only the decoded contents of the first fragment I believe this is now fixed in GMime upstream:

Re: [PATCH] nmweb: Fix spacing around punctuation in headers

2022-10-14 Thread David Bremner
Jakub Wilk writes: > * David Bremner , 2022-10-11 08:20: >>>This is completely untested, but hey, what could possibly go wrong? >> >>I've yolo-ed this into production on nmbug.notmuchmail.org. Maybe you >>can poke at it and see if it looks like you expect. > > Looks good. Thanks! > applied to

Re: Selection bug

2022-10-14 Thread David Bremner
Justus Winter writes: > I think I found a reproducer: > > mkdir -p /tmp/selection-bug/{tmp,new,cur} > echo "[database] > path=/tmp/selection-bug" > /tmp/selection-bug/notmuch-config > NOTMUCH_CONFIG=/tmp/selection-bug/notmuch-config notmuch new > NOTMUCH_CONFIG=/tmp/selection-bug/notmuch-config

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-14 Thread Tomi Ollila
On Wed, Oct 12 2022, Robin Jarry wrote: > Hi Tomi, > > Tomi Ollila, Oct 12, 2022 at 21:39: >> > diff --git a/notmuch-show.c b/notmuch-show.c >> > index ee9efa7448d7..ad31e0123268 100644 >> > --- a/notmuch-show.c >> > +++ b/notmuch-show.c >> > @@ -1159,6 +1159,18 @@ do_show_threaded (void *ctx, >>

Re: Splitting long lines in .notmuch-config

2022-10-13 Thread Rudolf Adamkovič
David Bremner writes: > Not sure if this helps, but we are using the GLib GKeyFile API, so > whatever it supports (if anything) for line continuation, we do too. I found nothing in the GLib/GKeyFile documentation. But then, I figured that Org mode has me covered, as usual. If anyone has the

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-12 Thread Robin Jarry
Hi Tomi, Tomi Ollila, Oct 12, 2022 at 21:39: > > diff --git a/notmuch-show.c b/notmuch-show.c > > index ee9efa7448d7..ad31e0123268 100644 > > --- a/notmuch-show.c > > +++ b/notmuch-show.c > > @@ -1159,6 +1159,18 @@ do_show_threaded (void *ctx, > > notmuch_thread_t *thread; > >

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-12 Thread Tomi Ollila
On Wed, Oct 12 2022, Robin Jarry wrote: > notmuch search does not output header values. However, when browsing > through a large email corpus, it can be time saving to be able to > paginate without running notmuch show for each message/thread. > > Add --offset and --limit options to notmuch show.

Re: Selection bug

2022-10-12 Thread Justus Winter
Hi David :) David Bremner writes: > Justus Winter writes: > >> there is a bug in notmuch emacs that is mildly annoying. Sometimes when >> I refresh my search buffer, and there are new mails, the topmost >> (i.e. newest) message seems to be selected (i.e. with green background), >> but in fact

Re: [PATCH] cli: add options --offset and --limit to notmuch show

2022-10-11 Thread Robin Jarry
Robin Jarry, Oct 12, 2022 at 00:19: > + if (print_status_query ("notmuch search", query, s)) I just realized that I copy pasted code from notmuch-search.c and did not updated everything on the way... I'll hold before sending a v2 if there are other remarks or changes required. Cheers all.

Re: [PATCH] nmweb: Fix spacing around punctuation in headers

2022-10-11 Thread Jakub Wilk
* David Bremner , 2022-10-11 08:20: This is completely untested, but hey, what could possibly go wrong? I've yolo-ed this into production on nmbug.notmuchmail.org. Maybe you can poke at it and see if it looks like you expect. Looks good. Thanks! -- Jakub Wilk

Re: Selection bug

2022-10-11 Thread David Bremner
Justus Winter writes: > there is a bug in notmuch emacs that is mildly annoying. Sometimes when > I refresh my search buffer, and there are new mails, the topmost > (i.e. newest) message seems to be selected (i.e. with green background), > but in fact if i hit enter (or do any other state

Re: [PATCH] nmweb: Fix spacing around punctuation in headers

2022-10-11 Thread David Bremner
Jakub Wilk writes: > --- > devel/notmuch-web/nmweb.py| 2 +- > devel/notmuch-web/templates/show.html | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > This is completely untested, but hey, what could possibly go wrong? > I've yolo-ed this into production on

Re: [PATCH] test: add regression test for Subject with newline.

2022-10-10 Thread David Bremner
David Bremner writes: > This tests the issue reported by Thibault in id:87wn9w4xus@thb.lt > --- > > I could not duplicate the problem here. Maybe it depends on the version of > gmime? > I have 3.2.9 here. Now that I have gmime 3.2.13 I can confirm your bug (my previously posted test

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-10 Thread Tomi Ollila
On Thu, Oct 06 2022, Michael J. Gruber wrote: > Am Do., 6. Okt. 2022 um 18:34 Uhr schrieb David Bremner : >> >> Michael J Gruber writes: >> >> > >> > Yes, lto-wrapper calls make. >> > >> > Are we compiling test functions on the fly during the test? In that >> > case we need to make sure that

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-06 Thread David Bremner
Michael J Gruber writes: > Could it be that within a parallel make session, that gcc-make-call > gets delegated to the master make jobserver and thus gcc returns too > early? Wild speculation, I admit. That's the kind of thing I would consider a bug in gcc. > I haven't checked the code, but

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-06 Thread Michael J Gruber
Am Do., 6. Okt. 2022 um 18:34 Uhr schrieb David Bremner : > > Michael J Gruber writes: > > > > > Yes, lto-wrapper calls make. > > > > Are we compiling test functions on the fly during the test? In that > > case we need to make sure that each test depends on the build > > products, or else the

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-06 Thread David Bremner
Michael J Gruber writes: > > Yes, lto-wrapper calls make. > > Are we compiling test functions on the fly during the test? In that > case we need to make sure that each test depends on the build > products, or else the test helper compilation and its users might run > in parallel ... Yes, we

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-06 Thread David Bremner
David Bremner writes: > Gianfranco Costamagna writes: > >> Hello, the test is now failing in Ubuntu 22.04 (last LTS), when run with >> parallel > 1 >> >> (version 0.37) >> >> e.g. here you can see a build fail >> >> /<>/test/test-lib.sh: line 904: ./test19: No such file or >> directory >>

Re: Test failure in Ubuntu 22.04 and 22.10 (new test)

2022-10-06 Thread David Bremner
Gianfranco Costamagna writes: > Hello, the test is now failing in Ubuntu 22.04 (last LTS), when run with > parallel > 1 > > (version 0.37) > > e.g. here you can see a build fail > > /<>/test/test-lib.sh: line 904: ./test19: No such file or > directory > make[2]: *** read jobs pipe: Bad file

Re: Splitting long lines in .notmuch-config

2022-10-05 Thread David Bremner
Rudolf Adamkovič writes: > Hi there! > > Is it possible to split long lines in the .notmuch-config? I normally > wrap my markup, config, and source files to 80 columns, but some of the > queries I define in my .notmuch-config now sprawl for over 200 columns. > I have tried to use two

Re: Tag notmuch email based on header values?

2022-10-04 Thread David Bremner
obvious I am missing. > > PS: Please CC me on replies, as I am not subscribed to the list. > You can add RT-Owner as header to index (see notmuch-config(1)) and re-index. ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: Tag notmuch email based on header values?

2022-10-04 Thread Alan Schmitt
Hello, On 2022-10-04 14:04, Petter Reinholdtsen writes: > I would like to tag all emails with a specific header, but fail to find > a way to do this. Is this a missing feature in notmuch? > > To be specific, I want to filter out emails related to request tracker > tickets owned by me at the

Re: [PATCH 2/2] lib: add better diagnostics for over long filenames.

2022-10-02 Thread Jose A Ortega Ruiz
On Sun, Oct 02 2022, David Bremner wrote: > Previously we just crashed with an internal error. With this change, > the caller can handle it better, although the error code could be > further improved. This works better for me, yes. A possible improvement is that, with this patch, one's only

Re: [PATCH] emacs: add notmuch-search-edit-search and notmuch-tree-edit-search

2022-09-23 Thread David Bremner
h-mode. At the risk of stating the obvious, we already sortof have this with notmuch-tag-jump and notmuch-jump-search. Maybe that code can be generalized / re-used? It might just be familiarity, but I actually prefer the way our "hydras" work to those of magit. d __

Re: [PATCH] emacs: add notmuch-search-edit-search and notmuch-tree-edit-search

2022-09-23 Thread David Bremner
Tomi Ollila writes: > ...and bind these to "E" in their respective keymaps. > > Expected to be called interactively, then using read-from-minibuffer > with current search string as initial contents for editing. > (Noninteractive use makes little sense, but is supported.) applied to master.

Re: [PATCH] nmweb: escape subject in search view

2022-09-23 Thread David Bremner
David Bremner writes: > Fix a bug reported by Jakub Wilk [1]. > > [1]: id:20220822064717.qftn4tr7cs4r2...@jwilk.net applied to master d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] test: replace aging OpenPGP key used in the test suite

2022-09-23 Thread David Bremner
Justus Winter writes: > This replaces the old OpenPGPv4 key that is used in the test suite > with a more modern OpenPGPv4 key. All cryptographic artifacts in the > test suite are updated accordingly. > > Having old cryptographic artifacts in the test suite presents a > problem once the old

Re: [PATCH] test: replace aging OpenPGP key used in the test suite

2022-09-23 Thread Daniel Kahn Gillmor
I believe this is "v2" of Justus's earlier patch id:20220909161354.715326-1-jus...@sequoia-pgp.org, even though the subject line doesn't say "v2" in it: On Thu 2022-09-22 10:46:06 +0200, Justus Winter wrote: > This replaces the old OpenPGPv4 key that is used in the test suite > with a more modern

Re: [PATCH] test: replace aging OpenPGP key used in the test suite

2022-09-22 Thread Michael J Gruber
ted > > signatures. This is not wrong per-se, I'm just wondering whether it is > > intentional (or forced by the standard) when the aim of this series is > > future-proofing. sha256 is the current "replacement" for sha1, which > > means it's the one which will be

Re: [PATCH] test: replace aging OpenPGP key used in the test suite

2022-09-22 Thread Justus Winter
e current "replacement" for sha1, which > means it's the one which will be replaced next ;) Yes I am. It happened when I re-created the signature. Recreating the artifacts was somewhat tedious (I'm working on tooling for that, but the changes to notmuch I created by hand), so I opted

Re: [PATCH] test: replace aging OpenPGP key used in the test suite

2022-09-22 Thread Michael J Gruber
Am Do., 22. Sept. 2022 um 10:47 Uhr schrieb Justus Winter : > > This replaces the old OpenPGPv4 key that is used in the test suite > with a more modern OpenPGPv4 key. All cryptographic artifacts in the Both v4? Only one key file is named v4. > @@ -6,7 +6,7 @@ Message-ID: > MIME-Version: 1.0

Re: [PATCH 2/2] test: replace aging OpenPGP key used in the test suite

2022-09-19 Thread David Bremner
Justus Winter writes: > This replaces the old OpenPGPv4 key that is used in the test suite > with a more modern OpenPGPv4 key. All cryptographic artifacts in the > test suite are updated accordingly. > > Having old cryptographic artifacts in the test suite presents a > problem once the old

Re: [PATCH] emacs: notmuch-tree-outline-mode

2022-09-19 Thread Jose A Ortega Ruiz
On Sun, Sep 18 2022, jao wrote: > I think the same trick i'm playing could be used to allow folding of > subtrees at more than one level (just insert several hidden > instead > of just one), but i'm not sure it would be of much use or introduce > any problem, so i've not done it here. Perhaps we

Re: Notmuch emacs client is slow when opening inbox.

2022-09-19 Thread David Bremner
Jose A Ortega Ruiz writes: > On Sun, Sep 18 2022, David Bremner wrote: > >> Jose A Ortega Ruiz writes: >>> >>> interesting! if we were to have this, i think i'd prefer pagination >>> rather than increasing the limit and keeping the old ones, and make it >>> work for tree searches too. and

Re: Notmuch emacs client is slow when opening inbox.

2022-09-18 Thread Jose A Ortega Ruiz
On Sun, Sep 18 2022, David Bremner wrote: > Jose A Ortega Ruiz writes: >> >> interesting! if we were to have this, i think i'd prefer pagination >> rather than increasing the limit and keeping the old ones, and make it >> work for tree searches too. and perhaps the limit (page size) could be

Re: Notmuch emacs client is slow when opening inbox.

2022-09-18 Thread David Bremner
Jose A Ortega Ruiz writes: > > interesting! if we were to have this, i think i'd prefer pagination > rather than increasing the limit and keeping the old ones, and make it > work for tree searches too. and perhaps the limit (page size) could be > a query parameter, so that one could have

Re: [PATCH] emacs: add notmuch-search-edit-search and notmuch-tree-edit-search

2022-09-18 Thread Jose A Ortega Ruiz
looks good, and very useful, to me, fwiw. now i'll have to free E in my keymap, which i was using for something else... i was thinking that, given how crowded those keymaps are becoming, it might be worth considering two-key chords, with the first grouping by "kind" (a la gnus); e.g. "/" could

Re: Notmuch emacs client is slow when opening inbox.

2022-09-17 Thread Sam Hedin
On Sat, Sep 17, 2022 at 12:46 PM Teemu Likonen wrote: >to:something AND date:90days.. >tag:something AND date:90days.. That's perfect, thank you. I hadn't even considered a date range. On Sat, Sep 17, 2022 at 8:01 PM Jose A Ortega Ruiz wrote: > interesting! if we were to have this, i

Re: Notmuch emacs client is slow when opening inbox.

2022-09-17 Thread Jose A Ortega Ruiz
On Sat, Sep 17 2022, sam.he...@gmail.com wrote: > I found this from 2011, which seems to discuss the feature I want. > However, it was never merged as far as I can see: > https://notmuchmail.org/pipermail/notmuch/2011/006297.html interesting! if we were to have this, i think i'd prefer

Re: Notmuch emacs client is slow when opening inbox.

2022-09-17 Thread Teemu Likonen
* 2022-09-17 12:19:44+0200, sam hedin wrote: > While the notmuch emacs client is in general very impressive, opening > my inbox makes Emacs lag terribly. I believe the reason is that there > seems to be no way to limit the number of results, so when I search > for the inbox tag, there are too

Re: [PATCH] nmweb: escape subject in search view

2022-09-16 Thread David Bremner
David Bremner writes: > Fix a bug reported by Jakub Wilk [1]. > > [1]: id:20220822064717.qftn4tr7cs4r2...@jwilk.net > --- > devel/notmuch-web/nmweb.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/devel/notmuch-web/nmweb.py b/devel/notmuch-web/nmweb.py > index

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-16 Thread Tomi Ollila
On Mon, Sep 12 2022, Daniel Kahn Gillmor wrote: > On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: >> Tomi Ollila writes: >> >>> On Fri, Sep 09 2022, Justus Winter wrote: >>> --- test/T350-crypto.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: "-1 tests skipped"

2022-09-16 Thread Tomi Ollila
On Sun, Sep 11 2022, Daniel Kahn Gillmor wrote: > I'm running the test suite on notmuch master > (8eabd6388ecb7bea8246a9ba6943a0432d23406e), and i see the following > report: > > ``` > All 1758 tests behaved as expected (12 expected failures). > -1 tests skipped. > All tests in 2 files skipped. >

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-12 Thread Daniel Kahn Gillmor
On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: > Tomi Ollila writes: > >> On Fri, Sep 09 2022, Justus Winter wrote: >> >>> --- >>> test/T350-crypto.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh >>> index

Re: [PATCH 2/2] test: replace aging OpenPGP key used in the test suite

2022-09-12 Thread Daniel Kahn Gillmor
This series looks good to me. i've tested it and there are no failures, and there's nothing i can see that's obviously missing from it. Thanks for the thorough fix, Justus! A few notes about the change (none of them even close to being blockers): - i note that signature creation timestamps had

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-11 Thread Justus Winter
Tomi Ollila writes: > On Fri, Sep 09 2022, Justus Winter wrote: > >> --- >> test/T350-crypto.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh >> index 3c6626b4..721cbfdd 100755 >> --- a/test/T350-crypto.sh >> +++

Re: [PATCH 1/2] test: compute expected keyid from fingerprint

2022-09-11 Thread Tomi Ollila
On Fri, Sep 09 2022, Justus Winter wrote: > --- > test/T350-crypto.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 3c6626b4..721cbfdd 100755 > --- a/test/T350-crypto.sh > +++ b/test/T350-crypto.sh > @@ -467,7 +467,7 @@

Re: Multiple files per message in emacs

2022-09-06 Thread Rafael Ávila de Espíndola
Rafael Ávila de Espíndola writes: >> If you can build from source, there is new support for viewing >> duplicates in master. > Just tested with 0.37 and it works. One thing that still seems to be missing is handling different tags. For example, there is no way to mark a new duplicated message

Re: feature request: notmuch-show-print-message w/prefix to print PS to file

2022-09-05 Thread Alexander Adolf
David Bremner writes: > [...] > One workaround is to set notmuch-print-mechanism to > notmuch-print-ps-print/evince, and save the file from evince. In principle yes, but this requires a specific third party app to be installed. We have all necessary means built into Emacs already, so it would

Re: best practices for keeping a notmuch tag in sync with maildir folder

2022-09-05 Thread Michael J Gruber
Am Mo., 5. Sept. 2022 um 13:33 Uhr schrieb David Bremner : > > Bence Ferdinandy writes: > > > are there any best practices for keeping notmuch tags synced with an imap > > folder? It seems to me that simply moving a mail file in the shell from one > > folder to the other is not something that

Re: best practices for keeping a notmuch tag in sync with maildir folder

2022-09-05 Thread David Bremner
Bence Ferdinandy writes: > are there any best practices for keeping notmuch tags synced with an imap > folder? It seems to me that simply moving a mail file in the shell from one > folder to the other is not something that works well, at least with mbsync > the moved file didn't appear in my

Re: feature request: notmuch-show-print-message w/prefix to print PS to file

2022-09-05 Thread David Bremner
Alexander Adolf writes: > Hello, > > I'd like to request a feature. My intent is to redirect PostScript > printing of a message via `notmuch-show-print-message` to a file. > Ideally (IMHO) `notmuch-show-print-message` would accept an optional > prefix argument ("C-u"), which would be passed down

Re: Database location bug when database does not already exist

2022-09-03 Thread Sean Whitton
Hello, On Sat 03 Sep 2022 at 08:34AM -03, David Bremner wrote: > Sean Whitton writes: > >> Hello, >> >> In the following situation: >> >> - only notmuch config is ~/.notmuch-config >> - database.mail_root is set >> - database.path is not set >> - notmuch database does not yet exist >> >> then

Re: [PATCH 1/3] test: rename indexing corpus

2022-09-03 Thread David Bremner
David Bremner writes: > The corpus is not really suitable for general indexing test since the > sole message is ignored (and will most likely continue to be ignored) > by notmuch-new. applied the first two patches (test changes) to master ___ notmuch

Re: Feature request: search for last N modified mails

2022-09-03 Thread David Bremner
Ico writes: > My normal mail workflow is to keep todo's in my inbox; these can be a few days > or weeks old if I'm lazy. Every now and then I find myself accidentally > removing things from the inbox, and I have a very hard time finding things > back. As discussed on #notmuch IRC today: I'd like

Re: [PATCH 1/3] lib/sexp: provide relative lastmod queries

2022-09-03 Thread David Bremner
David Bremner writes: > Test the relatively trivial logic changes for the sexp query parser > first before refactoring that logic to share with the infix query > parser. series applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org

Re: Database location bug when database does not already exist

2022-09-03 Thread David Bremner
Sean Whitton writes: > Hello, > > In the following situation: > > - only notmuch config is ~/.notmuch-config > - database.mail_root is set > - database.path is not set > - notmuch database does not yet exist > > then notmuch wants to create its db under mail_root/.notmuch, contrary > to

Re: [PATCH 2/6] test: add test for creating database in various configurations.

2022-09-03 Thread David Bremner
David Bremner writes: > The existing database creation (via add_email_corpus) was always done > in the traditional configuration. The use of xapian-metadata is just > to portably ensure that there is a database created where we expect > there to be. remainder of the series applied to master. d

Re: [PATCH] emacs: new notmuch-tree-process-exit-functions

2022-09-03 Thread David Bremner
jao writes: > Hook run when the tree insertion process finishes its job. > applied to master ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-09-03 Thread David Bremner
Antoine Beaupré writes: > This enables auto-completion of commands, something which plain > read-string does not do. It's otherwise a drop-in > replacement. According to `C-h f`, read-shell-command was introduced > in Emacs 23.1 or earlier. Applied to master. d

Re: [PATCH] emacs/show: use read-shell-command instead of read-string

2022-08-31 Thread Tomi Ollila
On Tue, Aug 30 2022, Antoine Beaupré wrote: > This enables auto-completion of commands, something which plain > read-string does not do. It's otherwise a drop-in > replacement. According to `C-h f`, read-shell-command was introduced > in Emacs 23.1 or earlier. LGTM. Tomi > --- >

Re: notmuch release 0.37 now available

2022-08-22 Thread Michael J Gruber
Thanks for another fine release, and for being a pleasant upstream to work with! For Fedora Linux/RHEL/etc folks: notmuch 0.37 is available in rawhide and f37 (branched), as well as in updates-testing for the current release f36, all with sfsexp support. It will not go to any EPEL branch (per

Re: nmweb HTML injection

2022-08-22 Thread Michael J Gruber
Am Mo., 22. Aug. 2022 um 09:22 Uhr schrieb Jakub Wilk : > > See: https://nmbug.notmuchmail.org/nmweb/search/markup%20where%20appropriate > > and from the mail subject was dumped without escaping into HTML. > Interesting :) The body is htmlescape()ed, but the subject header is used as is. I

Re: notmuch release 0.37 now available

2022-08-22 Thread erik colson
Awesome! Thank you! -- erik colson ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] emacs: new notmuch-tree-process-exit-functions

2022-08-21 Thread Tomi Ollila
On Sun, Aug 21 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- LGTM. I (also would have chosen this name instead of the *sentinel* one) Tomi > This patch supersedes , but > changing the new variable name. > > Right now, it can be used for silly

Re: [Emacs] Using notmuch-address with EUDC, and completion-at-point

2022-08-18 Thread Alexander Adolf
Hello David, David Bremner writes: > [...] > One point is that it is unlikely that notmuch will ever require the most > recent version of emacs (currently the baseline is supposedly emacs > 25.1). It's fine to optionally take advantage of new features in emacs, > but we want people to be able

Re: [Emacs] Using notmuch-address with EUDC, and completion-at-point

2022-08-18 Thread David Bremner
Alexander Adolf writes: > > From what it sound s like, it would seem to make more sense to wait for > that Emacs patch to get merged? Bundling the new code with notmuch, but > without any integration with the rest of it, effectively leaving it to > users to figure out how to make use of it

Re: Formatting nm-search output

2022-08-18 Thread David Bremner
martin f krafft writes: > Is there a way to get notmuch search to print custom fields for the > messages it returns, i.e. if I wanted to get a list of messages (not > threads) matching my search terms, along with e.g. date, subject, > from/to/cc, and body size? Hi Martin; Currently the

Re: [PATCH] emacs: new notmuch-tree-process-hook

2022-08-17 Thread jao
how about notmuch-tree-process-sentinel-functions, or perhaps, since it's only called on exit, notmuch-tree-process-exit-functions? jao ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org

Re: [PATCH] emacs: new notmuch-tree-process-hook

2022-08-16 Thread Tomi Ollila
On Tue, Aug 16 2022, j...@gnu.org wrote: > Hook run when the tree insertion process finishes its job. > > -- > > Right now, it can be used for silly things like removing or changing > the the "End of search." hardcoded message in the tree buffer. But > also for more sophisticated things like

Re: [Emacs] Using notmuch-address with EUDC, and completion-at-point

2022-08-16 Thread Alexander Adolf
Hello David, David Bremner writes: > [...] >> You could do >> >> (require 'eudcb-notmuch-address) >> (eudc-notmuch-address-set-server "localhost") >> >> and bind the function eudc-expand-inline to a key chord of your choice >> in message-mode-map. >> >> Then you'd no longer have to

Re: [PATCH] test: increase cffi timeout

2022-08-16 Thread David Bremner
michaeljgruber+grubix+...@gmail.com writes: > From: Michael J Gruber > > By default, the test suite uses 2min for other tests and 5s for cffi > tests. Sporadically, this leads to test failures caused by the timeout > on slower or loaded test infrastructure (as seen on ppc64le in Fedora's >

Re: [PATCH] test: increase cffi timeout

2022-08-15 Thread Tomi Ollila
On Sun, Aug 14 2022, michaeljgruber wrote: > From: Michael J Gruber > > By default, the test suite uses 2min for other tests and 5s for cffi > tests. Sporadically, this leads to test failures caused by the timeout > on slower or loaded test infrastructure (as seen on ppc64le in Fedora's >

Re: release 0.37 is immanent

2022-08-14 Thread David Bremner
David Bremner writes: > It has been a while, and there have been quite a few changes since > 0.36. I propose feature freeze for 0.37 August 13, with a release around > a week after that. > > d Release candidate 0.37_rc0 has been tagged and uploaded to notmuchmail.org. Please report any serious

Re: [PATCH 8/9] review: Rename variables to better express intention

2022-08-14 Thread David Bremner
Mohsin Kaleem writes: > --- > emacs/notmuch-hello.el | 18 +- > emacs/notmuch-jump.el | 2 +- > emacs/notmuch-lib.el | 4 ++-- > emacs/notmuch-tree.el | 24 > emacs/notmuch.el | 29 +++-- > 5 files changed, 39

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-08-12 Thread David Bremner
David Bremner writes: > To apply patch series, you may want to try mailscripts [1]. The > description makes it sound debian-centric, but I guess the elisp > functions like notmuch-extract-thread-patches are portable. That function is one reason why it's nice to start a new thread with each

Re: [PATCH] emacs: add new option notmuch-search-exclude

2022-08-12 Thread David Bremner
Mohsin Kaleem writes: > > I'm not sure what you mean by the first two patches occur twice, could > you clarify so I can fix the issue? I've dropped the reverted patch and > rebased on top of master so you shouldn't have any issues applying the > patch series now. > For reference, just look at

Re: [PATCH 7/9] test: Fix Navigation of notmuch-hello to search results

2022-08-12 Thread David Bremner
Mohsin Kaleem writes: > The default value of oldest-first is true so the oldest mail is shown > first by default. This test case used the tree-from-search function > which now persists this value of true (previously always defaulting to > nil in its place) which produced a different tree output

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-12 Thread David Bremner
asserting exclude option is working and consistent. > + > +test_begin_subtest "Search doesn't contain excluded mail by default" > +test_emacs '(notmuch-hello) > + (goto-char (point-min)) > + (re-search-forward "inbox") > + (widget-button-press

Re: [PATCH 5/9] feat: Add more interactive specs

2022-08-12 Thread David Bremner
This needs a better commit message. Both the subject (what is actually happening) and the body (more detail about what, and some explanation about why). I'd suggest sticking to emacs: as a tag for the subject, but this is less important than the other two issues I mentioned.

Re: [PATCH 4/9] feat: Allow :exclude configuration in notmuch-hello

2022-08-12 Thread David Bremner
Mohsin Kaleem writes: > --- > emacs/notmuch-hello.el | 35 ++- > 1 file changed, 22 insertions(+), 13 deletions(-) I would suggest describing this change as a change to notmuch-saved-searches; that variable is used other places in notmuch as well (mainly

Re: [PATCH 2/9] docs: Update with notmuch-*-toggle-exclude

2022-08-12 Thread David Bremner
Mohsin Kaleem writes: > --- > devel/emacs-keybindings.org | 2 +- > doc/notmuch-emacs.rst | 5 + > 2 files changed, 6 insertions(+), 1 deletion(-) apologies, but this patch will need to be rebased on top of master, as I've just changed that section of the emacs manual. For now I'm

Re: [Emacs] Using notmuch-address with EUDC, and completion-at-point

2022-08-12 Thread David Bremner
Alexander Adolf writes: > Hello David, > > thanks for your comments and questions. > > David Bremner writes: > >> Alexander Adolf writes: >> >>> As I wanted email address completion via completion-at-point in >>> message-mode too, I implemented a new EUDC function to go into >>>

Re: Overriding mm-inline-override-types in notmuch-show

2022-08-11 Thread David Bremner
David Bremner writes: > Al Haji-Ali writes: > >> The variable `mm-inline-override-types` is overridden in `notmuch-show` to >> "stop application/* parts from being displayed". >> >> This works well, however it means in other places the part *is* expanded. >> For example when

Re: Embed elisp.py from flycheck, use it in notmuch-emacs doc

2022-08-11 Thread David Bremner
Tomi Ollila writes: > > This series is probably good; at least it does not break software > (and if doc quality (or making of it) gets better then good :D) > > Tomi Applied to master. d ___ notmuch mailing list -- notmuch@notmuchmail.org To

Re: [PATCH 3/3] doc: add some documentation about duplicate files.

2022-08-11 Thread David Bremner
David Bremner writes: > This is mainly motivated by the new emacs-UI features to select > duplicates, but hopefully it will help demystify things for users of > the CLI as well. applied the remaining two patches to master (with a tiny adjustment of wording for the man output in the second

Re: [PATCH 2/2] emacs/show: restrict inlined mimetypes on refresh.

2022-08-11 Thread David Bremner
Tomi Ollila writes: > On Mon, Aug 01 2022, David Bremner wrote: > >> This fixes the bug reported by Al [1]. Essentially apply the same fix >> as [2] in a different place. >> >> [1]: id:877d41nmr1@gmail.com >> [2]: 90a7c1af368a527700dcde9b0dcbd760afc7bd92 > > LGTM. > > Tomi Applied to

Re: Embed elisp.py from flycheck, use it in notmuch-emacs doc

2022-08-10 Thread Tomi Ollila
On Sun, Jul 31 2022, David Bremner wrote: > After finding myself spending a while trying to re-create one of the > features [0] of the el sphinx domain used in flycheck, I decided to try > just converting the docs to use that sphinx extension. > > As I remarked in 2018 [1], the

Re: [PATCH 2/2] emacs/show: restrict inlined mimetypes on refresh.

2022-08-10 Thread Tomi Ollila
On Mon, Aug 01 2022, David Bremner wrote: > This fixes the bug reported by Al [1]. Essentially apply the same fix > as [2] in a different place. > > [1]: id:877d41nmr1@gmail.com > [2]: 90a7c1af368a527700dcde9b0dcbd760afc7bd92 LGTM. Tomi > --- > emacs/notmuch-show.el | 1 + >

Re: Create tags from folders

2022-08-09 Thread David Bremner
Reto writes: > > Out of interest, how does your workflow look like? > All based on folder queries? I don't use folders much anymore. My main searches are defined in terms of List-ID ORed with tags to sort into mailing-list-like-things (as some things I think should be part of the list are

Re: Create tags from folders

2022-08-08 Thread Reto
On Mon, Aug 08, 2022 at 10:39:36PM -0300, David Bremner wrote: > e.g. query:python as > 'folder:reto@labrat.space/INBOX.lists.python-list' > This has the advantage that you don't have to retag when new files are > added, which is often the desired behaviour. Thanks, I do use queries for some

Re: Create tags from folders

2022-08-08 Thread David Bremner
Reto writes: > > Second, I let notmuch index multiple email addresses in the same store, > meaning my folder queries are then nested rather deep. > > So my lovely tag:python query amounts to `notmuch search > 'folder:reto@labrat.space/INBOX.lists.python-list'` > > Which... is a mouthful. > >

Re: Create tags from folders

2022-08-08 Thread Reto
lovely tag:python query amounts to `notmuch search 'folder:reto@labrat.space/INBOX.lists.python-list'` Which... is a mouthful. Regexes aren't a solution, just makes it now two problems as I have multiple python lists that could match ;) Cheers, Reto PS: not op, but also re-tagging even th

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-08 Thread Mohsin Kaleem
with foo. 3. Run `M-x notmuch-refresh-this-buffer` and the mail you tagged should no longer be shown. 4. Hit the i key and it will be shown again. 5. Hit i again and it will be hidden. 6. Hit i again to re-show it and go ahead and remove the foo tag 7. Run `M-x notmuch-refresh-this-buffer` or hit

Re: Create tags from folders

2022-08-08 Thread Thomas Schneider
Hi, Notmuch mailinglist writes: > My email is from Protonmail and I use sieve filters to organise my mail as > needed into folders. > Mbsync creates a folder structure which mirrors what is on my proton mail > account. > But is it possible for notmuch to create tags based on the folders

Re: [PATCH 6/9] test: Add test cases for new exclude option

2022-08-08 Thread Tomi Ollila
uire_emacs > +add_email_corpus > +notmuch config set search.exclude_tags deleted > +notmuch tag +deleted -- 'from:"Stewart Smith"' or 'from:"Chris Wilson"' > + > +# Basic test cases just asserting exclude option is working and consistent. > + > +test_begin

<    2   3   4   5   6   7   8   9   10   11   >