Re: post-insert-hook

2024-10-04 Thread Ralph Seichter
* David Bremner: > The post-insert-hook is only called by notmuch-insert. [...] Thanks, David. Why I did not suspect this, I have no idea. In my setup, I don't require notmuch-insert, so the same is true for the hook. -Ralph ___ notmuch mail

post-insert-hook

2024-10-04 Thread David Bremner
The post-insert-hook is only called by notmuch-insert. You can find discussion of the --keep hook in notmuch-insert(1). The hook itself is documented in notmuch-hooks(5). ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email

Re: When exactly is the post-insert hook called?

2024-10-03 Thread Ralph Seichter
Oops, looks like I somehow hijacked a thread instead of creating a new one. Sorry, my bad. I guess switching one's MUA is not easily done without small hiccups along the way. -Ralph ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send

When exactly is the post-insert hook called?

2024-10-03 Thread Ralph Seichter
I have been using a post-new hook for ages without problems, and today I got curious about post-insert. I set up ~/.maildir/.notmuch/hooks/post-insert like I previously did with post-new. Whenever invoked manually, post-insert notes an event in a log file. The issue is that I don't see post-insert

[PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread David Bremner
Jani Nikula writes: > > I presume the two lines above... > >> +notmuch insert < "$gen_msg_filename" >> +echo $? > > ...and this line are leftover debug messages? Uh, yeah. I should have fixed those a while ago when Tomi pointed them out. > > Otherwise LGTM. I guess this could be expanded with a

[PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread Jani Nikula
,tmp} > > test_begin_subtest "pre-new is run" > rm_hooks > @@ -45,6 +47,16 @@ create_echo_hook "post-new" expected output > notmuch new > /dev/null > test_expect_equal_file expected output > > +test_begin_subtest "post-insert hook is run&quo

Re: [PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread David Bremner
Jani Nikula writes: > > I presume the two lines above... > >> +notmuch insert < "$gen_msg_filename" >> +echo $? > > ...and this line are leftover debug messages? Uh, yeah. I should have fixed those a while ago when Tomi pointed them out. > > Otherwise LGTM. I guess this could be expanded with a

Re: [PATCH] test: add simple tests for post-insert hook

2014-10-28 Thread Jani Nikula
,tmp} > > test_begin_subtest "pre-new is run" > rm_hooks > @@ -45,6 +47,16 @@ create_echo_hook "post-new" expected output > notmuch new > /dev/null > test_expect_equal_file expected output > > +test_begin_subtest "post-insert hook is run&quo

[PATCH] test: add simple tests for post-insert hook

2014-10-18 Thread David Bremner
expected output notmuch new > /dev/null test_expect_equal_file expected output +test_begin_subtest "post-insert hook is run" +rm_hooks +generate_message +create_echo_hook "post-insert" expected output +echo $gen_msg_filename +cat output +notmuch insert < "$

[PATCH] test: add simple tests for post-insert hook

2014-10-18 Thread David Bremner
expected output notmuch new > /dev/null test_expect_equal_file expected output +test_begin_subtest "post-insert hook is run" +rm_hooks +generate_message +create_echo_hook "post-insert" expected output +echo $gen_msg_filename +cat output +notmuch insert < "$

[PATCH v2 3/3] cli/insert: add post-insert hook

2014-09-28 Thread Jani Nikula
The post-new hook might no longer be needed or run very often if notmuch insert is being used. Therefore a post-insert hook is needed (arguably pre-insert not so much, so don't add one). Also add the --no-hooks option to skip hooks. --- doc/man1/notmuch-insert.rst | 9 + doc/man5/no

[PATCH v2 0/3] notmuch insert failure paths and post-insert hook

2014-09-28 Thread Jani Nikula
This is v2 of the final three patches of [1]. The failure paths have been improved further still, with some new warning messages on any cleanup errors as well. Man pages have been updated. Tests are still lacking. The post-insert hook should be simple, but I haven't had a sudden outbur

[PATCH v2 3/3] cli/insert: add post-insert hook

2014-09-28 Thread Jani Nikula
The post-new hook might no longer be needed or run very often if notmuch insert is being used. Therefore a post-insert hook is needed (arguably pre-insert not so much, so don't add one). Also add the --no-hooks option to skip hooks. --- doc/man1/notmuch-insert.rst | 9 + doc/man5/no

[PATCH v2 0/3] notmuch insert failure paths and post-insert hook

2014-09-28 Thread Jani Nikula
This is v2 of the final three patches of [1]. The failure paths have been improved further still, with some new warning messages on any cleanup errors as well. Man pages have been updated. Tests are still lacking. The post-insert hook should be simple, but I haven't had a sudden outbur

[PATCH 11/11] cli/insert: add post-insert hook

2014-09-22 Thread Jani Nikula
The post-new hook might no longer be needed or run very often if notmuch insert is being used. Therefore a post-insert hook is needed (arguably pre-insert not so much, so don't add one). Also add the --no-hooks option to skip hooks. --- notmuch-insert.c |7 +++ 1 files chang

[PATCH 11/11] cli/insert: add post-insert hook

2014-09-22 Thread Jani Nikula
The post-new hook might no longer be needed or run very often if notmuch insert is being used. Therefore a post-insert hook is needed (arguably pre-insert not so much, so don't add one). Also add the --no-hooks option to skip hooks. --- notmuch-insert.c |7 +++ 1 files chang