Re: [Nouveau] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

2015-09-09 Thread Hans de Goede
Hi, On 08-09-15 09:53, Hans de Goede wrote: Hi, On 07-09-15 21:55, Ilia Mirkin wrote: May I ask why you're doing 512x512 instead of 1024x1024? These are already scaled up coordinates, so 1024x1024 should work no? Or is it because of the seams on the edges? Do those not also appear with 512x512

Re: [Nouveau] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

2015-09-08 Thread Hans de Goede
Hi, On 07-09-15 21:55, Ilia Mirkin wrote: May I ask why you're doing 512x512 instead of 1024x1024? These are already scaled up coordinates, so 1024x1024 should work no? Or is it because of the seams on the edges? Do those not also appear with 512x512 or does it sample outside of the box? This

Re: [Nouveau] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

2015-09-07 Thread Ilia Mirkin
May I ask why you're doing 512x512 instead of 1024x1024? These are already scaled up coordinates, so 1024x1024 should work no? Or is it because of the seams on the edges? Do those not also appear with 512x512 or does it sample outside of the box? Separately, why not use this approach on nv40 as we

[Nouveau] [PATCH mesa 2/3] nv30: Fix color resolving for nv3x cards

2015-09-07 Thread Hans de Goede
We do not have a generic blitter on nv3x cards, so we must use the sifm object for color resolving. This commit divides the sources and dest surfaces in to tiles which match the constraints of the sifm object, so that color resolving will work properly on nv3x cards. Signed-off-by: Hans de Goede