Re: [Nouveau] [PATCH v2 1/7] exa: add GM10x acceleration support

2016-10-27 Thread Samuel Pitoiset
Two minor nitpicks below. I didn't read all shaders carefully because it's a pain, but I didn't see any obvious things. :-) Thanks for that great work Ilia! Reviewed-by: Samuel Pitoiset On 10/27/2016 04:02 PM, Ilia Mirkin wrote: rendercheck -f a8r8g8b8 passes as much as on a GK208, and xv

[Nouveau] [PATCH v2 1/7] exa: add GM10x acceleration support

2016-10-27 Thread Ilia Mirkin
rendercheck -f a8r8g8b8 passes as much as on a GK208, and xv appears to work. Very lightly tested. Instead of sticking coordinates into pushbufs, the vertex shader is modified to read them from a constbuf, indexed by vertex id. This approach could be used for all nvc0 generations, but I didn't wan