[Numpy-discussion] Re: Adding bit_count ufunc

Hi all, Thanks for all the great work on this PR on using the CPU instruction for bitcounts. This will be really useful for hamming distance like calculations. I wanted to check if there was anything else needed to merge this PR? It seems like there was a lot of good feedback addressed. https://

[Numpy-discussion] Re: Adding bit_count ufunc

> > as long as the correspondence is mentioned in the docstring this should > be discoverable enough Ah ok, that's a good point. I will make the change. Thanks! ~Ganesh On Mon, Dec 5, 2022 at 3:21 AM Ralf Gommers wrote: > > > On Sun, Dec 4, 2022 at 6:30 PM Ganesh Kathiresan > wrote: > >> Hi

[Numpy-discussion] Re: Adding bit_count ufunc

On Sun, Dec 4, 2022 at 6:30 PM Ganesh Kathiresan wrote: > Hi all, > > Thanks for the suggestions! I have gotten the PR to a working state with > UT on top of the latest main (PR > ). > > So it looks to me like this new ufunc should be called `bitwise_cou

[Numpy-discussion] Re: Adding bit_count ufunc

Hi all, Thanks for the suggestions! I have gotten the PR to a working state with UT on top of the latest main (PR ). So it looks to me like this new ufunc should be called `bitwise_count` > rather than `bit_count`. This does sound like a good idea, but

[Numpy-discussion] Re: Adding bit_count ufunc

On Fri, Nov 25, 2022 at 9:55 PM Serge Guelton wrote: > On Fri, Nov 25, 2022 at 08:09:02PM +0100, Sebastian Berg wrote: > > Thanks for bringing this up again. The Python method exists and it > > seems like relatively basic functionality. > > > > Overall, I am slightly in favor of adding the ufunc

[Numpy-discussion] Re: Adding bit_count ufunc

On Fri, Nov 25, 2022 at 08:09:02PM +0100, Sebastian Berg wrote: > Thanks for bringing this up again. The Python method exists and it > seems like relatively basic functionality. > > Overall, I am slightly in favor of adding the ufunc. So if nobody > voices an opinion that it doesn't seem a good

[Numpy-discussion] Re: Adding bit_count ufunc

Thanks for bringing this up again. The Python method exists and it seems like relatively basic functionality. Overall, I am slightly in favor of adding the ufunc. So if nobody voices an opinion that it doesn't seem a good fit for NumPy, I would be happy to move forward with it. - Sebastian PS