Hey John,
Will you be able to clean up the indentation issues for your inplace increment
patch today. I would like to include it in NumPy 1.7.
Thanks,
-Travis
On Jul 6, 2012, at 10:37 AM, John Salvatier wrote:
> Okay, done (
> https://github.com/jsalvatier/numpy/commit/7d03753e6305dbc878
Okay, done (
https://github.com/jsalvatier/numpy/commit/7d03753e6305dbc878ed7df3e21e9b099eae32ed
).
On Tue, Jul 3, 2012 at 11:41 AM, Frédéric Bastien wrote:
> Hi,
>
> Here is code example that work only with different index:
>
> import numpy
> x=numpy.zeros((5,5))
> x[[0,2,4]]+=numpy.random.r
Hi,
Here is code example that work only with different index:
import numpy
x=numpy.zeros((5,5))
x[[0,2,4]]+=numpy.random.rand(3,5)
print x
This won't work if in the list [0,2,4], there is index duplication,
but with your new code, it will. I think it is the most used case of
advanced indexing. A
Hi Fred,
That's an excellent idea, but I am not too familiar with this use case.
What do you mean by list in 'matrix[list]'? Is the use case, just
incrementing in place a sub matrix of a numpy matrix?
John
On Fri, Jun 29, 2012 at 11:43 AM, Frédéric Bastien wrote:
> Hi,
>
> I personnaly can't
Hi,
I personnaly can't review this as this is too much in NumPy internal.
My only comments is that you could add a test and an example in the
doc for matrix[list]. I think it will be the most used case.
Fred
On Wed, Jun 27, 2012 at 7:47 PM, John Salvatier
wrote:
> I've submitted a pull request
I've submitted a pull request ( https://github.com/numpy/numpy/pull/326 ).
I'm new to the numpy and python internals, so feedback is greatly
appreciated.
On Tue, Jun 26, 2012 at 12:10 PM, Travis Oliphant wrote:
>
> On Jun 26, 2012, at 1:34 PM, Frédéric Bastien wrote:
>
> > Hi,
> >
> > I think he
On Jun 26, 2012, at 1:34 PM, Frédéric Bastien wrote:
> Hi,
>
> I think he was referring that making NUMPY_ARRAY_OBJECT[...] syntax
> support the operation that you said is hard. But having a separate
> function do it is less complicated as you said.
Yes. That's precisely what I meant. Thank y
Right, that makes sense. Thanks.
On Tue, Jun 26, 2012 at 11:34 AM, Frédéric Bastien wrote:
> Hi,
>
> I think he was referring that making NUMPY_ARRAY_OBJECT[...] syntax
> support the operation that you said is hard. But having a separate
> function do it is less complicated as you said.
>
> Fred
Hi,
I think he was referring that making NUMPY_ARRAY_OBJECT[...] syntax
support the operation that you said is hard. But having a separate
function do it is less complicated as you said.
Fred
On Tue, Jun 26, 2012 at 1:27 PM, John Salvatier
wrote:
> Can you clarify why it would be super hard? I
Can you clarify why it would be super hard? I just reused the code for
advanced indexing (a modification of PyArray_SetMap). Am I missing
something crucial?
On Tue, Jun 26, 2012 at 9:57 AM, Travis Oliphant wrote:
>
> On Jun 26, 2012, at 11:46 AM, John Salvatier wrote:
>
> Hello,
>
> If you incr
On Jun 26, 2012, at 11:46 AM, John Salvatier wrote:
> Hello,
>
> If you increment an array using advanced indexing and have repeated indexes,
> the array doesn't get repeatedly incremented,
> http://comments.gmane.org/gmane.comp.python.numeric.general/50291. I wrote a
> C function that does
Hello,
If you increment an array using advanced indexing and have repeated
indexes, the array doesn't get repeatedly incremented,
http://comments.gmane.org/gmane.comp.python.numeric.general/50291. I wrote
a C function that does incrementing with repeated indexes correctly. The
branch is here (http
12 matches
Mail list logo
