Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Fri, May 3, 2013 at 12:13 PM, Arink Verma wrote: > I have created a new PR, have removed one irrelevant version check. > https://github.com/numpy/numpy/pull/3304/files > I made some remarks on the PR. The convention on numpy-discussion is bottom posting so you should do that to avoid future c

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

I have created a new PR, have removed one irrelevant version check. https://github.com/numpy/numpy/pull/3304/files On Fri, May 3, 2013 at 11:29 PM, Arink Verma wrote: > I hardly found, any thing to improve and correct.. not even typo in docs? > Where we need to avoid the version checks? > > > >

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

I hardly found, any thing to improve and correct.. not even typo in docs? Where we need to avoid the version checks? On Fri, May 3, 2013 at 10:52 PM, Charles R Harris wrote: > > > On Thu, May 2, 2013 at 6:47 PM, wrote: > >> On Thu, May 2, 2013 at 6:30 PM, Ralf Gommers >> wrote: >> > >> > >>

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 6:47 PM, wrote: > On Thu, May 2, 2013 at 6:30 PM, Ralf Gommers > wrote: > > > > > > > > On Fri, May 3, 2013 at 12:29 AM, Ralf Gommers > > wrote: > >> > >> > >> > >> > >> On Thu, May 2, 2013 at 9:54 PM, Charles R Harris > >> wrote: > >>> > >>> > >>> > >>> On Thu, May 2, 2

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 6:30 PM, Ralf Gommers wrote: > > > > On Fri, May 3, 2013 at 12:29 AM, Ralf Gommers > wrote: >> >> >> >> >> On Thu, May 2, 2013 at 9:54 PM, Charles R Harris >> wrote: >>> >>> >>> >>> On Thu, May 2, 2013 at 11:49 AM, Ralf Gommers >>> wrote: On Thu,

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Fri, May 3, 2013 at 12:29 AM, Ralf Gommers wrote: > > > > On Thu, May 2, 2013 at 9:54 PM, Charles R Harris < > charlesr.har...@gmail.com> wrote: > >> >> >> On Thu, May 2, 2013 at 11:49 AM, Ralf Gommers wrote: >> >>> >>> >>> >>> On Thu, May 2, 2013 at 6:45 PM, Pauli Virtanen wrote: >>> Cha

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 9:54 PM, Charles R Harris wrote: > > > On Thu, May 2, 2013 at 11:49 AM, Ralf Gommers wrote: > >> >> >> >> On Thu, May 2, 2013 at 6:45 PM, Pauli Virtanen wrote: >> >>> Charles R Harris gmail.com> writes: >>> [clip] >>> > * Did you notice this line on the requirements page?

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 11:49 AM, Ralf Gommers wrote: > > > > On Thu, May 2, 2013 at 6:45 PM, Pauli Virtanen wrote: > >> Charles R Harris gmail.com> writes: >> [clip] >> > * Did you notice this line on the requirements page? "Having your >> > first pull request merged before the GSoC application

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 6:45 PM, Pauli Virtanen wrote: > Charles R Harris gmail.com> writes: > [clip] > > * Did you notice this line on the requirements page? "Having your > > first pull request merged before the GSoC application deadline (May 3) > > is required for your application to be accepte

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

Charles R Harris gmail.com> writes: [clip] > * Did you notice this line on the requirements page? "Having your > first pull request merged before the GSoC application deadline (May 3) > is required for your application to be accepted." > > Where is that last requirement? It seems out of line to m

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

For the sake of completeness, I don't think I ever mentioned what I used to profile when I was working on speeding up the scalars. I used AQTime 7. It is commercial and only for Windows (as far as I know). It works great and it gave me fairly accurate timings and all sorts of visual navigation

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 7:14 AM, Nathaniel Smith wrote: > On Thu, May 2, 2013 at 6:26 AM, Arink Verma > wrote: > > Yes, we need to ensure that.. > > Code generator can be made, which can create code for table of registered > > dtype during build time itself. > > I'd probably just generate it at r

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

Updating table at runtime, seems a good option. But then we have maintain separate file for caching and storing. I will see, op2calltree.py and gperftools both. >* Instead of making a giant table of everything that needs to be done >to make stuff fast firs

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 6:26 AM, Arink Verma wrote: > Yes, we need to ensure that.. > Code generator can be made, which can create code for table of registered > dtype during build time itself. I'd probably just generate it at run-time on an as-needed basis. (I.e., use the full lookup logic the fi

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 11:26 AM, Arink Verma wrote: > Yes, we need to ensure that.. > Code generator can be made, which can create code for table of registered > dtype during build time itself. So dtypes can be registered at runtime as well. In an ideal world, 'native' numpy types would not be sp

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

Yes, we need to ensure that.. Code generator can be made, which can create code for table of registered dtype during build time itself. Also at present there lot of duplicate code that attempts to work around these slow paths, simplification of that code is also required. On Thu, May 2, 2013 at

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Thu, May 2, 2013 at 5:25 AM, Arink Verma wrote: > @Raul > I will pull new version, and try to include that also. > What is wrong with macros for inline function? > Yes, time for ufunc is reduced to almost half, for lookup table, I am > generating key from argument type and returning the appropr

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

@Raul I will pull new version, and try to include that also. What is wrong with macros for inline function? Yes, time for ufunc is reduced to almost half, for lookup table, I am generating key from argument type and returning the appropriated value.[1] @Chuck Yes I did some profiling with oprofile

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

On Tue, Apr 30, 2013 at 8:26 PM, Arink Verma wrote: > Hi all! > I have written my application[1] for *Performance parity between numpy > arrays and Python scalars[2]. *It would be a great help if you view it. > Does it look achievable and deliverable according to the project. > > [1] > http://www.

Re: [Numpy-discussion] GSoC : Performance parity between numpy arrays and Python scalars

It is great that you are looking into this !! We are currently running on a fork of numpy because we really need these performance improvements . I noticed that, as suggested, you took from the pull request I posted a while ago for the

Re: [Numpy-discussion] Gsoc : Performance parity between numpy arrays and Python scalars

Few comments on the topic, The postings I did to the list were in numpy 1.6 but the pull requests were done on the latest code at that time I believe 1.7 . There are still a few comments pending that I have not had a chance to look into, but that is a separ