Re: svn commit: r1532782 [1/2] - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/ap

2013-10-16 Thread Michael Dürig
On 16.10.13 9:45 , Jukka Zitting wrote: Yes this should work (even though I'm not too fond of using thread locals). An cleaner alternative to a ThreadLocal would be to use an extra commitinfo argument to carry the information down the stack through the relevant commit and merge methods Th

Re: svn commit: r1532782 [1/2] - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/ap

2013-10-16 Thread Jukka Zitting
Hi, On Wed, Oct 16, 2013 at 2:58 PM, Michael Dürig wrote: > Well there is the extra benefit for transporting that info across cluster > nodes. I don't see the benefit. There's no reliable way to match such external commitinfos to the respective content changes, so we can't use that information

Re: svn commit: r1532782 [1/2] - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/ap

2013-10-16 Thread Michael Dürig
On 16.10.13 6:36 , Jukka Zitting wrote: Hi, On Wed, Oct 16, 2013 at 11:47 AM, Michael Dürig wrote: On 16.10.13 5:23 , Jukka Zitting wrote: I don't think this is a good idea. Why? You're essentially passing information from Root.commit() a few levels down the stack to ChangeDispatcher.lo

Re: svn commit: r1532782 [1/2] - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/ap

2013-10-16 Thread Jukka Zitting
Hi, On Wed, Oct 16, 2013 at 11:47 AM, Michael Dürig wrote: > On 16.10.13 5:23 , Jukka Zitting wrote: >> I don't think this is a good idea. > > Why? You're essentially passing information from Root.commit() a few levels down the stack to ChangeDispatcher.localCommit(). Routing that information th

Re: svn commit: r1532782 [1/2] - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/core/ oak-core/src/main/java/org/apache/jackrabbit/oak/kernel/ oak-core/src/main/java/org/ap

2013-10-16 Thread Jukka Zitting
Hi, On Wed, Oct 16, 2013 at 10:43 AM, wrote: > - Use :commit-info on the root node to pass commit information across I don't think this is a good idea. Instead I'd use a ThreadLocal or just pass the extra information as an extra argument in the commit call. BR, Jukka Zitting

Re: IndexEditor and Commit Failure

2013-10-16 Thread Chetan Mehrotra
> The lucene index is asynchronous Okie I missed that part completely i.e. OAK-763. Yup with that used for such indexers this problem would not be observed. Thanks for the pointer Alex!! Chetan Mehrotra

Re: IndexEditor and Commit Failure

2013-10-16 Thread Alex Parvulescu
Hi Chetan, The lucene index is asynchronous and the way it works is it (periodically) branches the current state and runs a diff to update the index data. [0] This shouldn't include the conflicts you refer to, but I may be wrong here. My guess is the solr index will pass on an async model too, so

IndexEditor and Commit Failure

2013-10-16 Thread Chetan Mehrotra
Hi, Currently the various IndexEditor (Lucene,Property and Solr) are invoked as part of CommitHook.processCommit call whenever a JCR Session is saved. In case the commit fails would it leave the Index state in inconsistent state? For PropertyIndex I think it would be fine as the index content is

RE: svn commit: r1532681 - /jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/mongomk/MongoDocumentStore.java

2013-10-16 Thread Marcel Reutegger
we should probably also consider upgrading the java driver. the default write concern changed with 2.10.0: http://docs.mongodb.org/manual/release-notes/drivers-write-concern/#driver-write-concern-change the default is now equivalent to SAFE aka ACKNOWLEDGED. regards marcel > -Original Messa

Re: svn commit: r1532157 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/nodetype/NodeTypeImpl.java oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/nodetype/No

2013-10-16 Thread Michael Dürig
On 15.10.13 8:04 , Tobias Bocanegra wrote: I think the semantics of NodeType.equals() should be mentioned in the JCR API. I'm indifferent if we should consider the comparison between 2 different implementations. The symmetry requirement comes from the general contract of equals and we can't

Re: svn commit: r1532415 [1/11] - in /jackrabbit/site/live/oak/docs: ./ META-INF/ css/ js/

2013-10-16 Thread Michael Dürig
On 15.10.13 6:29 , Jukka Zitting wrote: Hi, On Tue, Oct 15, 2013 at 12:21 PM, wrote: Added: jackrabbit/site/live/oak/docs/META-INF/ jackrabbit/site/live/oak/docs/META-INF/DEPENDENCIES jackrabbit/site/live/oak/docs/META-INF/LICENSE jackrabbit/site/live/oak/docs/META-INF/N