Re: Close method on NodeStore API

2014-06-13 Thread Jukka Zitting
Hi, On Fri, Jun 13, 2014 at 7:20 AM, Chetan Mehrotra wrote: > 1. Make NodeStore API extend Closeable -1 No client of the of the API should need to close the store. Only the code that starts a NodeStore instance should be able to close it. > 2. Have the actual implementations (i.e. SegmentNodeSt

Re: Close method on NodeStore API

2014-06-13 Thread Davide Giannella
On 13/06/2014 13:20, Chetan Mehrotra wrote: > Hi, > > Recently Alex pointed that we do not close the NodeStore in the > oak-run console which brought up the topic of how to support closing > of NodeStore. Currently both SegmentNodeStore and DocumentNodeStore > need to be closed properly > > There a

Close method on NodeStore API

2014-06-13 Thread Chetan Mehrotra
Hi, Recently Alex pointed that we do not close the NodeStore in the oak-run console which brought up the topic of how to support closing of NodeStore. Currently both SegmentNodeStore and DocumentNodeStore need to be closed properly There are couple of options 1. Make NodeStore API extend Closeab