Request for feedback: OSGi Configuration for Query Limits (OAK-1571)

2014-03-26 Thread Thomas Mueller
Hi, I'm trying to make some query settings (limits on the number of nodes read) configurable via OSGi. So far, I have a patch of about 100 KB, and this is just wiring together the components (no OSGi / Whiteboard so far). I wonder, is there an easier way to do it? With system properties, it's

Re: Request for feedback: OSGi Configuration for Query Limits (OAK-1571)

2014-03-26 Thread Chetan Mehrotra
Patch looks fine to me. Probably we can collapse QueryIndexProvider and QueryEngineSettings into a single QueryEngineContext and pass that along till Root. So: is it worth it to have the 100 KB source code overhead just to make things configurable separately for each Oak instance? I think

Re: Request for feedback: OSGi Configuration for Query Limits (OAK-1571)

2014-03-26 Thread Thomas Mueller
Hi, Patch looks fine to me. Probably we can collapse QueryIndexProvider and QueryEngineSettings into a single QueryEngineContext and pass that along till Root. OK, I will then continue in this direction. Thanks! Regards, Thomas