Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean up unused variable in dlm_process_recovery_data

2018-04-02 Thread piaojun
LGTM On 2018/4/3 13:42, Changwei Ge wrote: > Signed-off-by: Changwei Ge Reviewed-by: Jun Piao > --- > fs/ocfs2/dlm/dlmrecovery.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c > index

[Ocfs2-devel] [PATCH] ocfs2/dlm: clean up unused variable in dlm_process_recovery_data

2018-04-02 Thread Changwei Ge
Signed-off-by: Changwei Ge --- fs/ocfs2/dlm/dlmrecovery.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c index ec8f758..be6b067 100644 --- a/fs/ocfs2/dlm/dlmrecovery.c +++ b/fs/ocfs2/dlm/dlmrecovery.c @@ -1807,7

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: wait for dlm recovery done when migrating all lock resources

2018-04-02 Thread Joseph Qi
On 18/3/15 20:59, piaojun wrote: > Wait for dlm recovery done when migrating all lock resources in case that > new lock resource left after leaving dlm domain. And the left lock > resource will cause other nodes BUG. > > NodeA NodeBNodeC > > umount:

Re: [Ocfs2-devel] [PATCH] ocfs2: Take inode cluster lock before moving reflinked inode from orphan dir

2018-04-02 Thread Joseph Qi
On 18/3/31 01:42, Ashish Samant wrote: > While reflinking an inode, we create a new inode in orphan directory, then > take EX lock on it, reflink the original inode to orphan inode and release > EX lock. Once the lock is released another node might request it in PR mode > which causes

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: wait for dlm recovery done when migrating all lock resources

2018-04-02 Thread Changwei Ge
On 2018/4/2 12:32, piaojun wrote: > Hi Changwei, > > On 2018/4/2 10:59, Changwei Ge wrote: >> Hi Jun, >> >> It seems that you have ever posted this patch, If I remember correctly. >> My concern is still if you disable dlm recovery via ::migrate_done. Then flag >> DLM_LOCK_RES_RECOVERING can't be