Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment

2018-02-23 Thread piaojun
Hi Changwei, On 2018/2/23 17:55, Changwei Ge wrote: > Hi Jun, > > On 2018/2/23 17:13, piaojun wrote: >> Hi changwei, >> >> On 2018/2/23 15:30, ge.chang...@h3c.com wrote: >>> From: Changwei Ge >> This line seems unnecessary, others looks good to me. > I used git send-email, thus this line was add

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment

2018-02-23 Thread Joseph Qi
On 18/2/23 15:30, ge.chang...@h3c.com wrote: > From: Changwei Ge > > Obviously, the comment before dlm_do_local_recovery_cleanup() has > nothing to do with it. So remove it. > > Signed-off-by: Changwei Ge It seems to say we can no longer trust the lvb in this case. Maybe it should be placed

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment

2018-02-23 Thread Changwei Ge
Hi Jun, On 2018/2/23 17:13, piaojun wrote: > Hi changwei, > > On 2018/2/23 15:30, ge.chang...@h3c.com wrote: >> From: Changwei Ge > This line seems unnecessary, others looks good to me. I used git send-email, thus this line was added by parameter --from. I suppose you could ignore it if it seems

Re: [Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment

2018-02-23 Thread piaojun
Hi changwei, On 2018/2/23 15:30, ge.chang...@h3c.com wrote: > From: Changwei Ge This line seems unnecessary, others looks good to me. thanks, Jun > > Obviously, the comment before dlm_do_local_recovery_cleanup() has > nothing to do with it. So remove it. > > Signed-off-by: Changwei Ge > --- >

[Ocfs2-devel] [PATCH] ocfs2/dlm: clean unrelated comment

2018-02-22 Thread ge.changwei
From: Changwei Ge Obviously, the comment before dlm_do_local_recovery_cleanup() has nothing to do with it. So remove it. Signed-off-by: Changwei Ge --- fs/ocfs2/dlm/dlmrecovery.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c i