Patch on unsupported AT command

Hi all, If some unsupported AT command is issued, different modem may have their own response. Now at my hand is a Huawei modem (EM770W), and it returns "COMMAND NOT SUPPORT". In my case, this modem doesn't support "AT+CGAUTO=0" in atmodem/gprs.c. Current oFono will hang there for it's n

[PATCH 2/2] Refactor code order and remove unusable variables

No impact to code correctness for voicecall. --- drivers/hfpmodem/voicecall.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c index 60ac45d..4b75904 100644 --- a/drivers/hfpmodem/voicecall.c +++ b/driver

[PATCH 1/2] Rename call to active_call to be more meanful

Rename vd->call to vd->active_call in hfpmodem voicecall.c --- drivers/hfpmodem/voicecall.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c index 9ba72e4..60ac45d 100644 --- a/drivers/hfpmodem/voicecall

Re: ppp

On Thu, 12 Nov 2009, Denis Kenzior wrote: Unfortunately it is not that simple. pppd requires a proper kernel file descriptor to hand off to the kernel ppp line discipline. In our userspace implementation that is not the case. 1 kernel file descriptor is shared by potentially many GAtChat ch

Re: ppp

Denis Kenzior wrote: Hi Ryan, Hello, We need a ppp interface for our modem. I was told on the chat forum that a tap/tun device was to be used. Has anyone else started with this or thought how to implement this? We're currently working on a userspace ppp implementation that will integrate

Re: ppp

Hi Ryan, > Hello, > > We need a ppp interface for our modem. I was told on the chat forum that > a tap/tun device was to be used. Has anyone else started with this or > thought how to implement this? We're currently working on a userspace ppp implementation that will integrate with GAtChat. The

Re: [PATCH 3/3] Replace parse_clcc by at_util_parse_clcc in atmodem voicecall

Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/3] Add parse_clcc into atutil.c

Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/3] Fix: Set data to NULL in hfpmodem drivers

Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

ppp

Hello, We need a ppp interface for our modem. I was told on the chat forum that a tap/tun device was to be used. Has anyone else started with this or thought how to implement this? After reading briefly the code from pppd, the implementation, for a first draft, is pretty straight forward (w/

RE: [PATCH 4/4] Fix: Fill in the phone number info for outgoing call

Hi Denis, Denis Kenzior wrote: > Hi Zhenhua, > >> +ofono_voicecall_notify(vc, call); >> + > > As I mentioned above, you do not need to do this. oFono will > synthesize the outgoing call properly. Worst case we will > send a PropertyChanged signal after CLCC is polled and the new number > i

[PATCH 3/3] Replace parse_clcc by at_util_parse_clcc in atmodem voicecall

Replace parse_clcc by at_util_parse_clcc in atmodem voicecall. --- drivers/atmodem/voicecall.c | 59 +- 1 files changed, 2 insertions(+), 57 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 9ed3696..9dae1c8 100644

[PATCH 2/3] Add parse_clcc into atutil.c

So that it could be shared by atmodem and hfpmodem. --- drivers/atmodem/atutil.c | 55 ++ drivers/atmodem/atutil.h |1 + 2 files changed, 56 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/atutil.c b/drivers/atmodem/atutil.c index 687a4

[PATCH 1/3] Fix: Set data to NULL in hfpmodem drivers

Hi, The patch is to set data to NULL in hfpmodem drivers. --- drivers/hfpmodem/network-registration.c |2 ++ drivers/hfpmodem/voicecall.c|3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/hfpmodem/network-registration.c b/drivers/hfpmodem/network-re