Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

Hi Kristen, > static GAtChat *control; > static GAtChat *modem; > static GMainLoop *event_loop; > +static GAtPPP *ppp; I hate myself for this nitpick, but please group GAtPPP *ppp with the others before the mainloop variable. > +static void print_ip_address(guint32 ip_addr) > +{ > + str

Re: [patch 5/6] IP support for PPP

Hi Kristen, > Signed-off-by: Kristen Carlson Accardi we don't do signed-off-by statements inside oFono. So please skip these and fix your .gitconfig. > Implement IPCP support. Creates a tun interface to pass IP traffic. Also even if we would be doing signed-off-by statements, you messed them

Re: [patch 1/6] Add PPP protocol support with HDLC framing

Hi Kristen, > This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a > different patch. > > --- > Makefile.am |4 > gatchat/gatppp.c | 552 > ++ > gatchat/gatppp.h | 59 > gatchat/gat

RE: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Yang, > >> - item->text = sim_string_to_utf8(data+1, len-1); > >> + utf8 = sim_string_to_utf8(data+1, len-1); > > > >I applied the patch and fixed up the arithmetic operator style issue. Please > >make sure you follow this convention from now on. > > Thank you, and I will pay attention to t

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Denis, > > > + if (utf8 == NULL) > > > + return FALSE; > > > + > > > + item->text = utf8; > > > > Why bother with utf8 variable? Just do > > > > if (item->text == NULL) > > return FALSE; > > > > I actually find this acceptable because 'item' is a return structure, so

Re: [patch 5/6] IP support for PPP

Hi Kristen, > > > +/** IPCP support / > > > +enum { > > > + /* supported codes */ > > > + IPCP_SUPPORTED_CODES= (1 << CONFIGURE_REQUEST) | > > > + (1 << CONFIGURE_ACK) | > > > + (1 << CONFIGURE_NAK) | > > > +

RE: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Denis, >-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >Denis Kenzior >Sent: Wednesday, March 17, 2010 4:30 AM >To: ofono@ofono.org >Subject: Re: [PATCH 2/4] Handle the conversion failure when parsing item > >Hi Yang, > >> -item->text

[patch 4/6] CHAP with MD5 authentication

Signed-off-by: Kristen Carlson Accardi Implement authentication support with CHAP and MD5 digest --- Makefile.am |3 gatchat/gatppp.c | 12 ++ gatchat/gatppp.h |2 gatchat/gatppp_internal.h | 15 +++ gatchat/gatpppauth.c | 230

[patch 3/6] LCP support

Signed-off-by: Kristen Carlson Accardi Implement LCP support for the PPP protocol --- Makefile.am |6 - gatchat/gatppp.c | 53 + gatchat/gatppp_internal.h |8 + gatchat/gatppplcp.c | 244 ++ 4 files cha

[patch 2/6] Generic PPP control protocol

Signed-off-by: Kristen Carlson Accardi Implement a generic control protocol that can be shared by both LCP and NCP implementations. --- Makefile.am |3 gatchat/gatppp_internal.h |2 gatchat/gatpppcp.c| 1509 ++ gatchat

[patch 0/6] PPP patches v2

Changed patches based on feedback. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[patch 6/6] Allow gsmdial to use gatchat ppp support

Add option to use PPP to gsmdial. --- gatchat/gsmdial.c | 82 -- 1 file changed, 79 insertions(+), 3 deletions(-) Index: ofono/gatchat/gsmdial.c === --- ofono.orig/gatchat/gsmdia

[patch 5/6] IP support for PPP

Signed-off-by: Kristen Carlson Accardi Implement IPCP support. Creates a tun interface to pass IP traffic. --- Makefile.am |2 gatchat/gatppp.c |2 gatchat/gatppp_internal.h | 12 + gatchat/gatpppnet.c | 369 +++

[patch 1/6] Add PPP protocol support with HDLC framing

This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. --- Makefile.am |4 gatchat/gatppp.c | 552 ++ gatchat/gatppp.h | 59 gatchat/gatppp_internal.h | 97

Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

On Sun, 14 Mar 2010 13:02:52 -0700 Marcel Holtmann wrote: > > > > +static void print_ip_address(guint32 ip_addr) > > +{ > > + struct in_addr addr; > > + addr.s_addr = ip_addr; > > + g_print("%s\n", inet_ntoa(addr)); > > It is just fine to use printf() like everybody else. The g_print > f

Re: [patch 5/6] IP support for PPP

On Sun, 14 Mar 2010 13:22:37 -0700 Marcel Holtmann wrote: > > +/** IPCP support / > > +enum { > > + /* supported codes */ > > + IPCP_SUPPORTED_CODES= (1 << CONFIGURE_REQUEST) | > > + (1 << CONFIGURE_ACK) | > > + (1

Re: [PATCH 1/4] Fix the structure of stk_subaddress

Hi Yang, > --- > src/stkutil.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Yang, > - item->text = sim_string_to_utf8(data+1, len-1); > + utf8 = sim_string_to_utf8(data+1, len-1); I applied the patch and fixed up the arithmetic operator style issue. Please make sure you follow this convention from now on. Regards, -Denis

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Marcel, > > + if (utf8 == NULL) > > + return FALSE; > > + > > + item->text = utf8; > > Why bother with utf8 variable? Just do > > if (item->text == NULL) > return FALSE; > I actually find this acceptable because 'item' is a return structure, so we should a

Re: [PATCH 3/4] Add parser for file list objects

Hi Yang, > --- > src/stkutil.c | 42 ++ > src/stkutil.h |6 ++ > 2 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index ceba2d5..9f3bc0b 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -40

Re: [PATCH 4/4] Add parser for location information objects

Hi Yang, > src/simutil.c |2 +- > src/simutil.h |1 + > src/stkutil.c | 40 +--- > src/stkutil.h |9 + > 4 files changed, 48 insertions(+), 4 deletions(-) > > diff --git a/src/simutil.c b/src/simutil.c > index d9383b7..65ffa36 100644 > --

Re: [PATCH 3/4] Add parser for file list objects

Hi Yang, > --- > src/stkutil.c | 42 ++ > src/stkutil.h |6 ++ > 2 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index ceba2d5..9f3bc0b 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -40

Re: [PATCH 2/4] Handle the conversion failure when parsing item

Hi Yang, > src/stkutil.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index 787f7eb..ceba2d5 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -190,6 +190,7 @@ static gboolean parse_dataobj_item(struct > comprehension

Re: Barring API

Hi Pekka, > Hi all, > > I had a quick peek on barring API which is currently undocumented. > > It seems to me that there is a good reason for it being documented as > the properties by GetProperties() returned are different from the > properties emitted. I kinda like the the emitted properties >

Barring API

Hi all, I had a quick peek on barring API which is currently undocumented. It seems to me that there is a good reason for it being documented as the properties by GetProperties() returned are different from the properties emitted. I kinda like the the emitted properties (VoiceIncoming and VoiceOu

[PATCH 8/8][RFC] Enable SIM polling in atgen and phonesim drivers.

--- plugins/atgen.c|6 +- plugins/phonesim.c |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/plugins/atgen.c b/plugins/atgen.c index 7e760bc..ea322fb 100644 --- a/plugins/atgen.c +++ b/plugins/atgen.c @@ -156,12 +156,16 @@ static int atgen_disable(struct

[PATCH 7/8][RFC] Invalidate SIM manager properties when SIM extracted, add Present property.

--- src/sim.c | 107 ++--- 1 files changed, 95 insertions(+), 12 deletions(-) diff --git a/src/sim.c b/src/sim.c index cddb3e4..fe535bb 100644 --- a/src/sim.c +++ b/src/sim.c @@ -285,6 +285,7 @@ static DBusMessage *sim_get_properties(DBusCo

[PATCH 6/8][RFC] Try to fetch and parse proactive commands.

--- src/sim.c | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/src/sim.c b/src/sim.c index 63f50eb..cddb3e4 100644 --- a/src/sim.c +++ b/src/sim.c @@ -1804,8 +1804,46 @@ void ofono_sim_removed(struct ofono_sim *sim) } } +stat

[PATCH 5/8][RFC] STATUS, FETCH and TERMINAL RESPONSE for AT driver.

Fix ENVELOPE implementation. --- drivers/atmodem/sim.c | 286 ++--- 1 files changed, 273 insertions(+), 13 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 89ddcc6..d6f08b4 100644 --- a/drivers/atmodem/sim.c +++ b/drivers/a

[PATCH 4/8][RFC] Remove post-sim atoms after SIM is extracted.

--- src/modem.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index b935328..6dfa73a 100644 --- a/src/modem.c +++ b/src/modem.c @@ -52,6 +52,7 @@ enum ofono_property_type { struct ofono_modem {

[PATCH 3/8][RFC] Release calls when SIM is removed.

--- src/voicecall.c | 63 -- 1 files changed, 56 insertions(+), 7 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 18b923f..eef924c 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -57,6 +57,8 @@ struct ofono_voicecall {

[PATCH 2/8][RFC] Set polling interval depending on whether calls are active.

--- include/voicecall.h |2 ++ src/sim.c | 37 +++-- src/voicecall.c |5 + 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 6ceb3d8..dcce91a 100644 --- a/include/voicecall.h +

[PATCH 1/8][RFC] Add functions to notify core of SIM insertion/removal or request polling.

Implement optional polling. Polling is mandatory according to the specification but on most hardware it will me impractical because there will be vendor specific unsolicited notifications that can be used instead. Modem plugins need to handle them. --- include/sim.h | 21 ++- src/sim.c

[PATCH 3/4] Add parser for file list objects

--- src/stkutil.c | 42 ++ src/stkutil.h |6 ++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ceba2d5..9f3bc0b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -406,6 +406,46 @@ static gboolean

[PATCH 4/4] Add parser for location information objects

--- src/simutil.c |2 +- src/simutil.h |1 + src/stkutil.c | 40 +--- src/stkutil.h |9 + 4 files changed, 48 insertions(+), 4 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index d9383b7..65ffa36 100644 --- a/src/simutil.c +++ b/

[PATCH 2/4] Handle the conversion failure when parsing item

--- src/stkutil.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 787f7eb..ceba2d5 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -190,6 +190,7 @@ static gboolean parse_dataobj_item(struct comprehension_tlv_iter *iter,

[PATCH 1/4] Fix the structure of stk_subaddress

--- src/stkutil.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index b59c9f0..b408f38 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -286,7 +286,7 @@ struct stk_address { */ struct stk_subaddress { unsigned char len; -

Re: [PATCH] Add support of Huawei EM770 modem

Hi Yang, > Comparing with general Huawei modem, EM770 is a full feature modem that > supports voicecall, phonebook, call forwarding, call barring, etc. > --- > Makefile.am |3 + > plugins/em770.c | 226 > +++ > plugins/ofono.rules

[PATCH] Add support of Huawei EM770 modem

Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am |3 + plugins/em770.c | 226 +++ plugins/ofono.rules |1 + plugins/udev.c

RE: [PATCH] Add support of Huawei EM770 modem

>-Original Message- >From: ofono-boun...@ofono.org [mailto:ofono-boun...@ofono.org] On Behalf Of >Marcel Holtmann >Sent: Tuesday, March 16, 2010 2:45 PM >To: ofono@ofono.org >Subject: Re: [PATCH] Add support of Huawei EM770 modem > >Hi Yang, > >> Comparing with general Huawei modem, EM770