[PATCH] Fix: use of g_checksum_get_digest() inout argument

From: Pekka Pessi --- gatchat/ppp_auth.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c index fe3c501..1e0c82b 100644 --- a/gatchat/ppp_auth.c +++ b/gatchat/ppp_auth.c @@ -107,7 +107,7 @@ static void chap_process_challenge(struct

[PATCH 0/3] Updated patches to handle the asynchronized callback

Hi, I updated the patches according to the comments and did following changes: 1. removed last_result since it seems no use at all. 2. rename g_at_server_send_flush to g_at_server_send_result. It makes code easier to read. 3. add parse_ready flag to parse one command line at one time. Please re

[PATCH 1/3] Refactor the command parsing

--- gatchat/gatserver.c | 103 +++--- 1 files changed, 56 insertions(+), 47 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index c75fbf5..07999a8 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -112,6 +112,8 @@ struct

[PATCH 2/3] Add server send result code

--- gatchat/gatserver.c | 98 --- gatchat/gatserver.h | 17 + 2 files changed, 102 insertions(+), 13 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 07999a8..cad9d91 100644 --- a/gatchat/gatserver.c +++ b/gatcha

[PATCH 3/3] Add flag to parse one command line at once

--- gatchat/gatserver.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index cad9d91..251c3b8 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -116,6 +116,7 @@ struct _GAtServer { gboolean destroyed;

[PATCH 1/9] Add parser for network measurement results objects

--- src/stkutil.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 437dcdb..9a02658 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -619,6 +619,30 @@ static gboolean parse_dataobj_help_request(struct comprehen

[PATCH 3/9] Add parser for event list objects

--- src/stkutil.c | 10 ++ src/stkutil.h | 24 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index b997752..ecd5639 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -679,6 +679,14 @@ static gboolean parse_dataobj

[PATCH 2/9] Add parser for items next action indicator objects

--- src/stkutil.c | 38 ++ src/stkutil.h |5 + 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9a02658..b997752 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -67,6 +67,34 @@ static gboolean parse_

[PATCH 4/9] Add parser for cause objects

--- src/stkutil.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ecd5639..8f4ff39 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -687,6 +687,39 @@ static gboolean parse_dataobj_event_list(

[PATCH 5/9] Add parser for location status objects

--- src/stkutil.c | 30 ++ src/stkutil.h |6 ++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 8f4ff39..3aae6bf 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -67,6 +67,26 @@ static gboolean parse_dataobj

[PATCH 6/9] Add parser for transaction identifier objects

--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 3aae6bf..d573430 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -748,6 +748,14 @@ static gboolean parse_dataobj_location_status(

[PATCH 8/9] Add the macro for icon qualifier

--- src/stkutil.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/stkutil.h b/src/stkutil.h index b85592c..08a5355 100644 --- a/src/stkutil.h +++ b/src/stkutil.h @@ -296,6 +296,11 @@ enum stk_service_state { STK_NO_SERVICE =0x02 }; +enum stk_icon

[PATCH 7/9] Add parser for call control requested action objects

--- src/stkutil.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index d573430..6619bc3 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -756,6 +756,14 @@ static gboolean parse_dataobj_transaction_id(

[PATCH 9/9] Add parser for item icon identifier list objects

--- src/stkutil.c | 31 +++ src/stkutil.h |7 +++ 2 files changed, 38 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6619bc3..71899b9 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -786,6 +786,35 @@ static gboolean parse_dat

[PATCH] Fix: simplify isimodem call-barring driver.

From: Pekka Pessi Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). Use decimal MMI codes in . --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142 ++-- 2 files change

[PATCH] Fix: simplify isimodem call-barring driver.

From: Pekka Pessi Add support for lock codes AG and AC (MMI codes 333 and 353, respectively). Use decimal MMI codes in . --- drivers/isimodem/call-barring.c | 153 --- drivers/isimodem/ss.h | 142 ++-- 2 files change

Re: [PATCH] Fix: simplify isimodem call-barring driver.

2010/3/23 Denis Kenzior : >> Add support for lock codes AG and AC (MMI codes 333 and 353. respectively). > > First of all, please keep your commit messages less than 72 characters long > and headings less than 50 characters long. Is there any git setting or nice filter which could complain automat

Re: Access to SIM card when Modem is not "Powered"

Hi denis, 2010/3/19 Denis Kenzior : > I've been talking about this exact issue with Marcel but so far we have not > firmly agreed on any solution.  Our current thinking is to keep Powered > semantics as they are, but to also add Flight mode property.  This would in > affect allow interaction with

RE: Access to SIM card when Modem is not "Powered"

Pekka Pessi wrote: > I've been porting the N900 modem control code to oFono. The semantics > of Powered is fine with respect of the atoms, in other words, if the > modem crashes and boots itself, all the atoms are flushed nicely. > When powering up, the Powered can be set to true when the modem is

Re: Access to SIM card when Modem is not "Powered"

Hi Pekka, > However, then powering modem down, there are problems. The N900 modem > control needs to make difference between the state where the modem is > no more useful and the safe-to-exit state when the power off request > has been completed, modem has flushed its state to flash and given > so

Re: [PATCH 1/3] Refactor the command parsing

Hi Zhenhua, > --- > gatchat/gatserver.c | 103 > +++--- 1 files changed, 56 > insertions(+), 47 deletions(-) > > diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c > index c75fbf5..07999a8 100644 > --- a/gatchat/gatserver.c > +++ b/gatchat/gatser

Re: [PATCH 2/3] Add server send result code

Hi Zhenhua, > +static void g_at_server_send_result(GAtServer *server, GAtServerResult > result) +{ > + char buf[1024]; > + > + if (server->v250.is_v1) > + sprintf(buf, "%s", server_result_to_string(result)); > + else > + sprintf(buf, "%u", (unsigned int)result)

Re: [PATCH] Fix: simplify isimodem call-barring driver.

Hi Pekka, > From: Pekka Pessi > > Add support for lock codes AG and AC (MMI codes 333 and 353, > respectively). Use decimal MMI codes in . > --- > drivers/isimodem/call-barring.c | 153 > --- drivers/isimodem/ss.h | > 142 ++--

Re: [PATCH 2/9] Add parser for items next action indicator objects

Hi Yang, > --- > src/stkutil.c | 38 ++ > src/stkutil.h |5 + > 2 files changed, 43 insertions(+), 0 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index 9a02658..b997752 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -67,6 +6

Re: [PATCH 4/9] Add parser for cause objects

Hi Yang, > --- > src/stkutil.c | 35 +++ > 1 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index ecd5639..8f4ff39 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -687,6 +687,39 @@ static gboolean parse_d

Re: [PATCH 6/9] Add parser for transaction identifier objects

Hi Yang, > --- > src/stkutil.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/src/stkutil.c b/src/stkutil.c > index 3aae6bf..d573430 100644 > --- a/src/stkutil.c > +++ b/src/stkutil.c > @@ -748,6 +748,14 @@ static gboolean parse_dataobj_location_status( >

Re: [PATCH 8/9] Add the macro for icon qualifier

Hi Yang, > --- > src/stkutil.h |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > Please call them enums, not macros :) Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 9/9] Add parser for item icon identifier list objects

Hi Yang, > > +/* Defined in TS 102.223 Section 8.32 */ > +struct stk_item_icon_id_list { > + unsigned char qualifier; > + unsigned char len; > + unsigned char *array; > +}; > + And again here, the maximum size of the array is 126, so let us avoid g_mallocs. Regards, -Denis

Re: [PATCH 1/9] Add parser for network measurement results objects

Hi Yang, > --- > src/stkutil.c | 26 ++ > 1 files changed, 26 insertions(+), 0 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Fix: use of g_checksum_get_digest() inout argument

Hi Pekka, > gatchat/ppp_auth.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gatchat/ppp_auth.c b/gatchat/ppp_auth.c > index fe3c501..1e0c82b 100644 > --- a/gatchat/ppp_auth.c > +++ b/gatchat/ppp_auth.c > @@ -107,7 +107,7 @@ static void chap_process_challenge(str