Unreliable next_msg_id (was Re: [PATCH 2/2] Added SQLite history plugin)

Hi! At first look it seems that ofono stores permanently the next_msg_id only when the "sms_remove" functions is called, and that's does not happen when ofono quits in a not clean way. During our tests, users reported bad behaivour of the sqlite history plugins and error messages about sqlite con

Re: Unreliable next_msg_id (was Re: [PATCH 2/2] Added SQLite history plugin)

Hi Niko, > Hi! > > At first look it seems that ofono stores permanently the next_msg_id > only when the "sms_remove" functions is called, and that's does not > happen when ofono quits in a not clean way. > > During our tests, users reported bad behaivour of the sqlite history > plugins and error

Re: [PATCH 1/8] Extend sim-ready watch with card insert/eject events.

Hi Andrew, > --- > include/sim.h | 17 - > src/cbs.c |2 +- > src/modem.c | 11 ++- > src/sim.c | 49 + > 4 files changed, 44 insertions(+), 35 deletions(-) This patch has been applied, with a small fix a

Re: [PATCH 2/8] Functions to notify core of SIM insertion/removal.

Hi Andrew, > Make every plugin generate a sim inserted event on start. For devices > with removable card, the event should be emitted after the > plugin detects such event. > This patch has now been applied, thanks. Regards, -Denis ___ ofono mailing

Re: [PATCH 3/8] Add an atom for STK, move envelope command to stk driver.

Hi Andrew, > --- > Makefile.am |4 +- > drivers/atmodem/sim.c | 77 --- > include/sim.h |3 - > include/stk.h | 71 + > src/cbs.c | 10 ++- > src/modem.c |1 + > src/ofono.h |4 +- > sr

Re: [PATCH 4/8] Retrieve/forget emergency numbers on SIM insert/remove.

Hi Andrew, > --- > src/voicecall.c | 65 > +-- 1 files changed, > 58 insertions(+), 7 deletions(-) This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:

Re: [PATCH 6/8] Add SIM "Present" property.

Hi Andrew, > --- > src/sim.c | 117 > - 1 files > changed, 77 insertions(+), 40 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org h

Re: [PATCH 5/8] Remove post-sim atoms after SIM is extracted.

Hi Andrew, > --- > src/modem.c | 40 > 1 files changed, 40 insertions(+), 0 deletions(-) > This patch has been applied. However, I did change how we handle the lists of atoms afterward. Can you double check that my logic is still correct? Regards,

Re: [PATCH 7/8] Add AT driver for STK atom.

Hi Andrew, > --- > Makefile.am |1 + > drivers/atmodem/atmodem.c |2 + > drivers/atmodem/atmodem.h |3 + > drivers/atmodem/stk.c | 258 > + plugins/atgen.c | >2 + > plugins/phonesim.c|3 + > 6 f

Re: [PATCH 8/8] Implement STATUS polling in atmodem driver.

Hi Andrew, > --- > Makefile.am|2 + > drivers/atmodem/sim-poll.c | 319 > drivers/atmodem/sim-poll.h | > 22 +++ > plugins/atgen.c|8 +- > plugins/phonesim.c |5 +- > 5 files changed, 350 insertions(

Re: Access to SIM card when Modem is not "Powered"

Hi Pekka, > Attached. In the future, can you please use git-send-email so that I can comment on the patch much easier. > > > So far I like the idea of disable having a > > hint on whether a shutdown is in progress more than an explicit shutdown > > method. > > That is also possible, but then

Re: Unreliable next_msg_id (was Re: [PATCH 2/2] Added SQLite history plugin)

On Thu, Apr 15, 2010 at 8:35 PM, Denis Kenzior wrote: [...] >> During our tests, users reported bad behaivour of the sqlite history >> plugins and error messages about sqlite constraints violation, after a >> rude power off of the device (battery drained, forced shutdown with >> long press power b

Re: Unreliable next_msg_id (was Re: [PATCH 2/2] Added SQLite history plugin)

Hi Niko, > > The proper fix is to generate a SHA1 or MD5 hash over the contents, local > > reception/send time, remote reception / send time, destination / > > originator of the message. > > Dario suggested that to me too, the only problem I see is that an hash > signature does not provide ">" op

[PATCH] Fix Let data device be optional for mbm driver

Dell 5530 modem has no data device port. So data device should be optional in mbm drvier. --- plugins/mbm.c | 18 +- 1 files changed, 13 insertions(+), 5 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index 439d3b9..aeea81d 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c