Hi Petteri,
On 08/16/2010 02:26 AM, Petteri Tikander wrote:
> ---
> TODO |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/TODO b/TODO
> index 5221324..3481018 100644
> --- a/TODO
> +++ b/TODO
> @@ -101,7 +101,7 @@ SMS
>
>Priority: Medium
>Complexity: C4
>
Hi Sjur,
> plugins/modem.conf |5 +
> plugins/modemconf.c |1 +
> plugins/ste.c | 20 +++-
> 3 files changed, 25 insertions(+), 1 deletions(-)
please don't intermix modemconf and STE plugin changes. I need two
separate patches for this.
Regards
Marcel
___
Hi Sjur,
> CAIF in Linux kernel 2.6.35 must use RTNL for configuring
> CAIF interfaces.
> ---
> drivers/stemodem/gprs-context.c | 51 +--
> drivers/stemodem/rtnl.c | 318
> +++
> drivers/stemodem/rtnl.h | 24 +++
> 3 files changed, 380
Hi Sjur,
> Interim solution until support for SIM 'ready' notification is supported.
> ---
> Changes:
> o Fixed style issues (tabs and newlines)
>
> plugins/ste.c | 55 ---
> 1 files changed, 52 insertions(+), 3 deletions(-)
>
> diff --git
Hi Sjur,
> ...
> >do we really wanna create another vendor quirk here. If both modems
> >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom
> >registration and be done with it.
>
> Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c
>
> ---
> plugins/ste.c |2 +
Hi Sjur,
> Makefile.am |3 +-
> drivers/stemodem/radio-settings.c | 225
> +
> drivers/stemodem/stemodem.c |2 +
> drivers/stemodem/stemodem.h |2 +
> 4 files changed, 231 insertions(+), 1 deletions(-)
> create m
Hi Sjur,
> >>> ... The build system builds the plugins
> >>> properly and you can cross reference modem drivers from your modem
> >>> plugin without any problems.
> >>
> >>Simply refering to MBM driver from ste.c
> >>
> >one minor nitpick here. Can you please not squeeze this in between GPRS
> >an
Hi Sjur,
> >do we really wanna create another vendor quirk here. If both modems
> >behave identical then just pass OFONO_VENDOR_MBM in the SIM atom
> >registration and be done with it.
>
> Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c
>
> ---
> plugins/ste.c |2 +-
> 1
From: Sjur Brændeland
---
plugins/modem.conf |5 +
plugins/modemconf.c |1 +
plugins/ste.c | 20 +++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114 100644
--- a/plugins/modem.con
From: Sjur Brændeland
CAIF in Linux kernel 2.6.35 must use RTNL for configuring
CAIF interfaces.
---
drivers/stemodem/gprs-context.c | 51 +--
drivers/stemodem/rtnl.c | 318 +++
drivers/stemodem/rtnl.h | 24 +++
3 files changed, 380 in
From: Sjur Brændeland
---
plugins/ste.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index f1535e3..eeaa324 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -54,6 +54,7 @@
#include
#include
#include
+#include
#include
#include
From: Sjur Brændeland
---
Makefile.am |3 +-
drivers/stemodem/radio-settings.c | 225 +
drivers/stemodem/stemodem.c |2 +
drivers/stemodem/stemodem.h |2 +
4 files changed, 231 insertions(+), 1 deletions(-)
creat
From: Sjur Brændeland
Interim solution until support for SIM 'ready' notification is supported.
---
Changes:
o Fixed style issues (tabs and newlines)
plugins/ste.c | 55 ---
1 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/pl
From: Sjur Brændeland
---
Marcel Holtmann wrote:
...
>do we really wanna create another vendor quirk here. If both modems
>behave identical then just pass OFONO_VENDOR_MBM in the SIM atom
>registration and be done with it.
Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c
---
From: Sjur Brændeland
---
Marcel Holtmann wrote:
>>> ... The build system builds the plugins
>>> properly and you can cross reference modem drivers from your modem
>>> plugin without any problems.
>>
>>Simply refering to MBM driver from ste.c
>>
>one minor nitpick here. Can you please not squeeze
Hi Sjur,
> > ... The build system builds the plugins
> > properly and you can cross reference modem drivers from your modem
> > plugin without any problems.
>
> Simply refering to MBM driver from ste.c
>
> plugins/ste.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --g
From: Sjur Brændeland
---
plugins/modem.conf |5 +
plugins/modemconf.c |1 +
plugins/ste.c | 20 +++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114 100644
--- a/plugins/modem.con
From: Sjur Brændeland
---
plugins/ste.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index 5fecd5e..5a71945 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -55,6 +55,7 @@
#include
#include
#include
+#include
#include
#inclu
From: Sjur Brændeland
CAIF in Linux kernel 2.6.35 must use RTNL for configuring
CAIF interfaces.
---
drivers/stemodem/gprs-context.c | 51 +--
drivers/stemodem/rtnl.c | 318 +++
drivers/stemodem/rtnl.h | 24 +++
3 files changed, 380 in
From: Sjur Brændeland
---
Makefile.am |3 +-
drivers/stemodem/radio-settings.c | 225 +
drivers/stemodem/stemodem.c |2 +
drivers/stemodem/stemodem.h |2 +
4 files changed, 231 insertions(+), 1 deletions(-)
creat
From: Sjur Brændeland
Interim solution until support for SIM 'ready' notification is supported.
---
Changes:
o Fixed style issues (tabs and newlines)
plugins/ste.c | 55 ---
1 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/pl
From: Sjur Brændeland
---
Marcel Holtmann wrote:
...
>do we really wanna create another vendor quirk here. If both modems
>behave identical then just pass OFONO_VENDOR_MBM in the SIM atom
>registration and be done with it.
Re-use the MBM quirk rather than adding STE quirks in atmodem/sim.c
---
From: Sjur Brændeland
---
Marcel Holtmann wrote:
> ... The build system builds the plugins
> properly and you can cross reference modem drivers from your modem
> plugin without any problems.
Simply refering to MBM driver from ste.c
plugins/ste.c |2 ++
1 files changed, 2 insertions(+), 0 d
Hi Yang,
On 08/11/2010 08:01 PM, Yang Gu wrote:
> ---
> src/sim.c | 81 +++-
> src/simutil.h | 105
> +
> 2 files changed, 184 insertions(+), 2 deletions(-)
>
> diff --git a/src/sim.c b/src/si
Hi Thadeu,
On 08/13/2010 10:04 PM, Thadeu Lima de Souza Cascardo wrote:
> Some modems omit the quotes when dumping strings in UCS2. Parsing
> them as hexstring already does the hex decoding and accepts missing
> quotes.
> ---
> drivers/atmodem/phonebook.c | 142
> +--
Hi Sjur,
> >> Changes since last patch set:
> >> o Moved updates to plugins/ste to separate patch.
> >> o Updated error handling.
> >> o Style issues.
> >>
> >>
> >> Makefile.am |4 +-
> >> drivers/stemodem/radio-settings.c | 223
> >> ++
Marcel Holtmann wrote:
> Hi Sjur,
>
>> Changes since last patch set:
>> o Moved updates to plugins/ste to separate patch.
>> o Updated error handling.
>> o Style issues.
>>
>>
>> Makefile.am | 4 +-
>> drivers/stemodem/radio-settings.c | 223
>> +
Marcel Holtmann wrote:
> all the magic above is not needed. The build system builds the plugins
> properly and you can cross reference modem drivers from your modem
> plugin without any problems.
Sure, I'll change this.
Regards
Sjur
___
ofono mailing l
Hi Sjur,
> Changes since last patch set:
> o Moved updates to plugins/ste to separate patch.
> o Updated error handling.
> o Style issues.
>
>
> Makefile.am |4 +-
> drivers/stemodem/radio-settings.c | 223
> +
> drivers/stemodem/s
Hi Sjur,
> drivers/atmodem/sim.c |9 ++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
> index eb40ad7..8e7c403 100644
> --- a/drivers/atmodem/sim.c
> +++ b/drivers/atmodem/sim.c
> @@ -567,10 +567,12 @@ static void at_
Hi Sjur,
> Changes:
> o Use MBM stk driver implementation (avoid copying code).
>Note: stemodm.h has to declare the mbm_stk_init/exit functions because
>importing mbmdriver causes compile errors due to duplicated
>declarations.
>
>
> drivers/stemodem/stemodem.c |2 ++
>
---
plugins/modem.conf |5 +
plugins/modemconf.c |1 +
plugins/ste.c | 20 +++-
3 files changed, 25 insertions(+), 1 deletions(-)
diff --git a/plugins/modem.conf b/plugins/modem.conf
index 66bf932..b577114 100644
--- a/plugins/modem.conf
+++ b/plugins/modem.co
CAIF in Linux kernel 2.6.35 must use RTNL for configuring
CAIF interfaces.
---
Makefile.am |4 +-
drivers/stemodem/gprs-context.c | 51 +--
drivers/stemodem/rtnl.c | 318 +++
drivers/stemodem/rtnl.h | 24 +++
4 fi
---
Changes since last patch set:
o Moved updates to plugins/ste to separate patch.
o Updated error handling.
o Style issues.
Makefile.am |4 +-
drivers/stemodem/radio-settings.c | 223 +
drivers/stemodem/stemodem.c |2 +
d
---
plugins/ste.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/plugins/ste.c b/plugins/ste.c
index e1ca06c..1e3ed9d 100644
--- a/plugins/ste.c
+++ b/plugins/ste.c
@@ -55,6 +55,7 @@
#include
#include
#include
+#include
#include
#include
@@ -292,6 +293,7 @@
Interim solution until support for SIM 'ready' notification is supported.
---
Changes:
o Fixed style issues (tabs and newlines)
plugins/ste.c | 55 ---
1 files changed, 52 insertions(+), 3 deletions(-)
diff --git a/plugins/ste.c b/plugins/s
---
drivers/atmodem/sim.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index eb40ad7..8e7c403 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -567,10 +567,12 @@ static void at_pin_send_cb(gboolean o
Resubmitting based on rebase comments from Denis K.
Changes:
o SIM-ready and Radio-Settings are now split in two parts,
one patch for driver and one for plugin.
o Use MBM stk driver implementation (avoid copying code).
o Updated error handling for Radio Settings.
o Various Style issues (n
---
Changes:
o Use MBM stk driver implementation (avoid copying code).
Note: stemodm.h has to declare the mbm_stk_init/exit functions because
importing mbmdriver causes compile errors due to duplicated
declarations.
drivers/stemodem/stemodem.c |2 ++
drivers/stemodem/st
Denis Kenzior wrote:
> Hi Sjur,
>
I have to verify this with some of my colleagues, but I am pretty sure
emergency calls cannot be applied to the AT+CHLD command. i.e. they
cannot be part of mpty.
>>
>> Initial testing on STE modem indicates that emergency call cannot
>> participate
Hi Caiwen,
> Add 3GPP2 relative specifications.
>
> ---
>
> diff --git a/doc/standards.txt b/doc/standards.txt
>
> index a7eaa5e..1b8c23f 100644
>
> --- a/doc/standards.txt
>
> +++ b/doc/standards.txt
>
> @@ -81,3 +81,88 @@ technology specific features (e.g. UMTS/CDMA
Add 3GPP2 relative specifications.
---
diff --git a/doc/standards.txt b/doc/standards.txt
index a7eaa5e..1b8c23f 100644
--- a/doc/standards.txt
+++ b/doc/standards.txt
@@ -81,3 +81,88 @@ technology specific features (e.g. UMTS/CDMA).
- 102.384: Card Application Toolk
---
TODO |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/TODO b/TODO
index 5221324..3481018 100644
--- a/TODO
+++ b/TODO
@@ -101,7 +101,7 @@ SMS
Priority: Medium
Complexity: C4
- Owner: Pasi Miettinen
+ Owner: Petteri Tikander
SIM / SIM File system
--
1.
---
src/smsutil.c | 158 +
1 files changed, 92 insertions(+), 66 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index 25e405c..a12bede 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -57,6 +57,15 @@ static GSList *sms_assembly_ad
---
src/smsutil.c | 202 +++-
1 files changed, 198 insertions(+), 4 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index 22c70cf..0972988 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -45,6 +45,10 @@
#define SMS_BACKUP_PATH_DIR SM
---
src/smsutil.c | 54 ++
1 files changed, 26 insertions(+), 28 deletions(-)
diff --git a/src/smsutil.c b/src/smsutil.c
index 0972988..25e405c 100644
--- a/src/smsutil.c
+++ b/src/smsutil.c
@@ -46,7 +46,7 @@
#define SMS_BACKUP_PATH_FILE SMS_
46 matches
Mail list logo